* New translations deconz.properties (German)
* New translations sonos.properties (French)
* New translations openuv.properties (French)
* New translations synopanalyzer.properties (French)
When the binding is stopped sleeping threads are interrupted by design.
By throwing the InterruptedException, it should be caught in LifxSelectorUtil.sendPacket (which is waiting for the packet interval to elapse), which will then abort sending a packet.
This prevents:
```
[ERROR] [lifx.internal.util.LifxThrottlingUtil] - An exception occurred while putting the thread to sleep : 'sleep interrupted'
```
Signed-off-by: Wouter Born <github@maindrain.net>
* [tapocontrol] New Source Upload
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] Snapshot 3.2
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] Update CODEOWNERS
Fixed bindingname
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] Update README.md
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] new "Bridge-Version"
Credentials (TapoCloud) where now set in a bridge device.
Things now had to be attached to a bridge.
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] fixed device discovery bug
fixed device discovery bug
added bridge to thing-types.xml
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] code cleanup and optimization
- general code cleanup and optimization
- limited max connections and queued requests to 10 per destination
- device error handling revised
- review remarks of pull request processed
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] solved review requests
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] LightStrip L900 basicly supported
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] fixed review requests
Signed-off-by: Christian Wild <christian@wild-bw.de>
* [tapocontrol] fixed compiler warnings
Signed-off-by: Christian Wild <christian@wild-bw.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* New translations openhabcloud.properties (French)
* New translations transform.properties (French)
* New translations voicerss.properties (French)
* New translations actions.properties (German)
* New translations errors.properties (German)
* New translations stateflags.properties (German)
* New translations nanoleaf.properties (German)
* New translations surepetcare.properties (German)
* New translations deconz.properties (German)
* New translations tr064.properties (German)
* New translations deconz.properties (German)
* New translations openhabcloud.properties (German)
* New translations astro.properties (French)
* New translations hue.properties (French)
* New translations ntp.properties (French)
* New translations feed.properties (German)
* New translations lgwebos.properties (French)
* New translations gce.properties (French)
* New translations airquality.properties (French)
* New translations airquality.properties (French)
* New translations rotel.properties (French)
* New translations feed.properties (German)
* New translations hue.properties (French)
* New translations mail.properties (German)
* New translations sonyprojector.properties (French)
* New translations tradfri.properties (French)
* New translations powermax.properties (French)
When the docs are generated any {{ }} constructs are substituted with variables.
As a result the docs are less easy to understand.
Signed-off-by: Wouter Born <github@maindrain.net>
When the docs are generated any {{ }} constructs are substituted with variables causing the place holders to get lost.
As a result the docs are less easy to understand.
Signed-off-by: Wouter Born <github@maindrain.net>
* Change to json for states
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add 3rd colours.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Segments now mostly work
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* changes to json api fully made
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Mirror and Reverse channels added.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove old channels when needed.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Simplify return
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add support for named presets
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Dont add empty preset 0 to list
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add preset saving with custom names
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Tidy up
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Rename function for clarity
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add more channels
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Clean up
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix bugs and update readme for new channels
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Move remaining channel details to the respective channels to simplify
and avoid mistakes/errors.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Clarify supported models and documentation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Clarify supported models and documentation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Add notes for amps with built-in serial over IP
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Add notes for amps with built-in serial over IP
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* fix spotless error
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* substitute controller/amplifier
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* New translations intesis.properties (German)
* New translations avmfritz.properties (German)
* New translations hue.properties (German)
* New translations pixometer.properties (German)
* New translations volvooncall.properties (French)
* New translations tr064.properties (French)
* New translations transform.properties (German)
* New translations googletts.properties (German)
* New translations avmfritz.properties (German)
* New translations googletts.properties (German)
* New translations sonyprojector.properties (French)
* New translations meteoblue.properties (French)
* New translations avmfritz.properties (German)
* New translations mail.properties (German)
* New translations hue.properties (German)
* New translations astro.properties (French)
* Fix reconnect after first connection to TV is lost.
Fixes#7055
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Reduced log level to TRACE for logging of entered methods several times per second.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add support for scene collections.
Fixes#11533
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add unit test for parsing of scene collections response.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add default i18n properties file.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix CAT: File does not end with a newline.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Update documentation with scene collections.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix CAT: File does not end with a newline.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix formatting.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix CAT: File does not end with a newline.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Split offline tests into separate distinct tests.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Increase test coverage for scene/scene collection parsing.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Internationalization of dynamic scene/scene collection channels.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Rename scene collections to scene groups.
Renamed for all user-oriented texts/references to be consistent with now abandoned feature of the PowerView app.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Change custom text keys to not collide with framework.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Avoid multiple thing updates.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add missing label/description texts for secondary channel.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Remove unneeded @Nullable annotations.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* [openhabcloud] reconnect on connection errors
According to documentation (albeit for 2.x Socket IO version) [1],
reconnection is responsibility of the user on connect_error events.
[1] Lifecycle diagram in
https://socketio.github.io/socket.io-client-java/socket_instance.html
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] Update Socket IO dependency to 1.0.1
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] feature.xml updated also with socket io 1.0.1
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] Re-connect manually on error events when not connected
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] less loud logging on retries
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] removing unnecessary conditional in logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [openhabcloud] javadoc corrections and clarifications
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [hdpowerview] get secondary shade position value was inverted
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [hdpowerview] remove testing Jar from PR
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velbus] Add new functionality PRESSED and LONG PRESSED and fix bug
New functionnality :
Add the the possibility to simulate the PRESSED and LONG PRESSED message of an input.
Module supported with button simulation :
VMB1RYS (button : CH6)
VMB6IN (buttons : CH1 ... CH6)
VMB2PBN, VMB6PBN, VMB7IN, VMB8IR, VMB8PB, VMB8PBU, VMBEL1, VMBEL2, VMBEL4, VMBGP1, VMBGP1-2, VMBGP2, VMBGP2-2, VMBGP4, VMBGP4-2, VMBGP4PIR, VMBGP4PIR-2 (buttons : CH1 ... CH8)
VMBELO, VMBGPOD, VMBGPOD-2 (buttons : CH1 ... CH32)
Fix bug :
The channels names were not correctly assigned to the thing properties. The last channel had the default name, not the one retrieved from the module.
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Update bundles/org.openhab.binding.velbus/README.md
Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Update bundles/org.openhab.binding.velbus/README.md
Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Update bundles/org.openhab.binding.velbus/README.md
Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Add trigger on channel when using button simulation
Remove uneeded Thread.sleep in code.
Trigger the events PRESSED, LONG_PRESSED, RELEASED on the linked trigger channel when using the button simulation.
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Fix redundant superinterface DiscoveryService
Redundant superinterface DiscoveryService for the type VelbusThingDiscoveryService, already defined by AbstractDiscoveryService.
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
* Fix bug #11521
Typo in the Counter Channel name for VMB7IN.
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
Co-authored-by: cedricboon <cedric.boon@hotmail.com>
* Remove advanced option in group-type
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
* Add support for multiple commands in one message
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
* New translations powermax.properties (French)
* New translations openhabcloud.properties (German)
* New translations avmfritz.properties (German)
* New translations mail.properties (German)
* New translations hue.properties (German)
* New translations airquality.properties (French)
* New translations ntp.properties (German)
* New translations velux.properties (German)
* New translations mail.properties (German)
* New translations hue.properties (German)
* New translations avmfritz.properties (German)
* New translations pixometer.properties (German)
* New translations openuv.properties (French)
While integrating the review comments, I did not remember that some
variable names are written as they are because they result from some
deserialization.
This small PR fixes this.
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Implement Vacuum discovery for Homeassistant MQTT
Closes#8988
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Addressed review comments
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Spotless run again
Signed-off-by: Stefan Triller <github@stefantriller.de>
* New translations lametrictime.properties (French)
* New translations thingstate.properties (French)
* New translations twitter.properties (French)
* New translations tradfri.properties (French)
* New translations vigicrues.properties (French)
* Use appliance cache for getting full UID with protocol prefix instead of relying on property.
* Set bare protocol name as property.
* Fix potential null pointer access warnings.
* Remove unused import.
* Renamed property protocol to protocolAdapter for correctness.
* Add connectionType property.
* Add appliance model property.
* Remove useless properties brandId and companyId always having value MI.
* Rename property dc to deviceClass and set it consistently (not only from auto-discovered things).
* Added constants for remaining handlers with hardcoded device classes.
* Fix SCA: AuthorContributionDescriptionCheck
* Fix SCA: ModifierOrderCheck
* Rename ExtendedDeviceStateUtil to be a bit more generic.
* Extract device class string parsing to utility method.
* Fix SCA: ForbiddenPackageUsageCheck
* Fix redundant null check.
* Fix potential null pointer access warnings.
* Fix unsafe null type conversion (type annotations)
* Share same configuration (UID) for all appliance types.
* Refer to gateway instead of ZigBee network in configuration.
* Remove dependency to seriaNumber property for multicast channel updates.
* Simplified filtering of irrelevant device class.
* Remove devices from remoteUid cache also when disappearing from gateway, although this is a quite rare scenario.
* Add default i18n properties file.
* Add partial Danish translation.
Fixes#11422
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix that binding stops refreshing after RuntimException (#11396)
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* Updated after review comments
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* Only update state options if they've changed
Signed-off-by: Mark Hilbush <mark@hilbush.com>
* Fix update of state options
Signed-off-by: Mark Hilbush <mark@hilbush.com>
* New translations lgwebos.properties (French)
* New translations intesis.properties (German)
* New translations zway.properties (German)
* New translations velux.properties (German)
* New translations pushsafer.properties (German)
* New translations pushover.properties (German)
* New translations hue.properties (German)
* New translations rotel.properties (French)
* New translations openuv.properties (French)
* New translations synopanalyzer.properties (French)
* New translations nikohomecontrol.properties (Dutch)
* Added possiblity to send WOL Requests to configured Hostname, also removed unnecessary unit from Timeout Annotation in WakeOnLanPacketSenderTest
* Introduced parameter to decide whether to send WOL via IP or MAC
* Added two Methods for user clarity, marked old method as deprecated, adjusted README
* Updated internal methods to use explicit calls as well, added deprecated method call to README
Signed-off-by: Jonathan Saxen <jonathan@saxen.info>
* [openwebnet] first support for CEN
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] added CEN actions. OpenWebNetThingHandler.send() is now public
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] added CEN+ support
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] use WhereCEN, removed nullpointer warnings from EnergyHandler. Improved README
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] completed support for CEN/CEN+
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] improved log
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] corrected "pressure" and renamed some labels
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* Fix fix for channel id detection, Added missing channels to emucs electra
- M-bus channels are dynamic and present in the obis id.
The binding had most channel types fixed because most of the time these channels are the same.
However the device identifier is the same for multiple devices.
But the binding only registered only one and while the channel id was derived from this obis data.
For detected meters this resulted in the channel id to be the same if there are multiple devices.
This change looks at the channel id to assign it to the found device.
This is a bit tricky because the general device has no channel and has channels that have different id's.
So the binding needs to cover that case.
This change also adds some optional channels to the emucs electra meter.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Add support for Austrian meters
Improved the work done in pr #11193
Also-by: Thomas <thomas@knaller.info>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Added Null handling annotations.
* Reduce debug output
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added meta information for Bosch binding
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Set binding online only if fetching rooms and devices worked
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Replaced hard-coded IP address with configuration from things file
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixes after rebasing on 2.5.x branch
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Put keystore where openhab user can access it
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Attempt to get a new subscription ID when the old one is invalidated
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Better install script
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Asynchronously get subscription ID
Otherwise, code would get stuck on requesting second subscription ID
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Initial steps towards pairing
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Doesn't compile because of bouncycastle - compiles if commented out
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Bumped version
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added basic support for multiple devices to support Twinguard
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Support for power meter in power switches + all values from Twinguard
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add window contact to the list of supported things
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Updated README to indicate new supported devices
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added missing file
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added motion detector thing
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* All devices support RefreshType now
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Cleanup - removed pairing related stuff that doesn't work
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixed a weird bug where InWallSwitchHandler was not an instance of SHCHandler
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Update BoschSHCBridgeHandler.java
fixed HTTP request URL to get rooms from SHC
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add handler for Bosch Shutter Control to get and set its open level
Signed-off-by: Christian Oeing <christian.oeing@scalamat.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Auto update of .classpath by IDE
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Handle PercentType command to set a specific shutter level
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Put service name in constant instead of using it hard coded twice
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Refactor putState method of BoschSHCBridgeHandler
Remove unnecessary parts of the request like Gateway ID and put some general logic into separate methods to reuse them in other functions later
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Send operation state STOPPED to stop shutter from moving
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add shutter control to supported devices in README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add null reference check to avoid a NullReferenceException in ShutterControlHandler if device state couldn't be fetched
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add TemperatureLevelService
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add ThermostatHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add valve tappet position channel to thermostat via ValveTappet service
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add service registration for BoschSHCHandler, so the state updates are automatically calling the registered state update callback of the handler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add affectedChannels to service registration and handle RefreshType directly in BoschSHCHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Cleaned up DeviceStatusUpdate class
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added Bosch SHC certs
added public certificates from https://github.com/BoschSmartHome/bosch-shc-api-docs/tree/master/best_practice
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added pairing support
added support for keystore creation and pairing
documented the process in readme
refactoring of httpClient to take care of SSL context
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add RoomClimateControlService and ClimateControlHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Handle command to set setpoint temperature and move conversion from service state data to thing states into service state classes
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Remove unnecessary imports from ThermostatHandler.java
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make new service and handler @NonNullByDefault
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added comments for climate control service, handler and base service and handler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add missing comments on new classes and their methods
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make registerService method of BoschSHCHandler private and adjust usages
Derived handlers should use createService instead.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Throw an error instead of returning null for method getBridgeHandler of BoschSHCHandler
This allows for fewer null checks after the initialization of a handler.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add @author tags in JavaDoc of new classes
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Ran mvn spotless:apply to apply correct code formatting
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixed missing imports in BoschSHCService.java
This was caused by a too quick merge of me.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixed warnings about null annotations
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add @NonNullByDefault to all handlers
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added license header by executing mvn license:format
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #16 Adjust logger usages to not be too verbose
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #10 Remove obsolete parse-things.py script
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #29 Remove dev scripts install.sh and run.sh scripts
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added author name to each class comment
Added the author(s) and small comment to each class based on the git
history and if necessary created the basis class comment body.
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added license header for new files
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* run mvn spotless check/apply
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #24 Catch error response when trying to get state of a service of a device and throw specific error instead of returning invalid state object
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #24 Run mvn spotless:apply and mvn license:format to respect coding guidelines
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #5 Update README.md with up-to-date information about the setup of the binding
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #31 Typo in README.md
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add detailed description of the system password to provide in README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fix non-initialized member of @NonNullByDefault class ValveTappetServiceState
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #7 Moved each device to a separate subfolder inside devices folder
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #44 Adjust version of org.openhab.addons.reactor.bundles to 2.5.9-SNAPSHOT in pom.xml
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #45 Increase year in copyright headers
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #45 Remove several obsolete loggers and fix logging of exceptions
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #45 Fixed some code analysis warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #45 Ran mvn spotless:apply
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #45 Revert adding @NonNullByDefault to BoschSHCConfiguration
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Fixed code analysis warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* updated text files based on pull request feedback
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Apply suggestions from code review
Applied only suggested string text changes and few trivial code changes
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Improved comments and changed visibility
code review findings improved related to code comments
and public/private visibility of variables
removed example properties file and class path entries
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added @NonNullByDefault annotation where necessary and easy possible
in addition minor improvements like
removed TODO for code refactoring
used BoschSHCException instead of Error in one place
Renamed internal Error class to ErroInfo
ran spotless:apply
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* use SIUnits
replaced all Celcius units with eclipse SIUnits
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* change logging and GSON related code
increased many log levels
avoid creating new GSON instances in derived handler subclasses
changed catch code to avoid stack trace dumps
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add @NonNullByDefault to BoschSHCConfiguration class and remove obsolete usages of configuration in handlers
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Throw BoschSHCExceptions instead of generic Errors and handle them during creation of services
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use Class::new supplier function instead of deprecated Class.newInstance() method
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Remove @NonNullByDefault from inner classes and unused logger member to remove compile warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use Base64.getEncoder().encodeToString instead of Base64.getEncoder().encode and a manual conversion to String
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add @NonNullByDefault annotation to BoschSHCBridgeConfiguration and check for empty password and ip address in configuration
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use try-with-resources to auto-close streams for key store creation
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move data transfer objects of bridge into dto folder
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add thing type ids and channel type ids to README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move thing configurations out of thing-types.xml and into configs.xml. Remove deprecated required element and use attribute instead.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Adjust some elements, units, descriptions and labels in configs.xml and thing-types.xml
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move url and request creation from BoschSHCBridgeHandler to BoschHttpClient to reuse it inside BoschHttpClient
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add default timeout to request to smart home controller
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make httpClient of BoschSHCBridgeHandler @Nullable and use BoschHttpClient createUrl and createRequest methods where possible
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make gson field in BoschSHCBridgeHandler final
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Simplify getDevices method of BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use getContentAsString() instead of getContent() plus manual conversion to String
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use instanceof instead of isInstance(...) in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add registerService method to BoschSHCHandler to register already created services, so they can be created in the constructor of a handler and do not have to be @Nullable
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Using simpler String.format instead of MessageFormatter in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move ShutterControlState into dto subfolder and remove @NonNullByDefault annotation
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make bridgeHandler and deviceId in BoschSHCService @Nullable
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move DTOs in dto subfolders and remove @NonNullByDefault annotations from them
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add texts for errors during initialization of bridge
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Migrate PowerSwitch to new service architecture to get rid of BoschSHCBridgeHandler.updateSwitchState
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Remove obsolete null parameter from subscription request
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Removed obsolete TODO about hard-coded data which does not exist anymore
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use lambda for response handling of long poll
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Remove obsolete @NonNull annotations in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Throw http exceptions when trying to request state from a device to set the thing to offline
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Add state options for combined-rating, temperature-rating and humidity-rating channels
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fix several minor static code analysis warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Added migration artifacts
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fix formatting and increase version number
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* fix HTTP client issue, improve connection logging, add Developers markdown
the HTTPClient requests were broken
updated exception handling and logging for connection and pairing
describing source of certificates
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use service for shutter control handling instead of having the logic inside the ShutterControlHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Fix code formatting to remove code analysis warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixed pairing
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Fixed long poll
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move common error handling for parsing responses from BoschHttpClient into sendRequest method to make subscribe request logic clearer
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use scheduler.schedule instead of Thread.sleep during long polling
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Using synchronous request for subscribe request
The initialization is not finished without a successful subscription.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use synchronous long poll request to get it to work
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make long polling asynchronous to not block scheduler threads
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Only scheduling new long polls while bridge is not disposed and aborting long polling on disposal
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Move long polling logic into separate class
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Make long polling requests synchronous again, the asynchronous way still does not receive any state updates
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* replaced while loop for pairing with scheduler calls
Pattern from LongPolling reused.
Scheduling new initial access checks including pairing every 15 seconds until it was successful and long polling can be started
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Throw BoschSHCException instead of raw error to avoid code analysis warning
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Remove TODO from code and add issue #55 instead
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Pass non-null httpClient to bridge initialization instead of having to check for null reference
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Use one supportsThingTypes mapping to list the supported things with their handler in BoschSHCHandlerFactory
Previously an array plus a big switch was required.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #47 Starting http client before scheduling initial access
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Use logger.debug instead of logger.info
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* Include cause exception in the PairingFailedException
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Move fields above constructor in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove obsolete configuration field from BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Move fields and constructor in JsonRpcRequest to top of the class
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Log the failure of a long poll as warning instead of error
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Use %s instead of {} as placeholder for String.format
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Move @Nullable annotation in front of field name
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Specify UTF_8 as charset to convert string to byte array
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove spaces from pem files
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Change ArrayList to List in Device.java
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Use QuantityType for power and energy consumption of the in-wall switch handler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Check if StopMoveType is STOP in ShutterControlHandler before setting the device state
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Make fields of DeviceService final
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Stop http client and cancel scheduled pairing on bridge disposal
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove channel check in BoschTwinguardHandler for Refresh command
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add exception message to warning when update in BoschTwinguardHandler and WindowContactHandler returns incorrect state
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add additional information about channels to thing-types.xml and README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove confusing comment from LongPolling.subscribe method
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Removed obsolete error log in LongPolling.subscribe
A warning is already logged in BoschBridgeHandler when an exception occurs
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add detailed description for purity channel
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Fix typo in DEVELOPERS.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Change scheduledPairing field in BoschSHCBridgeHandler to be @Nullable
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Change type of channel values from DecimalType to QuantityType in BoschTwinguardHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove obsolete .classpath and .project files
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Fixed typo in DEVELOPERS.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Only log error message instead of whole stack trace in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove exception which is not thrown and typo in BoschSslUtil
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Use SmartHomeUnits instead of AbstractUnit in BoschTwinguardHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Added supported-bridge-type-refs to thing-types.xml
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove invalid whitespace from thing-types.xml
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Fixed warnings and errors caused by updated Gson library
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Update info about auto reload of bundle jar in DEVELOPERS.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Update information about adding items and things via UI, added missing password configuration value and changed headline in README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Execute long polling requests asynchronous to not block a thread
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Refactored WindowContactHandler to use ShutterContactService instead of implementing service logic itself
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove obsolete .gitignore. The ignored files are already ignored by the root .gitignore
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Rename constant supportsThingTypes to SUPPORTED_THING_TYPES in BoschSHCHandlerFactory
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Use List.of instead of Arrays.asList
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Call super.dispose last in BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add exception message to status when http connection to controller fails
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Handle JsonSyntaxException in BoschHttpClient.sendRequest
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Forward InterruptedExceptions to callers, so they have to be handled correctly
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Logging long poll error message and code instead of hash
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Throwing InterruptedException during pairing instead of only logging it
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Move nested class AbortLongPolling to end of LongPolling class
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Make gson instance static final in BoschHttpClient
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Rename gson to GSON and make it static final in BoschSHCHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Remove @Nullable annotations from GSON-created objects
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add causing exception to ExecutionException in BoschHttpClient.sendRequest
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #14 Add JsonSyntaxException to definition of processUpdate in BoschTwinguardHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* fixed keyStore creation
Moved PEM files into expected folder according to package
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* moved final fields above non-final fields
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* updated copyright year in header by executing mvn license:format
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* fixed last two pending warnings
added back the removed @Nullable annotation in sendRequest()
replaced deprecated SslContextFactory constructor call
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added Bouncy Castle third-party license info into NOTICE
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* changed Bouncy Castle version to same version as currently used in org.openhab.core.io.jetty.certificate to later reduce download size
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #62 Correctly check if long poll response is valid
GSON will not return null if there is no "result" field, but will just set the "result" member to null.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Add @NonNullByDefault annotation to LongPollResultTest class and fix method name
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* added first unittests for BoschSslUtil class
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added next unittests for BoschHttpClient class
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #55 replaced the password with a fixed one
The changeable SHC system password for the keystore is replaced by a static string in the code.
The keyStore name is now based on SHC ipAddress to support multiple SmartHomeControllers.
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #72 changed use units of measure for the twinguard humidity and purity values
all other QuantityTypes in bindingcode are fine
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #77 changed title of binding to Bosch Smart Home
Replaced the SHC occurrences with Smart Home,
to avoid technical names.
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #62 Try to restart long polling when it fails before taking the thing offline
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request
This might be the reason why the subscribe request does never finish or finishes with a timeout
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #74 Schedule initial access when long polling fails unexpected
We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Use direct formatting of logger.trace instead of String.format
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
* #76 Use i18n texts instead of raw translations for status messages about failed long polling
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #76 Use logger.debug instead of logger.warn for long poll error as it is handled now
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #78 defined api-version
each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* logging bundle version
removed the old static version string
access OSGi bundle version information instead
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #75 improved initial access
- added isOnline check and isAccessPossible now failed in case HTTPStatus is an error
- same HTTPStatus check done to all blocking send() request calls
- using i18n strings for all bridge updateStatus calls
- skipped the 'controller' and use only 'Bosch Smart Home' in descriptions
- added more @Nullable annotations
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #72 changed use units of measure for the twinguard humidity and purity values
all other QuantityTypes in bindingcode are fine
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #77 changed title of binding to Bosch Smart Home
Replaced the SHC occurrences with Smart Home,
to avoid technical names.
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #62 Try to restart long polling when it fails before taking the thing offline
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request
This might be the reason why the subscribe request does never finish or finishes with a timeout
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #74 Schedule initial access when long polling fails unexpected
We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Use direct formatting of logger.trace instead of String.format
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
* #76 Use i18n texts instead of raw translations for status messages about failed long polling
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #76 Use logger.debug instead of logger.warn for long poll error as it is handled now
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #78 defined api-version
each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* logging bundle version
removed the old static version string
access OSGi bundle version information instead
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #75 improved initial access
- added isOnline check and isAccessPossible now failed in case HTTPStatus is an error
- same HTTPStatus check done to all blocking send() request calls
- using i18n strings for all bridge updateStatus calls
- skipped the 'controller' and use only 'Bosch Smart Home' in descriptions
- added more @Nullable annotations
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* added newline
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
* #46 Rename BoschInWallSwitchHandler, BoschTwinguardHandler, BoschSHCBridgeConfiguration and BoschSHCBridgeHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #46 Adjust descriptions of things
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #40 Use LatestMotionService in MotionDetectorHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #40 Use service instead of custom logic in BoschTwinguardHandler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #40 Add PowerMeterService to use in InWallSwitchHandler instead of having the logic directly in the handler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #40 Rename InWallSwitchHandler to LightControlHandler
This is the official name in the Bosch API documentation, so we should use it as well (https://apidocs.bosch-smarthome.com/local)
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #34 Get device info on thing initialization to check if device exists
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #34 Use generic sendRequest method of http client to have consistent error handling
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #34 Fix formatting error when logging device info
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #83 Add info if a channel is writable to README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #84 Adjust/Add descriptions of supported devices
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #25 Add humidity level service and wall thermostat handler
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #25 Add wall thermostat handler to handler factory
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #66 Check type of service state when received by bridge to make sure that it has the expected type
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #41 Add child lock service to Thermostat handler and link its state to a "child-lock" channel
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Add null check in BoschSHCServiceState.isValid
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #41 Use custom channel type for child-lock. Handle setting child lock state.
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #101 Store expected state type inside a member instead of a static variable
The static variable was stored in the base class, so it was only initialized once even for different state types
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #63 Use better identifier for thing that is missing a (valid) bridge
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #108 Add changelog to README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #109 Catch possible null pointer exception in long poll response handling
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Fix potential null pointer access
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Fix static code analysis error and 2 warnings
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #111 Remove changelog from README.md
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* #112 Remove JSON from logs
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Stefan Kaestle <stefan@mad-kow.de>
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
Co-authored-by: Christian Oeing <christian.oeing@scalamat.de>
Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* Added support for the 50 GPS waypoints provided by the Automower API
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Added Channel for last position
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Fixed channel of position 40
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Updated Doku + mvn:spotless apply
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Inputs from static code analysis
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Removed channel groups
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* mvn spotless:apply
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
Allows translating the binding strings with Crowdin.
Also fixes a wrong thing action description annotation.
Also fixes few SAT warnings
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Allows translating the powermax binding strings with Crowdin.
This is not a 100% internationalization of the binding, rather 95%.
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* New translations lgwebos.properties (French)
* New translations sonos.properties (French)
* New translations weatherunderground.properties (French)
* New translations gce.properties (French)
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes#6843).
Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes#10490).
- Improved handling Spotify API error messages (Closes#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Update imports to use JUnit 5 instead of JUnit 4
* Add commonly used JUnit 4 classes to forbidden packages
Related to: https://github.com/openhab/openhab-core/pull/2534
Signed-off-by: Wouter Born <github@maindrain.net>
* New translations gree.properties (German)
* New translations iCloud.properties (French)
* New translations iCloud.properties (German)
* New translations jeelink.properties (German)
* New translations linky.properties (French)
* New translations mail.properties (French)
* New translations mail.properties (Russian)
* New translations pixometer.properties (German)
* New translations sagercaster.properties (French)
* New translations sonyprojector.properties (French)
* New translations twitter.properties (Russian)
* New translations weathercompany.properties (French)
* Externalize strings to support translation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Name events thread.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Fix formatting
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Fix SAT warning
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Fix threadname
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Fix thing lifecycle.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Adjustments from review.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Adjustment from review.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
* Fix config reload after changes.
Fixes#11407
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Don't try to initialize client when bridge is offline.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add filter period channel.
Fixes#11310
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Round remaining filter life percentage to one decimal.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Improve and extend example configuration.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Mark filter period channel as advanced due to Link CC/Air Dial conflicts.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add comment about value getting overwritten.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Remove redundant parentheses.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix SCA report: First javadoc author should have 'Initial contribution' contribution description.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix SCA issue: NoEmptyLineSeparatorCheck
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* [upb] Fix javadoc
Signed-off-by: Marcus Better <marcus@better.se>
* [upb] Handle Device State Report messages
Signed-off-by: Marcus Better <marcus@better.se>
* More useful debug logging of received messages
Signed-off-by: Marcus Better <marcus@better.se>
* Null annotation
Signed-off-by: Marcus Better <marcus@better.se>
* made listeners a ConcurrentHashMap
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required
Fixes#11393
Also-by: Daniel Weber <uni@fruggy.de>
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
Based on WLED API (https://kno.wled.ge/interfaces/http-api/) current handler uses NL=1 so sleep timer is hard coded to 1 minute. Should be default (ND) to use configured time in WLED.
Fixes#11389
Signed-off-by: Sven Jensen <github@s7j.de>
Co-authored-by: Sven Jensen <github@s7j.de>
Adds the products with IDs 93, 112, 113, 114 so that they can be discovered and the right features are available.
Fixes#11402
Signed-off-by: Wouter Born <github@maindrain.net>
This is a very minor spelling fix for openhabcloud. In some cases, "Notification" was spelled
"Notificaton". There are no other changes.
Signed-off-by: Brian Warner <brian@bdwarner.com>
* Initial commit
Intial work history lost due to the repository shrunk done at c53e4aed26 (intially started from old unshrunked repo)
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Implement reconnect attempts
If database can be connected at bridge initialization schedule retry attempts.
Prevent query execution scheduling if bridge isn't online
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Minor documentation changes and fix trigger channel name
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Fix NPE bug initializing ThingActions
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Implement query actions and another fixes
Implement actions to execute query and get last query result
Correctly serialize as JSON non scalar results to result channels
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update parameters and correct channel
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Fix formatting and forgot part on previous commit
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Improve documentation
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Add javadoc comment and license to all classes
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Code cleanup
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Untrack unused i18n file
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Fix log level for query actions trace information
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Add dbquery addon to bundles pom
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Temporary remove mqtt bindings that make travis build to fail
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Fix formatting issue
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Revert "Temporary remove mqtt bindings that make travis build to fail"
This reverts commit 21c09957b5.
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Code clean up from static analysis
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update code to be compatible with 3.1.0
Update dependencies version
Update Copyright
Other minor changes for new static analysis validations.
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Requested PR changes
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/JDBCBridgeHandler.java
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/DatabaseBridgeHandler.java
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Apply suggestions from code review
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Suggestions from code review
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update parent version
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/jdbc-bridge.xml
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Changes asked in PR review
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Update bundles/org.openhab.binding.dbquery/README.md
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* README documentation imporovements
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* Fix format issue
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* added data validation
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Revert "added data validation"
This reverts commit 945101056b.
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* added calibration channels
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* added calibration channels
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* initial d20601 impl
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* fixed D20601 temp and battery
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* README updated and changed D20601 to mechanical handle
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* spotless
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* use common events
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* fix spotless
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Revert "added calibration channels"
This reverts commit 6287b4be19fc37e8d1c2211109628fff513ecc8e.
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Revert "added calibration channels"
This reverts commit fca8b4b11d1df0345bc02466311cf3f139044562.
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Revert "Revert "added data validation""
This reverts commit e8ff27fa44461a108f3942f5e9547d72bb280d65.
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Revert "added data validation"
This reverts commit 8d7bd95629426640d9f63d53c05335f3dcbd9b5b.
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* added more comments and fixed channel labels
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* added state enums
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* added missing modifiers
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* fixed typo in comment
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* upstream changes
Signed-off-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
Co-authored-by: Thomas Lauterbach <lauterbachthomas@gmail.com>
* Ensure unnecessary trailing zeroes are removed, to avoid issues with transformations.
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* Change to use setScale()
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* [verisure] Adapted to new authentication process and support for non MFA activated user. (#11228)
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* Updated after code review.
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* Updated after code review.
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* Updated after code review.
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
* [logreader] Added hint about case sensitive patterns
- Added hint about case sensitive patterns
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Added support for DECT500 and HAN-FUN bulbs
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Incorporated comment from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
The Thing definition in () in l193 references the *name* that was assigned in l192, correct? So they should match.
Or do I misunderstand the mapping here ?
Signed-off-by: Markus Storm <markus.storm@gmx.net>
* Added new channel:
* secondActionPressed: Indicates if second action of rocker switch is pressed too
* Added two new profiles for channel rockerSwitchAction:
* rockerswitchaction-toggle-switch
* rockerswitchaction-toggle-player
* EnOceanSensorHandler can now handle extensible channels too
* EEP F6-02 refactoring
Also-by: Dietmar Franzen <dfranzen@fb3.fra-uas.de>
Signed-off-by: Daniel Weber <uni@fruggy.de>
There was a harmless race condition between a message being written
and the PIM being initalized to message mode by the binding. This adds
a latch to ensure writes happen after initalization.
Signed-off-by: Marcus Better <marcus@better.se>
* Add raw channels for state, program and phase.
* Provide program/phase texts when missing from XGW 3000 and for multicast.
* Consistent handling of missing program/phase text across all appliance types.
* Fix tumble dryer example configuration.
* Changed tumble dryer Finished phase text for consistency.
Fixes#11335
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
The XStream.setupDefaultSecurity method is deprecated since XStream 1.4.18.
It no longer does anything, because this is the default in newer XStream versions.
Signed-off-by: Wouter Born <github@maindrain.net>
* Fixes an issue now that the binding is not polling the snapshot anymore where the jpg could return an old image from cache.
* Fixes an issue that could be caused if you spammed the refresh key whilst watching ipcamera.mjpeg
* Improvements in stopping the servlet and stopping any open streams if the pause button is pressed on a camera thing.
* Reduces memory, thread and open file descriptor resource use.
* Fixes empty passwords create bad log output for logged ffmpeg commands.
* Fix for INSTAR cameras that created a WARN about bad user/pass when setting up the alarm server.
Closes#11301
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Switch properties files encoding from ISO-8859-1 to UTF-8
Crowdin will generate translations in this encoding, so this prevents a lot of diffs which makes it easier to review future Crowdin PRs.
Related to openhab/openhab-core#2298
Signed-off-by: Wouter Born <github@maindrain.net>
* [upb] Fix retry logic
The retry logic was broken so it never retried. This fixes it and adds
unit tests for the serial communication and retry behavior.
Signed-off-by: Marcus Better <marcus@better.se>
* Remove excessive log
Signed-off-by: Marcus Better <marcus@better.se>
* [pulseaudio] Fix sink-input configuration and other small improvements (#11272)
The binding requires a parameter to activate the parsing of sink-input entries on the pulseaudio server. This patch :
- document this behaviour
- fix the parsing of these parameters if a configuration file is used (the old method of casting launched a class cast exception)
Other small improvements :
- Force a refresh/new parsing when the configuration changes
- Fix scheduled disconnection : if a sound is played during the grace period, the scheduled disconnection is postponed, not added to the last
- add a possibility to never disconnect the audio sink (in order to have a lower latency when playing sound)
Closes#11272
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Small fixes after proofreading
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Fix: Start UPNP listener to catch power off button, thing id in log
messages
Signed-off-by: Markus Michels <markus7017@gmail.com>
* comment removed
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Improvements for temperature channels
Fixes#11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Added jlaur as miele binding maintainer
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix spinning speed for washing machines
Fixes#11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Added time as category for DateTime-related channels
Fixes#11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Elapsed/remaining time channels are no longer marked as advanced.
Fixes#11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fixed type for temperature item examples.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Document all states (cross-appliance).
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Improved error handling for getTemperatureState
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Split current/target temperature into two channel types for label reuse
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix possible NullPointerException
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Distinguish between oven program temperatures
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Mark oven program temperature 1 and 2 as advanced.
Fixes#11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* [helioseasycontrols] reference heliosventilation binding
There are two binding supporting different types of Helios ventilation systems. Cross referencing the bindings in their descriptions should help users identify the right binding for their device.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Fix typos.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Do not expose getTypeClass through interface.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix channel supercool for fridges and partially fix supercool/superfreeze for fridge-freezers.
Fixes#11320
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix two-way channel synchronization for supercool/superfreeze for fridge-freezer.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* [Luxtronik] Fix possible out ouf bound error for older heatpumps
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
* fix typo
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
* [nanoleaf] reimplement touch detection based on sse, stabilize behavior
* [nanoleaf] add swipe support
* [nanoleaf] add / tested full shapes support
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
* [lifx] Add channels for controlling absolute color temperature in Kelvin
Adds an 'abstemperature' channel to all Thing Types for controlling the absolute color temperature in Kelvin.
MultiZone lights also have 'abstemperaturezone' channels that allow for controlling the color temperature of a zone in Kelvin.
These channels make it easier to use the same color temperature with lights that have a different color temperature range.
Furthermore the channel type tags have been updated which simplifies using the generated items with the semantic model.
Signed-off-by: Wouter Born <github@maindrain.net>
* Fix Potential null pointer accesses
* Added constants for TCP port and poll interval in seconds.
* Extract interface from DanfossAirUnitCommunicationController.
* Remove unused constants which seems to be left-overs from skeleton.
* Added constant for discovery timeout value for readability.
* Created handler subfolder for DanfossAirUnitHandler (like discovery) for consistency with other bindings.
* Handle lost connection gracefully without updating all channels to zero.
* Fix infinitly blocking network calls preventing proper error handling.
* Fix thing status being reset to ONLINE after failing to update all channels.
* Fix error handling when receiving invalid manual fan step.
Fixes#11167Fixes#11188
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Move to using 8080 servlet not Netty.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add some mjpeg features to servlet.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix autofps bug
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Reached feature parity.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Cleanup serverPort from cameras.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* bug fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Refactor groups.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Bug fixes to groups
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update readme
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Cleanup
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* clean up 2.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* bug fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improve snapshot fetching for autofps.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make functions synchronized.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Abstract servlets
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix NPE warnings
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove ability to go child or parent folders.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* autofps improvement
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix NullPointerException at OneCall-API
* reduce min refreshInterval from 10 to 1 min to support paid plans
Signed-off-by: ehora <oliver.raible@yapoware.com>
* Implement HEV packets
* Add colorhevlight thing type with a hevcycle channel
* Update documentation
Signed-off-by: Wouter Born <github@maindrain.net>
* Fix multicast and multi-protocol support (ZigBee/Wi-Fi)
* Fix channel description referring to hood but also used for oven and other appliances.
* Fix auto-discovery finding already configured things through files.
Fixes#11242Fixes#11243
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
HM devices provide not only 'long press' events, but also 'long
press continued' (sent in configured long press interval) and 'long
press released' events. So far, those events were swallowed in the
button datapoint handler.
Improve the situation by forwarding those events to the button trigger
channel, making them usable in e.g. rules that react on button long
presses.
A double press timeout of 2 seconds is too long and disturbs single
press processing. Additionally, for double press processing to be
useful, the first press would need to be swallowed until double press
timeout elapses, which is not what happened here: the first PRESS was
sent out as SINGLE_PRESS event, making it impossible to meaningfully
distinguish the 'single press' and 'double press' events within rules.
If needed, double press handling can be implemented equally well within
a rule.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
* Add Hub configuration option hardRefreshBatteryLevel for refreshing battery status more frequently.
* Explicitly update battery channels to Undefined when data is missing or invalid.
Fixes#11259
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Add configuration option to auto load metadata channels
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Debug message
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* [icalendar] Fixes#11084: Different method for retrieving events
Replaced retrieval of events for CommandTags by another, already implemented method, fixing wrong behaviour in case of moved or removed events. Also updated dependencies to get this binding resolvable again.
Signed-Off-By: Michael Wodniok <michi@noorganization.org>
* change MyQ binding to use now required oAuth for authentication
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Clean up error handling
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Cleanup checkstyle errors
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* missing newline
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Remove unused classes
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Add token listener
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* add a redirect limit...just in case
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Don't resue the oAuth service if we have been disosed or its closed. Reduce logging verbosity.
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Force login if we get a 401 response
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* [linky] Removed from the distribution until it is fixed
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Apply spotless
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fixes#11170 by introducing an intelligent thread.sleep (getting the duration of the sound, if possible, then wait the appropriate time for letting the sound play). By the way, the method to get the sound duration is not as easy as I thought.
Also fix a minor issue with the last volume not propertly saved.
And fix some minor warnings by using final local variable.
Signed-off-by: Gwendal ROULLEAU <gwendal.roulleau@gmail.com>
* [powermax] Introduce some new channels for better status reporting
* New panel channels:
- Ringing indicator (the siren is currently sounding)
- Date/time the last message was received from the panel
- List of all active alarms and alerts (similar to panel's
Memory list, but items get removed from the list as conditions
resolve)
* New zone channels:
- Alarmed indicator (zone is in alarm, or has an alarm in memory)
- Tamper alarm indicator (same but for a tamper condition)
- Inactive indicator
- Tamper indicator (zone is actively tampered right now)
- Last status message received for this zone, and when
* Use descriptive names for zones in log messages. If you create a
Thing for a zone, it will use that Thing's label in all reporting
for that zone. If there's no Thing then it will attempt to use the
zone label from the panel (e.g. "Basement").
* Clear all channels during startup to keep from displaying stale
values loaded from persistence
* Also includes some minor SAT fixes (checkstyle, spotbugs)
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Incorporate review feedback from lolodomo
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* [nuki] Opener support and discovery (#10671)
* Added Opener support
* New Smartlock channels
* Discovery support
* Secured communication using hashed token
* Improved callback handling
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed code style problems
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Id of bridge is unique for openhab instance
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Added compatibility with smart lock created by previous binding version
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Secure token configuration + threading improvements
Added configuration option to enable or disable using hashed token
for bridge API authentication.
Turning bridge offline when device request fails.
All HTTP calls made async so that openhab thread is not blocked.
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Only discover bridges which return some response
Only bridges which return 200 or 403 response are discovered.
Nuki API might return bridges which no longer exists or are on different
network and are not reachable. We do not want to put these in inbox, only those
who respond do HTTP calls.
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Changed ownership of nuki binding
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Fixed @Nullable annotations
* Fixed too many logger messages
* Rewritten configuration to use configuration class
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* NukiId moved back to configuration and switched to configuration classes in all devices
* Doorbell ringing channel switched to trigger channel
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Channel description reformatted into table
* Fixed bug where repeated bridge discovery was overwriting existing bridge properties
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed ringactionTimestamp property name
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed search of changed thing in HTTP callback
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Improvements to uuid generation
* Bridge id is generated only from bridgeId property, making it stable across openhab installations
* Using InstanceUUID as unique callback identifier instead of bridge id
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Improved duplicate thing discovery
* Implemented duplicate thing detection using openHAB ThingRegistry
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Fixed all nullable warnings
* Fixed README formatting
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* [twitter][WIP] Initial contribution
using the 1.x binding as a template, I created a new Twitter Binding.
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com> (github: computergeek1507)
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* trying to fix twitter4j dependency stuff
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* add to bundle POM
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* trying to fix build
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Fixed dependency issues, Got Actions working
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* updating readme
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* fix class name
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Fixes based on review
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Cleanup based on review and mvn checks
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* grammar fix
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* remove Apache dependencies
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* added Null Checks based on review
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* change null check around
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Add new batteryVoltage channel.
Fixes#11154
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix documentation for lowBattery.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Organized channels into two groups: Shade and Battery.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Revert breaking change.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Change Humidity channel from Number to Number:Dimensionless
* Fix documentation for temperature channels.
Fixes#9755
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Use system default channel type for battery level.
* Add channel categories where applicable
* Add missing channel descriptions (and fix two existing)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
New channel "status-distance" that shows the distance of the robot from
its charging station while it is searching for the remote starting point.
Signed-off-by: Stefan Triller <github@stefantriller.de>
* MQTT.Homeassistant Climate support
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant synthetic config test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant refactoring
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant discovery test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant thing handler test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant switch test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Climate test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant author header added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant copyright header added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test fixed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test fixed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test infrastructure updated. Added tests with mqtt publishing and commands posting.
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant fixed Climate#send_if_off handling
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant do not filter the power command
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant climate unit test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* Update bundles/org.openhab.binding.mqtt.homeassistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/DiscoverComponents.java
Redundant annotation removed
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* MQTT.Homeassistant Redundant @Nullable annotations removed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Unit tests added for all components
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Unit tests stability fix
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant @NonNullByDefault removed from Device, config.dto package created
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Climate author added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Device.sw_version renamed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant tests wait timeout increased to 10s
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Co-authored-by: antroids <antroids@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Currently openHAB and the CCU are using different values for the same state of a rollershutter.
Added information about this under Troubleshooting and listed some examples.
Signed-off-by: Michael Bredehorn <michael@bredehorn.nrw>
* Fix urls are null until binding restarts.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to using port config.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* automate the ffmpeg output folder to follow the UID.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* spotless fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* change to using the userdata folder.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* change to better field description.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add advanced.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add link to docs.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve example path in readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.ipcamera/README.md
Cut and paste bandit strikes again. thanks.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Change to using ipcamera as folder loc.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improve Ffmpeg motion and refactor to remove compiler warnings.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [hydrawise] Migrated to new GraphQL based API
Fixes#7261
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Addressed PR comments.
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Address PR review comments.
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Initial contribution of AmpliPi binding
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* change http client from cxf jax-rs to Jetty
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* applied spotless
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Remove Jackson dependency
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Add support for input handling
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Clean up, improvements and documentation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Remove unused password from configuration class
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Remove example properties file
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* revert change in .gitignore
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Update README
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Address review feedback
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Handle ExecutionException as network error
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* [js-transform] Introduced support for additional parameters
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* Added junit tests and updated readme
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* Typo fixes
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* Typo fix
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* Fixed junit test
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* [orbitbhyve] initial contribution
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* [orbitbhyve] improvements based on code review
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* [orbitbhyve] next bunch of fixes related to code review
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* Update bundles/org.openhab.binding.orbitbhyve/src/main/java/org/openhab/binding/orbitbhyve/internal/OrbitBhyveHandlerFactory.java
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Add white shortcut for sat threshold
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix compiler warnings.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* [homeconnect] Predefined temp / spin speeds options for unsupported washer programs
Fix#10701
Also save in programs cache the unuspported program
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Use constants OPTION_WASHER_TEMPERATURE and OPTION_WASHER_SPIN_SPEED
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment : using constants
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [miio] Minor improvement documentation & message
* [miio] minor cleanup from sat
* miio] fix another minor datetimeformat SAT issue
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Currently, when a message is received the command will be determined only from the hard-coded set of ON/OFF commands, which means if I configure
a thing and attach it to a switch there is no guarantee that it will respond as expected to receive commands. This PR changes the message factory
to require either bytes (from the RFXcom device) or all the details required to make a transmissable message, including the confguration of the
associated Thing. At the moment, this is only used by lighting4 and raw types, but I expect it will be useful for others in the future.
The hard-coded ON/OFF commands in lighting4 are based on experimentation with different devices, and are not at all consistent. This PR deprecates the
use of those so that in a future release, Lighting4 devices will only work when configured with the correct command ids up front. This will resolve
inconsistent behaviour where devices that have been discovered may work correctly, work only for ON or OFF but not both, have ON and OFF the wrong
way around, turn ON one physical device and OFF another, or any combination of those possibilities.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* [volvooncall] Extend battery channels
Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.
Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
* [fmiweather] Fix UNDEF observations in corner case situations.
In addition, tests added for static utility functions in
AbstractWeatherHandler.
Resolves#11024.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
The set of available HM-MOD-EM-8 channels varies depending on the
function a given channel is configured to use, which is why for those
devices we can't determine a static ThingType, but instead must populate
the thing channels on initialization. The existing code already handled
that case, but missed registering channel types for the dynamically
generated channels, which is why those channels were not shown in main
UI.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
* [mielecloud] Less strict e-mail validation
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
* Some more e-mail validation test cases
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
Co-authored-by: Björn Lange <bjoern.lange@tu-dortmund.de>
* Adding localization and a bit of code cleansing.
Signed-off-by: clinique <gael@lhopital.org>
* Review corrections
Signed-off-by: clinique <gael@lhopital.org>
* Bulk updated to UOM.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* ipObserver creation
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Bulk updated to UOM.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* channel fixup for UOM.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve UOM.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* updates
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Battery ch fixed.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix time channels.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* readme update and remove %unit% from rain channels.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* readme fixup.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* edit global files.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix merge conflicts.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix up build issues.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* remove reboot channel.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* readme fixup.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Rename channels to put kind first.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update to build on latest main.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add support for outBatt1
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Added auto discovery.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* add bundle to POM.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* newline added.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix bug in discovery.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Added tags
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update to 3.2.0-SNAPSHOT
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.ipobserver/src/main/resources/OH-INF/thing/thing-types.xml
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Update bundles/org.openhab.binding.ipobserver/src/main/resources/OH-INF/thing/thing-types.xml
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Clean up channels
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update binding description.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix jsoup suggestions.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.ipobserver/src/main/java/org/openhab/binding/ipobserver/internal/IpObserverDiscoveryService.java
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Update bundles/org.openhab.binding.ipobserver/src/main/resources/OH-INF/thing/thing-types.xml
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Removed nullable.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improvements
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix compiler warnings
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to datetime
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* change to use system channels.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Move to Number:Intensity for solar
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type
Closes#10812
Signed-off-by: Colin Keehan <github@colin.xyz>
* Cleanup of binding configuration classes
* Added context to CaddxMessage
* Logging enhancements
* Added support for ignoring Zone Status Transitions
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* [ihc] Improved command handling when controller is not ready
When connection from binding to IHC controller is open, but controller
is in programming state, things state is offline with special status to
indicate that binding can't send or receive any resource updates at the
moment. Things status check during command sending will prevent
unnecessary resource updates which will eventually fail and binding then
tries to restart the connection.
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* Fixed a rare NPE introduced while replacing commons-lang
* Provide additional null pointer checks
It is possible that the meta data returned for some device does not
contain a default or maximum value.
Fixes#10945Fixes#10961
Signed-off-by: Martin Herbst <develop@mherbst.de>
* fixed typo in example
* Updated the instructions on how to find buttonPress values
openHAB 3.X put the REST API behind authorization and the old URL no longer works in the browser due to an authentication error. These new instructions allow for a trivial way to find the commands.
Signed-off-by: Jerry Gallo <2wyck3d@gmail.com>
* Improve matching the command responses to the sending channel
* Use newer method to get device list using `device_list_page`
* Adding the ability to send custom requests to cloud
* Adding the ability to send custom commands with additional elements in
the json
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Fix: current channel would not get added.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix: online and offline now detect correctly.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improve discovery.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Bug fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Misc Improvements and log cleanup.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make current sensor channel dynamically get removed if not supported.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix compiler warning.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* readme updates.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Shift refresh()
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add RSSI and water flow meter count channels.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to flowSensorCount
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix bug
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix NPE on parsing jsReplies.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add new programs channel.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix wrong api use.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to using max time if the time is null.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add device withRepresentationProperty
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update readme
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix rain sensor not working in 219 firmware.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Spotless fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix gson double up error.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add more channels
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* refresh completed before bridge goes online.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Simplify.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Allow non default password to not stop discovery.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add ignoresRain channel
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Simplify commands in station handler.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add new rainDelay channel.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make constants consistent.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add categories.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Changes requested by FlorianSW
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Stop catching and throwing new exp.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Create a state class.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/discovery/OpenSprinklerDiscoveryService.java
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* Fix for EOF exception that stops polling with bad wifi.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change signal strength over to 0-4 range
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Handle toUnit null returns.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Support discovery on subnets that are not /24
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* update readme for recent changes to signalStrength channel.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix code anal issue and readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove info logging.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* remove traces of old dependancy.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Changes for fwolter
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* support RSSI and rssi
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update after new command sent.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve delayedRefresh
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove supressWarnings
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* [openwebnet] changed ALL_DEVICES_REFRESH_INTERVAL to 60s
to avoid lights/shutters status updates flooding
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] added UPnP discovery for MyHOME_Screen3,5.
Updated catalogue links in README
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [miio] change deviceID to Xiaomi used string
Change the deviceId from the current hexadecimal to the string used by
Xiaomi.
This is needed as we have some devices that have deviceIds that are
non-numeric, hence breaking the current logic.
Note: separately removing the upnp discovery as this has become
irrelevant with cloud discovery and devices supporting the udp regular
discovery.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [homematic] Add HM-MOD-EM-8 properties
If a HM-MOD-EM-8 channel is configured to 'sensor' mode, it advertises a
STATE datapoint, which we should both display as non-advanced and give a
description.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
If a player goes offline (it e.g. lost power or network connection),
mark it as such in the thing status.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
This enables raw message transmission by configuring a raw thing with pulses to
send for either ON, OFF, OPEN or CLOSED commands.
To enable extended config, this includes a refactor for the RFXComHandler to
support different Configuration objects depending on the thing type, and moves
the parsing, validation, and message matching logic to the Configuration objects
where the logic is more appropriate.
To enable testing of the RFXComHandler, the RFXComMessageFactory was abstracted
out and injected as a dependency.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* Added service references to DynamicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* - bus_thermostat renamed to bus_thermo_zone
- bus_temp_sensor renamed to bus_themo_sensor
- linked OWN4j 0.5.3-SNAPSHOT (camelCase for enums)
Signed-off-by: Conte Andrea <andrea@conte.com>
* updated ReadMe according to things renaming
Signed-off-by: Conte Andrea <andrea@conte.com>
* Updated readme and thermo thing labels. Renamed thing descriptors to BusThermoZone and BusThermoSensor
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* using own4j release 0.5.3
Signed-off-by: Conte Andrea <andrea@conte.com>
* removed json tags in README. Added KG4691 to tested thermostats
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Co-authored-by: Massimo Valla <mvcode00@gmail.com>
For the bindings homeconnect, lgwebos, netatmo, remoteopenhab, rotel,
somfytahoma, sonos and sonyprojector
Depends on openhab/openhab-core#1505
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [ADD] First version which was tested with my local setup.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
Signed-off-by: Sven Carstens <sven.carstens@aoe.com>
* [ADD] Refactoring, add calculated value for direct self consumption and prepare for more.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [ADD] Add chanel description to README and make some channels advanced.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Remove wrong colon in channel types.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Put colon at the right place in channel types.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Fix spelling of PVPlant in constants and things.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Separate channelName from energy manager tagName.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Reduce loglevels and fix findings from code-analysis.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Move all custom calculations to the handler instances, remove custom tracking of child handlers, fix wrong calculation of the "direct consumed" values.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README and remove unnecessary Nullable and NotNull annotations.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Change wrong ItemType for power items in README
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Change modeConverter to Switch
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Relay stateDevice to Thing status, anything but "OK" means ThingStatus.OFFLINE
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Remove stateDevice from items as it is represented by the device status.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README and remove unnecessary logging.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Allow child things to be configured by hand with a guid.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Allow child things to be configured by hand with a guid.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README and move things config to separate config.xml
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Improve README and remove all trace/debug logging.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
* [MOD] Use real channel timestamp as the refresh trigger.
Signed-off-by: Sven Carstens <s.carstens@gmx.de>
Co-authored-by: Sven Carstens <sven.carstens@aoe.com>
* Add Unit handling functionality to SNMP Reads
Signed-off-by: James Melville <jamesmelville@gmail.com>
* Use core library for Unit parsing
Signed-off-by: James Melville <jamesmelville@gmail.com>
* [ihc] Support for TLSv1.2
So far IHC controller have supported only TLSv1. As TLSv1 is already
deprecated and upcoming IHC controller FW version will introduce support
for TLSv1.2.
This change introduce TLSv1.2 support for the binding. TLS version is
selectable to be backward compatible for older controller versions.
Communication error handling is also improved e.g. because of wrong
password or if Java environment doesn't support required TLS version.
When fatal communication error occurs, binding will not hammer
controller with retries as it need user actions.
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* [ihc] Introduced auto mode and other improvements
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* [ihc] introduced default constant
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
* [homeconnect] 9 channels added for washer appliance
Corresponding to 9 program options not fully supported by the API.
Fix#10704
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: formatting in XML thing file
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: add these new channels (except i-DOS) to washerdryer appliance
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: method isLinkedChannelsForUnsupportedFeatures renamed
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Change state options for rinse plus channel
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Update the new channels when the active program is updated
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: update documentation
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: typo in channel description
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [nest] Add support for Smart Device Management (SDM) API
* Reworks WWN implementation so that the thing types have a wwn_ prefix and the classes have a WWN prefix and reside in a 'wwn' package
* Adds an SDM implementation which is also based on: https://github.com/bhigg-code/openhab-addons/tree/2.5.x/bundles/org.openhab.binding.nestdeviceaccess
* Adds unit tests for (de)serialization of the SDM and Pub/Sub API requests and responses
* Updates the binding documentation for the changes and additions
Fixes#8664
Also-by: Brian Higginbotham <brianhigginbothamtx@gmail.com>
Signed-off-by: Wouter Born <github@maindrain.net>
* Fix and improve documentation
Signed-off-by: Wouter Born <github@maindrain.net>
* Always use UTF8 when decoding SDM events
Signed-off-by: Wouter Born <github@maindrain.net>
New firmware type reported from the community that's not in the SDK. Also,
we don't actually _use_ the firmware type or device type for anything, so
lets not crash if we don't match the bytes - lets just flag it unknown.
https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Based on the RFXtrx SDK, new blind types. They mostly seem to match existing logic,
so this shouldn't break existing things.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* [homeconnect] Improve logging of SSE connection and add backoff interval in case of connection error
Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
* [homeconnect] Fix SSE authorization header problem
Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
* [homeconnect] Fix synchronized monitor
Signed-off-by: Jonas Brüstel <jonas@bruestel.net>
* [miio] add support for Mi Smart Standing Fan Pro Global (dmaker.fan.p15)
add support Mi Smart Standing Fan Pro EU/Global (dmaker.fan.p15)
Improve p8 & p9 fans
close#10843
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] improve timeunit
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* fixes#10738, #10799
Signed-off-by: Markus Michels <markus7017@gmail.com>
* - Feature #10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change #10039 Info on "not reachable / timeout" should be warning,
not info
- Fix #10799 Missing Channel Definition for Vibration Events
- Fix #10738 Shelly UNI - ADC Voltage units of measure missing
- Fix #10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* #10737 Shelly EM - add powerFactor channel support
Signed-off-by: Markus Michels <markus7017@gmail.com>
* README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* channel powerFactor (EM+EM3) is now of type Number:Dimensionless
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Fix for #10864: Do not trigger same alarm within 5 minutes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* better logic for alarm filter
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Fix exception in aggregation function when daily forecast is empty
Also catch any Exception to prevent thread from crashing
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* Refactor to improve robustness of calculations
Improve tests to cover different forecast scenarios
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* Fix urls are null until binding restarts.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Change to using port config.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* automate the ffmpeg output folder to follow the UID.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* spotless fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* change to using the userdata folder.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* change to better field description.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add advanced.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add link to docs.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* improve example path in readme.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update bundles/org.openhab.binding.ipcamera/README.md
Cut and paste bandit strikes again. thanks.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Change to using ipcamera as folder loc.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Based on both the SDK and experimentation, this commit correctly identifies the
firmware and hardware version. A warning has been added for people with really
old firmware that may be different, but we didn't handle those different cases
well anyway.
Also includes updated firmware types and device types and support for pretty-
printing of the device and firmware type.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
This is a new feature in the Pro firmwares that provides the real raw RF
pulse lengths as shorts. Good for being able to parrot switches that aren't
otherwise supported, once we add the tx support as well.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* Update unit formating
Signed-off-by: Matt Myers <mmyers75@icloud.com>
* Updates per last review
Signed-off-by: Matt Myers <mmyers75@icloud.com>
* Updated units to decimal
Signed-off-by: Matt Myers <mmyers75@icloud.com>
* [semsportal] Allow portal and station cofiguration with .things file
Signed-off-by: Iwan Bron <bron@olisa.eu>
* Fix README.md warning
Signed-off-by: Iwan Bron <bron@olisa.eu>
* Make thing type better visible in documentation
Signed-off-by: Iwan Bron <bron@olisa.eu>
Co-authored-by: Iwan Bron <bron@olisa.eu>
There's no reason not to read multiple bytes at a time (that I could find) so
for best practice, set the read limit to be the maximum size of an rfxcom
message. Tested fine on my system.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* correct handling of system date/time field to close#10684
Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
* further fix
Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* Provides the ability to specify a timeout in the config, instead of using hardcoded 10 seconds.
Signed-off-by: Geroen Dierckx <geroen.dierckx@gmail.com>
* Use a single numeric type (double), remove ints and floats
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Rebases with master. Fixes All Checkstyle warning, renames package 'model' -> 'dto'
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Prevent possible NPE
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Spotless
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Fixes missing unit information (especially for HmIP devices)
For some HmIP devices the "valueunit" attribute is empty and thus no
default unit type could be derived. Using the data point name solves
this problem (at least for the relevant data points).
Fixes#10533
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Condition result was wrong because of missing brackets
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Regenerated and reorganized descriptions
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Encoding changed to UTF-8 and some smaller text corrections
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Use default value as maximum if is greater than received max value
For some devices the data point definition retrieved from the CCU
contains default values that are higher than the maximum value. In order
to allow the configuration of these config options the allowed maximum
value needs to be set to the default value.
Fixes#10552
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [VENSTAR THERMOSTAT BINDING] ADD AWAY MODE
Signed-off-by: Matthew Davies
matthew.davies@skynet.be
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* [VENSTAR THERMOSTAT] FIXED COMMAND AWAY MODE
Signed-off-by: Matthew Davies
matthew.davies@skynet.be
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE AFTER INITIAL COMMIT FEEDBACK
This code includes the Away mode of the Venstar thermostat. It is
updated following initial feedback and suggestions on my first version
from @digitaldan.
Signed-off-by: Matthew Davies <matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT BINDING - INCLUDE AWAY MODE
Removed the updateThermostat function, now have updateSettings and
updateControls corresponding to local API URLs.
Signed-off-by: Matthew Davies
<matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE - Modification updated as per feedback 1
June 2021
Signed-off-by: Matthew Davies
<matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE INCLUSION - UPDATED README
Signed-off-by: Matthew Davies <matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
new channels frequency and power factor.
Signed-off-by: Martin Hubert <github@martin-hubert.de>
Co-authored-by: Martin Hubert <github@martin-hubert.de>
* [velbus] Add new functionality PRESSED and LONG PRESSED and fix bug
New functionality:
Add the the possibility to simulate the PRESSED and LONG PRESSED message of an input.
Module supported with button simulation :
VMB1RYS (button : CH6)
VMB6IN (buttons : CH1 ... CH6)
VMB2PBN, VMB6PBN, VMB7IN, VMB8IR, VMB8PB, VMB8PBU, VMBEL1, VMBEL2, VMBEL4, VMBGP1, VMBGP1-2, VMBGP2, VMBGP2-2, VMBGP4, VMBGP4-2, VMBGP4PIR, VMBGP4PIR-2 (buttons : CH1 ... CH8)
VMBELO, VMBGPOD, VMBGPOD-2 (buttons : CH1 ... CH32)
Fix bug:
The channels names were not correctly assigned to the thing properties. The last channel had the default name, not the one retrieved from the module.
Also-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
Use the provided planned time for a washing program to set the channel "remaining_program_time_state" when no program is active
Fix#10744Fix#10703
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also-by: Bert Plonus <bert.plonus@miele.com>
Also-by: Martin Lepsy <martin.lepsy@miele.com>
Also-by: Benjamin Bolte <benjamin.bolte@itemis.de>
Signed-off-by: Björn Lange <bjoern.lange@itemis.de>
Previously there was a mismatch between the UIDs used by the handler and
the one actually registered from the XML-file.
This lead to channels not showing up in the UI.
(See https://github.com/openhab/openhab-webui/issues/406 )
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
To avoid the core framework updating automatically an item state while a
command is sent to this item but its handling by the binding is failing
or ignored
Fix#10700
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [homeconnect] Returns an empty list of options for an unsupported program
Fix#10689
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: List.of
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix problem with historical Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* add scheduler to start/stop sending instantaneous consumption
Signed-off-by: Conte Andrea <andrea@conte.com>
* added scheduler also in Initialize() in order to start reading data of a newly discovered thing
Signed-off-by: Conte Andrea <andrea@conte.com>
* removed setActivePowerNotificationsTime() from dispose()
Signed-off-by: Conte Andrea <andrea@conte.com>
* add log in dispose() method
Signed-off-by: Conte Andrea <andrea@conte.com>
* temperatureHotWaterTarget channel is writable
* temperatureTargetHotWater_2 channel doesn't exist in the binding
Signed-off-by: Martin Kurgi <martinkurgi@gmail.com>
* Adapted to new checkstyle
Signed-off-by: Markus Michels <markus7017@gmail.com>
* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"
Signed-off-by: Markus Michels <markus7017@gmail.com>
* #10617 Vibration event added for DW2
Signed-off-by: Markus Michels <markus7017@gmail.com>
* brackets
Signed-off-by: Markus Michels <markus7017@gmail.com>
* some unused stuff/code removed
Signed-off-by: Markus Michels <markus7017@gmail.com>
* [somfytahoma] Open to other portals
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: suppress the advanced setting for cookie handling
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Fixed ColorTemperature set to UNDEF
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Fixed SAT findings
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Fixed warning during unit tests
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Changed color temperature handling in GroupHandler
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Changed default color mode for color commands to XY
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* [MongoDB Persistence] Rename connectToDatabase to tryConnectToDatabase.
Currently, the implementation throws a RuntimeException.
This fails horribly in query() and store(), because the exception is never caught and connection reestablishment won't happen.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix JavaDoc
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix Bundle name
The correct database name is "MongoDB" without a space.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Also check for connection validity in isConnected()
When the connection was established successfully once, and the server goes down (e. g. a restart of the DB server), the connection still seems to be OK.
This would throw an exception later on, which is not caught and connection reestablishment won't happen.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Disconnect from database before reconnecting to database.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Disconnect from database when connection procedure fails.
When, for example, the creation of the index fails (disk full, ...), the connection is still there, but the collection isn't created with it's appropriate indices.
Thus, disconnect when the procedure fails to ensure no database connection remains valid.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix logic
Create the shared collection with its indices when collectionPerItem is disabled, not enabled.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Access database via getDatabase()
Preparation for synchronization.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove global mongoCollection variable.
This allows to easify implementing necessary multithreading locks.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Codestyle improvements.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Move isConnected-Check into tryConnectToDatabase.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Synchronize all connection handling methods.
Though the MongoDB driver is thread-safe, we still need to synchronize connection establishment/closing/...
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove all unnecessary @NonNullByDefault attributes.
The given attributes should not be NotNullByDefault, because some may be null, too.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove duplicate logging.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Test the db connection after creating the MongoClient.
The mongo always succeeds in creating the connection.
We have to actually force it to test the connection to try to connect to the server.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix date query.
Issues:
- Second should have been getEndDate, not getBeginDate
- Send a Date object as the other version wasn't serializable.
- EndDate would have overridden beginDate.
Fixes#10574
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add debug log for MongoDB query sent to the server.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Reorder index on collections.
The order (Item, Timestamp) makes much more sense and should be better for performance.
All queries are always done with an item, and the dates are optional.
Also, the database server can now execute a range query for the date.
Existing indices are not dropped for backwards compatibility with other systems analyzing the data.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add @author JavaDoc as per developer guidelines.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Improve logging
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add @NonNullByDefault
This was removed in 1f8e4525 by mistake.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Do not use isConnected() to test the connection.
The new method throws the real underlying exception instead of a generic one. This allows for detailed logging.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove useless @inheritDoc as per code analysis tool.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* Unnecessary NonNull annotations removed
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* Bugfix "If network connection is interrupted, WebThing will not be reconnected." Due to the variable webThingURI is unset, re connection fails
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* webThingURI will be loaded in a lazy way
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* Do not discover on ENTRY_MODIFY
ENTRY_MODIFY is triggered on each keypress multiple times, so we should
not trigger on it.
The usecase for ENTRY_MODIFY triggers where detecting permission changes
of the event nodes.
Inotify does have a dedicate event ("ATTRIB") for that but Java
WatchService normalizes this to a ENTRY_MODIFY event
(See LinuxWatchService.java)
After permission changes users now have to trigger a scan manually.
* Use proper representation property
* Show event node in label
This makes it easier to figure out which thing is which device in the
presence of symlinks or multiple identical devices.
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
* Fix broken image & dashboard links in rendered online documentation
* Fix prerequisite version in documentation (do not use milestone version)
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
This change accepts a new message type which is sent by some air ventilation devices durin teach in. This is required for the search feature to detect these devices correctly.
Signed-off-by: David Schumann <david@dev-core.org>
* Accept all Jetty supported http method types
This fixes a number of open issues due to the fact that we were only accepting a limited number of http method types. The effect of this was some functionality like DELETE or HEAD requests would just not work when using the cloud service, which madee our UI look broken in different ways, also it poluted the users log with a lot of messages.
Fixes https://github.com/openhab/openhab-core/issues/2312
Fixes https://github.com/openhab/openhab-cloud/issues/328
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Fixed typo for starting sequence
* Added support for "find me" & "test sound" function
* Added clear names for faults
Signed-off-by: Marcel Bossert-Schwab <mbossertschwab@gmx.de>
Information about how to use Dash Buttons nowadays as Amazon doesn't support them anymore.
Also-by: Wouter Born <github@maindrain.net>
Signed-off-by: Marcel Simat <marcel@freese.name>
* Make clear rfc2217 is supported
* Fix typo
* Update specification link and partial linky support
* Improve wording
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
* Refresh devices after reboot or disconnect
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* Cancel refreshSchdule in dispose. updateStatus messages @text cleanup.
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [velux] break on socket timeout if interrupted flag set
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] pause initialize until pending dispose is done
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] synchronization key is IP address not ThingUID
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging level
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging level, improve user comprehensibility
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] access updateBindingState() externally via static method
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] tweak logging
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] defer refreshBindingInfo until after initialized / disposed
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] refactor method names to show the type of scheduler they run on
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] don't terminate thread early
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] restore calls to updateBindingState
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] logger cosmetics
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging levels
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] change logger level
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] synch on ip address object instead of Future<>; make shutdown timeout explicit; disable HSM on shutdown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] add lock modifier, remove duplicate synchronized, refactor HSM shutdown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] shutdown code was not being called
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] don't convert InterruptedException to IOException
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] let shutdown explicity stop the polling loop
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues"
This reverts commit 022513ee85878f2f9cf2fd27fa3d79d251197c5a.
* [neohub] extra hub properties; hub id in logs (help for multiple hubs)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] run spotless
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] getFirmwareVersion returns null for unknown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] api version enum; tweaked logging
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] fix mvn warning
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] cosmetic for diff
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] device info property, and comments
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] tweaks to fin-ack sequence
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] eliminate irrelevant compiler warnings, and live test errors
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] avert merge conflict with #10525
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] apply changes in anticipation of reviewer approval
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* notify listeners on status change using discovery
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* adapt bridge discovery name to new string broadcast
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* check correctly if current status key is not null
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* change log from warn to debug
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* better handle when currStatus is null
also move logs from warn to debug
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* remove nonNullByDefault annotation
as dto can be null
Signed-off-by: Roie Geron <roie.geron@gmail.com>
* [modbus] gainOffset and bitMask profiles for working with modbus data
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README trailing whitespaces
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README and some final renaming
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] log error with incompatible units
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: test for incompatible unit
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] example renamed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused fields
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: make configuration parameters optional
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] xml indentantion fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static code analysis fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Minor fixes for null checking
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] remove comment
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile README disclaimer with many commands
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Grammar fixes in README
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix bit profile UI configuration
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Bit profile: Added possibility to invert value on read/write
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix typo with explanation of inverted
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile: unit tests for inverted parameter
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static checker fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] write bit feature in data thing
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* wip
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] resolve itest
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix data thing readStart validation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] readme fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Invalidate REFRESH data cache with cacheful writes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] cleanup
- abort if command is not convertible to 0/1 (previously wrote the
cached data)
- fail fast conditionals instead of deep if's
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README Fix typo in example
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix data thing write when child of endpoint
Also added regression test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/config/gainOffset.xml
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [modbus] performance-optimized logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README: Removing xtend syntax hint, not needed anymore
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] generics typing added
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] dead code
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] avoid supressing generic type warnings
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] unnecessary generics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] rename type parameter name
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] QU (short for quantity output) generic type instead of Q2
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused localization
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] profile constant visibility harmonized
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Add Power dimension to PAPP channels
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
* Add PAPP dimension in documentation
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
* [somfytahoma] added support for the Bioclimatic Pergola thing
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* Update bundles/org.openhab.binding.somfytahoma/README.md
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Add audio info channel
Signed-off-by: Jared <39014663+baku104788@users.noreply.github.com>
* Audio Info Channel implementation
Signed-off-by: Jared <39014663+baku104788@users.noreply.github.com>
* remove extra backup file
Signed-off-by: Jared <39014663+baku104788@users.noreply.github.com>
* Update readme info for audioinfo
Signed-off-by: Jared <39014663+baku104788@users.noreply.github.com>
No need to list transitive test dependencies, they are pulled in
automatically. Exception with sqlite4java shared libraries which are
needed for runtime.
With the update of DynamoDBLocal, tests require newer version of jetty
(9.4.18.v20190429), resolving #10502
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Update to SDKv2 Enhanced Client
In addition, introduce new more simple table layout, having only one
table for all items and with more efficient data encoding (saves some read capacity).
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Time To Live (TTL) support with new table schema
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Support QuantityType
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] suppress null warnings in tests
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Optimized query performance
Similar to https://github.com/openhab/openhab-addons/pull/8938,
avoid calling Item.getUnit() repeatedly when querying data.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Support for Group items
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Update copyright to 2021
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Removing TODO comments and add javadoc
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] javadoc
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Readability improved in TableCreatingPutItem
Also documenting the full retry logic.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] verify fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove slf4j from explicit dependencies
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove jackson from pom.xml, add as feature dep
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd.importpackage tuned
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] abort query() immediately if not configured to avoid NPE
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less chatty diagnostics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] xml formatting
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] corrected logger class
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] null checks
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] netty client configured
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd not to filter out importpackage org.slf4j.impl
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] cfg bundle group id
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove usage of org.apache.commons
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove extra prints from test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Reducing @SupressWarnings with generics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] README extra space removed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] spotless
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Removed unnecessary logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] encapsulation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] removed unnecessary NonNullByDefault({}) ctr-injected field
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] null annotations
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less verbose logging in tests
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Prefer Collections.emptyList over List.of()
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less verbose call
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Visitor to return values (simplifies the code)
Less warnings suppressed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] comments for remaining warning supressions
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] README tuning, typo fixing
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Using less verbose syntax
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] simplified logging on errors
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Code review comments
Avoiding null checker while having more compact code
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Null safety
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] configuration label and description formatting
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] xml indentation with tabs
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] @Nullable 1-line annotation with class fields
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] No need to override credentials per request
Client has the credentials set on build time
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] set API timeouts no matter what
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] adding exception message
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] static logger
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] dependency
- comments clarifying the logic of properties
- adding netty to dep.noembedding to ensure it is not compiled in
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] ensure correct jackson and netty versions using dependencyMgt
Specifically for development and testing
See 051c764789
for further discussion why this is needed.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] avoid google collections
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] jackson-dataformat-cbor not jackson-cbor
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] also restrict netty-transport-native-epoll linux-x86_64 version
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] refering dynamodb.cfg similar to other bundles
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd.importpackage to excl. reactivestreams and typesafe.netty
These are compiled-in dependencies, and thus we do not want to have them in
OSGi Import-Package.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.persistence.dynamodb/src/main/resources/OH-INF/config/config.xml
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.persistence.dynamodb/src/main/resources/OH-INF/config/config.xml
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [dynamodb] remove netty-codec-http2 as it is included in tp-netty
See https://github.com/openhab/openhab-core/pull/2257/
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] removed duplicate in bnd.importpackage
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] slf4j-api marked as provided to remove dep errors in runtime
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [ventaair] New VentaAir binding for air humidifiers
New binding that implements support for air humidifier from Venta Air.
Closes#9922
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Added One Call API weather warnings
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Changed Channel title to event
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Update README.md
As i spent hours to figure out the correct document to read about the address scheme, this might help others to avoid this and get this plugin to the same "copy and paste" use as the others, even if the existing scheme already is enough to get it working.
* Update bundles/org.openhab.binding.modbus.studer/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [pulseaudio] Add pulseaudio sink as openhab audio sink (#1895)
This add to the pulseaudio binding the capability to use "pulseaudio sink" as an "openhab sink" to output sound from openhab to a pulse audio server on the network.
You need to load module-simple-protocol-tcp sink in addition to the usual module-cli-protocol-tcp, and enable the sink in the thing configuration.
Closes#1895
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Small corrections after review
And getting rid of some other compilation warnings
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Fix some registration errors and allow the binding to load the simple module remotely
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Small corrections after reviews
initialize audiosink in a thread with scheduler.submit
clear some warning related code.
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Better interruptexception handling
* Fix two small concurrency bugs
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
This simplifies the DSMRHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.
Also contains a few other improvements:
* more constructor injection
* add a few missing @NonNullByDefault on test classes
Signed-off-by: Wouter Born <github@maindrain.net>
This removes the ResponseListener class and replaces it with lambda functions for the various Jetty response listeners. This seems to fix our duplicate onContent issue in #10470 , although i'm not at all clear why.
Fixes#10470
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Removed method that was already marked as deprecated
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Handle HM-ES-TX-WM with firmware version >= 2.0 as different device
The device provides different data points (channels) depending on the
firmware version. Therefore devices with a firmware version >= 2.0 are
handled as a different device.
Fixes#9793
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Don't change uninitialized thing state automatically to online
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Listen to all network interfaces instead of limiting it to only one
This also makes the specification of a separate bind address
superfluous.
Fixes#9855Fixes#10075
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Add support for HmIP-eTRV-C-2 device
The event messages received for this device are not correctly formatted
and thus some special treatment for at least one data point is required.
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Spotless formatting applied
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Update README.md
Avoid confusion connecting RS232 to a CAN bus, wasting days of work...
* Update bundles/org.openhab.binding.comfoair/README.md
Co-authored-by: boehan <boehan@users.noreply.github.com>
Co-authored-by: boehan <boehan@users.noreply.github.com>
* [somfytahoma] New channel on the bridge to execute scenes
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: documentation updated
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Console command added to list the scenarios IDs
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Update state of new channel
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: set auto update policy to recommend
Signed-off-by: Laurent Garnier <lg./hc@free.fr>
* Update HaywardBridgeHandler to set thingstatus online upon succesful getTelemetryData
Signed-off-by: matchews <mmyers75@icloud.com>
* updated default endpoint url
Signed-off-by: matchews <mmyers75@icloud.com>
* Bug fixes. Prevent bridge status toggling if a single request fails. Don't evaluate xml if http response if != 200
Signed-off-by: matchews <mmyers75@icloud.com>
* [tacmi] TA-CMI: Improvements on Schema API Connection
* Removed deprecation warning
* Ensure channels get re-added when removed manually
* Debounce unintended toggeling when status-polling overlaps with new commands.
Status fetching sometimes takes longer and then it occurs the status page reports still the old/previous value.
With this change values for things will be ignored when the thing was updated after the start of the page fetch.
Signed-off-by: Christian Niessner <github-marvkis@christian-niessner.de>
* [tacmi] TA-CMI: Schema API Connection: Bugfix: On initialization check if custom channel types still exists and re-create them when needed...
Signed-off-by: Christian Niessner <github-marvkis@christian-niessner.de>
* [tacmi] TA-CMI: Schema API Connection: Improvement: channels now have a 'updatePolicy' configuration parameter to specify the update behaviour
Signed-off-by: Christian Niessner <github-marvkis@christian-niessner.de>
* [tacmi] TA-CMI: Improvements & some initial SI-Units for the COE connection handler
Signed-off-by: Christian Niessner <github-marvkis@christian-niessner.de>
* [tacmi] TA-CMI: only catch URISyntaxException instead of generic Exception
Signed-off-by: Christian Niessner <github-marvkis@christian-niessner.de>
* This PR brings in the Shelly Manager, check doc/ShellyManager.md for
additional information.
* Restart Device in Manager when CoIoT Mode has changed
* Updated pattern to extract version info (thanks @fwolter), CoIoT warning
for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly
Manager
* Modified message when beta is detected (reference to 1.5.7 release build
confuses users running 1.10 beta)
* Fix for Enable/Disable AP roaming
* Handle button events also in detached mode, README updated
* Ignore inconsistent version string for initial 1.10 releases
* removed display of firmware id (there are various formats and it has
no value)
Signed-off-by: Markus Michels <markus7017@gmail.com>
In the Thing Configuration section starting at Line 40, the code example had parameters transposed versus the preceding description and the true operation of the binding. The correction puts the parameters included in the original example in the thing that they belong with in Lines 80 and 81. The optional notification parameters of the renderer were not included originally and I have left it like that.
Viomi's property battery life seems to have a weird typo. The property's real name is `battary_life` instead of `battery_life`. Using the wrong name `battery_life` makes the other properties in the batch to be undefined: `"run_state","mode","err_state","battary_life","box_type"`
The correct name `battary_life` is already used in other projects like https://github.com/rytilahti/python-miio/blob/master/miio/viomivacuum.py#L316 or 0bed81ab4f/lib/robots/viomi/ViomiValetudoRobot.js (L254)
Signed-off-by: Antonio Tapiador del Dujo <atd@singularities.org>
The fields are used to login with username and password instead of a refreshToken.
They're therefore not required.
Signed-off-by: Florian Schmidt <florian.schmidt.welzow@t-online.de>
* [Automower] Enhanced binding:
- Added support for the planner and calendar data
- Added command channels
- Updated docs
Signed-off-by: Marcin Czeczko <marcin.czeczko@gmail.com>
* [Automower] Fixed consts with channel ids after removal of channel
groups. Improved the mower state update:
- Cache the last read state from API
- Use cached mower state so the items linked will always be up to date
without the need to wait for API refresh period.
- Use timeZoneProvider to user user set timezone.
Signed-off-by: Marcin Czeczko <marcin.czeczko@gmail.com>
* Rolledback NotNullByDefault annotation
Signed-off-by: Marcin Czeczko <marcin.czeczko@gmail.com>
* [somfytahoma] New method to send a command to several devices in the same place
Also include the place into the inbox label (discovery)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: remove unnecessary method
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.
Signed-off-by: Wouter Born <github@maindrain.net>
* [lifx] Improve firmware version support
When the firmware of a light is upgraded the supported features can change.
With these changes the binding uses the features based on the light firmware version.
Also corrects some of the temperature ranges based on the LIFX products description.
Signed-off-by: Wouter Born <github@maindrain.net>
* Add option for using metadata value as measurement name
Also-by: Joan Pujol <joanpujol@gmail.com>
Signed-off-by: Johannes Ott <info@johannes-ott.net>
* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification
Signed-off-by: Wouter Born <github@maindrain.net>
This is a bigger refactoring bringing these (breaking) changes:
- System channel types are used where applicable
- Obsolete channels (such as power) were removed
- Some channel types were marked "advanced"
- "Tap" channels were converted to a trigger channel type providing a "system button" behavior
- Layout can now be requested by a console command
- Command options for effect channel are dynamically provided
- Log level has been reduced where appropriate
- HTTP request timeouts were reduced
- handleRemoval now returns quickly as expected
- Fixed hanging thread / infinite loop when requesting layouts for non-square panels
- Various other smaller enhancements and fixes
- Documentation has been adapted accordingly
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Minor restructuring of binding code
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Ensure that SystemType is present before switch
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Log on invalid System Type
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3
Related to openhab/openhab-addons#7722
Signed-off-by: Wouter Born <github@maindrain.net>
* Log event message construction improved
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* Changed level to debug for some logs
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* Added status request commands to b send when the bridge initializes
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* Don't change the label of the zone
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* Removed comment
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
Adding additional models to deviceType enum - "mono4" and "strip6" (please note this is not a typo in "strip6" - six is at the end and without 'e') - based on the analysis of the debug info those new models are not being recognised by Yeelight binding in OH3 and as a result the bulb or the led stripe is constantly showing offline despite correct device id.
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto
Signed-off-by: Wouter Born <github@maindrain.net>
This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See https://github.com/Pi4J/pi4j/issues/442 for details.
Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
* Adds a jackson.version property to simplify managing the version
* Make sure the specified version is used as add-on dependency by excluding Jackson from transitive dependencies
* Use openhab.tp-jackson feature with dynamodb
* Remove jackson-dataformat-cbor dependency from features which is now also provided by the openhab.tp-jackson feature
Signed-off-by: Wouter Born <github@maindrain.net>
* New feature: Shelly Manager
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Removed Shelly Manager to reduce PR size (will be another PR)
Signed-off-by: Markus Michels <markus7017@gmail.com>
* CoIoT initialization handles new COIOT options for the device,
sensorSleepTime is now adadvanced; Roller set position 0/100 is mapped
to UP/DOWN; Reference to Shelly Manager removed from README
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Nullpointer check added on settings.coiot (4Pro has this null)
Signed-off-by: Markus Michels <markus7017@gmail.com>
* README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Use regex to extract fw version from string, check fw version to detect
restarted, README updated, moved channel sensorSleepTime from group
device to sensors
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Rebase with main, update license headers
* Small PR cleanups
* One last small PR cleanup
* Syntactical sugar
* Updated error handling
* Spelling mistake
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* [miio] add support for zhimi.airpurifier.vb2 Mi Air Purifier Pro H
close#10174
* [miio] update modes to values visible in app
* [miio] cleanup and fix valuu mapping
* [miio] fix duration
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Add zhimi heaters
add new
zhimi.heater.ma2 Mi Smart Space Heater S
zhimi.heater.ma3 Mi Smart Baseboard Heater E
zhimi.heater.mc2 Mi Smart Space Heater S
zhimi.heater.na1 Smartmi Smart Fan
zhimi.heater.nb1 Smartmi Smart Fan Heater
improving existing
zhimi.heater.za1 Smartmi Radiant Heater Smart Version
zhimi.heater.za2 Smartmi Smart Convector Heater 1S
zhimi.heater.zb1 Smartmi Smart Convector Heater 1S
* [miio] add some more options
* remove accidental development file
* [miio] fix number:duration
* [miio] remove channeltype from heaters
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [bluetooth] Notify things again when they are removed from listeners like Inbox
* [bluetooth] Add javadoc on retractDiscoveryResult()
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
* Pimp properties and channel types with proper categories
* Update bundles/org.openhab.binding.deconz/src/main/resources/OH-INF/thing/sensor-thing-types.xml
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Co-authored-by: Matthew Skinner <matt@pcmus.com>
* Add support to myStrom Bulb
Add properties to myStrom devices and an action to refresh the properties.
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
* Fixes according to review comments
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
* Update bundles/org.openhab.binding.mystrom/README.md
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* Fixes according to review comments
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
* Use system color temperature channel type
channel type system.color-temperature is used and values mapped from 1-18 to 0-100%
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
* Better tracking of colour and brightness values
Format power state
Signed-off-by: Frederic Chastagnol <fchastagnol@fredoware.ch>
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* Support for Shelly Motion, some minotr improvements, README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* minor changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Bug fixes from hardening
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes, fix creations of sensors#motion and device#externalPower
for H%T; moved images/uiroller*.png to doc/images
Signed-off-by: Markus Michels <markus7017@gmail.com>
* missing in last fix
Signed-off-by: Markus Michels <markus7017@gmail.com>
Since the device does not follow its own protocol, we do not evaluate its
replies to our configuration commands but rather do a fire and forget.
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Added SMACK teach in
* Teached in devices can be teach out on a repeated teach in
* Improved detection of RPS devices, device types can be better distinguished now
* Bugfixes for discovery fallback to GenericThings
* Responses to message requests are send automatically now, no need for linking SEND_COMMAND channel
Fixes#10156
Signed-off-by: Daniel Weber <uni@fruggy.de>
* [modbus] More strict nullness. Remove apache.commons.lang from itests
* [modbus] Defaults for tcp and serial things according to docs
* [modbus] further explicit defaults
* [modbus] document default encoding for serial.
RTU is pretty much the only one used in the field.
Previous default was ascii implicitly.
* [modbus] verify defaults are used for undefined configuration parameters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [bluetooth] Add BluetoothDevice.isNotifying()
* [bluetooth] Improve Characteristic properties support
* [bluez] Improve Characteristic properties support
* [bluetooth] Add BluetoothDevice.canNotify()
* [bluez] Also catch DBusExecutionException on read value
* [bluetooth.generic] Activate notifications for linked channels where characteristics are able to notify
* [bluez] Adjust javadoc
* [bluegiga] Add BluetoothDevice.isNotifying() support
* [bluegiga] Fix notification enabled check
* [bluetooth] move canNotify() to Characteristic
* [bluegiga] rename notificationEnabled to notifying
* [bluetooth.generic] use handlerToChannels to subscribe to notifications
* [bluetooth.generic] implement TODOs of canRead()/canWrite()
* [bluetooth.generic] optimize ChannelUID
* [bluetooth.generic] use channelUids for link check
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
* [hdpowerview] refactor from jax-rs to http client
* [hdpowerview] adopt proposals of code reviewer
* [hdpowerview] adopt additional proposals of code reviewer
* [hdpowerview] provide exception class name
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Extended the original collection with all the languages currently listed on the VoiceRSS API website. Please consider including in main branch.
Signed-off-by: cURLy bOi <curly.boi.89@gmail.com>
* Removed internal vendor Map and minor additional improvements
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* #72 changed use units of measure for the twinguard humidity and purity values
all other QuantityTypes in bindingcode are fine
* #77 changed title of binding to Bosch Smart Home
Replaced the SHC occurrences with Smart Home,
to avoid technical names.
* #62 Try to restart long polling when it fails before taking the thing offline
* #62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request
This might be the reason why the subscribe request does never finish or finishes with a timeout
* #74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client
* #74 Schedule initial access when long polling fails unexpected
We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism.
* Use direct formatting of logger.trace instead of String.format
* #76 Use i18n texts instead of raw translations for status messages about failed long polling
* #76 Use logger.debug instead of logger.warn for long poll error as it is handled now
* #78 defined api-version
each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller
* logging bundle version
removed the old static version string
access OSGi bundle version information instead
* #75 improved initial access
- added isOnline check and isAccessPossible now failed in case HTTPStatus is an error
- same HTTPStatus check done to all blocking send() request calls
- using i18n strings for all bridge updateStatus calls
- skipped the 'controller' and use only 'Bosch Smart Home' in descriptions
- added more @Nullable annotations
* added newline
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Retry command submission when tahome gateway is busy.
* Changed log level, cosmetic changes
* Store list of scheduled retries; cancelled when handler is disposed.
* Made retryFutures thread-safe
Signed-off-by: Georg Siebke <github@georgsiebke.de>
The ceiling10 Yeelight lamp has 2 dimmer for brightness:
"bright" for the main light and bg_bright for the ambient light.
Both are of type dimmer and accept percentage values between 1 and 100.
This fix changes the datatype of the bg_bright property from Number
to Dimmer in the device mapping database file ceiling4, which is also
the one that is used for the ceiling10 lamp.
Accepted without sign-off under minor change exemption.
"format" parameter value for HTML seems that should be "html", not "HTML"
"HTML" seems to have no affect when using sendPriorityMessage, but "html" works.
Accepted without sign-off under minor change exemption.
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.
Signed-off-by: Flole <flole@flole.de>
* Improved error handling for Powermax binding
Catch all exceptions, and take all Powermax things offline in the event
of a communication failure. Also adds a 5-minute watchdog for
connections in Standard (non-Powerlink) mode.
* More Powermax error handling improvements
1. Mark the bridge and all things as offline when communication is lost
2. Bubble all I/O exceptions up to the bridge status
3. Set all channels to UnDefType.NULL when bridge goes offline
4. Ignore CRC errors on messages of type 0xF1
5. Don't try and download partition settings for panels that don't support partitions
6. Fix logging levels to avoid unnecessary non-DEBUG messages
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Internationalization + actions for messages
- Internationalization of UI relevant texts
- Better support for the error/warning/info/status messages received
from the device
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Review inputs + improvements
- inputs from @ssalonen
- additional action to retrieve all messages collectively
- added rule example for handling the collective message action
- added semantic tags in items example
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* mvn spotless:apply
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/java/org/openhab/binding/modbus/helioseasycontrols/internal/HeliosEasyControlsHandler.java
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/resources/OH-INF/i18n/helioseasycontrols_de.properties
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Review inputs from @fwolter
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Inputs from @fwolter
- changed return type for actions with a single return value
- corrected findings from static code analysis
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Removed configurationPid from TranslationProvider
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Changes requested by @fwolter
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Changed log level to debug when catching InterruptedException
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Added commands for second central heating circuit
* Added command for temperature sensor
* Added controlsetpoint2 and ch2_enable channels
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter], regarded OH3.
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200924 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200924 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Changes made in
org.openhab.binding.internal.kostal.inverter.secondgeneration.SecondGenerationHandler.java
found by Travis tests.
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201007 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Done changes in:
Channels.xml
PIKO1020.xml
README.md
SecondGeneration.xml
SecondGenerationChannelConfiguration.java
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201008 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201012 by Örjan Backsell, regarded to @fwolter
requested changes
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201028 by Örjan Backsell, regarded to @cpmeister
requested changes.
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201105 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201111 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201117 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter]
[WIP]
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201119 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201125 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201130 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201130, 1630 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201202 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201204 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Redesigned 20201204 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201010 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210112 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter]
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210114 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210119 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding (KostalInverterFactory.java)redesigned 20210119 by Örjan
Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210125 by Örjan Backsell
* Binding redesigned 20200923 by Örjan Backsell
(KostalInverterFactory.java)
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210125 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Added option to reverse rollershutter commands - UP -> DOWN and DOWN -> UP - might happen if rollershuter module's output is wired differently.
* Fixed PR comments.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* Add IR code commands to dropdown and documentation
* Add link to community for advanced UI creation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* [novafinedust] Test for optimizations on access to the serial port
- retry logic if port does not yet exist on startup
- do not write sleep command on shutdown if port has issues
- no not register data listener on port but wait for data instead to be
compatible with RFC2217 serial over network implementation
- ignore all buffered data from device during initialization to get the
device into a defined state
* Adress review comments
- moved most "normal" logging to TRACE level
- used lambda function
* Improve error messages as requested in the review
Signed-off-by: Stefan Triller <github@stefantriller.de>
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Implemented EEP family D2_50
* Added new thing type (heatRecoveryVentilation) and channels for heat recovery ventilation units
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* code refactoring (JAVA11 improvements)
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Removed unnecessary EEP classes
* Made final fields static
* Added @NonNullByDefault to EEP Class
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Removed @NonNullByDefault to not mess up PR with non related changes
Fixes#9465
Signed-off-by: Daniel Weber <uni@fruggy.de>
* Fix brightness
* Revert to old beahaviour if segments are used
* Fix formatting
* Remove unused Var
Signed-off-by: Sebastian Garske <sebgarske@gmail.com>
* add support for custom mapping
* add screenshot
* remove unnecessary variable
* make parameter nullable to avoid not required list instances
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* This PR merges the 2.5 code base with new features, a bunch of bug fixes
and improved documentation. Parts of the code has been re-factored and
vaious issues are fixed/optimized along the way.
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Minor fixed, support for Shelly Color Bulb, Shelly Motion
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Review changes applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change
Signed-off-by: Markus Michels <markus7017@gmail.com>
Fixes#6762
* Fix Unit tests
The method was used to create the pattern for a regex and for building
the channel id. I ave separated them now. At least the tests are green ;)
Signed-off-by: Stefan Triller <github@stefantriller.de>
* [irobot] Roomba: Add more properties.
On request by @falkena, also some i7 specifics
* [irobot] Roomba: Add map_upload channel.
Controls uploading Clean Map(tm) to the cloud.
* [irobot] discovery: Get rid of empty while() loop
Rewrite the loop so that it doesn't have empty body any more, this gets rid of
one more static analyzer warning. Added dumping the whole IDENT packet on TRACE
level, aids implementing support for newer devices.
Signed-off-by: Pavel Fedin <pavel_fedin@mail.ru>
* [modbus] Cascaded transforms with ∩
* [modbus] README to mention cascaded transformations
* [modbus] Take cascaded transformation into use
* [modbus] README to show preference towards new syntax
* [modbus] examples to use new syntax
* [modbus] fix test
* [modbus] remove apache commons lang dependency
- see also PR #10002
- I removed equals and hashCode implementation all-together, I could not see they played any role in practice.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [miio] validate response id matching command id
This PR prevents out of sync issues in case devices are too slow to
respond or the timeout is set too short.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] spotless adding space
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] update based on review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Support for Denon "Home" speaker as bridge added
* Fixed a runtime issue if no serial number is provided by the player, by using the PID as a fallback if no serial number is available
Signed-off-by: Wire82 <johannes.einig@me.com>
* Added support for color temperature capabilities and set value in Kelvin
* Use system default channel type
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Use for each loop in getChildThing()
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Further refine getChildThing() using stream map
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Fix spotless errors
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* fix some tivo binding bugs
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* update search example rule
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* [sonos] Add bass/treble/loudness controls
Related to #9874
Disable these controls when the output level is fixed
* Review suggestion: use OnOffType.from
* Add bass/treble/loudness channels to Arc and Arc SL models
* Review comment: remove usage of keySet
Factorize code
Define constants
* Use Map.of to simplify the code
* Review comments considered
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* add ontime
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Update bundles/org.openhab.binding.deconz/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [sonos] Add support for Sonos Arc/Arc SL + new controls for sub/surround speakers
Related to #9874
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Use OnOffType.from
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Configured XML parsers to resist XXE attacks
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for avmfritz
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for sonos
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for vitotronic and bosesoundtouch
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* changed avmfritz to singleton pattern
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* addressed roku binding
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* address all uses of DocumentBuilderFactory
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* fixed other occurrences in roku binding
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Fixes#7024
The problem was caused by the asynchttpclient dependency that seemed to require another version of the Netty dependency than what is added by the openhab.tp-netty feature.
This caused some of the classes in the ssl package to not be found during initialization.
I fixed it by upgrading the asynchttpclient dependency to a version that use the same version of Netty that is bundled(4.1.42.Final).
Signed-off-by: Jörgen Nilsson <mail.jnilsson@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Co-authored-by: Dan Cunningham <dan@digitaldan.com>
Co-authored-by: Craig Hamilton <craigh@quailholdings.com>
Co-authored-by: Brian O'Connell <boc@us.ibm.com>
Co-authored-by: Dan Cunningham <dan@digitaldan.com>
Co-authored-by: Craig Hamilton <craigh@quailholdings.com>
Co-authored-by: Brian O'Connell <boc@us.ibm.com>
* [pidcontroller] Catch empty commandTopic
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] Fix handling action
keys in action context from trigger are passed with prefix of trigger name.
This change removes the prefix to get the actual name and checks if it matches an item.
Else it tries the original name.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] review comment
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Add support for ESP32 devices
* Add Unit Tests
Ensure Gson objects are NonNull
Generify Handlers
Generify Utils
Signed-off-by: Christian Schlipp <christian@schlipp.de>
* Updates links to target the openhab-addons 'main' branch instead of the 'master' branch
* Updates some NOTICE files to indicate content is maintained by openHAB instead of Eclipse SmartHome
Signed-off-by: Wouter Born <github@maindrain.net>
The channel is added dynamically with a channel-type `abshumidity`, but the channel-type definition was names `absolutehumidity`
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Improve debugging in message classes
Each PowermaxBaseMessage subclass had its own toString() which added
useful debug info but duplicated a lot of the logic in the message
handler. I've moved the debug info inline and removed the duplication,
and also added decoding for more values to the debug output.
* Fix for 0xFF byte values, which convert to int -1
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Use set instead list to avoid duplicate listeners
* Remove from listeners when bridge is not ONLINE
* Unsubscribe from bridge handler events when thing handler is disposed
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
The KP115 plug is a WiFi smart plug with energy monitoring support.
It uses the same API as existing TP-Link smart home devices. This change adds support in the binding for the KP115.
Signed-off-by: Evan Anderson <evan@eaanderson.com>
1. Fixes#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address
Signed-off-by: James Melville <jamesmelville@gmail.com>
The internal package was placed before the binding specific package, and it should be the other way around.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Replace deprecated constructors
* Removed no longer existing settings from the documentation. They were already marked as deprecated since several versions.
* Refactored communication with the HM gateway
- simplified coding for the communication with the gateway
- buffer size for communication is now configurable to avoid problems
with too small buffers
- Previous solution for #6963 was not sufficient. Should be finally done
with these changes
* Retrieving the duty cycle is sufficient to check connection
- ping requests could therefore be safely removed problems with the automatic reconnection were solved.
* Changed to explicit list of Exception
Fixes#8808
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [pidcontroller] Remove limits, make Ki dependent from the loop time
Also fix naming of thread and shutdown executor.
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [dsmr] Fix handling problem reading gasmeter
The gasmeter seem to return an invalid date value in some cases.
Possible problems with the meter. This however caused the whole meter readings to be ignored, while it should only ignore the single problem value.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Make eclipse happy again.
Don't ask...
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Removed sat warnings
Removed usage of apache library and added NonNullByDefault to test classes..
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [innogysmarthome] Bug-fix - NPE solved which could occur when devices without a corresponding device state were returned by the API. That happened with the virtual device "NotificationSender" which is unimportant for the binding.
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] JavaDoc fixed
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimizations (warnings fixed)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code refactoring (InnogyClient class split to make it smaller)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization ; Potential bug with the reachable attribute solved (it was set multiple times within a loop)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Tests added
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Tests added
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code changed to not overwrite the reachable state provided by the API (when no corresponding message is available)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Copyright notice updated
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code and performance optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Co-authored-by: Sven Strohschein <sven.strohschein@gmail.com>
* add support qrcode based pairing
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add screenshots
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix typo
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* update config only if differnt to prevent endless update loop
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* clean up
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add support qrcode based pairing
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add screenshots
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix typo
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* update config only if differnt to prevent endless update loop
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* clean up
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* incorporate review feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix Nullable based on feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* correct the java hap version
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* Update bundles/org.openhab.io.homekit/pom.xml
* adapt groupid
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* incorporate review feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Co-authored-by: Eugen Freiter <freiter@gmx.de>
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* [openwebnet] Log messages cleanup
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Fixed normalizeWhere
* added builder for Bus Where addresses
* added messages to OwnIdTest
* depend on own4j 0.3.3-SNAPSHOT
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Discovery & reconnect for ZigBee USB gateways
* added mgmt of disconnect/reconnect of ZigBee USB Gateway from serial (#9170)
* added ZigBee USB Gateway auto discovery (#9171)
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] fixed up/down automation for old fw (#9651)
* now using openwebnet4j 0.3.3 (nrjavaserial 5.2.1)
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Fixes lowering dimmers from 20 to 10% does not change device level #9317
- bump openwebnet4j to 0.3.4
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] changes after PR review
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [tr064] Normalize numbers in phone book entries.
Phone book numbers and numbers to be looked up might be formatted
differently (real world example: '+49 (12345) 67890' vs. '01234567890'
(where the former is phonebook formatting and the latter is the format
transmitted by the avmfritz binding). Make sure such formatting
differences do not cause lookup mismatches.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
* add unit
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* documentation an XML
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* address review comments
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* improvements
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* improvements
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* added new channels and extra fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* wip
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* added multiple channels
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* fixes after PR comments
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* added support for AUTO fan mode
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fixes units
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fix PR
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* PR fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* PR fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fixed copyright 2020->2021
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
- Rename parameter 1 of "getActions" from "xmpp" to "xmppclient".
- Remove "getEvent()" as "receivedEvent" automatically contains the String since OH3.
In case of simulated Nikobus push button event refresh impacted modules too so binding fetches the updated state from affected modules.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
The original example references to the old telegram action, which is no longer supported. The updated example uses the (new) telegram binding.
Signed-off-by: Sören Berger <soeren.berger@u1337.de>
* [lgwebos] Remove outdated statement from README.md
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
* Adding a sentence on why these TV settings are relevant.
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
* [remoteopenhab] Catch exception when parsing item state
* Review comment: set channel state to UNDEF in case item state parsing failed
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Added ConfigOptionProvider to provide file names ending with '.js' in Profile configuration
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* open connection on refresh even if no modules exist
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* ran mvn spotless:apply
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* removed unnecessary file
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* returning when the connection is offline since following code won't work
either.
Signed-off-by: Wouter Denayer <wouter@denayer.com>
Co-authored-by: Wouter Denayer <wouter@denayer.com>
* [icalendar] Fixed issues with moved events and wrong displayed events
* [icalendar] Changed test to use local time in test-calendar of #9647Fixes#9647.
Handling for RFC 5545's RECURRENCE-ID field inside of
events and rounded begin (and based on it end) down in subsecond
precision.
The calendar does not define a timezone. On a machine that uses a
different timezone than Europe/Berlin the test failed. As the behavior
itself is specified, the test was changed to use local time for its
dates.
Signed-off-by: Michael Wodniok <michi@noorganization.org>
* [amazonechocontrol] add channel-types to schema
* [amazonechocontrol] use mergedApplianceIds to query state
Signed-off-by: Miguel <miguelwork92@gmail.com>
* Baseline original code from AndyXMB
* Initial updates for OH3
* fix null warnings and add sub-channel handling
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Expanded descriptions and note on textual config
Some paragraphs are expanded and some more info on the fritzbox subdevices are given. Channels are grouped by subdevice. Textual description with .items files is briefly described at the end but a clear warning on possible drawbacks is given and it is also clearly stated that it is discouraged.
Signed-of-by: Lionello Marrelli <marrelli_lio@yahoo.it>
* Improve debugging in message classes
Each PowermaxBaseMessage subclass had its own toString() which added
useful debug info but duplicated a lot of the logic in the message
handler. I've moved the debug info inline and removed the duplication,
and also added decoding for more values to the debug output.
* Fix for 0xFF byte values, which convert to int -1
* Change to inline debug messages
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Update README.md
examples updated
broken link for CAP DWD Profile fixed
some debugging information added
mapping files renamed to fit naming convention for files containing German language
additional mapping for weather warning added
examples also updated
mapping files extended with mapping for UNDEF state
* fix connection attempts when thing disposed
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* refactor session handling
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* rename
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* refactoring
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Corrected some item types in the documentation.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Correction as per @ssalonen's review.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Corrected sendIRCode handler
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
* Update YIOremoteDockHandler.java
Updating IR receiver switch handler so it's running now
Solved issue during triggering channel while it was disposed
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
* Update YIOremoteDockHandler.java
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
No "Other" option in Google-Cloud-TTS OAuth2 Client Type options. Choose "TV and Limited Input" instead. Rest of readme works as expected.
Signed-off-by: Zimmermann Zsolt <cina@cina.hu>
* [linky] Handle case when data from yesterday is still NaN
Fix#9386
* Refresh every 2 hours until data from yesterday are available
* Log yesterday even for month and year requests
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [fronius] Add support for Fronius Smart Meter
* [fronius] Use DTO, implement UoM
* [fronius] fix README.md
* [fronius] Add mandatory label for channel-type and fix property update
* [fronius] Store meterRealtimeBodyData instead of meterRealtimeResponse
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
* improve data handling and suspend
* fix command position
* add ACK to subResponse
* fix data position
* fix reactivation, trim too long responses
* ensure correct setting of activation channel
* Remove @SuppressWarnings(null), which is not needed anymore
* Remove updateState on dispose
Signed-off-by: Hans Böhm <h.boehm@gmx.at>
[nikohomecontrol] Small README update.
While searching why I can't get my electricity working, I think I spotted this typo.
Signed-off-by: Dries Vandenneucker <dries.vandenneucker@yahoo.com>
* [modbus] add support for rtu encoded over tcp
* [modbus] move classes to openhab/jamod
* [modbus] spotless
* [modbus] revert EndpointPoolConfiguration
* [modbus] remove virtual serial
* [modbus] resolve dependencies
* [modbus.studer] add support for RTU over TCP bridge
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* This is the initial contribution of the Generac MobileLink binding. This allows the Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
In trying the example I got an error from the serial binding. But by adding a `,` the serial binding was able to handle the example.
Signed-off-by: Michael R. Maletich <maleticm@gmail.com>
* [miio] suggest correct devicenames in readmehelper
* add newline at file end to make git happy
* [miio] update logic for mapping in readmeComments
* Allow readme maker to fix mappings based on the current options.
* [miio] make readmeOptionMapping static
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Clarify the process of adding/discovering the server
* Update bundles/org.openhab.binding.squeezebox/README.md
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Older HM dimmers are using a maximum values of 1.0. But also for these
devices the values must be corrected.
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [icalendar] Optimize searching events and adding a bit debug output
Fixes#9498 by limiting series events when retrieving possible events via
filter.
Adding a bit more debug output to allow debugging the correct scheduling of
events.
Signed-off-by: Michael Wodniok <michi@noorganization.org>
* Fix typos in example code
* One Call API: add channe dew-point for daily forecast
* One Call API: remove channel visibility in daily forecast as not included
in data
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
* [hue] Make sure the serial number will be in lowercase
Necessary for the auto-ignore discovery feature with the representation property.
Fix#9364
* Check that the serial number is not null
* Check that the serial number is not blank
* Build a discovery result even without a serial number
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [hueemulation] Correct format of UDN and serialNumber fields
* Avoid changing device ids on upgrade
* Revert light and group ids back to a number rather than hexadeximal
* Fix failing tests
Signed-off-by: Mike Major <mike_j_major@hotmail.com>
* Add aggregated channels for daily forecast.
Also updates to use Optionals instead of @Nullables, and add unit tests
* Revert unsing explicit unit definition
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* [icalendar] Provide example for Netcloud usage
Users of the icalender OH 1 binding might wonder how to get the url for the
ical file for their calenders. It took me a couple of hours to find this, so
I think it might be useful to have it as an example in the documentation.
Signed-off-by: Stefan Triller <github@stefantriller.de>
* Added new channel parameter tariff to channels instantpower, totalusage, currentFlow, cumulativeValue, counter and currentNumber
* Parameter is currently just read by EEP A5_12, which is used by AutomatedMeterSensor ThingType
* AutomatedMeterSensor ThingType has extensible channels now
Fixes#9333
Signed-off-by: Daniel Weber <uni@fruggy.de>
The only way to recover from an incompatible OH2 database is to create a new database.
With these changes the add-on will create a new database automatically and archive the incompatible database files in a backup directory.
Fixes#8794
Signed-off-by: Wouter Born <github@maindrain.net>
<category>DimmableLight</category>
The above category does not exist here <https://www.openhab.org/docs/concepts/categories.html> and the new UI does not have this as a valid option to select when creating an item.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
<category>DimmableLight</category>
The above category does not exist here <https://www.openhab.org/docs/concepts/categories.html> and the new UI does not have this as a valid option to select when creating an item.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fixed: removed unnecessary refresh on push activity
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Also-By: Tom Blum <trinitus01@googlemail.com>
Co-authored-by: Tom Blum <trinitus01@googlemail.com>
* [miio] add support for basic huayi lights
also remove some double spaces in json files
* miio update devicenames
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Update configfile lines for renamed openhab-addons-external artifactId
* Add missing 2.5.x configfiles files which were never merged into the main branch
* Fix configfile lines not aggregated in feature.xml file
Fixesopenhab/openhab-distro#1205
Signed-off-by: Wouter Born <github@maindrain.net>
* [velux] add data type to config params in readme
* [velux] eliminate mvn warning
* [velux] fix Somfy bugs: uniqueindex = serial number or name
* [velux] fix inconsistent switch state logic
* [velux] cosmetics on BRIDGE_THING_TYPE_UID
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Initial attempt to resolve issue with flickering statuses when override
present on OTGW
* Update Units
Signed-off-by: James Melville <jamesmelville@gmail.com>
* Fix Offline detection and Improve discovery.
* Motion options bug fix.
* Message content bug fix.
* Fix all handlers to process all chunks as one.
* Remove password from FFmpeg command log.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1.
(cherry picked from commit ad2a1e3635)
Add-ons should not depend on tec.uom.se classes but use core unit classes instead so they are less impacted when this library is replaced or upgraded.
Signed-off-by: Wouter Born <github@maindrain.net>
* Update some of the miot files to the new definition
* Apply units,category & tags for some channels
* apply standard sorting
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [icalendar] Fix race condition while initialization of EventFilterHandler
Should fix#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler.
Also added a bit more output.
* [icalendar] use implicit conversion to string for logging
Signed-off-by: Michael Wodniok <michi@noorganization.org>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] Add discovery from cloud feature.
This allows to discover things that are not directly on the same subnet
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0.
Closes#9208
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [miio] dynamically generate channelTypes
Simplify the json database creation for new models and less chance for
errors
Related to #7276
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] Implement alternative MiIoQuantityTypes
* Improved way avoiding multiple entries for Unit
* Test cases for the MiIoQuantityTypes class
* Apply suggestions from code review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [OpenUV] Correcting incorrect behaviour when UV < 1
and some code enhancements
* Correcting SAT findings
* Initiating bundle localization in French
Signed-off-by: clinique <gael@lhopital.org>
* [irobot] iRobot binding
Supports iRobot Roomba and probably some other iRobots (in parts where they
are compatible)
* [irobot] Drop custom hivemq wrapper
setUnsubscribeOnStop() has been introduced in
org.openhab.core.io.transport.mqtt.MqttBrokerConnection, so it can now handle
iRobot's quirks. The custom wrapper is no more needed, remove it
Signed-off-by: Pavel Fedin <pavel_fedin@mail.ru>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [velux] set explicit timeouts & keepalives on socket
* [velux] implement mdns service
* [velux] fix representation property names
* [velux] fix representation properties
* [velux] finalize mdns
* [velux] spotless
* [velux] use both mDNS and regular DNS to resolve ip addresses
* [velux] complete class rewrite using asynchronous polling thread
* [velux] refactor bridgeDirectCommunicate to simplify looping
* [velux] asynchronous polling means Thread.sleep no longer needed
* [velux] faster synch of actuator changes
* [velux] use single thread executor instead of thread pool
* [velux] faster synch of actuator changes
* [velux] shut down task executor
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Update README.md
* Fix Indentation
* Change comment character from '#' to '//'
* Remove wrong formatting attempts ('rsqb' & 'lsqb')
* Minor changes
* Update README.md
Remove link to the API since website doesn't exist any more.
Signed-off-by: Felix Schneider <fs@felix-schneider.org>
sorry i missed to change the IP of my own config. Thing Configuration was not accepted bei Visual Studio Code, curly brakets were missed and the definition of ThingID<>Thing was not accepted.
* [dynamodb] fix serialization of ZonedDateTime timestamps
Resolves#9156.
AWS SDK does not know how to serialize ZonedDateTime. We resolve this
by providing explicit serializer/deserializer.
In addition, integration tests had issue with timezones. The persistence
converts all timestamps from the DynamoDB to system timezone for display
purposes. This was not taken into account in the tests and failure was
expected with non-UTC system timezone.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [miio] Update channels only if they are linked
With introduction of miot devices with enormous amount of channels
refreshes can become slow. With this change only relevant updates are
done.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Cloud Communication for devices
Allows to define if communication to devices is direct or send via the
Xiaomi cloud.
Introduce additional channel to execute commands via cloud.
Other small improvements
* Use common method from abstract handler to send commands
* Common way to handle custom commands
* Introduce small delay before refreshing robot properties after sending
commands (similar to the basic handler) so devices have time to update
their properties
* [miio] simplify cloudconnector
* [miio] Cleanup all jobs when unloading
* [miio] update to use dedicated ScheduledExecutorService
Use dedicated ScheduledExecutorService to avoid unloading problems
* Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java
* [miio] fix for removeif
* miio- Improve scheduler
* [miio] fix communication error if device is not on the network
* [miio] update with comments from feedback
* remove scheduler tracking
* improve status setting for cloud communication
* [miio] update with feedback review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* improvements
- use insecure client and remove TrustManager
- add call list channel
* address review comments
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
The channels 1-3 of LCN-B3I are mapped to binary channels 6-8. This could be anticipated from the Button Tables (B6-8) that it connects to. However, the added comments should help people to save a few hours and some gray hair ;-)
* removed state update if value didn't change so expiry binding can actually - expire. If expire time was larger than refresh interval of the binding, expiration never happened ...
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* [miio] update for vacuum.e2
small update now critical commands are confirmed working.
* [miio] update readme
as dock command is now also confirmed
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* * fixed refresh handing due `channelLinked` not called anymore on startup for example (similar to https://github.com/openhab/openhab-core/issues/1707),
* "Impacted Modules" can be empty if button is configured as "standalone" and does not impact modules,
* minor doc fix
* * check if configured impacted module for `impactedModules` is referencing an existing thing,
* fixed warnings
* Fixed review comment.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* fixed: InterrupedException
* changed: single and group queues to device queue
added: standard volume to speak request
* changed: log from info to debug
* fix compile warnings
* remove dependency on StringUtils
* more improvements
* fix HandlerPowerController
* attempt to solve stopping tts
* logging powercontroller
* fix smarthome devices not updating
* finalize smarthome device update fix
* additional device information logging for discovery
* fix color channel for smarthome devices
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Co-authored-by: Tom Blum <trinitus01@googlemail.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* [openwebnet] Fixed config, handling and discovery of ZigBee devices (fixes#8915 and fixes#8917). Added test for ownID. Now uses openwebnet4j v0.3.2
* [openwebnet] ZigBee: improved handling of wrong 'where' parameter. Updated README. Improved logging.
* [openwebnet] Improved discoveryByActivation to distinguish dimmers from lights. Now using openwebnet4j 0.3.2-1
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* Add some utility classes that will be used by other bluetooth bindings.
* Add handle field to BluetoothDescriptor
Signed-off-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* Max value and format pattern were not correct for dimmers (Fixes#8799)
* Fixed calls to deprecates methods/constructors
* Make sure channelLinked is executed at restart (see also: https://github.com/openhab/openhab-core/issues/1707)
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Refactor to prevent endless loop.
* Allow `-rtsp_transport tcp` to be over-ridden.
* Display actual preset names
* Allow IP to not match due to Hostname given in setup.
* Fix index off by 1
* Bug fixes for HLS
* Compatibility fix for GotoPreset
* Improve default snapshot quality and allow FFmpeg arguments to be
changed.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* Corrected caddx discovery bug
* Maintenance
- Changed refresh logic for the things
- Code cleanup
- Corrected off by one errors
- Added initial tests for the message parsing
* Corrected ParameterizedTest
* Changed new Date().getTime to System.currentTimeMillis()
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* [jablotron] fixed bug when bridge stays offline forever in some cases
* [jablotron] fixed the JA100 channel update bug
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* Avoid a hidden NPE when getIdentifier() of an uninitialized ThingHandler is called
* Fixed Powerline546EHandler
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.
Also contains a few other improvements:
* fix lastRequest timestamp not updated when sending messages to discover node properties
* use java.time Duration and Instant
* use List.of, Set.of
* remove redundant null suppression because of EEAs
Signed-off-by: Wouter Born <github@maindrain.net>
* [miio] Add support for mijia.vacuum.v2
related issue #9005
* [miio] fix channelTypes based on review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Add sendVideo and sendAnimation features.
* Re-order functions to keep inline with other functions.
* Readme change to trigger new build.
* Add ability to use raw file paths to send video and animations.
* Change Paths.get to Path.of as JavaDocs recommend.
* Allow absolute paths in SendPhoto methods and update readme.md
* Support for no caption with photo.
* Add absolute path support for png and webp.
* Add all file types requested.
* Remove multiple OR and only do lowercase once.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Some enhancements and corrections on the linky binding
spotless apply
Adressing code review comments
* Adressing potential NPR.
* Code review findings correction
* Pleasing SAT checks
Signed-off-by: clinique <gael@lhopital.org>
* Staging work
Saving my work
Vigicrues extensions for OH3
First code review
* Code review and some corrections
* Code review enhancements
Changed alert to Number
* Code review corrections
* Correcting my error
* Adressing SAT finding
Signed-off-by: clinique <gael@lhopital.org>
* [miio] Allow for quantity Type in the basic handler
This extends the miio:basic handler with the option to define channels
with QuantityType e.g. to use number:temperature
* [miio] add missing breaks
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.
Signed-off-by: Wouter Born <github@maindrain.net>
* Add KorbinianP to CODEOWNERS for senechome
* Implement Current, Voltage and Power for all three Phases
* Bugfix last commit, values are inside array
* Implement Grid Frequency
* Fix name of currentGridVoltagePerPhase
* Extend README.md with new parameters
* Implement SenecBatteryStateValue for easier comparison of values in rules
* Implement new statistic data points and battery voltage
batteryVoltage
liveBatCharge
liveBatDischarge
liveGridExport
* Bugfix item types
* Implement Review findings, change channelBatteryStateValue to QuantityType
* Revert change of channelBatteryStateValue from DecimalType to QuantityType
Signed-off-by: Korbinian Probst <kp.droid.dev@gmail.com>
* Properly handle datagrams that are not immediately available so no NPEs are logged on debug
* Properly handle sockets channels that are not connected so no NPEs are logged on debug
* Prevent load/garbage by reusing ByteBuffer and not allocating trace logging strings
Fixes#8932
Signed-off-by: Wouter Born <github@maindrain.net>
* [rrd4j] Improve performance
* Cache item to improve performance
* Also return DecimalType for QuantityType values
Related to #8928
Reintroduces #8809
Signed-off-by: Wouter Born <github@maindrain.net>
Changed some wordings.
-Kept "DataSource" as the term for the way data is stored in a .rrd file. Such is more inline with the used Default Datasources (-numeric, ...).
-Removed the requirement for an everyMinute Strategy, inserted a explanation for relationship between Sample Intervall and Strategy instead.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
* Added Channel for link to latest feed; update rome deoendency to version 1.15
* Removed unsed interface
* Run spotless
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* [snmp] Set thing only online on valid response
Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured).
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Fix index out of bounds when persisting empty StringType values
* Fix deserialization when strings contain type separator
* Improve debug logging
* Improve test coverage
Fixes#8790
Signed-off-by: Wouter Born <github@maindrain.net>
* [icalendar] Describe download exceptions a bit more detailed.
Fixes#8846
* [icalendar] Apply suggestions from code review
Signed-off-by: Michael Wodniok <michi@noorganization.org>
Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] delay refresh to avoid devices not ready yet
Delay refresh after command is send as some devices are not ready yet
with the execution and will report wrong status.
This is confusing to the users.
Related forum topic:
https://community.openhab.org/t/xiaomi-mi-air-purifier-xiaomi-mi-io/34840/300
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] remove change from PR
* Update documentation with changed Influx2 RC port
* Fix problem with non decimal numeric types
Improve documentation with more explicit information about Influx types used
Implement toString to InfluxPoint to allow some trace info to be useful in case it's needed
Fixes#8697Fixes#8798
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Additionally:
- documentation has been updated and improved
- logging has been improved for better debugging
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* [MeteoAlerte] Update for OH3
Replaced old gif pictures with svg nicer pictures
Added a missing alert report (vague-submersion)
Added end of validity report timestamp
Some code cleansing.
Signed-off-by: clinique <gael@lhopital.org>
* [lcn] Fix status message of RollerShutter inverting
The status of RollerShutter was not inverted when invertUpDown=true. Fixes#8680
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* Add Groovy scripting support
This makes it really easy to start using Groovy 3.x scripts with openHAB!
Signed-off-by: Wouter Born <github@maindrain.net>
Changed the README.md file to include more information as in #8733:
Specified that the chatId in the APIs must be followed by an "L" or it won't work (at least, not for group chats).
Add support for following types
"mrbond.airer.m1s",
"mrbond.airer.m1pro",
"mrbond.airer.m1super"
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Refactored discovery service to ThingHandlerService
* Fixed discovery for Geofence Sensor
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Remove duplication by making use of default Java generated exceptions
* Make ThingActions labels/descriptions more consistent
Signed-off-by: Wouter Born <github@maindrain.net>
* Remove proxy workarounds
* Move ThingActions and a few other classes into the internal package
* Use more consistent action labels/descriptions
Related to:
* openhab/openhab-core#1714
* openhab/openhab-core#1639
Signed-off-by: Wouter Born <github@maindrain.net>
* [airvisualnode] Support AirVisual Pro version
* [airvisualnode] Autodetect Pro version
* [airvisualnode] Remove unused channels
Signed-off-by: Oleg Davydyuk <ilveann@gmail.com>
* [miio] eliminate warning org.apache.commons.io.FileUtils in readmemaker
Eliminate
[WARNING] org.openhab.binding.miio.internal.ReadmeHelper.java:[25]
The package org.apache.commons.io.FileUtils should not be used.
* [miio] add StandardCharsets.UTF_8 to file readwrite
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Improved unsupported handler that build experimental support
New unsupported handler that tries to find channels for unsupported
devices and creates experimental database file for it.
* [miio] logger fixes
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Fix memory leak in SNMP. When receiving an async request it is placed in a pending request queue. Not canceling it leads to infinty life cycle for those requests, filling up memory.
* Test the canceling of the snmp aync request by its handler.
Signed-off-by: Falk Bauer <falk.bauer@k-is.com>
Applied the changes found by spotless.
According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the 4th was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the 4th was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
* [miio] allow for device remarks in the readme from json db
* Update bundles/org.openhab.binding.miio/src/test/java/org/openhab/binding/miio/internal/ReadmeHelper.java
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com
* Configures XStream security to prevent "Security framework of XStream not initialized, XStream is probably vulnerable" warnings.
* Resolves the itest bundles for the upgrade to XStream 1.4.13
Related to openhab/openhab-core#1688
Signed-off-by: Wouter Born <github@maindrain.net>
* add representationProperty to thing definition to make it OH3 compatible
* adapted to OH3 (representationProperty added to thing definition)
* as always...spotless:apply :-(
Signed-off-by: Markus Michels <markus7017@gmail.com>
* OH3 adaption - fixes small issues when running on OH3
* #8612: Fix total consumption for RGW2+Roller
* #8492: Shelly Plug US
* 2 more immediate = true catched and removed
* spotless applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* [miio] enable telnet for lumi gateway
* allow enable telnet and some other functions on gateway
* use new fw as default for chugmi plug
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
+ Bug fix: Recording to GIF would only record for 5 seconds.
+ Clean up readme to remove channels and configs that don't exist after
moving to actions.
+ Compatibility fix for http headers.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Swagger upgrade for the Netatmo binding (required to use the OAS 3 Swagger annotations, the old annotations dependencies were removed with OpenHAB 3)
- Swagger-Codegen updated to the latest version (to generate the OAS 3 Swagger annotations)
- Retrofit replaced by the default code generation (Retrofit 1 code generation is broken with newer swagger-codegen versions and an update to Retrofit 2 is also incompatible and would require more dependencies)
- NULL handling for collections introduced (newer versions of the Swagger codegen return NULL for empty collections instead of an empty collection ...)
- The binding is now working completely again (compiles and starts), but there are still some TODOs
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
sven.strohschein@gmail.com>
Upgrades the compiler and its dependencies so the compiler results of Maven builds are more similar to those generated in recent Eclipse versions.
To fix compilation issues in Eclipse for add-ons using classes from javax.xml.stream several dependencies were upgraded/excluded.
Signed-off-by: Wouter Born <github@maindrain.net>
* Fix issue with All Mute and extra source options
* Add channel to select preset favorite
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Improve exception handling of the embedded MQTT broker so the port can be reconfigured when it is already bound and it properly unlocks files
* Rework MQTT integration tests so they each run the embedded broker on their own reserved port
Signed-off-by: Wouter Born <github@maindrain.net>
Fixed 3 bugs:
- Network bridge not listening on bus
- Reconnection handler keeps reconnecting even after a successful reconnection
- Minor typo in alarm wakeup time channels
Signed-off-by: Cedric Boon <cedric.boon@hotmail.com>
In case of the parameters & response are not equal avoid the
java.lang.IndexOutOfBoundsException: Index: 4, Size: 4
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
The handleUpdate method was deprecated when profiles were introduced (see eclipse-archived/smarthome#4108).
Instead the "follow profile" can be used which forwards item updates as commands to handlers.
This profile works with any binding instead of only those that implement the handleUpdate method.
Related to openhab/openhab-core#1669
Signed-off-by: Wouter Born <github@maindrain.net>
This should make it easier to fix these broken add-ons and the PRs that fix them will then not contain all these changes which make them easier to review.
Signed-off-by: Wouter Born <github@maindrain.net>
