demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 15:11:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ecobee] Improve handling of invalid_grant error (#8857)

Browse Source 
Signed-off-by: Mark Hilbush <mark@hilbush.com>
This commit is contained in:
Mark Hilbush 2020-10-27 11:10:03 -04:00 committed by GitHub
parent 472c0fd960
commit a84222cf5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
bundles/org.openhab.binding.ecobee/src/main/java/org/openhab/binding/ecobee/internal/api/EcobeeApi.java
View File

@ -170,13 +170,24 @@ public class EcobeeApi implements AccessTokenRefreshListener {
logger.info("API: The Ecobee authorization process threw an exception", e);
ecobeeAuth.setState(EcobeeAuthState.NEED_PIN);
} catch (OAuthResponseException e) {
logger.info("API: Exception getting access token: error='{}', description='{}'", e.getError(),
e.getErrorDescription());
// How to handle the possible error codes?
handleOAuthException(e);
}
return isAuthorized;
}
private void handleOAuthException(OAuthResponseException e) {
if ("invalid_grant".equalsIgnoreCase(e.getError())) {
// Usually indicates that the refresh token is no longer valid and will require reauthorization
logger.warn("API: Received 'invalid_grant' error response. Please reauthorize application with Ecobee");
deleteOAuthClientService();
createOAuthClientService();
} else {
// Other errors may not require reauthorization and/or may not apply
logger.warn("API: Exception getting access token: error='{}', description='{}'", e.getError(),
e.getErrorDescription());
}
}
@Override
public void onAccessTokenResponse(AccessTokenResponse accessTokenResponse) {
}