Commit Graph
34 Commits
Author SHA1 Message Date
Florian HotzeandGitHub 389f6a3434 [rest] Persistence: Optionally add current Item state to response (#4394)
* [rest] Persistence endpoint: Optionally add current Item state to response

This new optional parameter gives the UI additional possibilities for charts.
E.g. it is now possible to display a bar chart with monthly energy consumption, where the consumption is only persisted at the end of the month, that includes the data from this month.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-10-09 19:32:31 +02:00
Florian HotzeandGitHub d012d36bba [automation] Add support for synchronized execution of compiled scripts (#4402)
* [automation] Synchronize execution of compiled scripts if ScriptEngine implements Lock interface

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-10-06 19:20:30 +02:00
Florian HotzeandGitHub c454ee2241 Fix input parameter not enabled if label/description provided for discovery services (#4393)
Fixes an issue from #4389.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-09-30 17:51:35 +02:00
Florian HotzeandGitHub 437a885d82 [thing] Add toString overrides to ThingImpl & BridgeImpl (#4382)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-09-19 18:53:26 +02:00
Florian HotzeandGitHub e027bb5cb1 [rest] Add caching for transformation resource (#4376)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-09-13 08:54:50 +02:00
Florian HotzeandGitHub 6d174a91c2 Fix favicon for authorize/login page (#4335)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-08-04 18:11:01 +02:00
Florian HotzeandGitHub 1ce5b378d3 Icon servlet: Set Cache-Control header to enable icon caching (#4336)
I have removed the Modified-Since handling as it did not have an effect due to the missing Cache-Control header,
and instead added Cache-Control with a max-age set.
This enables "forever" caching of icons, which should be fine since they are static assets.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-08-04 17:33:06 +02:00
Florian HotzeandGitHub e1574488b6 [rules] Don't attempt to pre-compile disabled rules (#4329)
Fixes an issue, where an error that compilation failed for disabled rules.
Reported on the community: https://community.openhab.org/t/oh-4-2-snapshot-disabled-rules-failed-to-compile-error-in-opehab-log/157402.
Follow-up for #4289.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-07-24 20:18:49 +02:00
Florian HotzeandGitHub f631f1bbca [rules] Remove leftover from #4289 (#4319) 2024-07-14 22:28:38 +02:00
Florian HotzeandGitHub 918b4faa3b [rules] Add support for pre-compilation of conditions and actions (#4289)
* ScriptConditionHandler/ScriptActionHandler: Add support for pre-compilation of scripts

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-07-09 19:12:33 +02:00
Florian HotzeandGitHub f7f4b7653c PersistenceExtensions: Support state as string for persist method (#4268)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-06-05 18:30:36 +02:00
Florian HotzeandGitHub b9940d6687 [automation] Improve logging in ScriptConditionHandler (#4192)
Fixes #4179.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-04-21 10:16:03 +02:00
Florian HotzeandGitHub be9cbf2649 [automation] Avoid memory leak on script loading failure (#4162)
Core part of the fix for https://github.com/openhab/openhab-addons/issues/16462.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-27 22:32:20 +01:00
Florian HotzeandGitHub e871dcfa47 [rest] TokenResource: Set SameSite attribute for session id cookie (#4160)
* [rest] TokenResource: Properly set SameSite attribute for session id cookie

Fixes #4159.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-27 22:31:29 +01:00
Florian HotzeandGitHub 7f47d825a0 [rest] Add caching for add-on resource (#4107)
* [rest] Introduce a CACHE_CONTROL constant
* [rest] Add caching for add-ons endpoint

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-27 19:37:36 +01:00
Florian HotzeandGitHub c9ee992047 [automation] Allow empty script for script action & script condition (#4148)
* Script action: Allow script to be empty
* Short evaluate to reasonable defaults when script is empty

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-17 20:31:51 +01:00
Florian HotzeandGitHub 977fa0329a [rest] Enable filters for cacheable items list (#4119)
This allows the usage of filters when using `staticDataOnly=true`.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-10 11:41:52 +01:00
Florian HotzeandGitHub 38b73bf989 [auth] Set doctype for auth page (#4129)
Fixes https://github.com/openhab/openhab-webui/issues/2443.

See https://developer.mozilla.org/en-US/docs/Web/HTML/Quirks_Mode_and_Standards_Mode.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-10 09:59:38 +01:00
Florian HotzeandGitHub f4d6089eb0 Call, Contact, Image items: Don't create command descr from state descr (#4097)
* Contact item: Fix command descriptions provided even though commands are not accepted

If a state description is set on a contact item, currently a command description is automatically created as well.
This is wrong as contact items do not accept commands (except refresh) and caused the UI to display a control for the default (list) widget for these contacts.

* Also fix Call and Image items & Allow explicitly setting command description

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-03 13:20:10 +01:00
Florian HotzeandGitHub 81805ae6d9 [rest] Set editable for members of an item (#4118)
* [rest] Set editable for members of an item

Required by the UI.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-03 10:14:32 +01:00
Florian HotzeandGitHub d26aa080ab Script profile: Fix deprecation warning (#4110)
Refs #4058.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-02 10:46:28 +01:00
Florian HotzeandGitHub 45f8bff876 Upgrade tool: Add upgrade task for script profile changes (#4117)
* Upgrade tool: Add upgrade task for script profile changes

Refs #4058.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-03-02 10:41:34 +01:00
Florian HotzeandGitHub 6be00bd585 Script profile: Separate toHandlerScript for commands and states (#4058)
* Script profile: Separate toHandlerScript for commands and states

This allows much more fine-grained control for the script profile.
E.g. it is now possible to mimic the behaviour of the `system:follow` profile, but apply a script transformation to the forwarded state.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2024-02-06 21:29:19 +01:00
Florian HotzeandGitHub f5bd7f94f3 [rest] Add no-cache directive to cached REST responses (#3970)
Fixes https://github.com/openhab/openhab-webui/issues/2102.

This forces the browser to revalidate the cache every time it is accessed to ensure the data is always fresh.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#directives.

This is approach is also suggested in the mdn web docs, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#up-to-date_contents_always.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-12-27 17:52:49 +01:00
Florian HotzeandGitHub 2794c973d3 [rest] Add caching for UoM info (#3838)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-10-09 09:18:45 +02:00
Florian HotzeandGitHub 176e23f296 Fixes source filter not working for GenericEventTrigger (#3837)
While reviewing https://github.com/openhab/openhab-js/pull/300,
I noticed that filtering by source `org.openhab.core.expire` was not possible.

This was because the specified source was checked against the event topic, which makes no sense at all given that different schemes.
Source filtering is done inside the `apply` method.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-10-08 19:43:08 +02:00
Florian HotzeandGitHub c4fb71fcc6 [automation] Update texts for rule-based actions (#3733)
Core part of https://github.com/openhab/openhab-webui/issues/1921.

With UI-support for scenes & scripts, the texts (labels, descriptions etc.) for rule-based actions should be updated to mention scenes & scripts as well.
This improves the UI experience.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-07-30 20:26:51 +02:00
Florian HotzeandGitHub f5a0b37b3d [persistence] Handle null value for relative & inverted props of filters (#3727)
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-07-25 21:07:24 +02:00
Florian HotzeandGitHub e1741cf61d [rest] Add caching for TagResource & De-duplicate code for caching (#3729)
* [rest] Add caching for TagResource
* [core] Add & use RegistryChangedRunnableListener class

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-07-25 20:59:39 +02:00
Florian HotzeandGitHub 72ec0f3517 [rest] Add missing fields to /rest/items?staticDataOnly=true resource (#3712)
Fixes #https://github.com/openhab/openhab-webui/issues/1958.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-07-21 13:35:38 +02:00
Florian HotzeandGitHub 62a83557ae [persistence] Handle null value for unit field of filters (#3716)
Setting up a treshold filter with the UI, it did not work because the unit field was blank.
I got an NPE from PersistenceTresholdFilter, and the PersistenceIncludeFilter would also throw a NPE in that case.
For PersistenceTimeFilter, defaulting to "s" is just cosmetic.

Picks-up PR #3681 and should be merged for the 4.0 release, because the UI does not prevent the unit field from being null.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-07-20 17:17:53 +02:00
Florian HotzeandGitHub be7488958d [sse] Add type information to state event (#3647)
* SSE Item state stream: Provide state type

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

* Add comment for method source

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-06-08 14:31:34 +02:00
Florian HotzeandGitHub 633002c647 Fix wrong event subscription in CommunicationManager (#3529)
* Fix wrong event subscription in CommunicationManager

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-04-07 14:26:19 +02:00
Florian HotzeandGitHub 56fa0c9851 Add method overloads for PercentType to Audio & Voice actions (#3352)
* Overload Audio & Voice actions to support float in addition to PercentType for volume
* Align params in Audio & Voice actions to increase code readability
* Fix mathematical interval notation in string

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-02-14 09:10:01 +01:00