demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-10 21:31:53 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

[automation] Avoid memory leak on script loading failure (#4162)

Browse Source 
Core part of the fix for https://github.com/openhab/openhab-addons/issues/16462.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This commit is contained in:
Florian Hotze 2024-03-27 22:32:20 +01:00 committed by GitHub
parent e871dcfa47
commit be9cbf2649
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bundles/org.openhab.core.automation.module.script/src/main/java/org/openhab/core/automation/module/script/internal/ScriptEngineManagerImpl.java
View File

@ -175,7 +175,13 @@ public class ScriptEngineManagerImpl implements ScriptEngineManager {
return true;
} catch (Exception ex) {
logger.error("Error during evaluation of script '{}': {}", engineIdentifier, ex.getMessage());
logger.debug("", ex);
// Only call logger if debug level is actually enabled, because OPS4J Pax Logging holds (at least for
// some time) a reference to the exception and its cause, which may hold a reference to the script
// engine.
// This prevents garbage collection (at least for some time) to remove the script engine from heap.
if (logger.isDebugEnabled()) {
logger.debug("", ex);
}
}
}
return false;