* [unifi] Fix PoE port mode for 24V
The value UniFi expects is actually pasv24. Tested with different UniFi controller versions.
* [unifi] Added Hilbrand as codeowner to UniFi binding
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [unifi] Set PoE thing offline if no data could be found
This would better reflect the PoE thing status if there is a problem with either the data from the api or a configuration problem (like invalid port number).
* [unifi] Fix bug to detect PoE ports when first port is not PoE port
The binding assumed either all ports or no ports were PoE, and asssumed if port 0 was not PoE none was PoE.
However, some switches have ports starting at port 5 to be PoE. Therefor changed code to just test each port if it is PoE.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
When a user has configured additional settings on a PoE port, like name.
These settings where lost when changing the PoEPort status in openHAB.
This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too.
In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Subchannels were created by appending the key. However this was done inside a loop and if multiple updates were needed they would be appended to the channel name, instead of taking the channel name each time.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Updated readme, added how to generate i18n en properties file/kar files/use -pl option
- Also put command in blocks to make them stand out more in the readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [unifi] New wiredClient and poePort, Discovery support
This change adds the following changes:
- 2 new things: a wired client and POE port.
- Adds discovery of clients and poePort.
- Adds guest channel to client thing.
Also included some refactoring and bug fixes.
This change includes changes made by Matthew Bowman that he created on his own branch but were never completed.
Closes#9609: Implemented async http call, which should fix the buffer overflow.
Closes#10375: At least should avoid the stack overflow.
Closes#11964: cid will be handled in lower case.
* Removed type from UniFiCache constructor
It's redundant and only used for logging.
* Added UniFi Site and wLAN things
* Improved default state handling
Updated refresh/state update, to also update when no data available.
Simplified usage of cache: call cache directly instead of implicit via controller class.
Made getDefaultState generic to all things, and simplified passing channelId instead of channelUID to sub methods.
* Moved dto objects to dto package.
* Added support for client experience
* Made fields private
No need to have them protected.
* Added PoE power-cycle command
Also added wireless client as command as this better fits with the openHAB model to handle commands that are only one way and not have a state.
* Updated readme
* [unifi] Added client/guest count to wlan
* Fix QRcode construction and added hidden ssid support in qrcode string
Also-by: Matthew Bowman <mgb@otr.mx>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Co-authored-by: Matthew Bowman <mgb@otr.mx>
Closes#8709
Additional:
- Added action to send and receive json commands to a tplink device. This can be used for test purposes or to run commands not available through channels.
Fixes:
- Power channel of a bulb is defined as QuantityType in xml, therefor it should create the state using QuantityType
- Retry getting values 5 times before setting the device offline. Reduced socket time out to 2 seconds as it normally should react quickly and if it times out it tries again.
Also-by: Dustin Masters <ceo@dustinsoftware.com>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Season timeleft calculated the wrong time at the end of the year, because the seasons it measures the time with are the seasons within the same year.
So for times at the end of the year it computed against the season at the beginning of the year, resulting in negative number of days.
Also changed the time of timeLeft to actual days instead of quantity unit days.
Because with the milliseconds internal resolution it will generate events each and every time this channel is updated as milliseconds change often.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
These are color bulbs and should have the color channel instead of the brightness channel.
Closes#11660
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Fix fix for channel id detection, Added missing channels to emucs electra
- M-bus channels are dynamic and present in the obis id.
The binding had most channel types fixed because most of the time these channels are the same.
However the device identifier is the same for multiple devices.
But the binding only registered only one and while the channel id was derived from this obis data.
For detected meters this resulted in the channel id to be the same if there are multiple devices.
This change looks at the channel id to assign it to the found device.
This is a bit tricky because the general device has no channel and has channels that have different id's.
So the binding needs to cover that case.
This change also adds some optional channels to the emucs electra meter.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Add support for Austrian meters
Improved the work done in pr #11193
Also-by: Thomas <thomas@knaller.info>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Added Null handling annotations.
Enhancements:
- Added play actions to start a track or other via a rule.
- Added albumImageUrl with the url to the album image to not have to send the whole image via the openHAB eventbus.
- Added a parameter imageIndex to set the image size to use (0, 1 or 2) to channels albumImage and albumImageUrl.
- Added offset and limit parameters to playlists channel (Closes#6843).
Fixes:
- Fixed invalid expire value set on ExpiringCache (Closes#10490).
- Improved handling Spotify API error messages (Closes#11308).
- Added TTL to discovery results to fix duplicated Spotify Connect devices reported in the inbox (Closes#7400).
- Fixed device list update problem for devices. If no devices where configured as separate things (or the devices added where offline, but non added where not offline) the list was not updated.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] Catch empty commandTopic
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] Fix handling action
keys in action context from trigger are passed with prefix of trigger name.
This change removes the prefix to get the actual name and checks if it matches an item.
Else it tries the original name.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] review comment
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
The internal package was placed before the binding specific package, and it should be the other way around.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Fix handling problem reading gasmeter
The gasmeter seem to return an invalid date value in some cases.
Possible problems with the meter. This however caused the whole meter readings to be ignored, while it should only ignore the single problem value.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Make eclipse happy again.
Don't ask...
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Removed sat warnings
Removed usage of apache library and added NonNullByDefault to test classes..
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [snmp] Set thing only online on valid response
Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured).
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
