demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-11 05:41:52 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity
2,162 Commits 1 Branch 0 Tags 39 MiB
e3396c9477
Commit Graph

179 Commits

Author SHA1 Message Date
J-N-K
2a3e2e5567
Reduce Mockito warnings (#2893) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2022-04-03 22:36:55 +02:00
Wouter Born
9ff7ad43b9
Add more null annotations to automation bundles (#2763) 
* Add more null annotations to automation bundles. This adds null annotations to many classes in the automation bundles and a few dimension classes.
* Further cleanup AutomationCommandExport
* Remove null from RuleStatusInfo JavaDocs. This should be clear from how the class is now annotated.
* Validate deserialized RuleStatusInfo
* Allow TriggerHandlerCallback to be triggered without providing a context

Signed-off-by: Wouter Born <github@maindrain.net>
 2022-02-25 16:40:02 +01:00
Wouter Born
92917946d4
Add even more null annotations (#2752) 
This PR adds even more missing null annotations which did not fit in #2742 as it grew too big.

Signed-off-by: Wouter Born <github@maindrain.net>
 2022-02-17 21:30:51 +01:00
Wouter Born
3d7be0ffa7
Avoid throwing raw exception types (#2747) 
* Avoid throwing raw exception types

This fixes all 36 AvoidThrowingRawExceptionTypes SAT findings.

Signed-off-by: Wouter Born <github@maindrain.net>
 2022-02-14 16:14:25 +01:00
Wouter Born
ad936cd83f
Add more null annotations (#2742) 
* Add more null annotations
* Fix mock name

Adds null annotations to most of the tests as well as a few other classes.
Also fixes a few other SAT findings.
Fixes ~300 SAT findings in total.


Signed-off-by: Wouter Born <github@maindrain.net>
 2022-02-14 11:33:50 +01:00
Christoph Weitkamp
0709933061
[automation] Log warning for equals condition for DecimalTypes and QuantityTypes (#2653) 
* Allow equals comparison for DecimalTypes and QuantityTypes

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2022-01-15 15:39:51 +01:00
Christoph Weitkamp
cabb3f7315
Update license headers to 2022 (#2671) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2022-01-07 13:16:42 +01:00
Christoph Weitkamp
824c0bb77c
Align parsing of startlevel config (#2661) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2022-01-04 21:03:16 +01:00
Kai Kreuzer
e3b07782b4
pom reference update from http to https (#2644) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-12-23 22:55:20 +01:00
Kai Kreuzer
1ebf7395d9 Apply spotless 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-12-20 06:59:22 +01:00
openhab-bot
5ac05c4968 [unleash-maven-plugin] Preparation for next development cycle. 2021-12-19 21:49:34 +00:00
Yannick Schaus
198e2eb405
Change the syntax for references in automation modules configuration (#2606) 
Fixes #2510.

This changes the placeholder syntax used by the reference resolver notably
used in rule templates from `${reference}` to `{{reference}}`.

The former syntax is also used by other languages, notably JavaScript's
template strings, and therefore writing rule templates including JavaScript
code with template strings wouldn't behave as expected.

This also fixes a bug identified in #2510 where you couldn't have a
single closing brace before the start of the first placeholder - which
could more easily happen than having two closing braces.

Signed-off-by: Yannick Schaus <github@schaus.net>
 2021-12-12 19:20:19 +01:00
Christoph Weitkamp
eb982f430d
Fixed nullness anotations for TriggerHandlerCallback (#2589) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2021-12-04 17:48:18 +01:00
Christoph Weitkamp
07ee8e6ffc
Added nullness anotations to ChannelEventTriggerHandler (#2586) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2021-12-03 14:32:05 +01:00
Wouter Born
bf81eaa1c2
Fix/suppress PMD CompareObjectsWithEquals findings (#2548) 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
 2021-10-30 19:37:34 +02:00
Christoph Weitkamp
f694535598
Log item name in warnings of ItemStateConditionHandler (#2540) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2021-10-25 22:14:06 +02:00
Yannick Schaus
2663a3fc7e
Community Marketplace Add-on Service - initial contribution (#2405) 
Signed-off-by: Yannick Schaus <github@schaus.net>
 2021-09-14 09:04:04 +02:00
Sami Salonen
4bcf48662a
Consistent ordering of entries in jsondb (#2437) 
* Consistent ordering of entries in jsondb

Resolves #2436.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
 2021-08-08 16:05:38 +02:00
Christoph Weitkamp
66847ebef9
[automation] Allow UoM in 'ItemStateCondition' (#2435) 
* Allow UoM in ItemStateConditions

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2021-07-31 19:17:57 +02:00
Kai Kreuzer
5a667cc868 applied spotless 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-06-27 23:22:02 +02:00
jenkins
b8d2077805 [unleash-maven-plugin] Preparation for next development cycle. 2021-06-27 15:50:02 +00:00
Stewart Cossey
08632596b3
[automation] Fix offset for ephemeris condition (#2398) 
Signed-off-by: Stewart Cossey <stewart.cossey@gmail.com>
 2021-06-06 09:40:36 +02:00
Fabian Wolter
e007307796
[automation] Expose TriggerHandlerCallback scheduler (#2388) 
* [automation] Expose TriggerHandlerCallback scheduler

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
 2021-05-31 10:04:21 +02:00
Kai Kreuzer
0343f44601
[automation] add tags to item modules (#2378) 
* add tags to item modules
* made state/command configuration optional

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-05-25 16:39:31 +02:00
Wouter Born
7579aa4d31
Fix more SAT findings and add a few suppressions (#2335) 
* Fix more SAT findings and add a few suppressions

Signed-off-by: Wouter Born <github@maindrain.net>
 2021-05-05 20:59:59 +02:00
Thomas Weißschuh
9663060943
[automation] match on complete channel UID (#2337) 
Matching only on "topic.contains(channelUID)" will lead to false
positivies.

This was reported for the linuxinput binding, where pressing the "left"
key would also trigger rules for the "l" key.

The channels for these are
`linuxinput:input-device:test:keypresses#KEY_L` and
`linuxinput:input-device:test:keypresses#KEY_LEFT`

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
 2021-05-04 10:49:44 +02:00
Wouter Born
05b7ec86f1
Fix new SAT findings (#2291) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2021-04-14 18:41:07 +02:00
Sönke Küper
db488d861e
[automation] Added rule rest endpoint and backend operation for rule execution simulation (#2125) 
* Added marker interface for TriggerHandler to indicate if they are time based and thus can be used to simulate execution times.
* Added marker interface for ConditionHandler to indicate, if they are time based and thus can be checked during rule execution for a certain time.
* Moved CronAdjuster to common, so it can be used for the rule simulation
* Created RuleExecutionSimulator that allows simulation of rules
* Added method in RuleManger to create simulation
* Added rest endpoint for rule simulation.
* Changed marker interface to return TemporalAdjuster instead of cron expression. This better hides the internals of the TriggerHandler (i.e. the cron expression) and is more clear and flexible for other handlers to implement

Fixes #2044
Fixes #2266

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
 2021-04-11 09:31:48 +02:00
Christoph Weitkamp
7907f48735
Added nullness annotations to TypeParser (#2181) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2021-02-07 09:47:27 +01:00
Sönke Küper
65218f81fc
Added rule condition for not a holiday (#2043) 
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
 2021-02-06 16:37:29 +01:00
Wouter Born
46666eb169
Fix deprecations (#2163) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2021-01-30 12:22:31 +01:00
Wouter Born
774b9d607b
Update license headers to 2021 (#2041) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2021-01-01 16:43:46 +01:00
Wouter Born
bf14e1077f
Apply Spotless, resolve itest runbundles for 3.1.0 (#1982) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-22 10:01:42 +01:00
jenkins
965531696b [unleash-maven-plugin] Preparation for next development cycle. 2020-12-20 22:24:39 +00:00
Christoph Weitkamp
f83fc07c6a
[automation] Added ItemStateUpdate action (#1970) 
* Added ItemUpdate action

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-20 13:53:09 +01:00
Kai Kreuzer
8f13b99122
[automation] Correctly trigger rules with start level 50 trigger (#1962) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-18 22:07:19 +01:00
Kai Kreuzer
4a108e5c80
Reintroduce delayed rule initialization (#1960) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-18 20:04:28 +01:00
Kai Kreuzer
5d87c1def4
[automation] Fixed startup rules being triggered more than once 
Fixes #1943 

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-16 23:21:47 +01:00
Christoph Weitkamp
d37fa48da4
Temporarily hide ThingAction in UIs (#1947) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-16 23:21:27 +01:00
Kai Kreuzer
2b9f890831
Stabelized automation integration test (#1944) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-16 14:13:04 +01:00
Kai Kreuzer
8290306348
Fixed SAT issues (#1925) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-13 13:17:35 +01:00
Kai Kreuzer
313fb496ce
Added config options for start level trigger (#1923) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-13 09:31:34 +01:00
Kai Kreuzer
1a2c81d9e2
Improved startup logging and avoid scripts being loaded in start level service thread (#1919) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-13 09:31:09 +01:00
Kai Kreuzer
076ac3fe15
Implemented start level service (#1914) 
Fixes #1637
Fixes #1777
Fixes #1734
Fixes #1823
Fixes #1808

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-12 14:34:37 +01:00
Kai Kreuzer
f99135ae3d
Reverted the introduction of an automation threadpool (#1890) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-05 11:50:16 +01:00
Kai Kreuzer
a892c7bcac
Synchronize the executions of each rule (#1870) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-11-30 10:31:33 +01:00
Kai Kreuzer
575f744a43
Request automation thread pool as a scheduled pool (#1869) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-11-30 10:18:56 +01:00
Kai Kreuzer
1e2fd7b447
Make rule engine use a threadpool (#1857) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-11-29 10:56:01 +01:00
Kai Kreuzer
48209e4a45
[automation] Fixes NPE when no command is given in a member-of-group trigger (#1806) 
Fixes #1793 

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-11-11 16:27:31 +01:00
Christoph Weitkamp
0b239692ce
Added NPE checks for result of 'getSymbolicName()' methods (#1795) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-11-10 22:36:21 +01:00
Wouter Born
2f2bfde500
Remove Map null annotation workarounds (#1780) 
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-11-03 22:12:22 +01:00
Wouter Born
0281c10036
[infrastructure] add external null-annotations (#1775) 
Add EEAs and fix null analysis errors.

Related to:

* #888
* openhab/openhab-addons#8848

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-11-03 21:33:48 +01:00
Christoph Weitkamp
dd92288e97
Added nullness annotations, ctor injection (#1747) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-10-24 10:08:38 +02:00
Christoph Weitkamp
7d70a97b77
Fixed IndexOutOfBoundsException in ScriptModuleTypeProvider (#1730) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-10-19 13:41:58 +02:00
Wouter Born
0d1a15ef34
Update ActionService and ThingActions classes in Xtext cache (#1714) 
Xtext uses a cache for looking up classes when rules are run.
It also adds a null class value to this cache when a class is not found.

Once a value has entered the cache it will not be updated.
This causes the cache to return the wrong class (or the null value) when
calling static methods on ActionService and ThingActions classes that
were added/updated.

With the changes in this PR Xtext will be configured to use a custom cache
that updates the ActionService and ThingActions class references.

The PR also has a fix for the AnnotatedThingActionModuleTypeProvider not
properly sending ModuleType removed events when all ThingActions
registrations have been removed.

Fixes #1265
Fixes #1694

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-10-13 23:17:57 +02:00
Wouter Born
81e82e7d44
Use consistent capitalization with Conditions, Triggers, Actions (#1647) 
Fixes #1639

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-15 19:52:35 +02:00
Łukasz Dywicki
7652d04ff6 Remove dependencies which are not present in the project. (#1592) 
These cause build to fail with clean repository.

Signed-off-by: Łukasz Dywicki <luke@code-house.org>
 2020-09-03 20:33:32 +02:00
Wouter Born
057604cc2d
Use new Collection API methods (#1598) 
Using the new methods there will be less and more readable code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-22 23:04:11 +02:00
Wouter Born
d5529f0c1b
Fix various deprecations (#1595) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-15 10:54:41 +02:00
Wouter Born
7300734585
Use "openhab" event topic prefix (#1587) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-11 21:16:49 +02:00
Wouter Born
d3ea6063c0
Migrate to JUnit 5 (#1580) 
* Migrates all tests to the JUnit 5 Jupiter API
* Updates bnd to 5.1.2
* Updates maven-surefire-plugin to 3.0.0-M5
* Updates Mockito to 3.4.6
* Updates Hamcrest to 2.2
* Removes org.openhab.core.boot POM dependencies

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-09 14:36:46 +02:00
Kai Kreuzer
0f134996f2
removed boot bundle (#1559) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-07-24 13:11:56 +02:00
Paul Vogel
ed21001891
Cleanup tests: Simplify assertEquals with boolean to assertTrue or assertFalse (#1567) 
Signed-off-by: Paul Vogel <pavog@users.noreply.github.com>
 2020-07-23 22:19:00 +02:00
Christoph Weitkamp
c747f7f9bb
Fixed removal / replacement of annotated ThingActions (#1536) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-07-21 19:44:55 +02:00
Paul Vogel
27dcce5207
Replace for-loops and iterators with foreach-loops (#1561) 
Signed-off-by: Paul Vogel <pavog@users.noreply.github.com>
 2020-07-21 17:40:29 +02:00
Christoph Weitkamp
68405036f1
Removed 'Calendar' leftovers (#1522) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-06-14 17:13:28 +02:00
Kai Kreuzer
1fdede0f61
[automation] Removed superfluous file 
- Removed superfluous file

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-06-08 12:40:06 +02:00
Kai Kreuzer
840335bbd5
[automation] Moved constants to top and made them public for reference (#1513) 
* Moved constants to top and made them public for reference

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-06-07 23:03:53 +02:00
Kai Kreuzer
d265e16e67
[automation] Added group and system triggers to automation component (#1509) 
* Added group and system triggers to automation component

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-06-04 07:24:42 +02:00
Christoph Weitkamp
3eb93bf13a
Removed deprecated constructors and methods from Config API (#1448) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-20 22:16:54 +02:00
Wouter Born
f3508e4775
Use constructor injection and update null annotations (#1487) 
* Use constructor injection and update null annotations

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-05-20 17:29:18 +02:00
Wouter Born
84d9438737
Add null annotations to REST resources (#1475) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-05-17 19:32:35 +02:00
aisebastian
aca4513601
This patch adds more robust value comparison in the rule engine (#1456) 
Previously, the state values were compared only if the item state was instanceof DecimalType
which did not work for channels that had a dimension specifier, such as Type:Length. The itemState
instance was of type QuantityType<Quantity<BigDecimal>> and therefore was never compared in the rules

Signed-off-by: Sebastian Irimia <aisebastian@yahoo.com>
 2020-05-04 21:58:39 +02:00
Christoph Weitkamp
30839ac487
[automation] Fixed creation of 'EphemerisConditionHandler' (#1453) 
* Fixed creation of EphemerisConditionHandler

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-02 14:08:11 +02:00
Wouter Born
61e17ce39e
Upgrade SAT and Spotless, apply Spotless and enable check (#1446) 
* Update SAT and Spotless dependencies
* Apply Spotless and enable check

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-26 11:15:24 +02:00
Christoph Weitkamp
d371a34321
Removed dependency on 'org.apache.commons.lang' (#1433) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-22 14:32:31 +02:00
Wouter Born
92027ca922
Use .equals() on constants and literals to prevent NPEs (#1420) 
* Use .equals() on constants and literals to prevent NPEs

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-16 07:40:49 +02:00
Wouter Born
6c85b1bccd
Add and fix more null annotations (#1421) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-15 01:44:37 +02:00
Wouter Born
fb7a7ac421
Add null annotations to providers and ThingManager (#1412) 
* Add null annotations to providers and ThingManager

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-11 08:29:12 +02:00
Christoph Weitkamp
28afe7d866 Remove not needed object array creation for logging (#1344) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-27 09:22:17 +01:00
Christoph Weitkamp
08da8de5cf Moved "ESH-INF/" folders to "OH-INF/" folders (#1328) 
* Moved ESH-INF folders to OH-INF folders

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-17 15:29:18 +01:00
Wouter Born
18d0a52d02 Switch to Java 11 and drop Java 8 support (#1305) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-12 22:32:28 +01:00
Wouter Born
3811cb9560 Update copyright headers to 2020 (#1309) 
* Update copyright headers to 2020

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-01 18:06:34 +01:00
Christoph Weitkamp
800956598b Applied spotless formatter (#1302) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-30 22:55:19 +01:00
Christoph Weitkamp
59675788e0 Renamed packages 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-28 12:18:16 +01:00
jenkins
bc6a380297 [unleash-maven-plugin] Preparation for next development cycle. 2019-12-15 14:55:36 +00:00
Gaël L'hopital
4fef0100cb [ephemeris] Evolutions of the Ephemeris module (#1169) 
* Evolutions of the Ephemeris module

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
 2019-11-04 21:50:43 +01:00
Wouter Born
f002a21da5 Fix SAT errors/warnings in resources and tests (#1178) 
Fixes SAT errors/warnings in resources and tests reported by SAT 0.8.0-SNAPSHOT.

Related to openhab/static-code-analysis#363

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-11-03 11:04:19 +01:00
Christoph Weitkamp
1f9a6f685d Consider more than one value when applying the default value(s) for Things and Channels (#1067) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-01 22:23:52 +01:00
Christoph Weitkamp
12d91f7da9 [i18n] Refactoring and annotations (#1161) 
* Added nullness annotations to 'RuleTemplateI18nUtil'
* Added nullness annotations to 'ConfigDescriptionGroupI18nUtil'
* Moved 'ConfigDescriptionI18nUtil' into internal package
* Moved 'ConfigDescriptionGroupI18nUtil' into internal package
* Moved 'ThingTypeI18nUtil' into internal package
* Use 'ConfigI18nLocalizationService' instead of 'ConfigDescriptionI18nUtil'
* Use default labels / descriptions if application of localization is not successful
* Resolved itest.bndrun files

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-27 11:17:52 +01:00
Hilbrand Bouwkamp
d39b6bd35b [automation] Fix typos in EphemerisConditions.json (#1164) 
Closes #1163

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
 2019-10-24 20:37:24 +02:00
Feras Almannaa
144fc8b56f [automation] Fix the created cron to run only once at the trigger minute. (#1162) 
Fixes #1156

Signed-off-by: Feras AlManna <firas.almanna3@gmail.com>
 2019-10-23 18:11:42 +02:00
Wouter Born
2430256b6a Add null annotations to registries (#1134) 
Adds null annotations to all registries, the interfaces they implement and a few other classes.

Also-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-23 07:36:56 +02:00
Wouter Born
be69d2254e Use !isEmpty() instead of "size() > 0" or "size() != 0" (#1155) 
* Use !isEmpty() instead of "size() > 0" or "size() != 0"

!isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-21 09:00:52 +02:00
Christoph Weitkamp
a3d91bebfc [automation] Added EphemerisConditions for NGRE (#915) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-20 01:37:56 +02:00
Wouter Born
4895977966 Use isEmpty() instead of "size() == 0" (#1151) 
isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-20 01:27:11 +02:00
Christoph Weitkamp
21744d22b1 Normalized instantiation of loggers (#1138) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-18 22:29:27 +02:00
Christoph Weitkamp
91617d8af8 Fixed POM XML Shema Definition path (#1119) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-12 08:52:16 +02:00
Wouter Born
12e8edc039 Use diamond operator (#1114) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-11 02:29:47 -07:00
Wouter Born
4e10e0d116 Fix SAT JavadocMethodStyleCheck findings (#1109) 
* Fix SAT JavadocMethodStyleCheck findings

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-10 14:18:54 +02:00