demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-11 05:41:52 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Make rule engine use a threadpool (#1857)

Browse Source 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
This commit is contained in:
Kai Kreuzer 2020-11-29 10:56:01 +01:00 committed by GitHub
parent a301e96b6c
commit 1e2fd7b447
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
bundles/org.openhab.core.automation/src/main/java/org/openhab/core/automation/internal/TriggerHandlerCallbackImpl.java
View File

@ -12,31 +12,28 @@
*/
package org.openhab.core.automation.internal;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import org.openhab.core.automation.RuleStatus;
import org.openhab.core.automation.RuleStatusInfo;
import org.openhab.core.automation.Trigger;
import org.openhab.core.automation.handler.TriggerHandlerCallback;
import org.openhab.core.common.ThreadPoolManager;
/**
* This class is implementation of {@link TriggerHandlerCallback} used by the {@link Trigger}s to notify rule engine
* about
* appearing of new triggered data. There is one and only one {@link TriggerHandlerCallback} per RuleImpl and it is used
* by
* all
* rule's {@link Trigger}s.
* about appearing of new triggered data. There is one and only one {@link TriggerHandlerCallback} per RuleImpl and
* it is used by all rule's {@link Trigger}s.
*
* @author Yordan Mihaylov - Initial contribution
* @author Kai Kreuzer - improved stability
*/
public class TriggerHandlerCallbackImpl implements TriggerHandlerCallback {
private static final String AUTOMATION_THREADPOOL_NAME = "automation";
private final String ruleUID;
private ExecutorService executor;
@ -48,7 +45,7 @@ public class TriggerHandlerCallbackImpl implements TriggerHandlerCallback {
protected TriggerHandlerCallbackImpl(RuleEngineImpl re, String ruleUID) {
this.re = re;
this.ruleUID = ruleUID;
executor = Executors.newSingleThreadExecutor();
executor = ThreadPoolManager.getPool(AUTOMATION_THREADPOOL_NAME);
}
@Override
@ -93,13 +90,7 @@ public class TriggerHandlerCallbackImpl implements TriggerHandlerCallback {
}
public void dispose() {
synchronized (this) {
AccessController.doPrivileged((PrivilegedAction<Void>) () -> {
executor.shutdownNow();
return null;
});
executor = null;
}
executor = null;
}
@Override