* Use !isEmpty() instead of "size() > 0" or "size() != 0"
!isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.
Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
Suppresses the SystemPrintln SAT findings because this class is a Karaf shell command which prints to the console.
Signed-off-by: Wouter Born <github@maindrain.net>
Fixes wrong names identified by the following rules:
* ConstantNameCheck
* LocalFinalVariableNameCheck
* LocalVariableNameCheck
* StaticVariableNameCheck
Most mismatches identified by the MemberNameCheck have also been fixed except for those where the variables are used in events/DTOs etc which would cause issues.
Signed-off-by: Wouter Born <github@maindrain.net>
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.
Signed-off-by: Wouter Born <github@maindrain.net>
* updated license headers
* added NOTICE files
* moved about.html to NOTICE files
* changed main project license
* updated build.properties
* added files to check to prevent error about missing about.html
* removed license info on p2 feature
Signed-off-by: Kai Kreuzer <kai@openhab.org>
- wait for config update when online status has changed
- removed static methods and logger
- proper handling of "minimal" feature
- introduced a sync job that checks if everything is installed as expected (which serves as a retry mechanism in case of failed downloads)
fixes https://github.com/openhab/openhab-distro/issues/602
Signed-off-by: Kai Kreuzer <kai@openhab.org>
- upgraded to Java 8
- reduced calls to listInstalledFeatures, which is very expensive
- properly do the calculation of current/target/diff list of addons, when the config changes
- don't log errors when uninstallation fails as this can happen if it is a dependent feature that must not be uninstalled
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* adapted FeatureInstaller to adapt addons info in ConfigAdmin, so that this info is stored in a file
* removed experimental features
* removed package selection from UI as it is meant to be only set once
* introduced new packages: minimal, simple and expert
* introduced a setup page on the dashboard, if no package is set (and thus openHAB is uninitialized)
* added auto-refresh of dashboard to have new entries appear automatically
Signed-off-by: Kai Kreuzer <kai@openhab.org>
