demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-10 13:21:53 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Fix InstallServiceCommand SAT findings (#1124)

Browse Source 
Suppresses the SystemPrintln SAT findings because this class is a Karaf shell command which prints to the console.

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born 2019-10-13 21:52:44 +02:00 committed by Kai Kreuzer
parent 20faf1c63b
commit 627007d32e
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bundles/org.openhab.core.karaf/src/main/java/org/openhab/core/karaf/internal/command/InstallServiceCommand.java
View File

@ -18,6 +18,7 @@ import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.PrintStream;
@ -240,7 +241,7 @@ public class InstallServiceCommand implements Action {
System.out.println(" To stop the service:");
System.out.println(" $ service " + serviceFile.getName() + " stop");
System.out.println("");
System.out.println(" To uninstall the service :");
System.out.println(" To uninstall the service:");
System.out.println(" $ chkconfig " + serviceFile.getName() + " --del");
System.out.println(" $ rm /etc/init.d/" + serviceFile.getPath());
}
@ -269,7 +270,7 @@ public class InstallServiceCommand implements Action {
System.out.println(" To stop the service:");
System.out.println(" $ /etc/init.d/" + serviceFile.getName() + " stop");
System.out.println("");
System.out.println(" To uninstall the service :");
System.out.println(" To uninstall the service:");
System.out.println(" $ rm /etc/init.d/" + serviceFile.getName());
}
@ -401,8 +402,8 @@ public class InstallServiceCommand implements Action {
}
try {
is.close();
} catch (Throwable t) {
logger.error("Error closing inputstream", t);
} catch (IOException e) {
logger.error("Error closing inputstream", e);
}
}
@ -418,8 +419,8 @@ public class InstallServiceCommand implements Action {
}
try {
os.close();
} catch (Throwable t) {
logger.error("Error closing outputstream", t);
} catch (IOException e) {
logger.error("Error closing outputstream", e);
}
}
}

1
tools/static-code-analysis/pmd/suppressions.properties
View File

@ -14,3 +14,4 @@ org.eclipse.smarthome.ui.internal.proxy.ProxyServletService=AvoidCatchingThrowab
org.openhab.core.automation.internal.RuleEngineImpl=AvoidCatchingThrowable
org.openhab.core.automation.internal.RuleRegistryImpl=CompareObjectsWithEquals
org.openhab.core.automation.internal.provider.AutomationResourceBundlesEventQueue=AvoidCatchingThrowable
org.openhab.core.karaf.internal.command.InstallServiceCommand=SystemPrintln