Commit Graph

1853 Commits

Author SHA1 Message Date
Holger Friedrich
b0b8bb547b
Reduce rounding errors of RGB/HSB conversion and enhance ColorUtil (#3479)
* HSBType: Reduce rounding errors of RGB/HSB conversion
* Move RGB to HSV conversion to ColorUtil
* Restructuring HSBType and ColorUtil

- Move RBG/HSB conversion from HSBType to ColorUtil
- Rename helper functions "hsv" to "hsb" to be consistent with HSBType
- Add parameterized tests

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-04-07 18:43:01 +02:00
J-N-K
3047ed42a5
Prevent unnecessary MODIFY events in WatchServiceImpl (#3524)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-04-07 14:47:08 +02:00
Florian Hotze
633002c647
Fix wrong event subscription in CommunicationManager (#3529)
* Fix wrong event subscription in CommunicationManager

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-04-07 14:26:19 +02:00
J-N-K
8af908302b
Fix IllegalStateException in CommunityKaraAddonHAndler (#3528)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-04-07 09:44:28 +02:00
openhab-bot
4a82f5ba49
New Crowdin updates (#3509)
* New translations scriptprofile.properties (Italian)

* New translations messages.properties (German)

* New translations scriptprofile.properties (German)

* New translations scriptprofile.properties (Hebrew)

* New translations scriptprofile.properties (Polish)
2023-04-06 20:51:40 +02:00
J-N-K
ee392e861f
Fix WatchService tests (#3518)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-04-04 07:33:16 +02:00
Wouter Born
4851bfbcae
Fix recently introduced SAT issues (#3516)
* Fix recently introduced SAT issues

Signed-off-by: Wouter Born <github@maindrain.net>
2023-04-01 17:18:22 +02:00
J-N-K
d557a64532
Fix AbstractDependencyTracker (#3510)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-04-01 14:15:01 +02:00
J-N-K
8aa9e11342
Fix resource leak in SysfsUsbSerialScanner (#3513)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-04-01 11:32:53 +02:00
Holger Friedrich
74052e7bcd
Code cleanup: Use Java17 features (#3508)
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-04-01 09:51:12 +02:00
jimtng
003635dbfa
Fix Semantics default synonyms (#3511)
Fix incorrect Property id

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-04-01 09:32:12 +02:00
J-N-K
4182980ec8
Add ItemStateUpdatedEvent and enable group channel-links (#3141)
* Add (Group)ItemStateUpdatedEvent

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-31 23:01:40 +02:00
GiviMAD
4d0dba1abc
Fix OOBE in item metadata descriptions providers (#3488)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2023-03-30 20:33:21 +02:00
J-N-K
6294c48be4
Use try-with-resources on Files.walk/Files.list (#3504)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-29 09:54:41 +02:00
jimtng
c8cc05d24b
[REST] Sort profile-type resources by their label (#3491)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-29 08:49:04 +02:00
openhab-bot
8df40bc940
New Crowdin updates (#3489)
* New translations scriptprofile.properties (Hungarian)

* New translations voice.properties (Hungarian)
2023-03-29 08:47:45 +02:00
jimtng
30bbc95506
Clarify the script profile config description (#3506)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-29 08:41:38 +02:00
GiviMAD
b6c8aeaf10
Allow using quotes in metadata state/command description value/label (#3363)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2023-03-26 19:30:21 +02:00
Mark Herwege
850a9239de
Add inputHint parameter to sitemap Input element (#3418)
* Add inputHint param to sitemap Input element

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2023-03-26 11:15:56 +02:00
J-N-K
8494bf1199
[config] Fix ConvigValidationMessage in ThingManagerImpl (#3474)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-24 10:13:59 +01:00
openhab-bot
ae895790ac
New Crowdin updates (#3475)
* New translations automation.properties (Hebrew)

* New translations validation.properties (German)

* New translations validation.properties (Hebrew)

* New translations scriptprofile.properties (German)

* New translations scriptprofile.properties (Finnish)

* New translations scriptprofile.properties (Hebrew)

* New translations scriptprofile.properties (Polish)
2023-03-23 20:51:43 +01:00
openhab-bot
700b0e81ea
New Crowdin updates (#3471)
* New translations scriptprofile.properties (Danish)

* New translations scriptprofile.properties (Italian)
2023-03-22 19:50:43 +01:00
J-N-K
9289fd5a78
Bump spotless and fix formatting (#3469)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-20 23:14:59 +01:00
J-N-K
7bad9baa85
Introduce a profile for the generic SCRIPT transformation (#3292)
* Introduce a generic script profile

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-20 21:59:48 +01:00
jimtng
cb38d19360
Fix variable binding in ScriptTransformationService (#3464)
by setting all attributes before compiling

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-19 20:05:49 +01:00
jimtng
1e55914e55
Improve AbstractScriptFileWatcher initialization order and file handling (#3451)
* Remove initialImport from the constructor of AbstractScriptFileWatcher
- Calling initialImport inside the constructor may cause an NPE in child class.
* Refactor processWatchEvent in AbstractScriptFileWatcher
- Remove directory deletion handling and adapt test to check
for file removals instead.
- Include hidden files in deletions in case they were previously
loaded while not hidden, set to hidden, and then deleted.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-18 09:15:20 +01:00
J-N-K
a32f1e0253
Add ColorUtil for better support of xyY conversion (#3434)
* Add ColorUtil for better support of xyY conversion

This has been refactored to align with the usually used conversion by a lot of ZigBee products like Hue or Deconz.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-16 22:25:03 +01:00
lolodomo
52e36a0216
[sitemap] Add new color keyword "itemValue" (#3453)
Closes #3429

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-03-16 18:59:10 +01:00
GiviMAD
11e29c45f7
[voice] Fix default interpreter selection (#3458)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2023-03-16 09:05:10 +01:00
J-N-K
4390d515d6
Fix file processing in FileTransformationProvider (#3457)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-16 08:52:30 +01:00
GiviMAD
f529a7b77f
[CLI/voice] use parameters for cli voice commands startDialog and listenAndAnswer (#3253)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2023-03-16 08:07:06 +01:00
Jacob Laursen
3e1c0b3259
Fix InaccessibleObjectException (#3449)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-03-16 08:05:37 +01:00
J-N-K
c05fe8ad4d
Fix ready marker ordering on late subscriptions (#3454)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-13 21:15:55 +01:00
Andrew Fiddian-Green
73b8a3ae32
Fix channel order in REST API (#3448)
* Fix sort order of Things in UI
* Add itest for channel order

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2023-03-13 17:26:34 +01:00
J-N-K
95e04fccbd
Allow inline scripts in SCRIPT transformation (#3249)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-12 12:00:06 +01:00
Andrew Fiddian-Green
a5d65ce2ad
Add support for Jetty HTTP/2 clients (#3433)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2023-03-12 10:22:50 +01:00
lolodomo
a3a95b5bb9
AbstractCachedTTSService: make synthesize method non final (#3437)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-03-08 22:57:26 +01:00
openhab-bot
07ffc11c87
New Crowdin updates (#3438)
* New translations automation.properties (Polish)
* New translations automation.properties (Slovenian)
* New translations DefaultSystemChannels.properties (Slovenian)
* New translations LanguageSupport.properties (Portuguese, Brazilian)
* New translations magic.properties (Slovenian)
* New translations restauth.properties (Norwegian)
* New translations restauth.properties (Slovenian)
* New translations validation.properties (Norwegian)
* New translations validation.properties (Polish)
* New translations validation.properties (Slovenian)
* New translations voice.properties (Norwegian)
* New translations voice.properties (Slovenian)
2023-03-08 22:09:07 +01:00
Wouter Born
56f5550e6b
Fix broken ProxyServletService (#3436)
Reverts the partially working Whiteboard config changes of #3252 back to a working implementation using the HttpService.
The configurable threading makes this a non-trivial Servlet for use with the Whiteboard.

Fixes openhab/openhab-webui#1782

Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-08 20:07:59 +01:00
J-N-K
d0a0e6d399
Add support for channel-groups to update instructions (#3391)
* Add support for channel-groups to update instructions

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-07 21:57:39 +01:00
jimtng
f9751448c1
Fix ISE during WatchService disposal (#3432)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-07 15:43:45 +01:00
lolodomo
6d989ea6e2
Remove List element from sitemap syntax (#3423)
Related to openhab/openhab-webui#1755
Related to openhab/openhab-android#3285

This sitemap widget is not documented.

It is not implemented neither in Android app nor iOS app.

It was implemented in BasicUI but was buggy.
Support in BasicUI has been removed.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-03-05 20:48:06 +01:00
J-N-K
278e99b461
Fix IllegalStateException in WatchServiceImpl (#3389)
Added a check to prevent attempts to unregister already unregistered service

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-05 09:44:58 +01:00
J-N-K
07e8ff56c7
Prevent duplicate events in WatchService (#3404)
On Samba shares a single MODIFY event may result in different sequences of CREATE/DELETE/MODIFY events. Unfortunately this is not properly handled by the underlying library and we have to re-introduce our ugly workaround. The solution itself is a bit improved over the old one as it not only keeps the last event but determines the correct event by examining the sequence of received events.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-05 09:44:23 +01:00
Gwendal Roulleau
ac88faa5dc
[serial] Ability to use /dev/serial/ symlinks for usb serial device (#3290)
The rxtx serial port provider is now able to scan symlink in /dev/serial/by-id and use them as valid identifier.
Benefit : users won't have to fix the path of their USB serial device  with udev anymore, they can now use the explicit and stable symlink directly.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
[serial] Ability to use /dev/serial/ links

Revert previous commit (rewriting to use discovery serial service to provide the symlinks to all serial provider, and not only rxtx).
Workaround for the rxtx provider which can resolve symlink before using the native code (limit path to 80 char).

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
2023-03-04 14:43:46 +01:00
J-N-K
52380b7fbe
[rest] List transformation services (#3416)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-02 21:36:50 +01:00
J-N-K
76a22d9925
Fix ConfigValidationException handling in ThingManager (#3417)
Also makes sure the `checkPrerequisites` job can't crash by catching `RuntimeException` during processing.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-02 21:09:47 +01:00
J-N-K
a2cdb25aaf
Fix CME in ThingManagerImpl (#3415)
If several threads try to acquire a lock for things a CME is thrown.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-02 17:54:41 +01:00
Wouter Born
d154c8bcf9
Remove org.openhab.core.addon.sample left-over (#3413)
Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-02 11:29:19 +01:00
Wouter Born
59c5133815
Add Eclipse Add-on Service (#3406)
This service provides add-on information when debugging in Eclipse so it is possible to add Things based on the installed bindings and configure installed add-ons in the UI.
Replaces the Sample Add-on Service.

Also shows the "Add-on Management" configuration which allows for configuring if incompatible add-ons are included.

Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-02 07:41:49 +01:00
Kai Kreuzer
48c44a04d8
Fix service folder resolution path (#3412)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2023-03-02 07:39:59 +01:00
J-N-K
9778e6cc74
Allow initialization of incomplete things (#3397)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-03-01 13:14:16 +01:00
jimtng
ba7c68c05e
Fix overriding Jetty's User-Agent in HttpUtil (#3411)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2023-03-01 13:10:58 +01:00
Wouter Born
ec3af50f11
Upgrade to Karaf 4.4.3 (#3252)
* Sync runtime dependencies with Karaf 4.4.3, most notably:
  * Jetty 9.4.50.v20221201
  * Pax Logging 2.2.0
  * Pax Web 8.0.15
* Use OSGi R8 as compile dependency
* Rework Servlets to use Http Whiteboard annotations in favor of proprietary `org.openhab.core.io.http.servlet` classes
* Resolve itest runbundles

Also-by: Jan N. Klug <github@klug.nrw>

Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-01 13:09:07 +01:00
Gwendal Roulleau
5544945d48
[tts] Cache mechanism (#3057)
* [tts] Cache mechanism

Implements a cache mechanism for all TTS services.
Eviction policy is LRU mode.
This cache can serve several streams concurrently, for the same utterance, with only one call to the TTS. It doesn't wait for the stream to end and can serve data rapidly.
Cache size is a voice bundle parameter (10 mb default)

Closes #3039

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
2023-02-28 08:45:44 +01:00
lolodomo
f2b8fa77c6
Extend "iconcolor" attribute to all sitemap elements (#3403)
* iconcolor attribute added to all sitemap elements

This attribute was already available in syntax for the Image element but
was probably not used by any UI.
It is now available for any sitemap element and allows defining a color
for the widget icon based on conditional statements on the item value.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-26 19:49:51 +01:00
lolodomo
8c905b108e
Fix sitemap syntax for List element (#3402)
A "&" was missing !

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-25 19:25:18 +01:00
Mark Herwege
ea20371e21
Add Input type to sitemap model (#3398)
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2023-02-24 20:27:13 +01:00
openhab-bot
ccef3d24ff
New Crowdin updates (#3395)
* New translations DefaultSystemChannels.properties (Czech)

* New translations addons.properties (Czech)

* New translations marketplace.properties (Czech)

* New translations restauth.properties (Czech)

* New translations voice.properties (Czech)

* New translations validation.properties (Czech)
2023-02-24 20:25:02 +01:00
J-N-K
dff6f9b984
Refactor XML handling (#3385)
* Refactor XML handling for things
* integrate config.xml and improve naming

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-23 20:06:29 +01:00
J-N-K
f48200caa6
Allow access to rule summary for Role.USERS (#3392)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-21 19:31:55 +01:00
J-N-K
c739c85208
Fix AbstractScriptFileWatcher for windows (#3388)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-20 16:20:04 +01:00
lolodomo
cd45dfe9f7
New method to build a valid consumer name for a web client (#3359)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-19 17:22:00 +01:00
J-N-K
1b18831495
Fix ConfigDispatcherFileWatcher (#3384)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-19 11:47:20 +01:00
openhab-bot
0da4a226f1
New Crowdin updates (#3381)
* New translations validation.properties (Italian)

* New translations automation.properties (Hungarian)

* New translations automation.properties (Italian)
2023-02-19 11:45:13 +01:00
J-N-K
c17481c2ac
Align AbstractScriptDependencyTracker with AbstractScriptFileWatcher (#3372)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-18 09:17:59 +01:00
J-N-K
67ca7c61c3
Fix typo in RuleEnablementAction label (#3382)
Reported on Crowdin

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-18 09:17:18 +01:00
openhab-bot
ff063b93b2
New translations validation.properties (Hungarian) (#3374) 2023-02-17 06:57:16 +01:00
lolodomo
24d3055b80
Fix a typo in ItemsValidator (#3379)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-17 06:56:08 +01:00
J-N-K
d7fa5534bf
Refactor ThingManagerImpl (#3330)
* Refactor ThingManagerImpl

This

- moves config description URI to type-base class
- decouples the thing manager from bundle loading
- makes sure that all thing/channel-types and config descriptions are available when the thing is initialized
- enables thing type updates

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-15 22:03:59 +01:00
openhab-bot
7f5694856d
New Crowdin updates (#3371)
* New translations automation.properties (Polish)

* New translations automation.properties (Hebrew)

* New translations automation.properties (Italian)
2023-02-15 19:55:09 +01:00
J-N-K
35f7f3add1
Fix file-processing in AbstractScriptFileWatcher (#3369)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-14 20:38:37 +01:00
Florian Hotze
56fa0c9851
Add method overloads for PercentType to Audio & Voice actions (#3352)
* Overload Audio & Voice actions to support float in addition to PercentType for volume
* Align params in Audio & Voice actions to increase code readability
* Fix mathematical interval notation in string

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2023-02-14 09:10:01 +01:00
Cody Cutrer
474d24c62d
Refactor GenericEventTrigger and GenericEventCondition (#3299)
* rework GenericEventTrigger and GenericEventCondition

fixes #3234

to make their interfaces and semantics match, as well as having a
well defined (and useful) way of defining topic filters

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2023-02-14 09:07:23 +01:00
lolodomo
fd6e161d21
Use setpoint as default sitemap element for item with tag "Setpoint" (#3364)
* Use setpoint as default sitemap element for item with tag "Setpoint"

Fix openhab/openhab-webui#1697

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-12 19:30:29 +01:00
J-N-K
fcb8dee9a6
Improve handling of erroneous localized messages (#3366)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-12 17:04:33 +01:00
J-N-K
7f113c51bc
Refactor WatchService (#3004)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-12 14:12:22 +01:00
J-N-K
c349c0114e
Fix CME in ThingActionsResource (#3365)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-12 13:21:26 +01:00
lolodomo
f977a59ebe
Add param sslContextFactory when creating a HTTP or web socket client (#3356)
* Add param sslContextFactory when creating a HTTP or web socket client

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-02-12 10:45:02 +01:00
openhab-bot
1cad11a1ba
New translations LanguageSupport.properties (Portuguese) (#3353) 2023-02-12 10:43:31 +01:00
Kai Kreuzer
304617c5b7
Remove author from addon xsd (#3362)
* Remove author from addon xsd

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2023-02-11 19:50:05 +01:00
GiviMAD
c30e4b8eea
[voice] Support managed dialogs (#3264)
* [voice] introduce methods for dialog persistency

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2023-02-08 21:12:22 +01:00
J-N-K
a91b7f6425
Fix configuration for marketplace-services (#3357)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-06 19:37:56 +01:00
J-N-K
f67809a5e8
Fix CME in JarFileAddonService (#3351)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-04 15:43:45 +01:00
J-N-K
da81c6a6be
Fix AbstractScriptFilewWatcherTest (#3342)
The test only succeeded due to bad timing.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-03 20:37:48 +01:00
J-N-K
dd89d7b5a7
[persistence] Fix wrong .historicState call (#3348)
When calculating `.changedSince` the "then" state is queried via the `.historicState` method. Regardless of the `serviceId` used when calling `.changedSince` the historic state was always queried from the default persistence service.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-02-03 20:35:54 +01:00
Boris Krivonog
a50a0886e8
Fix parsing of YAML default value for community marketplace UI Widgets (#3334)
* fixes https://github.com/openhab/openhab-core/issues/3332

Signed-off-by: Boris Krivonog boris.krivonog@inova.si
2023-01-29 21:20:02 +01:00
Boris Krivonog
24b1cce213
Properly handle failure when parsing marketplace add-ons (#3339)
* When parsing marketplace addons, if one fails, none is loaded. This change ignores those that fail.
Signed-off-by: Boris Krivonog boris.krivonog@inova.si
2023-01-28 22:10:27 +01:00
lolodomo
9e31a41cb3
Build default doc link for misc and ui bindings (#3343)
Fix openhab/openhab-webui#1667

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-01-28 16:41:12 +01:00
lolodomo
14bae356c2
Consider language in KarafAddonService when creating Addon (#3341)
* [REST] Consider language when retrieving installed addons

Fix openhab/openhab-webui#1666

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-01-28 14:18:58 +01:00
lolodomo
c079f2cfaf
[REST] Consider language when requesting thing actions (#3337)
Fix #3303

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-01-26 11:06:38 +01:00
Cody Cutrer
35a70064c4
Fix CommunicationManager erroring on unusual item<->channel link (#3326)
Some bindings that dynamically create channels (mqtt.homie) might create
a channel that declares itself as Number:Dimensionless because the
end-device metadata has a unit of "%". But a savvy user might want to
link that to a Dimmer or Rollershutter item depending on what the device
actually is. This actually works just fine since QuantityType (with unit
PERCENT) and PercentType implicitly convert between each other. Except
this odd compatibility code in CommunicationManager that tries to assist
bindings that _aren't_ QuantityType compatible. It assumes if the channel's
item type is a dimensioned item, that the actual Item is a NumberItem,
and casts without checking. All this does is checks for that case to avoid
a ClassCastException.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2023-01-23 20:53:24 +01:00
J-N-K
673827733a
Fixes and enhancements for add-on services (#3293)
* Add an add-on service that provides add-ons in the addons-folder
* fix connection and countries

This is needed to show the add-ons from the addons in the UI.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-21 22:07:48 +01:00
J-N-K
1c34321cb5
[thing] Improve channel handling in ThingImpl (#3241)
* Improve channel-handling in `ThingImpl`

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-20 14:55:13 +01:00
J-N-K
dd756b8e25
Fix logger package addition in KarafAddonService (#3322)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-18 23:04:44 +01:00
J-N-K
8f9dafd1d6
Fix addon.xsd (#3320)
The namespace was missing, leading to problems in SAT

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-16 15:25:23 +01:00
Kai Kreuzer
10eb42af3f
Fix nullable errors (#3319)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2023-01-15 19:03:59 +01:00
J-N-K
3d54ee54d2
Introduce metadata for all add-ons (#3050)
* Introduce addon.xml

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-15 15:31:42 +01:00
Jacob Laursen
dd584779db
Improve UPNP callback removal (#3310)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-01-14 11:30:06 +01:00
J-N-K
ecbb854e03
Refactor AbstractScriptFileWatcher (#3255)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-12 19:37:42 +01:00
J-N-K
a09ad3d37c
Ensure metadata available at startlevel 20 (#3273)
* Ensure metadata available at start-level 20

This makes the `MetadataRegistry` report when the elements of the `ManagedMetadataProvider` is available via a ready marker (like other registries).

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-10 22:24:26 +01:00
J-N-K
fd5b451e59
Log the version/build on startup (#3270)
* Log the version/build on startup

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-10 22:13:44 +01:00
J-N-K
6cd6f6a538
Fix DateTimeTrigger not triggering on restored state (#3277)
During startup most likely the item state is `UndefType.NULL` which results in no triggering. States are restored from persistence by directly setting the item state, not by an `ItemStateEvent` and were therefore missed. Since changing the trigger is not necessary when the state updates but does not change, the event listening was changed to `ItemStateChangedEvent` only.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-10 22:11:52 +01:00
Cody Cutrer
d8a2c19609
Prevent a provider from removing elements added by another provider (#3301)
* prevent a provider from removing an element from another provider

if multiple providers provide the same element, the added callback
simply ignores the duplicates. but the provider has no idea its element
was ignored, so it may try to remove it in the future, and things will
get all out of whack if the element is removed from the registry even
if another provider thinks it's still there

this is easily reproducible by creating an item in the UI, then
creating the same item via a .items file, and then removing the item
from the .items file. The item will seem like it is gone to most
of openHAB, but will come back after reboot when the managed
provider re-adds.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2023-01-09 19:29:14 +01:00
Sami Salonen
ef34e5b0b4
QuantityType.as(PercentType.class) fixes with dimensionless units (#3297)
* QuantityType.as(PercentType.class) fixes with dimensionless units

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
2023-01-05 18:51:58 +01:00
stefan-hoehn
084f9779a7
Add method to get namespaces to MetadataRegistry and ItemResource (#3298)
* add retrieve namespaces for item

Signed-off-by: Stefan Höhn <stefan.hoehn@nfon.com>
2023-01-03 18:27:17 +01:00
Cody Cutrer
8be306a5bc
Cleanup event filtering and improve EventFilter usage (#3295)
* don't use event.topics OSGi service property
* use TopicPrefixEventFilter

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2023-01-03 16:30:12 +01:00
J-N-K
8d64ecfd8d
Update license header to 2023 (#3294)
* Update license header to 2023

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-03 09:45:42 +01:00
J-N-K
062e4a1758
[rest] Allow invoking ThingActions via API (#2810)
* [rest] Allow invoking ThingActions via API

Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-01 21:13:39 +01:00
Jacob Laursen
100aa6e838
Add method to DateTimeType for returning Instant (#3287)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-30 20:40:58 +01:00
Wouter Born
5e23b0e231
Fix Marketplace add-on range pattern matching (#3288)
* Fix Marketplace add-on range pattern matching

With this fix it will use the correct string for pattern matching add-on version ranges introduced in #2811.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-30 20:32:00 +01:00
J-N-K
98b4902c4a
Remove AccessController.doPrivileged calls (#3271)
The `AccessController` and the `SecurityManager` is deprecated for removal in Java 17. We don't make use of the `SecurityManager` anyway, so we can safely remove it.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-30 16:32:34 +01:00
J-N-K
d115032940
Add JavaDoc for the ThingBuilder (#3285)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-30 16:24:43 +01:00
jimtng
ab96a6ba55
[voice ]Only call getVolume when necessary (#3280)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-12-29 12:19:45 +01:00
Wouter Born
a3dc57784a
Remove wrong DataAmount units (#3261)
These wrong DataAmount units were added in #3208 for backwards compatibility.
In OH4 we can clean them up because this major version allows for breaking changes.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-23 23:51:28 +01:00
Wouter Born
80770161ac
Fix several compiler warnings (#3260)
Fixes a deprecation, unused imports and some raw type warning.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-23 16:41:46 +01:00
Wouter Born
7888da1684
Fix some recently introduced SAT and NPE issues (#3251)
Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-22 15:11:49 +01:00
Wouter Born
687688db7e
Update Eclipse .classpath files (#3250)
Also adds some missing files for recently added projects.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-22 14:14:35 +01:00
J-N-K
41ba3ff854
Raise minimum JDK version to 17 (#2994)
* Raise source level to Java 17 (except for model classes)
* Remove Nashorn script engine
* Upgrade spotless and add jvm options  
  See https://github.com/diffplug/spotless/issues/834
* Add suppression for findBugs false positive error
* Upgrade xtext to 2.29.0
* Adjust JNA
* Resolve itests

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-19 19:52:43 +01:00
Дилян Палаузов
d48ac20377
typo: successful (#3236) 2022-12-19 15:45:17 +01:00
J-N-K
5a9fb679ef
Remove redundant ctor in DecimalType (#3240)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-19 15:44:18 +01:00
J-N-K
3fc4d23734
Fix spotless and resolve itests (#3239)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-19 11:09:31 +01:00
openhab-bot
35254b3a0a [unleash-maven-plugin] Preparation for next development cycle. 2022-12-18 23:08:22 +00:00
openhab-bot
97299c7dcb
New Crowdin updates (#3237)
* New translations DefaultSystemChannels.properties (French)

* New translations restauth.properties (French)

* New translations voice.properties (French)
2022-12-18 14:03:51 +01:00
openhab-bot
92040d6b22
New Crowdin updates (#3229)
* New translations voice.properties (Hungarian)
* New translations automation.properties (Dutch)
2022-12-14 23:01:45 +01:00
Cody Cutrer
1d8d04f75e
Revert "Wrap ScriptEngine executions in a SafeCaller (#3180)" (#3227)
This reverts commit ff75505e70.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-13 19:16:27 +01:00
openhab-bot
d4ea62b983
New Crowdin updates (#3221)
* New translations DefaultSystemChannels.properties (Dutch)
* New translations restauth.properties (Dutch)
* New translations units.properties (Portuguese)
* New translations units.properties (Portuguese)
* New translations units.properties (Portuguese, Brazilian)
* New translations units.properties (Portuguese, Brazilian)
* New translations voice.properties (Dutch)
* New translations voice.properties (German)
* New translations voice.properties (Hebrew)
* New translations voice.properties (Italian)
* New translations voice.properties (Polish)
2022-12-12 22:23:13 +01:00
J-N-K
b842c87f98
Fix wrong websocket topics (#3223)
* Fix wrong websocket topics

The topics of the websocket event did not follow the openHAB convention of starting with `openhab/` followed by the component.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-12 20:49:42 +01:00
J-N-K
b39f735b9d
[rest] Fix missing backward compatibility in rules/runNow (#3225)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-12 20:48:45 +01:00
J-N-K
32ea8dddd0
Fix BasicAuthentication for websockets (#3219)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-12 08:56:25 +01:00
Kai Kreuzer
1523a1f2ab
Fix nullable errors in the IDE (#3220)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-12-11 23:17:09 +01:00
GiviMAD
e7ebc79897
[audio|voice] Add actions/commands to synthesize melodies and add configurable melody to the dialog processor (#3139)
* [voice] Add notification sounds to dialog processor
* [audio] add actions and commands to play melodies

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-12-11 16:13:59 +01:00
J-N-K
53861794de
Fix AbstractScriptFileWatcher missing deletes on Windows (#3216)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 16:11:53 +01:00
J-N-K
5bb31074b5
Fix NPE in PersistentInbox (#3215)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 15:49:09 +01:00
Cody Cutrer
e2bcdcc8f3
Allow profiles to access the entire context of the link they're applied to (#3151)
So that they can vary their processing based on the item or channeluid itself,
instead of (or in addition to) solely on the prior states passing through it.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-11 13:30:16 +01:00
jimtng
979e2c2d3e
Add countStateChangesSince/countStateChangesBetween to persistence extensions (#3211)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-12-11 12:55:42 +01:00
J-N-K
08d7d13c9b
Fix default unit for Energy (#3213)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 12:06:49 +01:00
J-N-K
94b8c2a540
Fix DataAmount dimension units (#3208)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 11:00:50 +01:00
Kai Kreuzer
015fed7a18
Prevent null warnings/errors in the IDE (#3209)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-12-11 02:02:09 +01:00
Kai Kreuzer
664fb559a4
Prevent compiler error in Eclipse due to potential null value (#3210)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-12-11 01:33:10 +01:00
J-N-K
0d9b678f36
Add countSince/countBetween to persistence extensions (#3145)
* Add countSince/countBetween to persistence extensions

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 00:14:06 +01:00
J-N-K
6479e4f818
[REST] allow running rules with context (#3160)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-11 00:01:46 +01:00
GiviMAD
5e6770749e
[voice] Avoid build a context to stop a dialog (#3206)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-12-10 16:48:58 +01:00
J-N-K
1b8280812b
Fix AVG calculation in GroupFunction (#3202)
Reported on the forum. Due to selection of the `RoundingMode` instead of a `MathContext` the average calculation is returning unexpected results: 19.0 °C / 19.5 °C results in 19.3 °C (instead of 19.25 °C) which might be acceptable, but 19.5 °C / 19.5 °C results in 20 °C (instead of 19.5 °C) which is obviously not what we want or expect. Setting the `MathContext` fixes this problem. I also corrected the same calculation for non-dimensional groups.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-10 16:02:35 +01:00
GiviMAD
c6b1fe266a
[voice] Use a builder to configure the dialog context and remove some deprecated method usages (#3195)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-12-10 13:49:42 +01:00
J-N-K
da2d6a8a21
Add EventWebSocket (#2891)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-10 12:28:58 +01:00
Hilbrand Bouwkamp
207c4a04da
Fix bug in migrateThingType to not call managed thing provider directly (#3162)
The `migrateThingType` call the managed thing provider directly instead of checking if it's actually a managed thing.
This check is done in the `thingUpdated` method. Changed the code so it makes the same call as in `thingUpdated`.

Also-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-12-10 10:12:04 +01:00
J-N-K
987cf221d3
Fix timer cancellation in automation cache (#3204)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-08 21:38:32 +01:00
J-N-K
d10cae0631
Improve UoM handling (#3201)
Also-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-07 15:55:02 +01:00
Cody Cutrer
ac7378d1bb
ScriptFileWatcher fixes for entire directories (#3185)
* handle entire directories being moved in and out of a watched script path
* ensure sorted scripts when ScriptFileWatcher restarts or new directories are added

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-06 19:01:49 +01:00
J-N-K
e90811cfd7
DSL support for sharedCache/privateCache (#3187)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-05 22:08:42 +01:00
J-N-K
b481ee73c9
Fix CME when creating SCRIPT transformations (#3188)
When updating file-based script transformations used in item state-descripting a CME can occur during reload. This is fixed by using thread-safe implementation of `HashMap`.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-04 17:56:20 +01:00
J-N-K
61bb5b3a31
Fix DSL action classes regression (#3197)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-03 21:07:15 +01:00
Kai Kreuzer
b52ea9e73e
Prevent NPE in SseResource (#3194)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-12-03 20:07:29 +01:00
GiviMAD
e48902132a
[voice] Fix start dialog with non default voice (broken recently) (#3190)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-12-03 15:13:03 +01:00
J-N-K
028724a73f
Add an access-tracking cache to be used in rules (#2887)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-02 09:47:00 +01:00
J-N-K
dc2f5d54f4
Fix transformRaw validation errors in DSL rules (#3178)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-30 23:12:12 +01:00
GiviMAD
d7f8ec2375
[voice] New voice manager dialog methods (#3142)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-11-30 22:46:38 +01:00
Cody Cutrer
ff75505e70
Wrap ScriptEngine executions in a SafeCaller (#3180)
Fixes #3179

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-30 22:36:49 +01:00
Дилян Палаузов
f64874e226
Fix a/an typos (#3184) 2022-11-30 21:16:18 +01:00
J-N-K
4bcc15daad
Refactor script dependency tracking (#3168)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-29 20:59:08 +01:00
Дилян Палаузов
e556fdf81b
Fix a/an typos (#3181)
* Typos a/an
* Fix typo generation in generateTagClasses.groovy

Signed-off-by: Wouter Born <github@maindrain.net>
2022-11-29 20:57:48 +01:00
Cody Cutrer
d96e5d5bc0
return the precise scheduled execution time for timers (#3182)
When writing tests and mocking time, it can be important that
execution_time match _exactly_ with what was sent to reschedule().
When re-calculating based on now and the expected remaining delay,
this might be off by a few milliseconds. We have the exact time
that was requested already, so might as well use it.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-29 18:25:53 +01:00
Cody Cutrer
af3738487c
add QuantityType.toUnitRelative (#3177)
this is a useful helper that can eliminate some complicated code elsewhere.
starting in SystemOffsetProfile. then I also want to use it in the homekit
addon.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-27 10:09:52 +01:00
Cody Cutrer
0cceb5b156
log full exception information when calling JSR223 scripts (#3176)
* log full exception information when calling JSR223 scripts

The scripts are user code, so in order to help them debug their code,
the full stack trace is very useful.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-27 09:28:36 +01:00
lolodomo
27b847f40c
Define format method for HSBType (#3165)
Pattern %s will match <hue>,<saturation>,<brightness>
Pattern %hsb% will match <hue>,<saturation>,<brightness>
Pattern %rgb% will match <red>,<green>,<blue>

Related to discussion in openhab/openhab-webui#427

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-11-26 16:00:54 +01:00
Cody Cutrer
f0875a46f2
tweak ScriptedRuleProvider slightly (#3170)
* tweak ScriptedRuleProvider slightly

just extend AbstractProvider so that it doesn't need to re-implement
managing listeners

Signed-off-by: Cody Cutrer <cody@cutrer.us>

* have ScriptedRuleProvider implement ManagedProvider

there's nothing that says ManagedProvider has to be backed by storage,
just that they should be able to add and remove elements

Since that's exactly what ScriptedRuleProvider does, might as well
have it conform to the interface.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-24 18:55:52 +01:00
J-N-K
f6e36c1852
[auromation] Fix createTimer for DSL rules (#3172)
* Fix createTimer for DSL rules

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-23 22:35:32 +01:00
Jacob Laursen
bf38f4d2b1
Clarify intention of beginDate/endDate in persistence extensions (#3164)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-21 17:13:05 +01:00
J-N-K
d00d14d9fc
Add default units for all dimensions (#3143)
* Add default units for all dimensions

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-19 23:10:38 +01:00
J-N-K
4f35d474fc
Strip unit if NumberItem has no dimension (#3153)
* Strip unit if NumberItem has no dimension

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-19 23:05:55 +01:00
J-N-K
c340e8db6c
Refactor ScriptExecution to plain Java ScriptExtension (#3155)
* Refactor ScriptExecution to plain Java ScriptExtension
* keep callScript backward compatible

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-19 20:29:58 +01:00
GiviMAD
06c0e90535
[auth] Fix wrong parameter on AuthorizePageServlet (#3154)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-11-13 11:08:58 +01:00
dependabot[bot]
440ce2eb6c
Bump ivy from 2.5.0 to 2.5.1 in /bundles/org.openhab.core.semantics (#3152)
Signed-off-by: dependabot[bot] <support@github.com>
2022-11-13 10:53:58 +01:00
J-N-K
64a31026cd
Add unmanaged scripts to rule engine (#3156)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-13 10:50:42 +01:00
J-N-K
d4ceca9fe0
Fix config normalization in ThingUpdatedEvent (#3157)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-13 10:44:30 +01:00
J-N-K
2bceba6954
Fix missing stateDescriptionProvider in Group items (#3144)
* Fix missing stateDescriptionProvider in Group items

The stateDescriptionProvider was not properly passed to the base item. Because of that units set in the state description were not properly used when setting the group state after calculating aggregation functions.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-06 20:50:05 +01:00
GiviMAD
9cdaa48fa5
[voice] Allow stopping single dialogs and start dialog on an existing processor (#3100)
* [voice] Allow stop single dialogs and start processing on an existing one

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-11-05 13:16:53 +01:00
Sami Salonen
18d063e272
Avoid parallel streams with common thread pool to avoid deadlocks (#3137)
* Avoid parallel streams with common thread pool to avoid deadlocks

To mitigate issue #3125

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
2022-11-01 20:05:54 +01:00
Cody Cutrer
221c80b12f
Change system.color-temperature-abs channel type to be a Number:Temperature (#3129)
refs https://github.com/openhab/openhab-addons/pull/13570#issuecomment-1288139778

now that Kelvin and mireds/mireks are easily convertible

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-01 09:50:01 +01:00
Cody Cutrer
3d279eb7f1
[mqtt] Properly process retained messages (#3124)
* [mqtt] Properly process retained messages

Only the _first_ message has the retained flag (always on MQTT3,
there is a flag to forward the retain flag on all messages with
MQTT5, but we don't set it), so we have to keep track of previously
retained messages as well.

This shows up as when a thing comes back online and re-subscribes
to a retained message that another thing subscribed to also,
it won't see any changes that happened to that topic since the
very first message was received.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-01 09:23:01 +01:00
J-N-K
d871066efc
Add DateTime handling to ItemStateConditionHandler (#3138)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-10-31 22:59:30 +01:00
J-N-K
d9bf8f7a15
[rest] add semantics query endpoint to item resource (#2985)
* [rest] add semantics query to item resource

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-10-30 15:50:36 +01:00
J-N-K
c24f0f3c6f
[automation] Fix ItemStateCondition for PercentType values (#3136)
* Fix ItemStateCondition for PercentType values

Dimmer items return their state as PercentType. The code did not properly handle PercentType because PercentType is a subclass of DecimalType. One value was converted by casting the value to DecimalType (which leads to 40 for 40%) while the other one used `.as` (which results in 0.4 for 40%). A comparison than of "state <= 50" with state = 20 is therefore executed as "20 <= 0.5"  which is not what the user would expect.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-10-29 13:17:48 +02:00
Cody Cutrer
a7d912d1e9
Fix invertible unit conversions when sent via a binding or uses in ItemUIRegistry (#3134)
* fix invertible unit conversions when sent via a binding
* do invertible unit conversion in ItemUIRegistry

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-27 20:26:27 +02:00
Cody Cutrer
e86f388a5b
Implement command completion in console for openhab command (#3111)
* Implement command completion in console for openhab command

And subcommands can implement it if they want. At the least the
CommandConsoleExtension's description will now be visible in
tab-completion.

I've also implemented detailed completion for openhab:items,
openhab:status, openhab:send, and openhab:update.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-22 10:52:31 +02:00
openhab-bot
73737e255a
New translations restauth.properties (Hebrew) (#3118) 2022-10-22 10:47:32 +02:00
Cody Cutrer
ccdf2c5573
Allow sending IncreaseDecreaseType directly to DimmerItem (#3116)
Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-17 08:05:02 +02:00
Cody Cutrer
3659542bae
Support mired units (#3108)
* Support mired units

Mired are fairly common to describe the color temperature of
lightbulbs (slightly less common than Kelvin), but are very
useful for various calculations when adjusting the color
temperature, as well as being necessary for various integerations
that require mired units.

This commit makes them a well-known unit (previously they were
still usable, using "MK^-1"), as well as making them easier to
work with on QuantityType. The hiccup is that Mireds aren't
technically a Temperature dimension, because they're a reciprocal.
So add a `inverse` method that delegates to javax.measure's
same method, and then use it as necessary when doing unit
conversions and comparisons. Unfortunately, because the
dimension changes, the return value of a conversion won't
necessarily be the same type, an additional method is added
for callers that are willing to handle the change in
dimension. This is implemented for all callers that can use
it in core.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-16 13:50:46 +02:00
Cody Cutrer
7f38d419c6
Allow sending QuantityType to NumberItem (#3115)
NumberItems always accept QuantityType

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-15 09:31:30 +02:00
openhab-bot
07be655b0e
New Crowdin updates (#3109)
* New translations automation.properties (Italian)
* New translations restauth.properties (German)
* New translations restauth.properties (Italian)
* New translations addons.properties (Italian)
* New translations restauth.properties (Danish)
* New translations restauth.properties (Finnish)
* New translations restauth.properties (Hungarian)
* New translations restauth.properties (Polish)
2022-10-15 09:27:02 +02:00
Christoph Weitkamp
389979c9da
Add more basic time-related classes for usage in script and rules (#3113)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-10-15 09:26:10 +02:00
J-N-K
ef3b13fce8
Fix AuthFilter crash if trusted network not configured (#3110)
* Fix AuthFilter crash if trusted network not configured

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-10-13 08:09:23 +02:00
GiviMAD
3ba0b8cf6d
[auth] grant implicit user role by network address (#3106)
* [auth] grant implicit user role by network

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-10-10 19:57:31 +02:00
openhab-bot
4096df1c64
New translations DefaultSystemChannels.properties (Norwegian) (#3098) 2022-10-05 18:44:21 +02:00
Cody Cutrer
5062ab5fb0
[rulesupport] sort JSR223 scripts by start level before filename (#3099)
The docs say that JSR223 scripts will be loaded in order of start level
(as defined by filename or containing folder). this works (mostly) fine
when you're stepping through start levels sequentially on startup, but if
you're already at SL100, and have scripts located in sl folders, and then
install an addon for those scripts, they were loading in alphabetic
order instead. This ensures they'll still respect start level order
relative to each other.

This should also fix the case of script start levels not matching
start levels OpenHAB actually steps through (which are all multiples
of 10) - i.e. if you define scripts in sl30, sl31, and sl32, when
OpenHAB jumps from 30 to 40, 31 should be executed before 32.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-10-05 18:43:48 +02:00
Christoph Weitkamp
93a8a214cf
Use Timer identifier when rescheduling the timer (#3095)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-09-29 14:05:09 +02:00
J-N-K
6d6250eb63
[transformation] Add swp to ignored extensions in FileTransformationProvider (#3094)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-09-27 18:32:19 +02:00
Dan Cunningham
b808ea6d13
Add live packet to SSE item state connections (#3086)
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
2022-09-26 19:09:33 +02:00
Cody Cutrer
065e33f5ab
Fix StartLevelService "hanging" if config is changed. (#3092)
Unregistered trackers aren't clear, so then we never register new trackers,
and thus never get notified of any changes.

Signed-off-by: Cody Cutrer <cody@cutrer.us>

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-09-25 09:44:57 +02:00
openhab-bot
92105d9a28
New translations DefaultSystemChannels.properties (Italian) (#3088) 2022-09-23 18:16:28 +02:00
J-N-K
0f82c38eea
Normalize thing configuration before initialization (#3024)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-09-20 22:15:24 +02:00
J-N-K
e3b90e32ce
Normalize Metadata configuration from managed provider (#2958)
* Normalize Metadata configuration from managed provider

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-09-20 21:20:27 +02:00
J-N-K
4a84b80c2c
Fix missing initial thing status event (#3072)
* Fix missing initial thing status event

A thing always has a status. This status is not properly propagated to the event bus when the thing is added. This e.g. leads to a situation where a thing's first status that is received by am event subscriber is "INITIALIZING" instead of "UNINITIALIZED". The status should always be sent so that the thing lifecycle can properly be tracked by event listeners.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-09-20 21:04:52 +02:00
J-N-K
dca8088fb4
Improve FeatureInstaller (#3049)
* Improve FeatureInstaller
* Remove unnecessary synchronized and clean up processing
* Re-add refeshing bundles after all configuratzion changes are processed
* Prevent unnecessary refreshes
* Make JNA part of the tp

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-09-18 10:43:12 +02:00
openhab-bot
8ebc8204c7
New Crowdin updates (#3082)
* New translations units.properties (Portuguese)

* New translations units.properties (Portuguese, Brazilian)

* New translations DefaultSystemChannels.properties (German)

* New translations DefaultSystemChannels.properties (Hungarian)

* New translations units.properties (Portuguese)

* New translations units.properties (Portuguese, Brazilian)

* New translations DefaultSystemChannels.properties (Polish)

* New translations DefaultSystemChannels.properties (Finnish)

* New translations DefaultSystemChannels.properties (Hebrew)

* New translations DefaultSystemChannels.properties (Danish)
2022-09-18 10:11:32 +02:00
Jacob Laursen
27c2887c8f
Fix access token serialization/deserialization (#3083)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-09-15 19:59:46 +02:00
Christoph Weitkamp
cda7b098bd
[thing] Added default channel types for electrical energy (#3079)
* Added default channel types for electrical energy

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-09-11 14:39:36 +02:00
Christoph Weitkamp
f33492d9be
[tls] Rethrow 'IOException' instead of swallowing it (#3078)
* Rethrow IOException instead of swollowing it

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-09-10 20:22:38 +02:00
Christoph Weitkamp
5e72011d91
Check for an existing thing handler before updating config (#3080)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-09-10 20:22:18 +02:00
Mark Herwege
c61ea770a5
Add visibility and color parameters to UI sitemap provider (#3075)
* add visibility and color parameters

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2022-09-06 19:21:02 +02:00
openhab-bot
584e36898a
New translations validation.properties (Luxembourgish) (#3074) 2022-09-03 19:55:46 +02:00
Anders Alfredsson
80794bfdcd
Use configured locale for SSE displayState (#3069)
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>

Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
2022-08-27 19:29:53 +02:00
Wouter Born
f69f6fa618
Add additional MqttBrokerConnectionConfig options (#3068)
Signed-off-by: Wouter Born <github@maindrain.net>
2022-08-25 21:37:31 +02:00
J-N-K
6c9b7676e4
Prevent crash on invalid entry in ManagedThingProvider (#3053)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-08-22 17:40:01 +02:00
Jacob Laursen
9bb88a1b7b
[oauth] Migrate usage of LocalDateTime to Instant (#3066)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-08-22 08:13:52 +02:00
jimtng
8f745b0d3d
Fix timezone handling in DateTimeTrigger (#3060)
* [DateTimeTrigger] Adjust to system timeline
* [DateTimeTrigger] Add tests for DateTimeTriggerHandler

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-08-12 08:47:06 +02:00
Flole998
6758aacba5
Add "time only"-Option for DateTimeTrigger in rules (#3051)
Signed-off-by: Flole <flole@flole.de>
2022-08-06 17:26:08 +02:00
openhab-bot
c4f0ab44df
New Crowdin updates (#3054)
* New translations units.properties (Portuguese)

* New translations units.properties (Portuguese, Brazilian)

* New translations firmware.properties (Slovenian)

* New translations units.properties (Slovenian)

* New translations validation.properties (Slovenian)

* New translations messages.properties (Slovenian)

* New translations tags.properties (Danish)

* New translations tags.properties (Slovenian)

* New translations DefaultSystemChannels.properties (Slovenian)

* New translations LanguageSupport.properties (Slovenian)

* New translations SystemProfiles.properties (Slovenian)

* New translations jsonStorage.properties (Slovenian)

* New translations network.properties (Slovenian)

* New translations i18n.properties (Slovenian)

* New translations voice.properties (Slovenian)

* New translations chart.properties (Slovenian)

* New translations persistence.properties (Slovenian)

* New translations addons.properties (Slovenian)

* New translations restauth.properties (Slovenian)

* New translations ephemeris.properties (Slovenian)

* New translations inbox.properties (Slovenian)

* New translations audio.properties (Slovenian)

* New translations hli.properties (Slovenian)

* New translations lsp.properties (Slovenian)

* New translations marketplace.properties (Slovenian)

* New translations sitemap.properties (Slovenian)

* New translations SystemThingStatusInfos.properties (Slovenian)

* New translations magic.properties (Slovenian)

* New translations automation.properties (Hebrew)

* New translations automation.properties (Slovenian)
2022-08-03 18:03:28 +02:00
J-N-K
193da095a8
fix javadoc (#3047)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-21 11:27:25 +02:00
J-N-K
1276932c29
Fix build warnings in addons (#3046)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-21 11:26:24 +02:00
J-N-K
ae3d7c749c
Add REST support for deleting links and removing orphaned links (#2970)
* add link remove for item to registry

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-19 09:24:47 +02:00
J-N-K
b6acaf7887
[rest] Allow bulk deletion of metadata (#2984)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-18 08:50:30 +02:00
J-N-K
836ae89489
Wait for thing-type available in PersistentInbox (#2981)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-17 21:15:48 +02:00
J-N-K
603988a963
Enrich distribution add-on with configDescriptionURI (#3045)
When changing to addon.xml later, this can be extended to all add-ons. It is necessary to improve the UI code for changing add-on log levels.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-17 21:04:25 +02:00
openhab-bot
13beca58ce
New translations hli.properties (Danish) (#3044) 2022-07-17 13:14:47 +02:00
openhab-bot
f84d72d449
New Crowdin updates (#3043)
* New translations messages.properties (Danish)

* New translations audio.properties (Danish)

* New translations inbox.properties (Danish)

* New translations addons.properties (Danish)

* New translations persistence.properties (Danish)

* New translations lsp.properties (Danish)

* New translations sitemap.properties (Danish)

* New translations SystemThingStatusInfos.properties (Danish)
2022-07-15 19:16:14 +02:00
J-N-K
16cf5a8ae1
Fix marketplace add-on uninstall (#3042)
Instead of using the full id (`marketplace:123456`) the id without service prefix was used to lookup installed add-ons. This is not an issue if the network is available because then the information is request from the forum. If no network connection is present it obviously fails.

This also reduces the log level in the case of connection issues. ERROR is to much and the stack trace is not necessary.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-14 22:49:37 +02:00
J-N-K
0b7fc242d4
Enhance transformation configuration (#3036)
* Enhance transformation configuration

This is needed to give the users the best experience when editing transformations in UI.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-14 21:00:53 +02:00
openhab-bot
2909945998
New Crowdin updates (#3038)
* New translations ephemeris.properties (Danish)

* New translations automation.properties (Hungarian)
2022-07-14 18:10:38 +02:00
J-N-K
2ad0b731bf
Log a warning when item for trigger/condition is missing or removed (#3007)
* Log a warning when item for trigger/condition is missing or removed

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-10 19:15:16 +02:00
Wouter Born
9984237ce8
Add default translations for automation module types (#3035)
These were generated using openhab/openhab-core#2966.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-07-10 09:27:40 +02:00
Patrick Fink
2b8bccb8fd
Add missing & refactor existing button toggle profiles (#3027)
* Add missing & refactor existing button toggle profiles
* ToggleProfileTest improvements

Signed-off-by: Patrick Fink <mail@pfink.de>
2022-07-09 19:53:30 +02:00
openhab-bot
205b5bad84
New translations firmware.properties (Danish) (#3031) 2022-07-08 18:42:09 +02:00
openhab-bot
d92a2c6945
New Crowdin updates (#3028)
* New translations units.properties (Portuguese)

* New translations DefaultSystemChannels.properties (Norwegian)

* New translations tags.properties (Norwegian)

* New translations SystemProfiles.properties (Norwegian)

* New translations audio.properties (Norwegian)

* New translations voice.properties (Norwegian)

* New translations ephemeris.properties (Norwegian)

* New translations inbox.properties (Norwegian)

* New translations restauth.properties (Norwegian)

* New translations addons.properties (Norwegian)

* New translations persistence.properties (Norwegian)

* New translations jsonStorage.properties (Norwegian)

* New translations chart.properties (Norwegian)

* New translations i18n.properties (Norwegian)

* New translations network.properties (Norwegian)

* New translations lsp.properties (Norwegian)

* New translations sitemap.properties (Norwegian)

* New translations hli.properties (Norwegian)

* New translations marketplace.properties (Norwegian)

* New translations magic.properties (Norwegian)

* New translations validation.properties (Norwegian)

* New translations SystemThingStatusInfos.properties (Norwegian)

* New translations units.properties (Portuguese, Brazilian)
2022-07-04 15:31:54 +02:00
J-N-K
37429e9b41
Remove OH2 leftover in Karaf Add-On service (#3026)
OH1 add-ons are not present in the OH3 distribution as they are not supported anyway, so we do not to filter them.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-07-03 14:07:41 +02:00
J-N-K
c5d9c90971
Fix symlinks not followed (#3023)
Reported on the forum https://community.openhab.org/t/custom-icons-disappears-in-openhab-3-3/136957/4

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-29 21:55:00 +02:00
J-N-K
f79f8c348e
Improve UID error message (#3022)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-29 21:54:31 +02:00
Kai Kreuzer
61fd47c853
Apply spotless and resolver (#3018)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-06-27 13:41:28 +02:00
openhab-bot
8944bdbbe4 [unleash-maven-plugin] Preparation for next development cycle. 2022-06-26 16:37:00 +00:00
Kai Kreuzer
2cf875fdd8
Fix ConcurrentModificationException in WatchQueueReader (#3016)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-06-26 17:14:51 +02:00
openhab-bot
cdeda77322
New Crowdin updates (#3013) 2022-06-24 18:19:02 +02:00
J-N-K
453857770a
Fix grep console not working (#3012)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-22 22:38:48 +02:00
J-N-K
0562ffe95e
Fix config validation for integer values (#3010)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-22 20:14:14 +02:00
J-N-K
c2ec97cfaf
Add ability to name timers / scheduled jobs (#2911)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-18 15:04:35 +02:00
J-N-K
e2958331e8
Refactor thing update handling of ThingManagerImpl (#2940)
Also code clean-up.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-18 14:53:58 +02:00
J-N-K
d74277f798
Use ThingStorageEntity instead of ThingImpl/BridgeImpl for storage (#2914)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-18 14:31:45 +02:00
J-N-K
cdf876c17e
Fix SSE topic filters (#2986)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-16 21:17:25 +02:00
J-N-K
84d5d38606
Fix dangling SSE subscriptions (#2983)
Unlike the sitemap SSE subscriptions generic event subscriptions did not implement a connection lost monitor.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-16 19:41:05 +02:00
J-N-K
293de9d6db
Allow DSL scripts for script transformation (#2990)
* Allow DSL scripts for script transformation

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-14 21:15:28 +02:00
openhab-bot
663240b040
New translations magic.properties (Polish) (#2997) 2022-06-11 15:02:05 +02:00
Kai Kreuzer
e69b9a7e7d
Fix DateTime trigger syntax to not break the equals function in the execution script (#2996)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-06-06 21:11:32 +02:00
J-N-K
1074e59183
[persistence] Extend PersistenceExtensions with "between" methods (#2931)
* Extend PersistenceExtensions with "between" methods

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-06 11:46:20 +02:00
J-N-K
0d0b64b8f6
Add option for formatting the y-axis labels in charts (#2937)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-04 19:02:10 +02:00
lolodomo
c61baf7600
[sitemap] Allow default color condition for labelcolor and valuecolor (#2995)
Closes openhab/openhab-webui#1298

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-06-04 18:22:27 +02:00
J-N-K
ffba442225
Bump maven-shade-plugin to 3.3.0 (#2992)
This is necessary for Java 17 source level.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-02 10:49:42 +02:00
GiviMAD
214fda0a7b
[javasound] Fix invalid cast on non windows os (#2988)
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-05-30 22:59:34 +02:00
J-N-K
d6c269d95a
[i18n] Allow generation of default translations for automation modules (#2966)
* Allow generation of default translations for automation modules

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-29 18:26:23 +02:00
J-N-K
344a9ae018
Fix log levels and duplicate implementation warning in tests (#2982)
* Fix log levels and duplicate implementation warning in tests

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-26 23:33:08 +02:00
J-N-K
40c7772af1
Fix NPE in ItemUIRegistry (#2955)
Reported on the forum. Also some code-cleanup.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-26 09:25:30 +02:00
GiviMAD
f5da311608
[voice] Fix try all interpreters (#2980)
* fix try all interpreters
* add test

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-05-26 07:47:28 +02:00
J-N-K
dd13da5d32
Add DateTimeTrigger to DSL rule model (#2963)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-25 21:50:48 +02:00
J-N-K
7027e1e139
[test] Allow intercepting logs and make assertions for log messages (#2939)
* [test] Allow intercepting logs and make assertions for log messages

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-25 21:13:40 +02:00
J-N-K
6c72972b16
Prevent non-profile links for trigger channels (#2771)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-25 18:09:59 +02:00
Wouter Born
86ee4dc2b5
Fix null type mismatch errors (#2976)
This fixes the null type errors in Eclipse which were introduced by #2906.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-05-23 16:30:08 +02:00
J-N-K
ad3a3c1caf
Assume installed addons are compatible (#2975)
It was reported that after an upgrade from aprevious version installed addons from marketplaces are not shown in the add-ons pages. This is a result of the new compatibility check which excludes incompatible add-ons by default. Already installed add-ons must be excluded from this check otherwise they can't be uninstalled.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-23 09:04:10 +02:00
lolodomo
e5ec888330
[voice] Add voice parameter to startDialog and listenAndAnswer (#2971)
* [voice] Add voice parameter to startDialog and listenAndAnswer

Fix #2819

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-05-21 10:50:00 +02:00
J-N-K
792b7511bf
Fix item name checking in ItemUtil (#2941)
* Fix item name checking in ItemUtil

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-21 09:29:42 +02:00
J-N-K
c96ce5b5a8
Fix namespace "channel" is added to item metadata (#2957)
* Fix namespace "channel" is added to item metadata

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-21 09:27:29 +02:00
lolodomo
103098c630
Fix interpret actions description (#2969)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-05-21 09:15:48 +02:00
J-N-K
bf54474b03
Fix MQTT status message when disconnected while connecting (#2951)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-20 20:45:01 +02:00
J-N-K
fe5b1ed6ac
Reduce levels of modbus connection logger (#2972)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-20 20:40:50 +02:00
J-N-K
b52d9f2e4f
Fix "openhab --help" and "help openhab" in Karaf console (#2953)
* Enable "openhab --help" and "help openhab" in Karaf console

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:39:45 +02:00
J-N-K
910047355c
Fix console extension output to wrong console (#2961)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:35:20 +02:00
J-N-K
d8ebbb5857
Allow sub-directories for icons (#2946)
* Allow sub-directories for icons

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:33:32 +02:00
J-N-K
d4a68c83fe
Add processing of Accept header to AudioServlet (#2960)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:31:36 +02:00
J-N-K
b11086ef45
Fix spaces in options not properly handled in i18n-maven-plugin (#2964)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:26:51 +02:00
J-N-K
d523275004
Fix resource leaks in AudioServlet (#2959)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:25:12 +02:00
Sami Salonen
09b9b33cc0
[expire] Allow ignoring commands (#2954)
* [expiry] [expire] bool configuration parameters parsing as util method
* [expiry] [expire] extend ExpiryManager to allow ignoring commands

Similar to ignoreStateUpdates parameter, this introduces new optional
parameter ignoreCommands.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
2022-05-11 18:30:53 +02:00
GiviMAD
5753627c02
[voice] Allow list of HLIs in dialog function (#2906)
* [Voice] Allow hli list

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-05-11 17:42:06 +02:00
J-N-K
de1f850e10
Fix EphemerisManager crashing on invalid configuration (#2949)
It has been reported in the past (and in the forum) that the EphemerisManagerImpl can't handle illegal configurations. Due to dependencies in other bundles this results in the whole automation component to be unavailable.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-05 21:25:30 +02:00
J-N-K
53a072d685
Fix transformations not removed if file deleted (#2945)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-05 21:13:29 +02:00
J-N-K
ad3a0848db
Add support for automatic creation of ManagedProviders for UI components (#2948)
* Add support for automatic creation of ManagedProviders for UI components

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-05 08:50:56 +02:00
openhab-bot
b5673e1050
New translations DefaultSystemChannels.properties (French) (#2944) 2022-05-01 14:32:58 +02:00
Wouter Born
8f7db68d1a
Fix a few SAT findings (#2936)
Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-27 23:09:37 +02:00
Wouter Born
13d2edb43e
Add spaces to Magic service labels (#2935)
This adds some spaces to the Magic service labels so they look nicer in UIs.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-27 23:06:29 +02:00
Jonathan Gilbert
1bd70ef909
Add ManagedProviders to UIRegistry (#2617)
* UIRegistry now extensible, like other Registries

Signed-off-by: Jonathan Gilbert <jpg@trillica.com>

* Fix comments and more

Signed-off-by: Wouter Born <github@maindrain.net>

Co-authored-by: Wouter Born <github@maindrain.net>
2022-04-27 01:20:01 +02:00
GiviMAD
89bc6592da
[Javasound] Fix microphone data line sharing on Windows OS (#2890)
Fix microphone dataline sharing on Windows OS

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-04-26 20:06:29 +02:00
openhab-bot
bb634b9189
New Crowdin updates (#2930)
* New translations DefaultSystemChannels.properties (Italian)

* New translations DefaultSystemChannels.properties (Dutch)

* New translations DefaultSystemChannels.properties (Polish)

* New translations DefaultSystemChannels.properties (Finnish)

* New translations DefaultSystemChannels.properties (Hebrew)

* New translations DefaultSystemChannels.properties (German)

* New translations DefaultSystemChannels.properties (Hungarian)

* New translations addons.properties (Hungarian)

* New translations marketplace.properties (Hungarian)
2022-04-26 17:25:51 +02:00
J-N-K
86960f243f
[automation] Allow using * as wildcard in thing status triggers (#2832)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-25 14:16:44 +02:00
jimtng
26596ecc25
[Semantics] Return parent Location and Equipment (#2928)
* [Semantics] Return parent Location and Equipment

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-04-25 13:04:57 +02:00
J-N-K
3135017895
Properly close script engines in script transformation (#2932)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:40:43 +02:00
J-N-K
b331066ea9
Allow changing watched directory of a WatchService (#2894)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:01:33 +02:00
J-N-K
a192a1dfc6
Add a generic script transformation (#2883)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:00:03 +02:00
J-N-K
a42e798c8d
Fix "recursive membership detected" for plain items (#2918)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 14:38:41 +02:00
J-N-K
ca94fd57b0
Add new module DateTimeTrigger for triggering on a DateTime state (#2923)
* Add DateTimeTrigger

This adds a new module that triggers at the time given by the state of an item.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 11:29:55 +02:00
Łukasz Dywicki
c09db50d46
[modbus] Add configurable after connection delay (#2927)
Fixes #2926

Signed-off-by: Łukasz Dywicki <luke@code-house.org>
2022-04-23 13:49:43 +02:00
Gaël L'hopital
af6a6c6ac4
Adding missing system channels descriptions. (#2912)
* Adding missing system channels descriptions.
Removing some redundant null checks of the same package.

Signed-off-by: clinique <gael@lhopital.org>
2022-04-22 23:02:24 +02:00
J-N-K
ee7095d96d
Improve SaferCallerImplTest (#2922)
Failed to to unnecessary stubbing exception in https://ci.openhab.org/job/PR-openHAB-Core/4556/

Also removes unnecessary code.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-22 10:52:28 +02:00
J-N-K
0e7e7a37b7
Improve SchedulerImplTest (#2919)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-20 10:06:39 +02:00
J-N-K
7e641e12f8
Fix Metadata can't be deserialized (#2921)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-18 22:06:29 +02:00
Wouter Born
05fdc81b27
Improve test stability and OS compatibility (#2878)
This fixes the build being broken when building on Windows.
It also contains many fixes for timing issues which seem to impact macOS and Windows more than Linux.

* Fix .gitattributes and add *.xml_gen to fix line ending issues on Windows
* Derive fork count from CPU details in org.openhab.core tests for more stable tests on machines with fewer cores
* Adjust SafeCallerImplTest timings
* Increase ExecUtilTest timeout
* Increase SchedulerImplTest timeouts
* Increase AudioConsoleTest serveStream timeout
* Increase AudioServletTest serveStream timeout
* Increase SchedulerImplTest test timeouts
* Increase ExpireManagerTest timeout used for checking published events
* Increase PeriodicSchedulerImplTest max allowed delta
* Increase SchedulerImplTest timeouts
* Fix BundleInfoReader file stream not closed causing temp dir deletion issues on Windows
* Fix GenerateDefaultTranslationsMojoTest Windows line endings issues
* Fix GenerateDefaultTranslationsMojoTest Windows temp dir deletion problem
* Fix GenericItemProviderTest tearDown sometimes fails because of queued events
* Fix ChannelLinkNotifierOSGiTest wait for channel link events
* Fix ChannelCommandDescriptionProviderOSGiTest fails if provider not immediately registered
* Fix ChannelStateDescriptionProviderOSGiTest fails if provider not immediately registered
* Fix GenericItemChannelLinkProviderTest not waiting for async updated state to become true
* Fix GenericThingProviderTest failing due to events of previous test
* Fix InboxOSGiTest sometimes fails because of queued events
* Fix ScriptEngineOSGiTest failing because items are not yet added to registry
* Fix ThingManagerOSGiTest failing due to async handleRemoval call

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-14 23:00:33 +02:00
Wouter Born
a4353ee5ca
Fix UnitUtils.getDimensionName returns Angle instead of Dimensionless (#2895)
An Angle is also Dimensionless and because it is the first compatible unit it is always returned instead of any other Dimensionless unit.
With these changes `getDimensionName` will prefer the dimension of equal units over those of compatible units.

Fixes #2880

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-14 22:57:18 +02:00
J-N-K
4fbd4c5960
Do not allow empty last segment in UID (#2901)
* Fix empty segment in UID

Segments are not allowed to be empty. Also adds tests for UID construction.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-14 22:55:19 +02:00
J-N-K
afd8768340
Extend ProfileContext to allow data type changing profiles (#2852)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-14 22:52:52 +02:00
J-N-K
f83049ae71
Log a message if a model is parsed and no thing handler factory can be found (#2754)
* Log a message if a model is parsed and no thing handler factory can be found

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-12 22:43:14 +02:00
J-N-K
53dcf48a17
Add a registry for transformation configurations and allow editing them (#2821)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-11 08:18:14 +02:00
lolodomo
90f6a95251
[voice] New feature "listen and answer" (#2793)
* New method listenAndAnswer in VoiceManager
* New console command "voice listenandanswer"
* New REST API
* New rule action
* Enhanced console command "voice startdialog"

Closes #2688

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-04-09 16:26:09 +02:00
J-N-K
6a75130355
Allow type migrations in JSONStorage (#2784)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-09 15:49:38 +02:00
openhab-bot
661fa00e46
New Crowdin updates (#2903)
* New translations marketplace.properties (Greek)

* New translations validation.properties (Greek)

* New translations SystemThingStatusInfos.properties (Greek)

* New translations DefaultSystemChannels.properties (Greek)

* New translations addons.properties (Greek)

* New translations voice.properties (Greek)
2022-04-09 08:57:11 +02:00
J-N-K
df978f434a
Fix memory leak in ScriptedRuleProvider (#2897)
* Fix memory leak in ScriptedRuleProvider

The Rule was never removed from the internal tracking map and therefore allocated resources were never freed.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-07 08:19:05 +02:00
Flole998
2de0fafc6e
Implement "forceAsItem" functionality for Charts in sitemaps (#2657)
This is part of implementing #2185

Signed-off-by: Flole <flole@flole.de>
2022-04-05 20:56:14 +02:00
J-N-K
2a3e2e5567
Reduce Mockito warnings (#2893)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-03 22:36:55 +02:00
GiviMAD
7442220830
[AbstractRuleBasedInterpreter] Fix spanish tokenization (#2889)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-04-03 12:14:09 +02:00
Wouter Born
b5de891ebd
Update semantic metadata of group members when groups are added/removed (#2884)
* Update semantic metadata of group members when groups are added/removed

This fixes the issue that the semantic metadata is incorrect when defining items in files and groups in the UI.

Fixes #2117
2022-04-03 11:55:19 +02:00
J-N-K
eec80f0e20
Fix ScriptEngine not removed if created by ScriptAction (#2886)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-01 22:56:27 +02:00
openhab-bot
f5aeba0ad7
New Crowdin updates (#2873)
* New translations DefaultSystemChannels.properties (Finnish)

* New translations DefaultSystemChannels.properties (Dutch)

* New translations marketplace.properties (Polish)

* New translations SystemThingStatusInfos.properties (Polish)

* New translations validation.properties (Polish)

* New translations voice.properties (Polish)

* New translations DefaultSystemChannels.properties (Italian)

* New translations DefaultSystemChannels.properties (Polish)

* New translations DefaultSystemChannels.properties (Hebrew)

* New translations DefaultSystemChannels.properties (German)

* New translations marketplace.properties (French)

* New translations DefaultSystemChannels.properties (French)

* New translations addons.properties (French)

* New translations marketplace.properties (French)
2022-03-27 23:22:39 +02:00
J-N-K
5629a38e1a
Fix null annotations on PersistenceItemConfiguration (#2876)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-27 14:47:41 +02:00
Gaël L'hopital
847aa349d8
Adding Indoor Temperature as system channel type (#2866)
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
2022-03-26 12:29:03 +01:00
openhab-bot
22c39fb54d
New Crowdin updates (#2869)
* New translations addons.properties (Dutch)
* New translations addons.properties (Finnish)
* New translations addons.properties (German)
* New translations addons.properties (Hebrew)
* New translations addons.properties (Italian)
* New translations addons.properties (Polish)
* New translations marketplace.properties (Dutch)
* New translations marketplace.properties (Finnish)
* New translations marketplace.properties (German)
* New translations marketplace.properties (Hebrew)
* New translations marketplace.properties (Italian)
* New translations SystemThingStatusInfos.properties (Bulgarian)
* New translations units.properties (Catalan)
2022-03-25 18:44:31 +01:00
Christoph Weitkamp
3c494677b7
Improve description of REST API for deleting data from persistence (#2870)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-03-25 18:43:01 +01:00
Wouter Born
b5e0ccfa6a
Add missing default translations for add-ons/marketplace configuration options (#2868)
This makes it possible to use Crowdin for translating the new configuration options introduced in #2811.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-23 17:45:23 +01:00
openhab-bot
7e13f7f4bd
New Crowdin updates (#2863)
* New translations addons.properties (Chinese Simplified)
* New translations addons.properties (Czech)
* New translations addons.properties (Dutch)
* New translations addons.properties (Finnish)
* New translations addons.properties (French)
* New translations addons.properties (German)
* New translations addons.properties (Greek)
* New translations addons.properties (Hebrew)
* New translations addons.properties (Hungarian)
* New translations addons.properties (Italian)
* New translations addons.properties (Polish)
* New translations addons.properties (Portuguese, Brazilian)
* New translations addons.properties (Russian)
* New translations addons.properties (Spanish)
* New translations addons.properties (Ukrainian)
* New translations i18n.properties (Danish)
* New translations magic.properties (Dutch)
* New translations marketplace.properties (Dutch)
* New translations marketplace.properties (Hebrew)
* New translations marketplace.properties (Hungarian)
* New translations marketplace.properties (Italian)
* New translations network.properties (Danish)
* New translations SystemThingStatusInfos.properties (Dutch)
* New translations units.properties (Danish)
* New translations validation.properties (Danish)
* New translations validation.properties (Dutch)
* New translations voice.properties (Dutch)
2022-03-22 21:27:45 +01:00
J-N-K
41abd57161
Increase allowed deviation in PeriodicSchedulerImplTest (#2867)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-22 20:46:50 +01:00
J-N-K
5746a1ff2c
Fix enabling/disabling CommunityMarketplace (#2864)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-21 22:02:34 +01:00
Wouter Born
7fbd9768a7
Cleanup BundleVersion (#2861)
Fixes a few SAT findings in the BundleVersion class.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-21 08:19:27 +01:00
J-N-K
4577562f08
[addonservices] Add version filtering (#2811)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-20 18:43:07 +01:00
J-N-K
79e070c7ac
Improve ScriptFileWatcherTest (#2857)
Most of the tests add a timeout of 1s to account for small delays in async processing in the AbstractWatchService. This adds some more timeouts for tests which were missing those.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-19 21:08:00 +01:00
J-N-K
3d17049d52
Improve PeridodicSchedulerImplTest (#2856)
* Improve PeridodicSchedulerImplTest

The old implementation truncated timestamps to 1/10 s. Under some circumstances this could result in a failed tests:

offset = 201 -> truncatedOffset = 2
200ms delay expected, adjustment calculation results in an actual delay of 198ms
time = 399 -> truncatedTime = 3

expected: truncatedOffset + expected => 2 + 2 = 4
actual: truncatedTime = 3

The new implementation allows for an error of +/- 10ms which is far more than needed.

* increase tolerance
* fix consecutive executions build up errors

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-19 21:07:08 +01:00
J-N-K
91614c2b12
Fix ServiceException when add-on handlers are not fully initialized (#2830)
* Fix ServiceException when add-on handlers are not fully initialized

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-18 07:47:27 +01:00
Wouter Born
9e33db6702
Remove MQTT system broker leftovers (#2842)
The MqttService was used to keep track of the system MQTT brokers.
Since there are none it can be removed as well as the observer, tests, configuration and translations.

Fixes #2841

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-17 19:35:35 +01:00
Wouter Born
7ae37f810b
Fix typo in ScriptImpl exception message (#2847)
Fixes #2846

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-17 11:50:20 +01:00
J-N-K
2686102f20
[thing] Show config validation messages in thing status (#2829)
* Show config validation messages in thing status

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-17 11:49:08 +01:00
J-N-K
dd5df810c8
Fix config validation for decimal parameters with limited options (#2844)
* Fix config validation for decimal parameters with limited options

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-17 10:02:23 +01:00
J-N-K
0dcd57e7d8
Fix KAR installed check (#2845)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-16 09:24:43 +01:00
J-N-K
437b31dbe9
Fix things in REMOVING state initialize instead of getting removed (#2828)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-14 15:49:26 +01:00
Wouter Born
b62b2e1c90
Update bnd.bnd for CertificateGenerator package change (#2840)
There is also a bnd.bnd file referencing the CertificateGenerator so it also needs to be updated for the change in #2838

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-13 16:44:44 +01:00
J-N-K
ea68ae0163
[rest] Allow binary MediaType for RawType item states (#2825)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-13 16:27:26 +01:00
J-N-K
794e925253
[discovery] keep format of thing properties (#2740)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-13 15:54:05 +01:00
J-N-K
0c73547046
Fix exception during startup when kar is not yet loaded (#2753)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-13 14:33:23 +01:00
Wouter Born
ba4e73ccf4
Run org.openhab.core tests in forks to reduce build time (#2837)
This saves about 1 minute when building this bundle.
Most bundles depend on org.openhab.core so cores would stay idle until this bundle is build in a parallel builds.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-13 12:11:11 +01:00
J-N-K
c6fe634b0a
[test] Fix PersistenceExtensionTest (#2835)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-13 11:52:19 +01:00
J-N-K
73b76fa01d
[profile] Add accepted types to ProfileContext (#2814)
* Add accepted types to ProfileContext

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-13 11:21:02 +01:00
Wouter Born
9eef6a3b6d
Fix CertificateGenerator package (#2838)
The class is in a package that does not match the bundle name.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-13 10:42:06 +01:00
Wouter Born
92a6c1c283
Fix trigger channels not found (#2833)
Trigger channel types failed to load because the item type became required with the changes in #2775.
Also adds a unit test for the ThingDescriptionReader to prevent future regressions.

Fixes #2831

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-12 21:49:25 +01:00
Wouter Born
e6ddeccd78
Add more null annotations to XML processing classes (#2775)
This adds null annotations to many XML processing classes and a few others.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-10 19:57:31 +01:00
J-N-K
c7aec15290
Fix missing STARTLEVEL_COMPLETE ReadyMarker (#2755)
Since no requirements are defined for `STARTLEVEL_COMPLETE´ no `ReadyMarker` was added to the map of `ReadyMarker`s.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-09 22:05:30 +01:00
openhab-bot
b2d3cdba1e
New Crowdin updates (#2816)
* New translations validation.properties (Hungarian)

* New translations voice.properties (Hungarian)

* New translations SystemThingStatusInfos.properties (Hungarian)
2022-03-09 09:07:36 +01:00
lolodomo
23d43604ca
[voice] New optional arguments for console command voice startdialog (#2823)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-03-09 09:07:06 +01:00
lolodomo
dab0a59b87
[standardinterpreter] Update french syntax (#2827)
Use "imperatif" grammatical mode for commands

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-03-09 09:03:39 +01:00