Commit Graph
963 Commits
Author SHA1 Message Date
jimtngandGitHub 80207179f2 [timer] Add Timer::isActive() (#1450)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2020-04-28 21:48:02 +02:00
Wouter BornandGitHub 61e17ce39e Upgrade SAT and Spotless, apply Spotless and enable check (#1446)
* Update SAT and Spotless dependencies
* Apply Spotless and enable check

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-26 11:15:24 +02:00
Wouter BornandGitHub ed4b5ff94b Reconfigure and apply Spotless (#1442)
Adds a configuration for feature.xml files which will be necessary for https://github.com/openhab/static-code-analysis/pull/375

Also applies the results of running Spotless

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-23 17:17:12 +02:00
Christoph WeitkampandGitHub d371a34321 Removed dependency on 'org.apache.commons.lang' (#1433)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-22 14:32:31 +02:00
Christoph WeitkampandGitHub e17046ea3f Removed dependency on 'org.apache.commons.httpclient' (#1436)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-20 22:31:46 +02:00
Christoph WeitkampandGitHub a247a021e1 Removed deprecated constructor for 'DiscoveryResultImpl' (#1428)
* Removed deprecated contructor DiscoveryResultImpl
* Added SuppressWarnings('deprecation')
* Removed set default values
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-20 08:47:20 +02:00
Christoph WeitkampandGitHub 6b4e54ada3 Removed deprecated 'newItemBuilder' method (#1429)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-19 14:51:21 +02:00
Christoph WeitkampandGitHub 7940141421 Simplify lifecycle by using constructor injection (#1431)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-19 14:33:08 +02:00
Wouter BornandGitHub 92027ca922 Use .equals() on constants and literals to prevent NPEs (#1420)
* Use .equals() on constants and literals to prevent NPEs

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-16 07:40:49 +02:00
Christoph WeitkampandGitHub 9f41a755e3 Fixed failing ChannelTypesI18nTest because of invalid XML (#1427)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-15 12:50:22 +02:00
Wouter BornandGitHub 66da3a7912 Update nrjavaserial to 3.20.0 (#1426)
Updates nrjavaserial to the official 3.20.0 release (compatible with Java 8/11).
With the upgraded version the library will no longer crash the Java 11 VM on Windows.
The native libraries now use the built in RXTX lockfiles instead of the previously used (OS dependent) liblockdev whereas the OH build didn't use any lockfiles at all.
It also has a fix for errors being printed when scanning for serial ports whenever a serial port is locked (NeuronRobotics/nrjavaserial#166).
With the new version RXTX threads also have proper names and there is a fix for an IllegalMonitorStateException that might occur when closing ports.

Fixes #1384

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-15 11:10:55 +02:00
Wouter BornandGitHub b734c2cc04 Remove deprecated TrustManagerProvider (#1425)
* Remove deprecated `TrustManagerProvider`

It was deprecated since the introduction of the `ExtensibleTrustManager` (https://github.com/eclipse/smarthome/pull/6281).

Related to #1408

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-15 10:34:45 +02:00
Wouter BornandGitHub 778c72eabb Remove deprecated DiscoveryServiceCallback, ExtendedDiscoveryService (#1424)
- Remove deprecated DiscoveryServiceCallback, ExtendedDiscoveryService

Related to #1408

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-15 08:23:57 +02:00
Wouter BornandGitHub 6c85b1bccd Add and fix more null annotations (#1421)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-15 01:44:37 +02:00
Christoph WeitkampandGitHub b770bb1b4a Removed 'StateDescriptionProvider' interface (#1413)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-14 21:15:29 +02:00
Wouter BornandGitHub fb7a7ac421 Add null annotations to providers and ThingManager (#1412)
* Add null annotations to providers and ThingManager

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-11 08:29:12 +02:00
Wouter BornandGitHub 017532e2d4 Remove deprecated InboxFilterCriteria (#1417)
- Remove deprecated InboxFilterCriteria

Related to #1408

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-09 21:31:23 +02:00
Wouter BornandGitHub 3e1357f84b Remove deprecated discovery participant interfaces (#1418)
Removes:
* org.openhab.core.io.transport.mdns.discovery.MDNSDiscoveryParticipant
* org.openhab.core.config.discovery.UpnpDiscoveryParticipant

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-09 21:27:34 +02:00
J-N-KandGitHub 70b9355d08 [uom] Fix concurrency issue in state update (#1406)
* Fix concurrency issue in state update

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
2020-04-08 19:54:13 +02:00
Christoph WeitkampandGitHub aae207bfe9 Removed 'advanced' attribute from 'ChannelGroupType' (#1410)
* Removed 'advanced' attribute from ChannelGroupType

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-07 09:57:28 +02:00
Christoph WeitkampandGitHub 8955ef9a16 Added nullness annotations to 'ScriptExtensionProvider' (#1411)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-07 08:35:18 +02:00
Wouter BornandGitHub 945afcdb1a Add and fix more null annotations (#1407)
* Add and fix more null annotations
* Add more @NonNullByDefault and @Nullable annotations
* Remove unnecessary @NonNull annotations
* Fix a few other trivial SAT issues
* Add constructor injection for MDNSDiscoveryService

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-06 10:45:39 +02:00
Christoph WeitkampandGitHub 1981e548aa [thing] Dynamic state/command provider should not return original description (#1399)
* Clarify return values for implementation
* Dynamic state/command provider should not return original descritpion
* Added ERROR log message
* Added integration test for CommandDescriptionProvider

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-06 08:49:26 +02:00
Christoph WeitkampandGitHub 3cb26ee28a [storage] Improved JavaDoc (#1409)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-06 08:48:20 +02:00
Christoph WeitkampandGitHub 259af7aaef Fix java.lang.UnsupportedOperationException in StateDescriptionFragmentBuilder (#1405)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-05 17:53:48 +02:00
Christoph WeitkampandGitHub 86dc92b6c8 Replace unit placeholder in patterns if updated by DecimalType states (#1404)
* Replace unit placeholder in patterns if updated by DecimalType states

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-05 17:52:30 +02:00
Wouter BornandGitHub 1f825fc529 Fix null analysis errors in Eclipse (#1403)
Without helping the compiler a bit, it will show null analysis errors in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-04 18:09:44 +02:00
Jonathan GilbertandGitHub c9f1bf6d31 [automation] Add script extension to allow scripts to track their disposal (#1264)
* Added script extension to allow scripts to track their disposal

Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
2020-03-27 22:25:10 +01:00
Jonathan GilbertandGitHub caf912bc99 [automation] Added API for ScriptEngineFactory implementations to pull presets (#1256)
* Added API for ScriptEngineFactory implementations to pull presets

Existing API only allows engine factory implementors to request presets are pushed into existing scopes, rather than returning them directory, so that they can be bound into module or library systems. This change allows implementors to capture the presets requested (and potentially ignore any pushed), and therefore expose them via idiomatic import mechanisms for the language being implemented

Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
2020-03-27 22:22:04 +01:00
Yannick SchausandGitHub 15b3b07614 Add the Karaf jaas feature as runtime prerequisite (#1398)
* Add the Karaf jaas feature as runtime prerequisite
* Remove LoginModule reference from ManagedUserRealm

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-03-25 12:40:59 +01:00
Yannick SchausandGitHub d8fce0b8b3 Add auth feature to runtime base (#1396)
Signed-off-by: Yannick Schaus <github@schaus.net>
2020-03-24 08:49:52 +01:00
Yannick SchausandGitHub fe4e276b68 Implementation of a JWT-based OAuth2 flow for the admin API (#1389)
* Initial implementation of a JWT-based OAuth2 flow for the admin API

Implements #1388.

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-03-23 22:36:11 +01:00
Christoph WeitkampandGitHub a06eb598d7 [uom] Fixed intensity conversion from W/m² to µW/cm² (#1394)
* Fixed intensity conversion from W/m² to µW/cm²

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-03-22 12:03:01 +01:00
Wouter BornandGitHub 2681b5d90b Remove MagicHttpResource (#1390)
For ESH it made sense to use this but nowadays these UIs are no longer part of openhab-core and the demo app used for development is in openhab-distro.
Furthermore it provides links to UIs that are no longer part of OH3, uses ESH logos and the new Default UI is also using / so it throws exceptions.

See: https://github.com/openhab/openhab-distro/pull/1084#issuecomment-596226652

Signed-off-by: Wouter Born <github@maindrain.net>
2020-03-14 23:19:42 +01:00
Kai KreuzerandGitHub 427e969ef9 [persistence] Allow persistence services to define default strategies (#1387)
* Allow persistence services to define default strategies
* Added null annotations

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-03-09 21:57:44 +01:00
Kai KreuzerandGitHub 857679f66b removed ThingLinkManager and with it the auto-linking feature and "Simple Mode" (#1385)
* removed ThingLinkManager and with it the auto-linking feature and "Simple Mode"

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* removed feature from REST API as well

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* removed tests

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-03-03 00:23:04 +01:00
Kai KreuzerandGitHub d89fd33472 removed legacy add-on support (#1386)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-03-03 00:19:11 +01:00
Kai KreuzerandGitHub 0182ce567d fixed service pids (#1382)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-03-01 16:40:01 +01:00
Scott RushworthandGitHub 5710532b05 [automation] Improve file extension exclusion (#1370)
This change improves the way file extensions are excluded from ScriptFileWatcher. Discussed [here](https://github.com/openhab/openhab-core/pull/1367#discussion_r379914147).

Signed-off-by: Scott Rushworth <openhab@5iver.com>
2020-02-27 12:50:50 +01:00
Kai KreuzerandGitHub 2bb50f8255 fixed default service pid and removed esh traces in service configuration (#1380)
* fixed default service pid and removed esh traces in service configuration
* fixed default service.cfg location

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-02-27 12:49:56 +01:00
Christoph WeitkampandGitHub 253f9ab6ea Add implicit import for units to rule models (#1376)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-02-26 19:43:50 +01:00
Yannick SchausandGitHub 3f48088f94 Fix NPE with uninitialized state trackers (#1378)
This fixes a NPE which occurs when a ItemStateChangedEvent
is broadcasted by the ItemStatesSseBroadcaster while some
SseStateEventOutputs haven't initialized their list of
tracked items.

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-02-26 19:18:43 +01:00
Christoph WeitkampandGitHub 4258d87d4a Small improvements for SmartHomeUnits (#1377)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-02-25 19:48:48 +01:00
Yannick SchausandGitHub 4b772cb6b3 Simple dynamic item state updates SSE endpoint & API. (#1364)
* Simple dynamic item state updates SSE endpoint & API.

Implements #1363.

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-02-24 18:36:39 +01:00
Roland RosenfeldandGitHub 730a8e1e61 [ephemeris] isBankHoliday(offset, filename) now really uses the filename (#1375)
Closes: #1374

Signed-off-by: Roland Rosenfeld <roland@debian.org>
2020-02-24 13:06:08 +01:00
Scott RushworthandGitHub 1cb17e1a7d [automation] Corrected issue where scripts were not starting when OH restarted (#1367)
* Corrected issue where scripts were not starting when OH restarted

Fixes #841

Signed-off-by: Scott Rushworth <openhab@5iver.com>
2020-02-17 13:43:27 +01:00
paliandGitHub b15145a078 Added Bq/m³ and ppb units (#1368)
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
2020-02-17 08:50:19 +01:00
Yannick SchausandGitHub 60e040c529 Metadata-based state & command description providers (#1362)
* Metadata-based state & command description providers

Implements #1185.

These providers will look into item metadata, which
can be managed by UIs with the API, to set or override
the item's state description (pattern, options, read
only...) or command description.

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-02-15 18:08:42 +01:00
Kai KreuzerandGitHub 76153dcab0 Revert "Enabled spotless:check by default (#1303)" (#1366)
This reverts commit bb9308d8f5.
2020-02-13 21:41:35 +01:00
Yannick SchausandGitHub eea31e536d UI component registries initial implementation (#1356)
* UI component registries initial implementation

This is an initial implementation of #1355.
It was simple enough to make to be proposed as
a PR already without waiting for remarks on the RFC.

The SitemapProvider for the `system:sitemap`
namespace as described in #1355 is not part of
this PR.

Signed-off-by: Yannick Schaus <github@schaus.net>
2020-02-13 21:36:54 +01:00