Commit Graph
1654 Commits
Author SHA1 Message Date
lolodomoandGitHub 79ec0396b3 [voice] Check that the provided locale is supported by KS/STT/HLI services (#2789)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-02-20 15:47:28 +01:00
GiviMADandGitHub 417098e1ad [DialogProcessor] fix race condition (#2761)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-02-20 14:35:41 +01:00
Wouter BornandGitHub c300410fd9 Support multi bundle bindings in i18n-maven-plugin (#2748)
* Support multi bundle bindings in i18n-maven-plugin

The plugin did not generate translations for bundles of bindings that do not have a binding.xml file.
With this change it should also be possible to generate the default translations of the modbus and mqtt bindings.

Related to openhab/openhab-addons#12220

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-20 11:57:18 +01:00
Christoph WeitkampandGitHub 7997e2636a Prevent errors in log when client closes the HTTP connection (#2781)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-20 11:18:32 +01:00
GiviMADandGitHub 0e0adcbb8f [DialogProcessor] update say method nullability (#2780)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-02-19 14:01:41 +01:00
Wouter BornandGitHub f411561b70 Flush old JsonStorage to file before recreating a new one (#2778)
Fixes #2774

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-17 21:41:41 +01:00
J-N-KandGitHub dd537c21cb Fix dispose is called on handlers for disabled things (#2762)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-17 21:36:03 +01:00
Wouter BornandGitHub 92917946d4 Add even more null annotations (#2752)
This PR adds even more missing null annotations which did not fit in #2742 as it grew too big.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-17 21:30:51 +01:00
Christoph WeitkampandGitHub 9bf181bf0a Fixed config validation message for parameter options (#2777)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-17 20:33:37 +01:00
J-N-KandGitHub 69069270a9 Fix context being re-used for next execution (#2760)
Trigger information is inserted in the execution context. This information is changed to the new information each time the context is updated with the same keys. If the context of the next execution does not contain values for each key, the old key is re-used, leading e.g. to wrong event information in the context.

The solution is to re-set the individual context after each execution.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-17 20:32:58 +01:00
Christoph WeitkampandGitHub 44da7a4e0e Avoid URISyntaxException in tests (#2770)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-15 17:33:59 +01:00
Wouter BornandGitHub 69c63703c3 Stop catching Throwables in DefaultMetricsRegistration (#2767)
Looks like this workaround introduced in #2480 is unnecessary nowadays because #2484 addressed the root cause.
This fixes the AvoidCatchingThrowable SAT findings.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-15 16:38:10 +01:00
Wouter BornandGitHub fb6ef20cd9 Move Java only tests from org.openhab.core.tests to org.openhab.core (#2768)
These tests only require Java and not OSGi.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-15 16:34:14 +01:00
J-N-KandGitHub 8f5d703ceb Improve log message for invalid configuration updates by handler (#2766)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-15 12:31:18 +01:00
Wouter BornandGitHub 3d7be0ffa7 Avoid throwing raw exception types (#2747)
* Avoid throwing raw exception types

This fixes all 36 AvoidThrowingRawExceptionTypes SAT findings.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-14 16:14:25 +01:00
Wouter BornandGitHub ad936cd83f Add more null annotations (#2742)
* Add more null annotations
* Fix mock name

Adds null annotations to most of the tests as well as a few other classes.
Also fixes a few other SAT findings.
Fixes ~300 SAT findings in total.


Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-14 11:33:50 +01:00
Wouter BornandGitHub b5bf0b0157 Always run OSGi HTTP service on random port in itests (#2759)
It is probably always a good idea to run the OSGi HTTP service on a random available port in itests.
This fixes some stacktraces when running itests and it will also prevent future issues when tests using the HTTP service are written.

These stacktraces often show when running itests in parallel:

```
org.ops4j.pax.web.pax-web-runtime [org.ops4j.pax.web.service.internal.HttpServiceStarted] ERROR : Could not start the servlet context for context path []
java.io.IOException: Failed to bind to /0.0.0.0:8080
	at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:349)
	at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:310)
	at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
	at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
	at org.eclipse.jetty.server.Server.doStart(Server.java:401)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
	at org.ops4j.pax.web.service.jetty.internal.JettyServerImpl$1.start(JettyServerImpl.java:350)
	at org.ops4j.pax.web.service.internal.HttpServiceStarted.registerServlet(HttpServiceStarted.java:255)
	at org.ops4j.pax.web.service.internal.HttpServiceStarted.registerServlet(HttpServiceStarted.java:226)
	at org.ops4j.pax.web.service.internal.HttpServiceStarted.registerServlet(HttpServiceStarted.java:210)
	at org.ops4j.pax.web.service.internal.HttpServiceProxy.registerServlet(HttpServiceProxy.java:69)
	at org.openhab.core.io.http.servlet.BaseOpenHABServlet.activate(BaseOpenHABServlet.java:56)
	at org.openhab.core.io.http.servlet.OpenHABServlet.activate(OpenHABServlet.java:40)
...
```

Similar to: openhab/openhab-addons#11523

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-14 08:09:55 +01:00
lolodomoandGitHub 999dab5fb2 [voice] New REST API to start/stop dialog processing (#2731)
Related to #2688

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-02-13 20:44:17 +01:00
James MelvilleandGitHub 805f223fa9 Add triggeringThing name to DSL rules (#2756)
* Add triggeringThing name to DSL rules
* Include previous and new statuses

Signed-off-by: James Melville <jamesmelville@gmail.com>
2022-02-13 10:34:08 +01:00
James MelvilleandGitHub b594d0a8b7 Add new Imperial Pressure unit psi (#2758)
Signed-off-by: James Melville <jamesmelville@gmail.com>
2022-02-13 10:02:37 +01:00
James MelvilleandGitHub 92679aa6fd Add bearingTo method for PointType (#2757)
Signed-off-by: James Melville <jamesmelville@gmail.com>
2022-02-13 10:01:21 +01:00
J-N-KandGitHub 9a9217eab8 Expose three classes used as bindings in JSR-223 rules as interfaces (#2723)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-13 09:57:22 +01:00
J-N-KandGitHub c0b033b95c Fix WatchQueueReader cancelling jobs too early (#2745)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-12 10:10:23 +01:00
J-N-KandGitHub 719f66835e [rest] show start level in /systeminfo (#2749)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-12 10:08:36 +01:00
openhab-botandGitHub cc11e0ccd6 New Crowdin updates (#2743)
* New translations validation.properties (German)

* New translations validation.properties (Finnish)

* New translations validation.properties (Italian)

* New translations validation.properties (Hebrew)

* New translations SystemProfiles.properties (French)

* New translations validation.properties (French)
2022-02-12 09:56:54 +01:00
Wouter BornandGitHub b36f292dcd Prevent JsonStorage backup corruption when disk is full (#2746)
Fixes #2267

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-10 19:27:56 +01:00
Christoph WeitkampandGitHub 9cda2c8de8 [config] Add config validator for parameter options (#2691)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-09 09:00:36 +01:00
GiviMADandGitHub 9b438d7e12 [javasound/dialogprocessor] Not share mic ref on javasound + close audio streams and use RecognitionStartEvent on dialogprocessor (#2732)
* [javasound] not share targetdataline

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-02-08 19:27:43 +01:00
GiviMADandGitHub 75252cf4aa [voice] remove unused stt events (#2741)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-02-08 16:36:12 +01:00
J-N-KandGitHub d6f63e7500 [thing] Fix removal of thing properties (single and bulk) (#2735)
* fix removal of thing properties (single and bulk)

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-07 19:32:22 +01:00
J-N-KandGitHub ea6f21f74d allow multiple listeners for same directory in WatchService (#2724)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-07 10:14:41 +01:00
Wouter BornandGitHub d1a4d226b6 Upgrade XStream to 1.4.19 (#2738)
This addresses CVE-2021-43859, see:

https://x-stream.github.io/changes.html

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-06 21:33:10 +01:00
J-N-KandGitHub e1962843d5 fix recursive membership throws StackOverflowException on REST API call (#2736)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-06 21:19:36 +01:00
GiviMADandGitHub d48bdf4260 [StandardInterpreter] Add Spanish language (#2728)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-02-06 21:17:54 +01:00
Christoph WeitkampandGitHub 87ecfade74 [config] Add nullness annotations to config validation (#2690)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-06 20:30:20 +01:00
openhab-botandGitHub 5a4b6fedce New Crowdin updates (#2725)
* New translations validation.properties (German)

* New translations validation.properties (Italian)

* New translations voice.properties (French)

* New translations hli.properties (French)

* New translations validation.properties (French)

* New translations validation.properties (Italian)

* New translations SystemThingStatusInfos.properties (French)

* New translations validation.properties (Hebrew)

* New translations validation.properties (Finnish)
2022-02-06 12:47:43 +01:00
J-N-KandGitHub c4e1b14d00 [addonservices] allow uninstalling of removed addons and fix other issues (#2607)
* [addonservices] allow uninstalling of removed addons

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-06 09:48:55 +01:00
lolodomoandGitHub 3e94dd6e30 [voice] Minor changes requested during review of PR #2693 (#2729)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-02-03 20:25:32 +01:00
J-N-KandGitHub 8c16cb6e93 [config] Enable missing validations (#2720)
* enable validation for multipleLimit
* remove unused validation messages

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-01 16:41:56 +01:00
openhab-botandGitHub dec2d7c296 New Crowdin updates (#2717)
* New translations validation.properties (Italian)

* New translations validation.properties (Finnish)

* New translations validation.properties (German)

* New translations validation.properties (Hebrew)

* New translations voice.properties (Italian)

* New translations validation.properties (Luxembourgish)

* New translations voice.properties (German)

* New translations voice.properties (Finnish)

* New translations voice.properties (Hebrew)
2022-02-01 10:14:46 +01:00
J-N-KandGitHub 61f5e7f57d [config] Enable config validation for updates by handler (#2712)
* Enable config validation for updates by handler

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-02-01 10:10:37 +01:00
Christoph WeitkampandGitHub 9520bfdfe7 Do not throw CertificateParsingException all the time, fixed pinned certificate creation (#2695)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-02-01 09:21:26 +01:00
lolodomoandGitHub 8f0dd94343 [voice] Update dialog processing (#2693)
Related to #2688

Updated methods startDialog
New method stopDialog
Null annotations added to the class DialogProcessor

Allow translation of sentences "said" by the dialog processor in case of error

2 console commands added to start and stop a dialog

Enhanced integration tests

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-01-30 18:27:51 +01:00
Christoph WeitkampandGitHub 6edc413640 Fixed NPE and exceptiion while parsing config value (#2718)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-01-30 13:20:11 +01:00
J-N-KandGitHub 6193aa966e [config] improve type validation message (#2713)
* [config] improve type validation message

The message did not contain the detected wrong type which makes it harder to define what the actual error is.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-01-30 09:42:31 +01:00
Jonathan GilbertandGitHub 290ad08107 [automation] ScriptFileWatcher Initial import now only processes dir (#2708)
Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
2022-01-29 23:53:56 +01:00
lolodomoandGitHub a4c39d5ba0 [voice] Fix wrong check for defaultSTT (#2714)
Fix #2696

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-01-29 23:43:49 +01:00
Christoph WeitkampandGitHub 16bc9321f1 Allow String values for other Types (#2699)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-01-29 14:01:16 +01:00
J-N-KandGitHub fd16210ee6 [config] Added log message with validation errors for things (#2711)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-01-29 10:57:31 +01:00
openhab-botandGitHub 265c0be444 New Crowdin updates (#2701)
* New translations SystemThingStatusInfos.properties (Italian)

* New translations SystemThingStatusInfos.properties (German)

* New translations SystemThingStatusInfos.properties (Hebrew)

* New translations SystemThingStatusInfos.properties (Finnish)

* New translations marketplace.properties (Czech)

* New translations voice.properties (French)

* New translations sitemap.properties (French)
2022-01-27 14:20:27 +01:00