demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2026-07-29 12:34:22 +02:00
Code Issues 1 Packages Projects Releases Wiki Activity
2,379 Commits 1 Branch 1 Tag
6fc7700ea61984fffefbaec0e54afc58e2b153f2
Commit Graph
2379 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Wouter BornandGitHub 6fc7700ea6 Use protected modifier with constructor of abstract classes (#4010) 
Abstract classes should not have public constructors.
Constructors of abstract classes can only be called in constructors of their subclasses.
So there is no point in making them public.
The protected modifier should be enough.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 16:17:14 +01:00
Wouter BornandGitHub 81a91ee9ae Simplify adding elements to Collections (#4006) 
* Simplify adding elements to Collections

This optimizes and simplifies the code that adds elements to Collections.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 14:51:33 +01:00
Wouter BornandGitHub afd1d4726c Iterate using Map entries (#4003) 
* Iterate using Map entries

Iteration using Map entries is preferred because it is more efficient and helps preventing NPEs.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 14:50:50 +01:00
Wouter BornandGitHub 106c8b2270 Remove unnecessary semicolons (#4009) 
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 13:47:23 +01:00
Wouter BornandGitHub d162b82206 Fix String.format argument mismatches (#4008) 
These argument mismatches cause wrong messages being logged and thrown in exceptions.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 13:13:53 +01:00
Wouter BornandGitHub 26a958cd4d Use static inner classes (#4002) 
A static inner class does not keep an implicit reference to its enclosing instance.
This prevents a common cause of memory leaks and uses less memory per instance of the class.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 12:35:26 +01:00
Wouter BornandGitHub 10c0cf8211 Simplify assertions (#3996) 
* Simplify assertions

Using the appropriate assertion methods results in less and easier to read code as well as better error messages when assertions fail.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 12:24:50 +01:00
Wouter BornandGitHub 564d6e673e Fix SerialPort.getFlowControlMode() infinite recursion (#4007) 
An infinite recursion would occur when calling this method.
I did not find any add-ons using this method but that could be due to this bug.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 12:15:41 +01:00
Wouter BornandGitHub 58a106d36d Use diamond operator (#4001) 
Often the type can be inferred so the diamond operator can be used to simplify the code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-03 08:22:43 +01:00
Wouter BornandGitHub dc5f50db63 Fix assertEquals order (#3995) 
The first parameter should be the expected value and the second parameter the actual value.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-02 22:27:53 +01:00
Wouter BornandGitHub 896b05e177 Replace or remove assert statements (#3994) 
Java assertions are disabled by default so in this PR they are replaced/removed where applicable.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-02 22:21:42 +01:00
Mark HerwegeandGitHub dbc3b19a4f fix empty rule condition (#3993) 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
 2024-01-02 19:51:11 +01:00
Wouter BornandGitHub 041e3b5127 Remove redundant modifiers (#4000) 
Removes redundant modifiers from the code.
These modifiers redeclare the default modifiers that apply to interfaces, enums etc.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-02 19:29:29 +01:00
Wouter BornandGitHub 4e76d76088 Remove redundant array creation for calling varargs methods (#3997) 
These array creations are unnecessary because arrays are created automatically for methods using varargs.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-02 19:01:34 +01:00
Wouter BornandGitHub 89b67adbd7 Use isEmpty instead of 0 comparisons (#3999) 
`isEmpty()` expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Signed-off-by: Wouter Born <github@maindrain.net>
 2024-01-02 18:47:36 +01:00
J-N-KandGitHub a5316f920e Refactor ThingHandlerService to an OSGi component prototype (#3957) 
Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Signed-off-by: J-N-K <github@klug.nrw>
 2024-01-02 13:09:51 +01:00
openhab-botandGitHub 1ddbe3180a New translations addons.properties (Italian) (#3979) 2024-01-02 10:53:10 +01:00
Kai KreuzerandGitHub 30ae005956 Fix build number reporting at startup (#3991) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2024-01-02 10:40:02 +01:00
Wouter BornandGitHub 7d1dcd7937 Add network-interface context (#3981) 
This allows for selecting network interface names in configuration parameters.

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-31 22:17:10 +01:00
J-N-KandGitHub 2abe4e20ed Respond with 404 if add-on is missing in add-on service (#3989) 
* Respond with 404 if add-on is missing in add-on service

Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-12-31 14:56:15 +01:00
lolodomoandGitHub 8b14d56e2e [sitemap] Fix parsing of button (buttongrid element built with MainUI) (#3980) 
Fix openhab/openhab-webui#2242

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2023-12-30 15:57:52 +01:00
lolodomoandGitHub 63ae134c33 Consider network settings to avoid creating unexpected JmDNS instances (#3978) 
Fix #3976

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2023-12-30 12:50:27 +01:00
Wouter BornandGitHub f376606e92 Simplify boolean expressions (#3971) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-28 13:19:01 +01:00
Wouter BornandGitHub ba5647b871 More code cleanups (#3975) 
While cleaning up the code I found a some more code to cleanup:

* Remove unnecessary boxing
* Use `contains(..)` instead of `indexOf(..) != -1`
* Use `assertInstanceOf` in tests
* Make expensive trace logging conditional
* Remove redundant constructor
* Replace `collect(Collectors.toUnmodifiableList())` with `toList()`
* Replace `filter(..).count() == 0L` with `noneMatch(..)`
* Replace `filter(..).count() > 0` with `anyMatch(..)`

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-28 13:15:50 +01:00
Wouter BornandGitHub 0e03943e48 Use String.join instead of Collectors.joining (#3973) 
* Use String.join instead of Collectors.joining

String.join results in less code when joining an Iterable or Array.

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-28 13:11:14 +01:00
Wouter BornandGitHub e958d5b46a Replace lambdas with method references (#3972) 
Method references are more readable because they refer to class names and usually result in less code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-28 09:55:31 +01:00
J-N-KandGitHub bb7a0dad1c Fix NPE in GroupStateTriggerHandler and GroupCommandTriggerHandler (#3966) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-12-27 23:41:44 +01:00
Holger FriedrichandGitHub 361273fcb5 IP addon finder: developer docs (#3948) 
* IP addon finder: developer docs

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-27 20:25:32 +01:00
Andrew Fiddian-GreenandGitHub a93f3d7d90 Add-on suggestion finder for USB devices (#3922) 
Also-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
 2023-12-27 18:27:40 +01:00
Florian HotzeandGitHub f5bd7f94f3 [rest] Add no-cache directive to cached REST responses (#3970) 
Fixes https://github.com/openhab/openhab-webui/issues/2102.

This forces the browser to revalidate the cache every time it is accessed to ensure the data is always fresh.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#directives.

This is approach is also suggested in the mdn web docs, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#up-to-date_contents_always.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
 2023-12-27 17:52:49 +01:00
Wouter BornandGitHub b08a01c93f Remove unnecessary parenthesis from lambdas (#3968) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-27 17:52:13 +01:00
Wouter BornandGitHub ec05a63738 Remove unnecessary boxing (#3969) 
Using primitives makes the code faster and consume less memory.

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-27 17:50:09 +01:00
J-N-KandGitHub ff6b33f3d8 Fix duplicate UIDs in remote add-on services (#3961) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-12-26 23:17:05 +01:00
J-N-KandGitHub ad1c37d382 Fix month, week, day not supported (#3964) 
Due to the way month, week and day are defined in Indriya their symbol is not added as alias. This is a bug in indriya, but their release cycles are quite long and we should provide a fix for our users.

This should be backported to 4.1.x

Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-12-26 22:43:33 +01:00
Holger FriedrichandGitHub 7213e7b06a Update Jackson to 2.16.0 (#3956) 
Updates Jackson from 2.15.2 to 2.16.0

For release notes, see:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16

This upgrade addresses:

* CVE-2023-35116

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-23 21:54:36 +01:00
Holger FriedrichandGitHub e7fbd0179f Upgrade Netty to 4.1.104.Final (#3955) 
Upgrades:

* Netty from 4.1.99.Final to 4.1.104.Final

For all fixes and improvements of these upgrades, see:

* https://netty.io/news/index.html

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-23 21:53:11 +01:00
Wouter BornandGitHub 11e51abb44 Use OnOffType.from to reduce code (#3954) 
You can create an `OnOffType` using a boolean nowadays which reduces the amount of code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-12-23 15:33:07 +01:00
Holger FriedrichandGitHub d1bbaba4d4 Javadoc: Introduce custom tags implNote and apiNote (#3945) 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-23 14:52:51 +01:00
Holger FriedrichandGitHub bada23fdb8 Minor code cleanup (#3942) 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-23 12:54:29 +01:00
Holger FriedrichandGitHub 839ba1ab4c Apply spotless after release, resolve bundles (#3953) 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-22 23:14:28 +01:00
openhab-bot 3b279587b1 [unleash-maven-plugin] Preparation for next development cycle. 2023-12-22 11:48:43 +00:00
Kai KreuzerandGitHub 074fcdd7ea Delay the IP scan to make sure that no further candidates are added (#3951) 
* Delay the IP scan to make sure that no further candidates are added and do not use a dedicated thread pool

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2023-12-22 08:49:36 +01:00
openhab-botandGitHub be456792d3 New Crowdin updates (#3950) 
* New translations i18n.properties (Romanian)

* New translations network.properties (Romanian)

* New translations i18n.properties (French)

* New translations network.properties (French)

* New translations i18n.properties (Spanish)

* New translations network.properties (Spanish)

* New translations i18n.properties (Czech)

* New translations network.properties (Czech)

* New translations addons.properties (Danish)

* New translations i18n.properties (Danish)

* New translations network.properties (Danish)

* New translations marketplace.properties (Danish)

* New translations units.properties (Danish)

* New translations i18n.properties (German)

* New translations network.properties (German)

* New translations i18n.properties (Greek)

* New translations network.properties (Greek)

* New translations i18n.properties (Finnish)

* New translations network.properties (Finnish)

* New translations i18n.properties (Hebrew)

* New translations network.properties (Hebrew)

* New translations i18n.properties (Hungarian)

* New translations network.properties (Hungarian)

* New translations units.properties (Hungarian)

* New translations i18n.properties (Italian)

* New translations network.properties (Italian)

* New translations units.properties (Italian)

* New translations i18n.properties (Dutch)

* New translations network.properties (Dutch)

* New translations i18n.properties (Norwegian)

* New translations network.properties (Norwegian)

* New translations i18n.properties (Polish)

* New translations network.properties (Polish)

* New translations i18n.properties (Russian)

* New translations network.properties (Russian)

* New translations i18n.properties (Slovenian)

* New translations network.properties (Slovenian)

* New translations i18n.properties (Swedish)

* New translations network.properties (Swedish)

* New translations i18n.properties (Ukrainian)

* New translations network.properties (Ukrainian)

* New translations i18n.properties (Chinese Simplified)

* New translations network.properties (Chinese Simplified)

* New translations i18n.properties (Portuguese, Brazilian)

* New translations network.properties (Portuguese, Brazilian)
 2023-12-21 21:51:49 +01:00
Kai KreuzerandGitHub 4b310aff30 Catch ISE if config admin is no longer available (#3949) 2023-12-21 21:36:11 +01:00
Andrew Fiddian-GreenandGitHub 924e7b2d6d Fixes #3946 (#3947) 
* Fixes #3946

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
 2023-12-21 18:23:43 +01:00
Kai KreuzerandGitHub 369bd228e7 Move addons.xml to runtime folder (#3944) 
* Move addons.xml to runtime folder

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2023-12-20 23:53:10 +01:00
Kai KreuzerandGitHub dceec22a35 Improve HTTP 404 handling and logging (#3940) 2023-12-20 12:35:25 +01:00
Jacob LaursenandGitHub e8641efd5b Provide I18N properties for Unit Settings (#3941) 2023-12-20 12:34:58 +01:00
Holger FriedrichandGitHub 5e94d8350b Additional logging AddonInfo addons.xml (#3928) 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-12-20 11:19:35 +01:00
lolodomoandGitHub d7486a985e Sitemap generator: fix button parsing for Buttongrid (#3938) 
Fix #3937

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2023-12-20 09:46:41 +01:00