demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-27 12:41:32 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity
921 Commits 1 Branch 0 Tags 39 MiB
4258d87d4a
Commit Graph

554 Commits

Author SHA1 Message Date
Wouter Born
be69d2254e Use !isEmpty() instead of "size() > 0" or "size() != 0" (#1155) 
* Use !isEmpty() instead of "size() > 0" or "size() != 0"

!isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-21 09:00:52 +02:00
Wouter Born
55ddaa25fb Add null annotations to semantics (#1133) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-20 01:39:21 +02:00
Christoph Weitkamp
a3d91bebfc [automation] Added EphemerisConditions for NGRE (#915) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-20 01:37:56 +02:00
Christoph Weitkamp
36ca073ff4 Use constructor injection to simplify lifecycle (#1153) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-20 01:32:44 +02:00
Wouter Born
4895977966 Use isEmpty() instead of "size() == 0" (#1151) 
isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-20 01:27:11 +02:00
Christoph Weitkamp
8d6d650d2e Fixed potential NPE if 'defaultValue' is null (#1149) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-19 20:08:56 +02:00
Christoph Weitkamp
22ba5d92c1 Minor profile improvements (#1132) 
* Minor code improvements in profile factory
* Added integration test to check if factory creates all available profiles

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-19 15:14:57 +02:00
Wouter Born
42a0217386 Fixes a few more SAT findings (#1145) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-19 14:10:18 +02:00
Wouter Born
e35a218a30 [xml] Improve ThingTypeXmlProvider exception handling (#1136) 
* Improve ThingTypeXmlProvider exception handling

When a binding such as ZWave has hundereds of ThingTypes it's hard to debug thing type definition issues.
This PR adds a UID (ConfigDescription, ChannelType, ChannelGroupType and ThingType) to the logging so it will be easier to find the root cause of exceptions.
Because the exceptions are caught, an error in one ThingType definition will no longer prevent other perfectly fine ThingTypes to be registered so the impact of definition issues is reduced.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-18 22:54:45 +02:00
Christoph Weitkamp
21744d22b1 Normalized instantiation of loggers (#1138) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-18 22:29:27 +02:00
Christoph Weitkamp
0fdd691c22 Removed superflous resources (#1137) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-18 22:28:37 +02:00
Christoph Weitkamp
e7c8be33b2 Fixed minor spelling issue (#1143) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-18 22:28:07 +02:00
Mark Hilbush
8396a17d2d Add system profile for a 'rawbutton-on-off-switch' (#1131) 
* Add `rawbutton-on-off-switch` profile and tests

Signed-off-by: Mark Hilbush <mark@hilbush.com>
 2019-10-14 22:22:18 +02:00
Christoph Weitkamp
d8a0225b48 [rest] Added support for default values containing a list of configuration options (#1031) 
* Added support for default values containing a list of configuration options

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-14 12:51:22 +02:00
Wouter Born
933a4ae66a Fix unstable PersistentInboxTest (#1129) 
Activating the PersistentInbox after the mocks are initialized prevents the TimeToLiveCheckingThread calling the storage mock which would cause the exception.

Fixes #1091

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-14 07:17:25 +02:00
Wouter Born
627007d32e Fix InstallServiceCommand SAT findings (#1124) 
Suppresses the SystemPrintln SAT findings because this class is a Karaf shell command which prints to the console.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-13 21:52:44 +02:00
Christoph Weitkamp
91617d8af8 Fixed POM XML Shema Definition path (#1119) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-12 08:52:16 +02:00
Christoph Weitkamp
73d55a9fe9 Changed pid from 'org.eclipse.smarthome.core.i18nprovider' to 'org.eclipse.smarthome.i18n' (#1112) 
* Changed pid from 'org.eclipse.smarthome.core.i18nprovider' to 'org.eclipse.smarthome.i18n'

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-11 19:50:04 +02:00
Wouter Born
12e8edc039 Use diamond operator (#1114) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-11 02:29:47 -07:00
Wouter Born
4e10e0d116 Fix SAT JavadocMethodStyleCheck findings (#1109) 
* Fix SAT JavadocMethodStyleCheck findings

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-10 14:18:54 +02:00
Wouter Born
3d52c72a91 Fix SAT AuthorContributionDescriptionCheck findings (#1110) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-10 11:36:05 +02:00
Wouter Born
90005e4a56 Fix NoEmptyLineSeparatorCheck and NewlineAtEndOfFileCheck SAT findings (#1108) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-08 22:19:54 -07:00
Wouter Born
08a1f9a86d Fix SAT constant/variable name findings (#1106) 
Fixes wrong names identified by the following rules:

* ConstantNameCheck
* LocalFinalVariableNameCheck
* LocalVariableNameCheck
* StaticVariableNameCheck

Most mismatches identified by the MemberNameCheck have also been fixed except for those where the variables are used in events/DTOs etc which would cause issues.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-08 22:19:00 -07:00
Christoph Weitkamp
c86300e420 Fixed wrong trimmed properties (#1105) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-08 09:52:14 -07:00
Wouter Born
12b3c1030f Fix SAT "Initial contribution" warnings (#1100) 
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-07 21:25:40 -07:00
Wouter Born
3dacba3510 Fix SAT ModifierOrderCheck findings by using JLS suggested modifier order (#1103) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-07 21:24:16 -07:00
Wouter Born
7d3c5a1874 Remove @since JavaDoc tags (#1102) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-07 21:21:51 -07:00
Christoph Weitkamp
c31a5aa7ef [storage] Added nullness annotations (#1099) 
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-07 20:50:39 +02:00
Christoph Weitkamp
6a3c9b03ac Replaced orphaned 'registerHandlerLock' by 'thingLocks' (#1060) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-06 11:17:51 +02:00
Wouter Born
9ae7bbe2e8 Move remaining unit tests (#1095) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-04 21:35:13 -07:00
Christoph Weitkamp
2bb5cb7f64 [ephemeris] Adopted configuration for Ephemeris service (#919) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-04 21:33:43 -07:00
Christoph Weitkamp
e1d2ae1c43 [config dispatch] Added support for values containing a list of configuration options (#999) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-03 21:21:12 -07:00
Wouter Born
49f6afc72a Move IO HTTP unit tests (#1081) 
* Move IO HTTP unit tests

All IO HTTP tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 22:22:00 +02:00
Wouter Born
f5f58643f4 Move thing XML unit tests (#1079) 
* Move thing XML unit tests

Moves the thing XML unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 22:21:10 +02:00
Wouter Born
eba9be756b Move UI unit tests (#1078) 
* Move UI unit tests

All UI tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 22:20:20 +02:00
Wouter Born
8c17753006 Move voice unit tests (#1077) 
* Move voice unit tests

Moves the voice unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 22:19:30 +02:00
Wouter Born
8bed617a48 Move compat1x unit tests (#1080) 
* Move compat1x unit tests

All compat1x tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 20:00:57 +02:00
Wouter Born
f1f0e9e52b Move IO Net unit tests (#1082) 
* Move IO Net unit tests

All IO Net tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 20:00:04 +02:00
Wouter Born
4e07b56279 Move magic unit tests (#1083) 
* Move magic unit tests

All magic tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:59:02 +02:00
Wouter Born
28bc05e774 Move model LSP unit tests (#1084) 
* Move model LSP unit tests

All model LSP tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:57:48 +02:00
Wouter Born
8af30cc53b Move semantics unit tests (#1085) 
* Move semantics unit tests

All semantics tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:57:01 +02:00
Wouter Born
7fc9fa65e9 Move transform unit tests (#1076) 
* Move transform unit tests

All transform tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:54:20 +02:00
Wouter Born
c2c57dbf10 Move UI icon unit tests (#1075) 
* Move UI icon unit tests

All UI icon tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:53:26 +02:00
Wouter Born
f53beab04c Move thing unit tests (#1074) 
* Move thing unit tests

Moves the thing unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:52:40 +02:00
Wouter Born
7926b2280e Move core unit tests (#1070) 
* Move core unit tests

Moves the core unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:51:53 +02:00
Wouter Born
41e95ac16b Move audio unit tests (#1068) 
* Move audio unit tests

All audio tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:50:16 +02:00
Christoph Weitkamp
8d6bb2d9ff Removed FQN from servie declaration (#1088) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-03 13:30:04 +02:00
Hilbrand Bouwkamp
2f7689e0a7 [OAuth2] redirectURI should be optional on getAccessTokenResponseByAu… (#1073) 
* [OAuth2] redirectURI should be optional on getAccessTokenResponseByAuthorizationCode

The redirectURI should be optional (Nullable) on getAccessTokenResponseByAuthorizationCode as in the JavaDoc is stated (as is stated in the refered specification).

* [OAuth2] Removed redundant NonNull

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
 2019-10-03 10:27:20 +02:00
Christoph Weitkamp
8e3a521083 Contructor injection; SAT findings (#1036) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-01 15:20:50 +02:00
Christoph Weitkamp
e8fcba2ccf [DSL] Removed deleted things from internal map (#1058) 
* Applied formatter
* Fixed warnings
* Removed deleted things from internal map

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-30 18:53:47 +02:00
Wouter Born
8b72770bf3 Fix MQTT gracefulStop test (#1059) 
Wait for stop future to complete and fix the NPE that would cause the future not to complete.
When disconnecting the client the callback is null.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-30 15:57:19 +02:00
Wouter Born
0b2de2bfea Reenable org.openhab.core.io.transport.upnp.tests (#1057) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-30 10:41:39 +02:00
Wouter Born
40418414b2 Reenable org.openhab.core.io.transport.mqtt.tests (#1056) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-30 08:23:06 +02:00
Wouter Born
f721a30a36 Reenable org.openhab.core.io.rest.tests (#1055) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-29 22:52:26 +02:00
Wouter Born
c9232d9651 Inject SchedulerImpl into DelegatedSchedulerImpl to fix waiting bundles (#1054) 
Fixes #1053

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-29 16:47:19 +02:00
Feras Almannaa
b48f1c1925 [rest] Allow colons and dashes in sse topic filter validator (#1052) 
Fixes #1043 

Signed-off-by: Feras Almanna <firas.almanna3@gmail.com>
 2019-09-29 15:06:37 +02:00
Christoph Weitkamp
d2af7a350b [core] Removed access to 'ThingRegistry' from 'BaseThingHandler' (#1041) 
* Removed access to ThingRegistry from BaseThingHandler

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-29 12:26:46 +02:00
Christoph Weitkamp
978be4cf0f Fixed activation of inbox (#1051) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-28 22:24:05 +02:00
lolodomo
7b49f27823 Fix dynamic options in UI (#1050) 
* Fix dynamic options in UI
* Added unit tests

Fixes #1040

Also-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-28 21:02:29 +02:00
Christoph Weitkamp
b9d9135771 Use constructor injection to simplify lifecycle (#1037) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-27 12:19:50 +02:00
Christoph Weitkamp
3087c4a427 Moved test from integration to unit test (#1044) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-25 22:19:01 +02:00
lolodomo
a11385101b AbstractFileTransformationService: stop watchService properly (#965) 
* AbstractFileTransformationService: stop watchService properly

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-18 19:29:58 +02:00
Wouter Born
8509a94cfd Fix DateTimeType parsing of strings with arbitrary number of nano digits (#1039) 
* Fix DateTimeType parsing of strings with 2 nano digits

Some formatters such as the DateTimeFormatter.ISO_LOCAL_DATE_TIME may also output a string containing 2 nano digits which fail to be parsed by DateTimeValue.

* Fix parsing of arbitrary number of nano digits for Java 11

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-09-18 13:24:41 +02:00
Christoph Weitkamp
8d51cf9e37 Use constructor injection to simplify lifecycle (#1038) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-17 19:17:59 +02:00
Christoph Weitkamp
062692ac55 Enable Config Dispatch Tests (#995) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-16 21:13:02 +02:00
Christoph Weitkamp
cd57f1d79c Refactoring of builders (#908) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-16 21:10:39 +02:00
lolodomo
cf4b752ae1 [rest] New audio API (#1020) 
* New Audio REST API

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-15 08:50:15 +02:00
lolodomo
bb4b041790 Mapview element by default for a location item (#1032) 
Closes #1015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-14 15:59:40 +02:00
lolodomo
9724045bb6 [IconServlet] New optional parameter anyFormat (#978) 
* [IconServlet] New optional parameter anyFormat

Fix #824

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-02 23:22:16 +02:00
lolodomo
a1f388065c REST Voice API: new API for TTS (#1017) 
* REST Voice API: new API for TTS

Fix #927

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-02 22:47:50 +02:00
lolodomo
f2d69139e1 {voice] say: log something when the audio sink cannot be found (#1018) 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-09-02 17:13:33 +02:00
Christoph Weitkamp
4ccaa8b38e [rest] Changed property type to Boolean to allow null values (#1010) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-02 16:55:42 +02:00
pali
fa416be057 [bin2json] Binary to JSON converter initial contribution (#611) 
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
 2019-09-01 12:57:58 +02:00
lolodomo
e7d182607d Selection widget as default widget for Number or String items with options (#1009) 
* Selection widget as default widget for Number or String items with options

Fixes #984

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-30 11:13:50 +02:00
Christoph Weitkamp
b3802d565d [infrastructure] bump SAT to 0.7.0 (#1007) 
* Bump SAT version; Fixed high priority findings
* Defined path to feature file to avoid warnings

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-29 09:17:35 +02:00
Christoph Weitkamp
7d4b21f4d9 Fix gamma correction in HSBType (#996) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-28 22:24:16 +02:00
Christoph Weitkamp
982e938a9e Fixed wrong nullness annotation (#997) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-27 23:25:37 +02:00
Christoph Weitkamp
bb19110018 Added configurationPid (#1003) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-27 23:20:14 +02:00
Christoph Weitkamp
f86d011884 Use constructor injection to simplify lifecycle (#987) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-24 23:49:24 +02:00
Christoph Weitkamp
d16a342663 Streamline DTO serialization for REST item resources (#982) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-24 23:48:42 +02:00
Christoph Weitkamp
5c5c9ae126 Specified OSGi service (#989) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-24 23:47:44 +02:00
Christoph Weitkamp
e2132a7a46 Use constructor injection to simplify lifecycle (#994) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-24 23:45:46 +02:00
Christoph Weitkamp
be1cd25743 [itemregistry] Use constructor injection to simplify lifecycle (#988) 
* Use constructor injection to simplify lifecycle

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* PR extended by ItemStateConverter

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-23 18:21:28 +02:00
Christoph Weitkamp
c8395ef5be [persistence] Use constructor injection to simplify lifecycle (#991) 
* Use constructor injection to simplify lifecycle
* Added nullness annotations to PersistenceManager
* Removed declaration with null

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-21 20:42:02 +02:00
Stewart Cossey
f51bd640f3 Fix incorrect unit symbol for Byte and add unit symbol for Octet. (#990) 
Signed-off-by: Stewart Cossey <stewart.cossey@gmail.com>
 2019-08-21 20:34:08 +02:00
lolodomo
cb39c5b802 GetLabel: Handle correctly string value looking like a transform pattern (#959) 
* GetLabel: Handle correctly string value looking like a transform pattern

Fixes #957

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-19 12:55:28 +02:00
lolodomo
dcea4aa380 ItemUIRegistry: getLabel returning DateTime item formatted in local time zone (#951) 
* ItemUIRegistry: getLabel returning DateTime item formatted in local time zone

Fixes #832

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-17 22:28:34 +02:00
lolodomo
8fb20a4977 [semantics] Fix properties loading (#977) 
Fix #956

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-16 21:24:15 +02:00
Philipp Waller
608507e451 [automation] Update configDescriptions for jsr223.ScriptedTrigger (#964) 
Fixes #962 

Signed-off-by: Philipp Waller <philipp.waller@gmail.com>
 2019-08-13 21:27:29 +02:00
Christoph Weitkamp
3e38733b09 Fixed spelling in JavaDoc (#975) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-13 21:21:13 +02:00
Christoph Weitkamp
49e2286a94 Use constructor injection to simplify lifecycle (#976) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-13 21:20:43 +02:00
lolodomo
0820701ffc [DSL rule] New implicit variable newState (#973) 
Fix #925

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-13 21:13:03 +02:00
lolodomo
aebcc6cd9a [DSL] Unique job key for createTimer in DSL rule (#972) 
Fixes #943

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-13 21:12:23 +02:00
J-N-K
a17d63ad64 increase paho inflight message limit (#970) 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
 2019-08-12 11:08:39 +02:00
Wouter Born
9d2f09936d Fix null annotations order and cleanup (#958) 
* Move null annotations between modifiers and variable type
* Remove redundant public modifiers from interfaces where applicable
* Remove redundant `@NonNull` annotations

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-08-08 09:42:30 +02:00
J-N-K
f433a5683f fix TopicSubscribers (#955) 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
 2019-08-05 22:14:31 +02:00
lolodomo
f03f328bf0 DateTimeType: new methods toZone and toLocaleZone (#945) 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
 2019-08-02 13:57:39 +03:00
Wouter Born
9e7c6af1c8 Fix "No SerialPortProvider found" on startup (#939) 
Change reference cardinality from MULTIPLE to AT_LEAST_ONE so the serial port provider can be used immediately when ThingHandlers are initialized.

Fixes #937

This would always result in the following logging on startup:

[WARN ] [serial.internal.SerialPortManagerImpl] - No SerialPortProvider found for: /dev/ttyUSB0

Bindings without serial port reconnection logic would need to be manually restarted (Z-Wave Binding).

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-07-29 22:23:18 +03:00
Christoph Weitkamp
95e0190d55 Avoid multiple type castings (#946) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-28 11:32:15 +02:00
Christoph Weitkamp
c95dfcb1cc Added formatting tests for DateTimeType (#938) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-22 21:56:22 +02:00
Christoph Weitkamp
4f3e1c17cb Added equality tests for parsing and timzone (#933) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-22 10:44:10 +02:00
Markus Rathgeb
ef05b4d878 start with an upper case on "initial contribution" (#931) 
Related to: https://github.com/openhab/openhab-core/pull/916/#discussion_r305082016

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-07-21 12:24:58 +02:00
Kai Kreuzer
b6aae6907f Revert "openHAB JAX-RS publisher (#905)" 
This reverts commit ad81f040de.
 2019-07-17 11:55:29 +02:00
Kai Kreuzer
b3aabd73ab Revert "remove leftovers of REST optimize (#907)" 
This reverts commit c86cbea3ba.
 2019-07-17 11:55:29 +02:00
Christoph Weitkamp
4b7eddf16e [automation] Fixed topic (#922) 
- Fixed topic for `ThingStatusTriggerHandler`. Is is called "things", not "thing".

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-12 21:01:42 +02:00
Christoph Weitkamp
17c756513a [automation] Added 'ThingStatusTrigger' for NGRE (#911) 
* Added ThingStatusTrigger for NGRE

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-10 11:57:54 +02:00
Christoph Weitkamp
abab07dfb9 [automation] Added nullness annotations (#910) 
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-07-08 10:53:25 +02:00
maniac103
7bad7f6e3f Add missing null check to PageChangeListener. (#909) 
If visibility of a sitemap widget that does not have a (valid) item is
changed, 'itemToBeSent' becomes null, in which case we need to omit
filling out 'event.item' and 'event.state' (and keep them as null).

Closes #897

Signed-off-by: Danny Baumann <dannybaumann@web.de>
 2019-07-04 11:36:22 +02:00
Markus Rathgeb
c86cbea3ba remove leftovers of REST optimize (#907) 
The project has been replaced by REST publisher and the sources should
be removed by https://github.com/openhab/openhab-core/pull/905
It seems something went wrong.
Let's remove it now!

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-07-02 16:45:40 +02:00
Markus Rathgeb
ad81f040de openHAB JAX-RS publisher (#905) 
* add project for publisher
* add unmodified com.eclipsesource.jaxrs.publisher sources
* modify and use modified publisher
* drop tracker usage (only for custom whitelist by fragments)
* add the new code to new classes and namespace

Also-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-07-01 21:08:03 +02:00
Christoph Weitkamp
01f4724575 Added action for bank holiday from a given userfile (#901) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-26 13:23:37 +02:00
Kai Kreuzer
957cbe045c moved resources folder out of java source folder (#900) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2019-06-26 06:42:37 +02:00
Christoph Weitkamp
c2af2465d1 Added nullness annotations (#898) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-25 18:36:32 +02:00
Christoph Weitkamp
6d073daa82 Updated xml schema locations to openHAB (#899) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-25 18:30:07 +02:00
Daniel Walters
22937ae02f Fix typo in exception message (#896) 
Signed-off-by: Daniel Walters <danielwalters1@hotmail.com>
 2019-06-25 06:44:13 +02:00
Björn Brings
7fdef0717e Reduce polling frequency of usb serial scanner (#889) 
* Reduce polling frequency

Signed-off-by: Björn Brings <bjoernbrings@web.de>
 2019-06-24 19:13:59 +02:00
Kai Kreuzer
ce352d0ca7 corrected artifact name (#893) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2019-06-23 22:02:44 +02:00
Markus Rathgeb
5fda143230 simplify contains, get, compute separation (#887) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:35:43 +02:00
Markus Rathgeb
7d7f8d044d don't fail on nullable locale (currently not forbidden) (#886) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:34:18 +02:00
Markus Rathgeb
2ed5110668 slightly cleaner nullness handling (don't split contains and get) (#885) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:33:36 +02:00
Markus Rathgeb
fe9b060391 firmware: transfer latest FW don't require a info about previous FW (#884) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:25:22 +02:00
Markus Rathgeb
a23cd23a37 map entries of member variables could change between lines (#883) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:24:55 +02:00
Markus Rathgeb
a75fbe1e42 Class::getCanonicalName may return null (#882) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:24:20 +02:00
Markus Rathgeb
bf9f86354b fix nullness violation in MapDB test (#881) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:23:53 +02:00
Markus Rathgeb
b897de2f5e get semantic type can return null, isAssignableFrom requires non-null (#880) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:23:33 +02:00
Markus Rathgeb
6cdfd635f4 compine filter and map for tooling (#879) 
It should not matter if the instructions are split or not.
But if it is splitted the nullness tooling don't know that the stream
after the filter contains only non null elements.
As it should not matter and to make the tooling happy...

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:23:05 +02:00
Markus Rathgeb
ebda4b8fc7 handle nullness in unget handler of composite module correctly (#878) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:22:22 +02:00
Markus Rathgeb
f1dfb553c7 we don't know if the rule has been deleted async. (#877) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:21:41 +02:00
Markus Rathgeb
361d42b20a if null must not be returned, null must not be returned (#875) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:20:27 +02:00
Markus Rathgeb
0fc38a910b the format pattern must not be null (#874) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:19:46 +02:00
Markus Rathgeb
8e195d4058 don't use safe caller for event delegation to subscribers (#861) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-19 23:43:17 +02:00
Markus Rathgeb
fefbef50f5 UID: allow to encode arbitrary string (+decode) (#864) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-19 22:42:27 +02:00
Wouter Born
0f1c1bbb2d Fix Ephemeris ClassNotFoundException (#869) 
Fixes #868

Also-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-06-13 20:03:16 +02:00
Wouter Born
f3ced23830 Fix serial ports missing when ports are added to system property (#866) 
* Get all serial port identifiers by calling RXTX with and without using the gnu.io.rxtx.SerialPorts property
* Filter getSerialPortIdentifiers() stream on distinct port names
* Fix thread safety issues by saving getPortIdentifiers() Enumeration result to new list

Fixes #805

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-06-12 08:58:41 +02:00
Kai Kreuzer
d0dfbe3f44 Ephemeris service (#506) 
Also-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2019-06-11 10:20:04 +02:00
Markus Rathgeb
849753befe small improvements of hexutils API and impl. (#862) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-10 17:07:04 +02:00
Markus Rathgeb
5977002c5f workaround for #597 (#863) 
Fixes: #597

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-10 11:28:09 +02:00
Markus Rathgeb
3b74ea1dad use separate class for named thread factory (#860) 
... to make it usable for others

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-09 20:32:01 +02:00
Markus Rathgeb
9018e9ae80 move event logging for better analyze options (#856) 
* move event logging for better analyze options
* add another optional event handling logging

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-09 10:33:42 +02:00
Christoph Weitkamp
1f20e8277a model: Use constructor injection to simplify lifecycle (#857) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-09 10:33:22 +02:00
Wouter Born
b99c439d77 Fix Jetty warnings by excluding weak cipher suites (#858) 
Newer Jetty versions log warnings when weak cipher suites are configured.
This occurs when using Karaf 4.2.6 with Jetty 9.4.18.v20190429.

See also: https://github.com/eclipse/jetty.project/pull/3050

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-06-09 10:32:46 +02:00
Christoph Weitkamp
306165dcfb Added 'RefreshType.REFRESH' and 'BinaryPrefix' to imports (#854) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-05 13:41:33 +02:00
Christoph Weitkamp
edd148f3f6 automation: Refactoring of 'DefaultScriptScopeProvider' (#851) 
* automation: Use constructor injection to simplify lifecycle
* Refactoring of 'DefaultScriptScopeProvider' class

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 20:47:22 +02:00
Christoph Weitkamp
5d7a19541f model: Refactoring of 'RuleEngineImpl' (#853) 
* Refactoring of 'RuleEngineImpl'
* Use 'EventType' type instead of the FQCN

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 16:11:18 +02:00
Christoph Weitkamp
e2e53cb5c2 Fixed JavaDoc to get rid of the Quartz includes (#852) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 14:49:09 +02:00
Christoph Weitkamp
64a466ff7d Added nullness annotations (#850) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 14:05:33 +02:00
Christoph Weitkamp
7f0d61d6a6 thing: Use constructor injection to simplify lifecycle (#849) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 13:14:41 +02:00
Christoph Weitkamp
59ffc98b23 model: Use constructor injection to simplify lifecycle (#840) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-02 15:55:53 +02:00
Markus Rathgeb
e9418cb4c1 split between activation logic (#836) 
If a component should be activated an instance is constructed and that
object is activated.
Let's split the construction and activation logic also if constructor
injection is used.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-05-28 21:36:33 +02:00
Christoph Weitkamp
eef779e91a Added nullness annotations (#837) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-28 17:56:48 +02:00