Commit Graph
1753 Commits
Author SHA1 Message Date
jimtngandGitHub 26596ecc25 [Semantics] Return parent Location and Equipment (#2928)
* [Semantics] Return parent Location and Equipment

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-04-25 13:04:57 +02:00
J-N-KandGitHub 3135017895 Properly close script engines in script transformation (#2932)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:40:43 +02:00
J-N-KandGitHub b331066ea9 Allow changing watched directory of a WatchService (#2894)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:01:33 +02:00
J-N-KandGitHub a192a1dfc6 Add a generic script transformation (#2883)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 19:00:03 +02:00
J-N-KandGitHub a42e798c8d Fix "recursive membership detected" for plain items (#2918)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 14:38:41 +02:00
J-N-KandGitHub ca94fd57b0 Add new module DateTimeTrigger for triggering on a DateTime state (#2923)
* Add DateTimeTrigger

This adds a new module that triggers at the time given by the state of an item.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-24 11:29:55 +02:00
Łukasz DywickiandGitHub c09db50d46 [modbus] Add configurable after connection delay (#2927)
Fixes #2926

Signed-off-by: Łukasz Dywicki <luke@code-house.org>
2022-04-23 13:49:43 +02:00
Gaël L'hopitalandGitHub af6a6c6ac4 Adding missing system channels descriptions. (#2912)
* Adding missing system channels descriptions.
Removing some redundant null checks of the same package.

Signed-off-by: clinique <gael@lhopital.org>
2022-04-22 23:02:24 +02:00
J-N-KandGitHub ee7095d96d Improve SaferCallerImplTest (#2922)
Failed to to unnecessary stubbing exception in https://ci.openhab.org/job/PR-openHAB-Core/4556/

Also removes unnecessary code.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-22 10:52:28 +02:00
J-N-KandGitHub 0e7e7a37b7 Improve SchedulerImplTest (#2919)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-20 10:06:39 +02:00
J-N-KandGitHub 7e641e12f8 Fix Metadata can't be deserialized (#2921)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-18 22:06:29 +02:00
Wouter BornandGitHub 05fdc81b27 Improve test stability and OS compatibility (#2878)
This fixes the build being broken when building on Windows.
It also contains many fixes for timing issues which seem to impact macOS and Windows more than Linux.

* Fix .gitattributes and add *.xml_gen to fix line ending issues on Windows
* Derive fork count from CPU details in org.openhab.core tests for more stable tests on machines with fewer cores
* Adjust SafeCallerImplTest timings
* Increase ExecUtilTest timeout
* Increase SchedulerImplTest timeouts
* Increase AudioConsoleTest serveStream timeout
* Increase AudioServletTest serveStream timeout
* Increase SchedulerImplTest test timeouts
* Increase ExpireManagerTest timeout used for checking published events
* Increase PeriodicSchedulerImplTest max allowed delta
* Increase SchedulerImplTest timeouts
* Fix BundleInfoReader file stream not closed causing temp dir deletion issues on Windows
* Fix GenerateDefaultTranslationsMojoTest Windows line endings issues
* Fix GenerateDefaultTranslationsMojoTest Windows temp dir deletion problem
* Fix GenericItemProviderTest tearDown sometimes fails because of queued events
* Fix ChannelLinkNotifierOSGiTest wait for channel link events
* Fix ChannelCommandDescriptionProviderOSGiTest fails if provider not immediately registered
* Fix ChannelStateDescriptionProviderOSGiTest fails if provider not immediately registered
* Fix GenericItemChannelLinkProviderTest not waiting for async updated state to become true
* Fix GenericThingProviderTest failing due to events of previous test
* Fix InboxOSGiTest sometimes fails because of queued events
* Fix ScriptEngineOSGiTest failing because items are not yet added to registry
* Fix ThingManagerOSGiTest failing due to async handleRemoval call

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-14 23:00:33 +02:00
Wouter BornandGitHub a4353ee5ca Fix UnitUtils.getDimensionName returns Angle instead of Dimensionless (#2895)
An Angle is also Dimensionless and because it is the first compatible unit it is always returned instead of any other Dimensionless unit.
With these changes `getDimensionName` will prefer the dimension of equal units over those of compatible units.

Fixes #2880

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-14 22:57:18 +02:00
J-N-KandGitHub 4fbd4c5960 Do not allow empty last segment in UID (#2901)
* Fix empty segment in UID

Segments are not allowed to be empty. Also adds tests for UID construction.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-14 22:55:19 +02:00
J-N-KandGitHub afd8768340 Extend ProfileContext to allow data type changing profiles (#2852)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-14 22:52:52 +02:00
J-N-KandGitHub 52cb6f22da Add .gradle to .gitignore (#2913)
While openHAB uses Maven, under some circumstances IntelliJ creates files in the .gradle/ directory.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-14 00:07:15 +02:00
J-N-KandGitHub f83049ae71 Log a message if a model is parsed and no thing handler factory can be found (#2754)
* Log a message if a model is parsed and no thing handler factory can be found

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-12 22:43:14 +02:00
J-N-KandGitHub 785d3e5ae5 Fix hanging build (#2910)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-11 18:52:04 +02:00
J-N-KandGitHub 53dcf48a17 Add a registry for transformation configurations and allow editing them (#2821)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-11 08:18:14 +02:00
lolodomoandGitHub 90f6a95251 [voice] New feature "listen and answer" (#2793)
* New method listenAndAnswer in VoiceManager
* New console command "voice listenandanswer"
* New REST API
* New rule action
* Enhanced console command "voice startdialog"

Closes #2688

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-04-09 16:26:09 +02:00
J-N-KandGitHub 6a75130355 Allow type migrations in JSONStorage (#2784)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-09 15:49:38 +02:00
openhab-botandGitHub 661fa00e46 New Crowdin updates (#2903)
* New translations marketplace.properties (Greek)

* New translations validation.properties (Greek)

* New translations SystemThingStatusInfos.properties (Greek)

* New translations DefaultSystemChannels.properties (Greek)

* New translations addons.properties (Greek)

* New translations voice.properties (Greek)
2022-04-09 08:57:11 +02:00
Wouter BornandGitHub 5df95cd8be Upgrade nrjavaserial to fix file descriptor leak (#2899)
Uses an openHAB 5.2.1.OH1 build based on the latest changes in the nrjavaserial master branch (https://github.com/NeuronRobotics/nrjavaserial/tree/7aa21d1dc8cecdc8daad3ebc40273cfb8179e9d2).
When there is an official release containing those changes we can upgrade to that.

Most importantly this fixes a file descriptor leak when checking lock dir permissions.
It also adds FreeBSD aarch64 (ARM64) support.

Fixes #1842

Signed-off-by: Wouter Born <github@maindrain.net>
2022-04-08 07:42:45 +02:00
J-N-KandGitHub df978f434a Fix memory leak in ScriptedRuleProvider (#2897)
* Fix memory leak in ScriptedRuleProvider

The Rule was never removed from the internal tracking map and therefore allocated resources were never freed.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-07 08:19:05 +02:00
Flole998andGitHub 2de0fafc6e Implement "forceAsItem" functionality for Charts in sitemaps (#2657)
This is part of implementing #2185

Signed-off-by: Flole <flole@flole.de>
2022-04-05 20:56:14 +02:00
J-N-KandGitHub 2a3e2e5567 Reduce Mockito warnings (#2893)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-03 22:36:55 +02:00
GiviMADandGitHub 7442220830 [AbstractRuleBasedInterpreter] Fix spanish tokenization (#2889)
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
2022-04-03 12:14:09 +02:00
Wouter BornandGitHub b5de891ebd Update semantic metadata of group members when groups are added/removed (#2884)
* Update semantic metadata of group members when groups are added/removed

This fixes the issue that the semantic metadata is incorrect when defining items in files and groups in the UI.

Fixes #2117
2022-04-03 11:55:19 +02:00
J-N-KandGitHub eec80f0e20 Fix ScriptEngine not removed if created by ScriptAction (#2886)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-04-01 22:56:27 +02:00
Wouter BornandGitHub f0b53cea34 Fix i18n-maven-plugin project name (#2879)
This makes it follow the naming scheme as used with the other projects.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-29 17:05:58 +02:00
openhab-botandGitHub f5aeba0ad7 New Crowdin updates (#2873)
* New translations DefaultSystemChannels.properties (Finnish)

* New translations DefaultSystemChannels.properties (Dutch)

* New translations marketplace.properties (Polish)

* New translations SystemThingStatusInfos.properties (Polish)

* New translations validation.properties (Polish)

* New translations voice.properties (Polish)

* New translations DefaultSystemChannels.properties (Italian)

* New translations DefaultSystemChannels.properties (Polish)

* New translations DefaultSystemChannels.properties (Hebrew)

* New translations DefaultSystemChannels.properties (German)

* New translations marketplace.properties (French)

* New translations DefaultSystemChannels.properties (French)

* New translations addons.properties (French)

* New translations marketplace.properties (French)
2022-03-27 23:22:39 +02:00
J-N-KandGitHub 5629a38e1a Fix null annotations on PersistenceItemConfiguration (#2876)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-27 14:47:41 +02:00
Wouter BornandGitHub f20799b69b Improve HostFragmentSupportTest (#2859)
* Remove duplications
* Better null handling
* Use constants
* Use default waitForAssert timeout (10s)

This may help to get the test more stable (#1089).

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-27 10:46:36 +02:00
Gaël L'hopitalandGitHub 847aa349d8 Adding Indoor Temperature as system channel type (#2866)
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
2022-03-26 12:29:03 +01:00
openhab-botandGitHub 22c39fb54d New Crowdin updates (#2869)
* New translations addons.properties (Dutch)
* New translations addons.properties (Finnish)
* New translations addons.properties (German)
* New translations addons.properties (Hebrew)
* New translations addons.properties (Italian)
* New translations addons.properties (Polish)
* New translations marketplace.properties (Dutch)
* New translations marketplace.properties (Finnish)
* New translations marketplace.properties (German)
* New translations marketplace.properties (Hebrew)
* New translations marketplace.properties (Italian)
* New translations SystemThingStatusInfos.properties (Bulgarian)
* New translations units.properties (Catalan)
2022-03-25 18:44:31 +01:00
Christoph WeitkampandGitHub 3c494677b7 Improve description of REST API for deleting data from persistence (#2870)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-03-25 18:43:01 +01:00
Wouter BornandGitHub b5e0ccfa6a Add missing default translations for add-ons/marketplace configuration options (#2868)
This makes it possible to use Crowdin for translating the new configuration options introduced in #2811.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-23 17:45:23 +01:00
openhab-botandGitHub 7e13f7f4bd New Crowdin updates (#2863)
* New translations addons.properties (Chinese Simplified)
* New translations addons.properties (Czech)
* New translations addons.properties (Dutch)
* New translations addons.properties (Finnish)
* New translations addons.properties (French)
* New translations addons.properties (German)
* New translations addons.properties (Greek)
* New translations addons.properties (Hebrew)
* New translations addons.properties (Hungarian)
* New translations addons.properties (Italian)
* New translations addons.properties (Polish)
* New translations addons.properties (Portuguese, Brazilian)
* New translations addons.properties (Russian)
* New translations addons.properties (Spanish)
* New translations addons.properties (Ukrainian)
* New translations i18n.properties (Danish)
* New translations magic.properties (Dutch)
* New translations marketplace.properties (Dutch)
* New translations marketplace.properties (Hebrew)
* New translations marketplace.properties (Hungarian)
* New translations marketplace.properties (Italian)
* New translations network.properties (Danish)
* New translations SystemThingStatusInfos.properties (Dutch)
* New translations units.properties (Danish)
* New translations validation.properties (Danish)
* New translations validation.properties (Dutch)
* New translations voice.properties (Dutch)
2022-03-22 21:27:45 +01:00
J-N-KandGitHub 41abd57161 Increase allowed deviation in PeriodicSchedulerImplTest (#2867)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-22 20:46:50 +01:00
J-N-KandGitHub 5746a1ff2c Fix enabling/disabling CommunityMarketplace (#2864)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-21 22:02:34 +01:00
Wouter BornandGitHub 7fbd9768a7 Cleanup BundleVersion (#2861)
Fixes a few SAT findings in the BundleVersion class.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-21 08:19:27 +01:00
J-N-KandGitHub 4577562f08 [addonservices] Add version filtering (#2811)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-20 18:43:07 +01:00
J-N-KandGitHub c2ba4dcd16 Fix build in localized environments (#2855)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-20 10:28:28 +01:00
J-N-KandGitHub 45b5c6772a Improve ThingManagerOSGiTest (#2858)
This change ensures that the storage of bridge and thing are done before the initialization is reported.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-19 21:09:02 +01:00
J-N-KandGitHub 79e070c7ac Improve ScriptFileWatcherTest (#2857)
Most of the tests add a timeout of 1s to account for small delays in async processing in the AbstractWatchService. This adds some more timeouts for tests which were missing those.

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-19 21:08:00 +01:00
J-N-KandGitHub 3d17049d52 Improve PeridodicSchedulerImplTest (#2856)
* Improve PeridodicSchedulerImplTest

The old implementation truncated timestamps to 1/10 s. Under some circumstances this could result in a failed tests:

offset = 201 -> truncatedOffset = 2
200ms delay expected, adjustment calculation results in an actual delay of 198ms
time = 399 -> truncatedTime = 3

expected: truncatedOffset + expected => 2 + 2 = 4
actual: truncatedTime = 3

The new implementation allows for an error of +/- 10ms which is far more than needed.

* increase tolerance
* fix consecutive executions build up errors

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-19 21:07:08 +01:00
J-N-KandGitHub 91614c2b12 Fix ServiceException when add-on handlers are not fully initialized (#2830)
* Fix ServiceException when add-on handlers are not fully initialized

Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-03-18 07:47:27 +01:00
Wouter BornandGitHub a0cc58c807 Upgrade Eclipse OSGi system bundle to 3.17.200 in runtime BOM (#2849)
This prevents deprecation warnings when running the itests with Java 17:

WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.eclipse.osgi.internal.framework.SystemBundleActivator (file:org.openhab.core.tests/target/test/tmp/testing/itest/cnf/cache/6.2.0/org.openhab.core.bom.runtime-index/org.eclipse.osgi-3.16.300.v20210525-1715.jar)
WARNING: Please consider reporting this to the maintainers of org.eclipse.osgi.internal.framework.SystemBundleActivator
WARNING: System::setSecurityManager will be removed in a future release

See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=574729

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-18 07:44:47 +01:00
Wouter BornandGitHub 9e33db6702 Remove MQTT system broker leftovers (#2842)
The MqttService was used to keep track of the system MQTT brokers.
Since there are none it can be removed as well as the observer, tests, configuration and translations.

Fixes #2841

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-17 19:35:35 +01:00
Wouter BornandGitHub 7ae37f810b Fix typo in ScriptImpl exception message (#2847)
Fixes #2846

Signed-off-by: Wouter Born <github@maindrain.net>
2022-03-17 11:50:20 +01:00