Commit Graph

448 Commits

Author SHA1 Message Date
Christoph Weitkamp
22ba5d92c1 Minor profile improvements (#1132)
* Minor code improvements in profile factory
* Added integration test to check if factory creates all available profiles

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-19 15:14:57 +02:00
Wouter Born
42a0217386 Fixes a few more SAT findings (#1145)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-19 14:10:18 +02:00
Wouter Born
e35a218a30 [xml] Improve ThingTypeXmlProvider exception handling (#1136)
* Improve ThingTypeXmlProvider exception handling

When a binding such as ZWave has hundereds of ThingTypes it's hard to debug thing type definition issues.
This PR adds a UID (ConfigDescription, ChannelType, ChannelGroupType and ThingType) to the logging so it will be easier to find the root cause of exceptions.
Because the exceptions are caught, an error in one ThingType definition will no longer prevent other perfectly fine ThingTypes to be registered so the impact of definition issues is reduced.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-18 22:54:45 +02:00
Christoph Weitkamp
21744d22b1 Normalized instantiation of loggers (#1138)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-18 22:29:27 +02:00
Christoph Weitkamp
0fdd691c22 Removed superflous resources (#1137)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-18 22:28:37 +02:00
Christoph Weitkamp
e7c8be33b2 Fixed minor spelling issue (#1143)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-18 22:28:07 +02:00
Mark Hilbush
8396a17d2d Add system profile for a 'rawbutton-on-off-switch' (#1131)
* Add `rawbutton-on-off-switch` profile and tests

Signed-off-by: Mark Hilbush <mark@hilbush.com>
2019-10-14 22:22:18 +02:00
Christoph Weitkamp
d8a0225b48 [rest] Added support for default values containing a list of configuration options (#1031)
* Added support for default values containing a list of configuration options

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-14 12:51:22 +02:00
Wouter Born
933a4ae66a Fix unstable PersistentInboxTest (#1129)
Activating the PersistentInbox after the mocks are initialized prevents the TimeToLiveCheckingThread calling the storage mock which would cause the exception.

Fixes #1091

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-14 07:17:25 +02:00
Wouter Born
627007d32e Fix InstallServiceCommand SAT findings (#1124)
Suppresses the SystemPrintln SAT findings because this class is a Karaf shell command which prints to the console.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-13 21:52:44 +02:00
Christoph Weitkamp
91617d8af8 Fixed POM XML Shema Definition path (#1119)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-12 08:52:16 +02:00
Christoph Weitkamp
73d55a9fe9 Changed pid from 'org.eclipse.smarthome.core.i18nprovider' to 'org.eclipse.smarthome.i18n' (#1112)
* Changed pid from 'org.eclipse.smarthome.core.i18nprovider' to 'org.eclipse.smarthome.i18n'

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-11 19:50:04 +02:00
Wouter Born
12e8edc039 Use diamond operator (#1114)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-11 02:29:47 -07:00
Wouter Born
4e10e0d116 Fix SAT JavadocMethodStyleCheck findings (#1109)
* Fix SAT JavadocMethodStyleCheck findings

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-10 14:18:54 +02:00
Wouter Born
3d52c72a91 Fix SAT AuthorContributionDescriptionCheck findings (#1110)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-10 11:36:05 +02:00
Wouter Born
90005e4a56 Fix NoEmptyLineSeparatorCheck and NewlineAtEndOfFileCheck SAT findings (#1108)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-08 22:19:54 -07:00
Wouter Born
08a1f9a86d Fix SAT constant/variable name findings (#1106)
Fixes wrong names identified by the following rules:

* ConstantNameCheck
* LocalFinalVariableNameCheck
* LocalVariableNameCheck
* StaticVariableNameCheck

Most mismatches identified by the MemberNameCheck have also been fixed except for those where the variables are used in events/DTOs etc which would cause issues.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-08 22:19:00 -07:00
Christoph Weitkamp
c86300e420 Fixed wrong trimmed properties (#1105)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-08 09:52:14 -07:00
Wouter Born
12b3c1030f Fix SAT "Initial contribution" warnings (#1100)
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-07 21:25:40 -07:00
Wouter Born
3dacba3510 Fix SAT ModifierOrderCheck findings by using JLS suggested modifier order (#1103)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-07 21:24:16 -07:00
Wouter Born
7d3c5a1874 Remove @since JavaDoc tags (#1102)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-07 21:21:51 -07:00
Christoph Weitkamp
c31a5aa7ef [storage] Added nullness annotations (#1099)
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-07 20:50:39 +02:00
Christoph Weitkamp
6a3c9b03ac Replaced orphaned 'registerHandlerLock' by 'thingLocks' (#1060)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-06 11:17:51 +02:00
Wouter Born
9ae7bbe2e8 Move remaining unit tests (#1095)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-04 21:35:13 -07:00
Christoph Weitkamp
2bb5cb7f64 [ephemeris] Adopted configuration for Ephemeris service (#919)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-04 21:33:43 -07:00
Christoph Weitkamp
e1d2ae1c43 [config dispatch] Added support for values containing a list of configuration options (#999)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-03 21:21:12 -07:00
Wouter Born
49f6afc72a Move IO HTTP unit tests (#1081)
* Move IO HTTP unit tests

All IO HTTP tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 22:22:00 +02:00
Wouter Born
f5f58643f4 Move thing XML unit tests (#1079)
* Move thing XML unit tests

Moves the thing XML unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 22:21:10 +02:00
Wouter Born
eba9be756b Move UI unit tests (#1078)
* Move UI unit tests

All UI tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 22:20:20 +02:00
Wouter Born
8c17753006 Move voice unit tests (#1077)
* Move voice unit tests

Moves the voice unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 22:19:30 +02:00
Wouter Born
8bed617a48 Move compat1x unit tests (#1080)
* Move compat1x unit tests

All compat1x tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 20:00:57 +02:00
Wouter Born
f1f0e9e52b Move IO Net unit tests (#1082)
* Move IO Net unit tests

All IO Net tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 20:00:04 +02:00
Wouter Born
4e07b56279 Move magic unit tests (#1083)
* Move magic unit tests

All magic tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:59:02 +02:00
Wouter Born
28bc05e774 Move model LSP unit tests (#1084)
* Move model LSP unit tests

All model LSP tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:57:48 +02:00
Wouter Born
8af30cc53b Move semantics unit tests (#1085)
* Move semantics unit tests

All semantics tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:57:01 +02:00
Wouter Born
7fc9fa65e9 Move transform unit tests (#1076)
* Move transform unit tests

All transform tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:54:20 +02:00
Wouter Born
c2c57dbf10 Move UI icon unit tests (#1075)
* Move UI icon unit tests

All UI icon tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:53:26 +02:00
Wouter Born
f53beab04c Move thing unit tests (#1074)
* Move thing unit tests

Moves the thing unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:52:40 +02:00
Wouter Born
7926b2280e Move core unit tests (#1070)
* Move core unit tests

Moves the core unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:51:53 +02:00
Wouter Born
41e95ac16b Move audio unit tests (#1068)
* Move audio unit tests

All audio tests are unit tests so there is no need for an itests project.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:50:16 +02:00
Christoph Weitkamp
8d6bb2d9ff Removed FQN from servie declaration (#1088)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-03 13:30:04 +02:00
Hilbrand Bouwkamp
2f7689e0a7 [OAuth2] redirectURI should be optional on getAccessTokenResponseByAu… (#1073)
* [OAuth2] redirectURI should be optional on getAccessTokenResponseByAuthorizationCode

The redirectURI should be optional (Nullable) on getAccessTokenResponseByAuthorizationCode as in the JavaDoc is stated (as is stated in the refered specification).

* [OAuth2] Removed redundant NonNull

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-10-03 10:27:20 +02:00
Christoph Weitkamp
8e3a521083 Contructor injection; SAT findings (#1036)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-10-01 15:20:50 +02:00
Christoph Weitkamp
e8fcba2ccf [DSL] Removed deleted things from internal map (#1058)
* Applied formatter
* Fixed warnings
* Removed deleted things from internal map

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-09-30 18:53:47 +02:00
Wouter Born
8b72770bf3 Fix MQTT gracefulStop test (#1059)
Wait for stop future to complete and fix the NPE that would cause the future not to complete.
When disconnecting the client the callback is null.

Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-30 15:57:19 +02:00
Wouter Born
0b2de2bfea Reenable org.openhab.core.io.transport.upnp.tests (#1057)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-30 10:41:39 +02:00
Wouter Born
40418414b2 Reenable org.openhab.core.io.transport.mqtt.tests (#1056)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-30 08:23:06 +02:00
Wouter Born
f721a30a36 Reenable org.openhab.core.io.rest.tests (#1055)
Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-29 22:52:26 +02:00
Wouter Born
c9232d9651 Inject SchedulerImpl into DelegatedSchedulerImpl to fix waiting bundles (#1054)
Fixes #1053

Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-29 16:47:19 +02:00
Feras Almannaa
b48f1c1925 [rest] Allow colons and dashes in sse topic filter validator (#1052)
Fixes #1043 

Signed-off-by: Feras Almanna <firas.almanna3@gmail.com>
2019-09-29 15:06:37 +02:00