demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2026-07-29 12:34:22 +02:00
Code Issues 1 Packages Projects Releases Wiki Activity

Lower the log level for useTags (#5142)

Browse Source 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This commit is contained in:
Andrew Fiddian-Green
2025-12-13 08:24:43 +01:00
committed by GitHub
parent 2789e69d5e
commit c0cd523e8c
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/link/ItemChannelLinkRegistry.java
+16 -7
View File
@@ -85,6 +85,7 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
private boolean useTagsGlobally = false;
private int startlevel = 0;
private boolean oneShotLoggingDone = false;
@Activate
public ItemChannelLinkRegistry(final @Nullable Map<String, @Nullable Object> configuration,
@@ -97,6 +98,7 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
this.itemRegistry.addRegistryChangeListener(this);
this.itemBuilderFactory = itemBuilderFactory;
this.eventRegistration = bundleContext.registerService(EventSubscriber.class.getName(), this, null);
this.oneShotLoggingDone = false;
modified(configuration);
}
@@ -109,6 +111,7 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
@Override
protected void deactivate() {
oneShotLoggingDone = false;
eventRegistration.unregister();
itemRegistry.removeRegistryChangeListener(this);
super.deactivate();
@@ -309,9 +312,7 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
} else {
Set<String> newTags = new HashSet<>(activeItem.getTags());
newTags.addAll(channelDefaultTags);
logger.info("Item '{}' adding tags '{}' supplied by channel '{}'.", activeItem.getName(),
channelDefaultTags, link.getLinkedUID());
logTagsAdded(activeItem.getName(), channelDefaultTags, link.getLinkedUID());
link.setTagsLinked(true);
updateExistingRegistryItemTagsAndNotifyRegistryListeners(activeItem.getName(), newTags);
@@ -344,8 +345,8 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
newTags.removeAll(oldLinkTags);
// on openHAB shutdown tagsLinked may be true but oldLinkTags is already empty so do not log
if (startlevel >= STARTLEVEL_COMPLETE) {
logger.info("Item '{}' removing tags '{}' supplied by channel '{}'.", activeItem.getName(), oldLinkTags,
oldLink.getLinkedUID());
logger.debug("Item '{}' removing tags '{}' supplied by channel '{}'.", activeItem.getName(),
oldLinkTags, oldLink.getLinkedUID());
}
// iterate over other links in case one may assign new tags
@@ -361,8 +362,7 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
} else {
alreadyHasPointOrPropertyTag = true;
newTags.addAll(otherLinkTags);
logger.info("Item '{}' adding tags '{}' supplied by channel '{}'.", activeItem.getName(),
otherLinkTags, otherLink.getLinkedUID());
logTagsAdded(activeItem.getName(), otherLinkTags, otherLink.getLinkedUID());
otherLink.setTagsLinked(true);
}
}
@@ -492,4 +492,13 @@ public class ItemChannelLinkRegistry extends AbstractLinkRegistry<ItemChannelLin
startlevel = newStartlevel;
}
}
private void logTagsAdded(String item, Set<String> tags, ChannelUID channel) {
if (logger.isDebugEnabled()) {
logger.debug("Item '{}' adding tags '{}' supplied by channel '{}'.", item, tags, channel);
} else if (!oneShotLoggingDone) {
oneShotLoggingDone = true;
logger.info("At least one Item added tags supplied by a channel. => Enable debug logging to see details.");
}
}
}