demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2026-07-29 12:34:22 +02:00
Code Issues 1 Packages Projects Releases Wiki Activity

Print message instead of null on console when specified play volume is invalid (#670)

Browse Source 
The fix helps users and also ensures the unit test works on both Java 8 and 11.

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2019-03-17 13:00:35 +01:00
committed by Christoph Weitkamp
parent 71b241ae21
commit 7e94df1656
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bundles/org.openhab.core.audio/src/main/java/org/eclipse/smarthome/core/audio/internal/AudioConsoleCommandExtension.java
+1 -1
View File
@@ -144,7 +144,7 @@ public class AudioConsoleCommandExtension extends AbstractConsoleCommandExtensio
try {
volume = PercentType.valueOf(args[2]);
} catch (Exception e) {
console.println(e.getMessage());
console.println("Specify volume as percentage between 0 and 100");
break;
}
playOnSinks(args[0], args[1], volume, console);
itests/org.openhab.core.audio.tests/src/main/java/org/eclipse/smarthome/core/audio/internal/AudioConsoleTest.java
+2 -1
View File
@@ -140,7 +140,8 @@ public class AudioConsoleTest extends AbstractAudioServeltTest {
fileHandler.wavFileName(), "invalid" };
audioConsoleCommandExtension.execute(args, consoleMock);
waitForAssert(() -> assertThat("The given volume was invalid", consoleOutput, nullValue()));
waitForAssert(() -> assertThat("The given volume was invalid", consoleOutput,
is("Specify volume as percentage between 0 and 100")));
}
@Test