demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2026-07-29 12:34:22 +02:00
Code Issues 1 Packages Projects Releases Wiki Activity

Add utility method to cast profile configurations to specific classes (#5333)

Browse Source 
* Add utility method to cast profile configurations to specific classes
* Replace ProfileContext implementation in ScriptProfileTest by a mock

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
This commit is contained in:
Christoph Weitkamp
2026-02-13 17:47:07 +01:00
committed by GitHub
parent d12b1f8456
commit 15ec1c8aa3
3 changed files with 22 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bundles/org.openhab.core.automation.module.script/src/test/java/org/openhab/core/automation/module/script/profile/ScriptProfileTest.java
+9 -39
View File
@@ -12,24 +12,14 @@
*/
package org.openhab.core.automation.module.script.profile;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.openhab.core.automation.module.script.profile.ScriptProfile.CONFIG_COMMAND_FROM_ITEM_SCRIPT;
import static org.openhab.core.automation.module.script.profile.ScriptProfile.CONFIG_STATE_FROM_ITEM_SCRIPT;
import static org.openhab.core.automation.module.script.profile.ScriptProfile.CONFIG_TO_HANDLER_SCRIPT;
import static org.openhab.core.automation.module.script.profile.ScriptProfile.CONFIG_TO_ITEM_SCRIPT;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
import static org.openhab.core.automation.module.script.profile.ScriptProfile.*;
import java.time.Instant;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ScheduledExecutorService;
import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.jupiter.api.BeforeEach;
@@ -419,32 +409,12 @@ public class ScriptProfileTest extends JavaTest {
}
public ProfileContext build() {
return new ProfileContext() {
@Override
public Configuration getConfiguration() {
return new Configuration(configuration);
}
@Override
public ScheduledExecutorService getExecutorService() {
throw new IllegalStateException();
}
@Override
public List<Class<? extends State>> getAcceptedDataTypes() {
return acceptedDataTypes;
}
@Override
public List<Class<? extends Command>> getAcceptedCommandTypes() {
return acceptedCommandTypes;
}
@Override
public List<Class<? extends Command>> getHandlerAcceptedCommandTypes() {
return handlerAcceptedCommandTypes;
}
};
ProfileContext mockedProfileContext = mock(ProfileContext.class);
when(mockedProfileContext.getConfiguration()).thenReturn(new Configuration(configuration));
when(mockedProfileContext.getAcceptedDataTypes()).thenReturn(acceptedDataTypes);
when(mockedProfileContext.getAcceptedCommandTypes()).thenReturn(acceptedCommandTypes);
when(mockedProfileContext.getHandlerAcceptedCommandTypes()).thenReturn(handlerAcceptedCommandTypes);
return mockedProfileContext;
}
}
}
bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/internal/ProfileContextImpl.java
+5
View File
@@ -56,6 +56,11 @@ public class ProfileContextImpl implements ProfileContext {
return configuration;
}
@Override
public <T> T getConfigurationAs(Class<T> configurationClass) {
return getConfiguration().as(configurationClass);
}
@Override
public ScheduledExecutorService getExecutorService() {
return ThreadPoolManager.getScheduledPool(THREAD_POOL_NAME);
bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/profiles/ProfileContext.java
+8
View File
@@ -38,6 +38,14 @@ public interface ProfileContext {
*/
Configuration getConfiguration();
/**
* Returns the configuration of the profile and transforms it to the given class.
*
* @param configurationClass configuration class
* @return configuration of profile in form of the given class
*/
<T> T getConfigurationAs(Class<T> configurationClass);
/**
* Get a scheduler to be used within profiles (if needed at all)
*