Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
* Provides the ability to specify a timeout in the config, instead of using hardcoded 10 seconds.
Signed-off-by: Geroen Dierckx <geroen.dierckx@gmail.com>
* Use a single numeric type (double), remove ints and floats
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Rebases with master. Fixes All Checkstyle warning, renames package 'model' -> 'dto'
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Prevent possible NPE
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Spotless
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Fixes missing unit information (especially for HmIP devices)
For some HmIP devices the "valueunit" attribute is empty and thus no
default unit type could be derived. Using the data point name solves
this problem (at least for the relevant data points).
Fixes#10533
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Condition result was wrong because of missing brackets
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Regenerated and reorganized descriptions
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Encoding changed to UTF-8 and some smaller text corrections
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Use default value as maximum if is greater than received max value
For some devices the data point definition retrieved from the CCU
contains default values that are higher than the maximum value. In order
to allow the configuration of these config options the allowed maximum
value needs to be set to the default value.
Fixes#10552
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [VENSTAR THERMOSTAT BINDING] ADD AWAY MODE
Signed-off-by: Matthew Davies
matthew.davies@skynet.be
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* [VENSTAR THERMOSTAT] FIXED COMMAND AWAY MODE
Signed-off-by: Matthew Davies
matthew.davies@skynet.be
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE AFTER INITIAL COMMIT FEEDBACK
This code includes the Away mode of the Venstar thermostat. It is
updated following initial feedback and suggestions on my first version
from @digitaldan.
Signed-off-by: Matthew Davies <matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT BINDING - INCLUDE AWAY MODE
Removed the updateThermostat function, now have updateSettings and
updateControls corresponding to local API URLs.
Signed-off-by: Matthew Davies
<matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE - Modification updated as per feedback 1
June 2021
Signed-off-by: Matthew Davies
<matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
* VENSTAR THERMOSTAT AWAY MODE INCLUSION - UPDATED README
Signed-off-by: Matthew Davies <matthew.davies@skynet.be>
Signed-off-by: raveydavies <84205523+raveydavies@users.noreply.github.com>
new channels frequency and power factor.
Signed-off-by: Martin Hubert <github@martin-hubert.de>
Co-authored-by: Martin Hubert <github@martin-hubert.de>
* [velbus] Add new functionality PRESSED and LONG PRESSED and fix bug
New functionality:
Add the the possibility to simulate the PRESSED and LONG PRESSED message of an input.
Module supported with button simulation :
VMB1RYS (button : CH6)
VMB6IN (buttons : CH1 ... CH6)
VMB2PBN, VMB6PBN, VMB7IN, VMB8IR, VMB8PB, VMB8PBU, VMBEL1, VMBEL2, VMBEL4, VMBGP1, VMBGP1-2, VMBGP2, VMBGP2-2, VMBGP4, VMBGP4-2, VMBGP4PIR, VMBGP4PIR-2 (buttons : CH1 ... CH8)
VMBELO, VMBGPOD, VMBGPOD-2 (buttons : CH1 ... CH32)
Fix bug:
The channels names were not correctly assigned to the thing properties. The last channel had the default name, not the one retrieved from the module.
Also-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>
Use the provided planned time for a washing program to set the channel "remaining_program_time_state" when no program is active
Fix#10744Fix#10703
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also-by: Bert Plonus <bert.plonus@miele.com>
Also-by: Martin Lepsy <martin.lepsy@miele.com>
Also-by: Benjamin Bolte <benjamin.bolte@itemis.de>
Signed-off-by: Björn Lange <bjoern.lange@itemis.de>
Previously there was a mismatch between the UIDs used by the handler and
the one actually registered from the XML-file.
This lead to channels not showing up in the UI.
(See https://github.com/openhab/openhab-webui/issues/406 )
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
To avoid the core framework updating automatically an item state while a
command is sent to this item but its handling by the binding is failing
or ignored
Fix#10700
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [homeconnect] Returns an empty list of options for an unsupported program
Fix#10689
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: List.of
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Fix problem with historical Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
* add scheduler to start/stop sending instantaneous consumption
Signed-off-by: Conte Andrea <andrea@conte.com>
* added scheduler also in Initialize() in order to start reading data of a newly discovered thing
Signed-off-by: Conte Andrea <andrea@conte.com>
* removed setActivePowerNotificationsTime() from dispose()
Signed-off-by: Conte Andrea <andrea@conte.com>
* add log in dispose() method
Signed-off-by: Conte Andrea <andrea@conte.com>
* temperatureHotWaterTarget channel is writable
* temperatureTargetHotWater_2 channel doesn't exist in the binding
Signed-off-by: Martin Kurgi <martinkurgi@gmail.com>
* Adapted to new checkstyle
Signed-off-by: Markus Michels <markus7017@gmail.com>
* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"
Signed-off-by: Markus Michels <markus7017@gmail.com>
* #10617 Vibration event added for DW2
Signed-off-by: Markus Michels <markus7017@gmail.com>
* brackets
Signed-off-by: Markus Michels <markus7017@gmail.com>
* some unused stuff/code removed
Signed-off-by: Markus Michels <markus7017@gmail.com>
* [somfytahoma] Open to other portals
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Review comment: suppress the advanced setting for cookie handling
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Fixed ColorTemperature set to UNDEF
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Fixed SAT findings
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Fixed warning during unit tests
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Changed color temperature handling in GroupHandler
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Changed default color mode for color commands to XY
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* [MongoDB Persistence] Rename connectToDatabase to tryConnectToDatabase.
Currently, the implementation throws a RuntimeException.
This fails horribly in query() and store(), because the exception is never caught and connection reestablishment won't happen.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix JavaDoc
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix Bundle name
The correct database name is "MongoDB" without a space.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Also check for connection validity in isConnected()
When the connection was established successfully once, and the server goes down (e. g. a restart of the DB server), the connection still seems to be OK.
This would throw an exception later on, which is not caught and connection reestablishment won't happen.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Disconnect from database before reconnecting to database.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Disconnect from database when connection procedure fails.
When, for example, the creation of the index fails (disk full, ...), the connection is still there, but the collection isn't created with it's appropriate indices.
Thus, disconnect when the procedure fails to ensure no database connection remains valid.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix logic
Create the shared collection with its indices when collectionPerItem is disabled, not enabled.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Access database via getDatabase()
Preparation for synchronization.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove global mongoCollection variable.
This allows to easify implementing necessary multithreading locks.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Codestyle improvements.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Move isConnected-Check into tryConnectToDatabase.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Synchronize all connection handling methods.
Though the MongoDB driver is thread-safe, we still need to synchronize connection establishment/closing/...
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove all unnecessary @NonNullByDefault attributes.
The given attributes should not be NotNullByDefault, because some may be null, too.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove duplicate logging.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Test the db connection after creating the MongoClient.
The mongo always succeeds in creating the connection.
We have to actually force it to test the connection to try to connect to the server.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Fix date query.
Issues:
- Second should have been getEndDate, not getBeginDate
- Send a Date object as the other version wasn't serializable.
- EndDate would have overridden beginDate.
Fixes#10574
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add debug log for MongoDB query sent to the server.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Reorder index on collections.
The order (Item, Timestamp) makes much more sense and should be better for performance.
All queries are always done with an item, and the dates are optional.
Also, the database server can now execute a range query for the date.
Existing indices are not dropped for backwards compatibility with other systems analyzing the data.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add @author JavaDoc as per developer guidelines.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Improve logging
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Add @NonNullByDefault
This was removed in 1f8e4525 by mistake.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Do not use isConnected() to test the connection.
The new method throws the real underlying exception instead of a generic one. This allows for detailed logging.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* [MongoDB Persistence] Remove useless @inheritDoc as per code analysis tool.
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
* Unnecessary NonNull annotations removed
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* Bugfix "If network connection is interrupted, WebThing will not be reconnected." Due to the variable webThingURI is unset, re connection fails
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* webThingURI will be loaded in a lazy way
Signed-off-by: Gregor Roth <gregor.roth@web.de>
Signed-off-by: gregor roth <gregor.roth@web.de>
* Do not discover on ENTRY_MODIFY
ENTRY_MODIFY is triggered on each keypress multiple times, so we should
not trigger on it.
The usecase for ENTRY_MODIFY triggers where detecting permission changes
of the event nodes.
Inotify does have a dedicate event ("ATTRIB") for that but Java
WatchService normalizes this to a ENTRY_MODIFY event
(See LinuxWatchService.java)
After permission changes users now have to trigger a scan manually.
* Use proper representation property
* Show event node in label
This makes it easier to figure out which thing is which device in the
presence of symlinks or multiple identical devices.
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
* Fix broken image & dashboard links in rendered online documentation
* Fix prerequisite version in documentation (do not use milestone version)
Signed-off-by: Robert Bach <openhab@mortalsilence.net>
This change accepts a new message type which is sent by some air ventilation devices durin teach in. This is required for the search feature to detect these devices correctly.
Signed-off-by: David Schumann <david@dev-core.org>
* Accept all Jetty supported http method types
This fixes a number of open issues due to the fact that we were only accepting a limited number of http method types. The effect of this was some functionality like DELETE or HEAD requests would just not work when using the cloud service, which madee our UI look broken in different ways, also it poluted the users log with a lot of messages.
Fixes https://github.com/openhab/openhab-core/issues/2312
Fixes https://github.com/openhab/openhab-cloud/issues/328
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Fixed typo for starting sequence
* Added support for "find me" & "test sound" function
* Added clear names for faults
Signed-off-by: Marcel Bossert-Schwab <mbossertschwab@gmx.de>
Information about how to use Dash Buttons nowadays as Amazon doesn't support them anymore.
Also-by: Wouter Born <github@maindrain.net>
Signed-off-by: Marcel Simat <marcel@freese.name>
* Make clear rfc2217 is supported
* Fix typo
* Update specification link and partial linky support
* Improve wording
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
* Refresh devices after reboot or disconnect
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* Cancel refreshSchdule in dispose. updateStatus messages @text cleanup.
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [velux] break on socket timeout if interrupted flag set
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] pause initialize until pending dispose is done
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] synchronization key is IP address not ThingUID
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging level
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging level, improve user comprehensibility
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] access updateBindingState() externally via static method
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] tweak logging
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] defer refreshBindingInfo until after initialized / disposed
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] refactor method names to show the type of scheduler they run on
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] don't terminate thread early
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] restore calls to updateBindingState
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] logger cosmetics
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] reduce logging levels
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] change logger level
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] synch on ip address object instead of Future<>; make shutdown timeout explicit; disable HSM on shutdown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] add lock modifier, remove duplicate synchronized, refactor HSM shutdown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] shutdown code was not being called
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] don't convert InterruptedException to IOException
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] let shutdown explicity stop the polling loop
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] eliminate once in a blue moon fin-ack fin-ack issues
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Revert "[neohub] eliminate once in a blue moon fin-ack fin-ack issues"
This reverts commit 022513ee85878f2f9cf2fd27fa3d79d251197c5a.
* [neohub] extra hub properties; hub id in logs (help for multiple hubs)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] run spotless
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] getFirmwareVersion returns null for unknown
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] api version enum; tweaked logging
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] fix mvn warning
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] cosmetic for diff
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] device info property, and comments
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] tweaks to fin-ack sequence
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] eliminate irrelevant compiler warnings, and live test errors
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] avert merge conflict with #10525
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [neohub] apply changes in anticipation of reviewer approval
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
