* Fix Offline detection and Improve discovery.
* Motion options bug fix.
* Message content bug fix.
* Fix all handlers to process all chunks as one.
* Remove password from FFmpeg command log.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1.
(cherry picked from commit ad2a1e3635)
Add-ons should not depend on tec.uom.se classes but use core unit classes instead so they are less impacted when this library is replaced or upgraded.
Signed-off-by: Wouter Born <github@maindrain.net>
* Update some of the miot files to the new definition
* Apply units,category & tags for some channels
* apply standard sorting
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [icalendar] Fix race condition while initialization of EventFilterHandler
Should fix#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler.
Also added a bit more output.
* [icalendar] use implicit conversion to string for logging
Signed-off-by: Michael Wodniok <michi@noorganization.org>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] Add discovery from cloud feature.
This allows to discover things that are not directly on the same subnet
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0.
Closes#9208
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [miio] dynamically generate channelTypes
Simplify the json database creation for new models and less chance for
errors
Related to #7276
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] Implement alternative MiIoQuantityTypes
* Improved way avoiding multiple entries for Unit
* Test cases for the MiIoQuantityTypes class
* Apply suggestions from code review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [OpenUV] Correcting incorrect behaviour when UV < 1
and some code enhancements
* Correcting SAT findings
* Initiating bundle localization in French
Signed-off-by: clinique <gael@lhopital.org>
* [irobot] iRobot binding
Supports iRobot Roomba and probably some other iRobots (in parts where they
are compatible)
* [irobot] Drop custom hivemq wrapper
setUnsubscribeOnStop() has been introduced in
org.openhab.core.io.transport.mqtt.MqttBrokerConnection, so it can now handle
iRobot's quirks. The custom wrapper is no more needed, remove it
Signed-off-by: Pavel Fedin <pavel_fedin@mail.ru>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [velux] set explicit timeouts & keepalives on socket
* [velux] implement mdns service
* [velux] fix representation property names
* [velux] fix representation properties
* [velux] finalize mdns
* [velux] spotless
* [velux] use both mDNS and regular DNS to resolve ip addresses
* [velux] complete class rewrite using asynchronous polling thread
* [velux] refactor bridgeDirectCommunicate to simplify looping
* [velux] asynchronous polling means Thread.sleep no longer needed
* [velux] faster synch of actuator changes
* [velux] use single thread executor instead of thread pool
* [velux] faster synch of actuator changes
* [velux] shut down task executor
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Update README.md
* Fix Indentation
* Change comment character from '#' to '//'
* Remove wrong formatting attempts ('rsqb' & 'lsqb')
* Minor changes
* Update README.md
Remove link to the API since website doesn't exist any more.
Signed-off-by: Felix Schneider <fs@felix-schneider.org>
sorry i missed to change the IP of my own config. Thing Configuration was not accepted bei Visual Studio Code, curly brakets were missed and the definition of ThingID<>Thing was not accepted.
* [dynamodb] fix serialization of ZonedDateTime timestamps
Resolves#9156.
AWS SDK does not know how to serialize ZonedDateTime. We resolve this
by providing explicit serializer/deserializer.
In addition, integration tests had issue with timezones. The persistence
converts all timestamps from the DynamoDB to system timezone for display
purposes. This was not taken into account in the tests and failure was
expected with non-UTC system timezone.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [miio] Update channels only if they are linked
With introduction of miot devices with enormous amount of channels
refreshes can become slow. With this change only relevant updates are
done.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Cloud Communication for devices
Allows to define if communication to devices is direct or send via the
Xiaomi cloud.
Introduce additional channel to execute commands via cloud.
Other small improvements
* Use common method from abstract handler to send commands
* Common way to handle custom commands
* Introduce small delay before refreshing robot properties after sending
commands (similar to the basic handler) so devices have time to update
their properties
* [miio] simplify cloudconnector
* [miio] Cleanup all jobs when unloading
* [miio] update to use dedicated ScheduledExecutorService
Use dedicated ScheduledExecutorService to avoid unloading problems
* Update bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoAbstractHandler.java
* [miio] fix for removeif
* miio- Improve scheduler
* [miio] fix communication error if device is not on the network
* [miio] update with comments from feedback
* remove scheduler tracking
* improve status setting for cloud communication
* [miio] update with feedback review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* improvements
- use insecure client and remove TrustManager
- add call list channel
* address review comments
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
The channels 1-3 of LCN-B3I are mapped to binary channels 6-8. This could be anticipated from the Button Tables (B6-8) that it connects to. However, the added comments should help people to save a few hours and some gray hair ;-)
* removed state update if value didn't change so expiry binding can actually - expire. If expire time was larger than refresh interval of the binding, expiration never happened ...
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* [miio] update for vacuum.e2
small update now critical commands are confirmed working.
* [miio] update readme
as dock command is now also confirmed
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* * fixed refresh handing due `channelLinked` not called anymore on startup for example (similar to https://github.com/openhab/openhab-core/issues/1707),
* "Impacted Modules" can be empty if button is configured as "standalone" and does not impact modules,
* minor doc fix
* * check if configured impacted module for `impactedModules` is referencing an existing thing,
* fixed warnings
* Fixed review comment.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* fixed: InterrupedException
* changed: single and group queues to device queue
added: standard volume to speak request
* changed: log from info to debug
* fix compile warnings
* remove dependency on StringUtils
* more improvements
* fix HandlerPowerController
* attempt to solve stopping tts
* logging powercontroller
* fix smarthome devices not updating
* finalize smarthome device update fix
* additional device information logging for discovery
* fix color channel for smarthome devices
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Co-authored-by: Tom Blum <trinitus01@googlemail.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* [openwebnet] Fixed config, handling and discovery of ZigBee devices (fixes#8915 and fixes#8917). Added test for ownID. Now uses openwebnet4j v0.3.2
* [openwebnet] ZigBee: improved handling of wrong 'where' parameter. Updated README. Improved logging.
* [openwebnet] Improved discoveryByActivation to distinguish dimmers from lights. Now using openwebnet4j 0.3.2-1
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* Add some utility classes that will be used by other bluetooth bindings.
* Add handle field to BluetoothDescriptor
Signed-off-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* Max value and format pattern were not correct for dimmers (Fixes#8799)
* Fixed calls to deprecates methods/constructors
* Make sure channelLinked is executed at restart (see also: https://github.com/openhab/openhab-core/issues/1707)
Signed-off-by: Martin Herbst <develop@mherbst.de>
* Refactor to prevent endless loop.
* Allow `-rtsp_transport tcp` to be over-ridden.
* Display actual preset names
* Allow IP to not match due to Hostname given in setup.
* Fix index off by 1
* Bug fixes for HLS
* Compatibility fix for GotoPreset
* Improve default snapshot quality and allow FFmpeg arguments to be
changed.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
* Corrected caddx discovery bug
* Maintenance
- Changed refresh logic for the things
- Code cleanup
- Corrected off by one errors
- Added initial tests for the message parsing
* Corrected ParameterizedTest
* Changed new Date().getTime to System.currentTimeMillis()
Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
* [jablotron] fixed bug when bridge stays offline forever in some cases
* [jablotron] fixed the JA100 channel update bug
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
* Avoid a hidden NPE when getIdentifier() of an uninitialized ThingHandler is called
* Fixed Powerline546EHandler
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.
Also contains a few other improvements:
* fix lastRequest timestamp not updated when sending messages to discover node properties
* use java.time Duration and Instant
* use List.of, Set.of
* remove redundant null suppression because of EEAs
Signed-off-by: Wouter Born <github@maindrain.net>
* [miio] Add support for mijia.vacuum.v2
related issue #9005
* [miio] fix channelTypes based on review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Add sendVideo and sendAnimation features.
* Re-order functions to keep inline with other functions.
* Readme change to trigger new build.
* Add ability to use raw file paths to send video and animations.
* Change Paths.get to Path.of as JavaDocs recommend.
* Allow absolute paths in SendPhoto methods and update readme.md
* Support for no caption with photo.
* Add absolute path support for png and webp.
* Add all file types requested.
* Remove multiple OR and only do lowercase once.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Some enhancements and corrections on the linky binding
spotless apply
Adressing code review comments
* Adressing potential NPR.
* Code review findings correction
* Pleasing SAT checks
Signed-off-by: clinique <gael@lhopital.org>
* Staging work
Saving my work
Vigicrues extensions for OH3
First code review
* Code review and some corrections
* Code review enhancements
Changed alert to Number
* Code review corrections
* Correcting my error
* Adressing SAT finding
Signed-off-by: clinique <gael@lhopital.org>
* [miio] Allow for quantity Type in the basic handler
This extends the miio:basic handler with the option to define channels
with QuantityType e.g. to use number:temperature
* [miio] add missing breaks
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.
Signed-off-by: Wouter Born <github@maindrain.net>
* Add KorbinianP to CODEOWNERS for senechome
* Implement Current, Voltage and Power for all three Phases
* Bugfix last commit, values are inside array
* Implement Grid Frequency
* Fix name of currentGridVoltagePerPhase
* Extend README.md with new parameters
* Implement SenecBatteryStateValue for easier comparison of values in rules
* Implement new statistic data points and battery voltage
batteryVoltage
liveBatCharge
liveBatDischarge
liveGridExport
* Bugfix item types
* Implement Review findings, change channelBatteryStateValue to QuantityType
* Revert change of channelBatteryStateValue from DecimalType to QuantityType
Signed-off-by: Korbinian Probst <kp.droid.dev@gmail.com>
* Properly handle datagrams that are not immediately available so no NPEs are logged on debug
* Properly handle sockets channels that are not connected so no NPEs are logged on debug
* Prevent load/garbage by reusing ByteBuffer and not allocating trace logging strings
Fixes#8932
Signed-off-by: Wouter Born <github@maindrain.net>
* [rrd4j] Improve performance
* Cache item to improve performance
* Also return DecimalType for QuantityType values
Related to #8928
Reintroduces #8809
Signed-off-by: Wouter Born <github@maindrain.net>
Changed some wordings.
-Kept "DataSource" as the term for the way data is stored in a .rrd file. Such is more inline with the used Default Datasources (-numeric, ...).
-Removed the requirement for an everyMinute Strategy, inserted a explanation for relationship between Sample Intervall and Strategy instead.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
* Added Channel for link to latest feed; update rome deoendency to version 1.15
* Removed unsed interface
* Run spotless
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* [snmp] Set thing only online on valid response
Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured).
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Fix index out of bounds when persisting empty StringType values
* Fix deserialization when strings contain type separator
* Improve debug logging
* Improve test coverage
Fixes#8790
Signed-off-by: Wouter Born <github@maindrain.net>
* [icalendar] Describe download exceptions a bit more detailed.
Fixes#8846
* [icalendar] Apply suggestions from code review
Signed-off-by: Michael Wodniok <michi@noorganization.org>
Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
* [miio] delay refresh to avoid devices not ready yet
Delay refresh after command is send as some devices are not ready yet
with the execution and will report wrong status.
This is confusing to the users.
Related forum topic:
https://community.openhab.org/t/xiaomi-mi-air-purifier-xiaomi-mi-io/34840/300
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] remove change from PR
* Update documentation with changed Influx2 RC port
* Fix problem with non decimal numeric types
Improve documentation with more explicit information about Influx types used
Implement toString to InfluxPoint to allow some trace info to be useful in case it's needed
Fixes#8697Fixes#8798
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Additionally:
- documentation has been updated and improved
- logging has been improved for better debugging
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* [MeteoAlerte] Update for OH3
Replaced old gif pictures with svg nicer pictures
Added a missing alert report (vague-submersion)
Added end of validity report timestamp
Some code cleansing.
Signed-off-by: clinique <gael@lhopital.org>
* [lcn] Fix status message of RollerShutter inverting
The status of RollerShutter was not inverted when invertUpDown=true. Fixes#8680
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* Add Groovy scripting support
This makes it really easy to start using Groovy 3.x scripts with openHAB!
Signed-off-by: Wouter Born <github@maindrain.net>
Changed the README.md file to include more information as in #8733:
Specified that the chatId in the APIs must be followed by an "L" or it won't work (at least, not for group chats).
Add support for following types
"mrbond.airer.m1s",
"mrbond.airer.m1pro",
"mrbond.airer.m1super"
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Refactored discovery service to ThingHandlerService
* Fixed discovery for Geofence Sensor
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Remove duplication by making use of default Java generated exceptions
* Make ThingActions labels/descriptions more consistent
Signed-off-by: Wouter Born <github@maindrain.net>
* Remove proxy workarounds
* Move ThingActions and a few other classes into the internal package
* Use more consistent action labels/descriptions
Related to:
* openhab/openhab-core#1714
* openhab/openhab-core#1639
Signed-off-by: Wouter Born <github@maindrain.net>
* [airvisualnode] Support AirVisual Pro version
* [airvisualnode] Autodetect Pro version
* [airvisualnode] Remove unused channels
Signed-off-by: Oleg Davydyuk <ilveann@gmail.com>
* [miio] eliminate warning org.apache.commons.io.FileUtils in readmemaker
Eliminate
[WARNING] org.openhab.binding.miio.internal.ReadmeHelper.java:[25]
The package org.apache.commons.io.FileUtils should not be used.
* [miio] add StandardCharsets.UTF_8 to file readwrite
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Improved unsupported handler that build experimental support
New unsupported handler that tries to find channels for unsupported
devices and creates experimental database file for it.
* [miio] logger fixes
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Fix memory leak in SNMP. When receiving an async request it is placed in a pending request queue. Not canceling it leads to infinty life cycle for those requests, filling up memory.
* Test the canceling of the snmp aync request by its handler.
Signed-off-by: Falk Bauer <falk.bauer@k-is.com>
Applied the changes found by spotless.
According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the 4th was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
According the comments DEFAULT_NUMERIC, DEFAULT_QUANTIFIABLE config should have 5 archives, the 4th was missing. Additionally the ConsolFunction changed in the DEFAULT_QUANTIFIABLE.
The DEFAULT_OTHER config had false computed archives.
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
* [miio] allow for device remarks in the readme from json db
* Update bundles/org.openhab.binding.miio/src/test/java/org/openhab/binding/miio/internal/ReadmeHelper.java
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com
* Configures XStream security to prevent "Security framework of XStream not initialized, XStream is probably vulnerable" warnings.
* Resolves the itest bundles for the upgrade to XStream 1.4.13
Related to openhab/openhab-core#1688
Signed-off-by: Wouter Born <github@maindrain.net>
* add representationProperty to thing definition to make it OH3 compatible
* adapted to OH3 (representationProperty added to thing definition)
* as always...spotless:apply :-(
Signed-off-by: Markus Michels <markus7017@gmail.com>
* OH3 adaption - fixes small issues when running on OH3
* #8612: Fix total consumption for RGW2+Roller
* #8492: Shelly Plug US
* 2 more immediate = true catched and removed
* spotless applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* [miio] enable telnet for lumi gateway
* allow enable telnet and some other functions on gateway
* use new fw as default for chugmi plug
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
+ Bug fix: Recording to GIF would only record for 5 seconds.
+ Clean up readme to remove channels and configs that don't exist after
moving to actions.
+ Compatibility fix for http headers.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Swagger upgrade for the Netatmo binding (required to use the OAS 3 Swagger annotations, the old annotations dependencies were removed with OpenHAB 3)
- Swagger-Codegen updated to the latest version (to generate the OAS 3 Swagger annotations)
- Retrofit replaced by the default code generation (Retrofit 1 code generation is broken with newer swagger-codegen versions and an update to Retrofit 2 is also incompatible and would require more dependencies)
- NULL handling for collections introduced (newer versions of the Swagger codegen return NULL for empty collections instead of an empty collection ...)
- The binding is now working completely again (compiles and starts), but there are still some TODOs
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
sven.strohschein@gmail.com>
Upgrades the compiler and its dependencies so the compiler results of Maven builds are more similar to those generated in recent Eclipse versions.
To fix compilation issues in Eclipse for add-ons using classes from javax.xml.stream several dependencies were upgraded/excluded.
Signed-off-by: Wouter Born <github@maindrain.net>
* Fix issue with All Mute and extra source options
* Add channel to select preset favorite
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Improve exception handling of the embedded MQTT broker so the port can be reconfigured when it is already bound and it properly unlocks files
* Rework MQTT integration tests so they each run the embedded broker on their own reserved port
Signed-off-by: Wouter Born <github@maindrain.net>
Fixed 3 bugs:
- Network bridge not listening on bus
- Reconnection handler keeps reconnecting even after a successful reconnection
- Minor typo in alarm wakeup time channels
Signed-off-by: Cedric Boon <cedric.boon@hotmail.com>
In case of the parameters & response are not equal avoid the
java.lang.IndexOutOfBoundsException: Index: 4, Size: 4
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
The handleUpdate method was deprecated when profiles were introduced (see eclipse-archived/smarthome#4108).
Instead the "follow profile" can be used which forwards item updates as commands to handlers.
This profile works with any binding instead of only those that implement the handleUpdate method.
Related to openhab/openhab-core#1669
Signed-off-by: Wouter Born <github@maindrain.net>
This should make it easier to fix these broken add-ons and the PRs that fix them will then not contain all these changes which make them easier to review.
Signed-off-by: Wouter Born <github@maindrain.net>
