* [modbus] gainOffset and bitMask profiles for working with modbus data
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README trailing whitespaces
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README and some final renaming
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] log error with incompatible units
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: test for incompatible unit
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] example renamed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused fields
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: make configuration parameters optional
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] xml indentantion fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static code analysis fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Minor fixes for null checking
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] remove comment
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile README disclaimer with many commands
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Grammar fixes in README
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix bit profile UI configuration
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Bit profile: Added possibility to invert value on read/write
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix typo with explanation of inverted
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile: unit tests for inverted parameter
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static checker fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] write bit feature in data thing
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* wip
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] resolve itest
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix data thing readStart validation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] readme fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Invalidate REFRESH data cache with cacheful writes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] cleanup
- abort if command is not convertible to 0/1 (previously wrote the
cached data)
- fail fast conditionals instead of deep if's
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README Fix typo in example
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix data thing write when child of endpoint
Also added regression test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/config/gainOffset.xml
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [modbus] performance-optimized logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README: Removing xtend syntax hint, not needed anymore
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] generics typing added
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] dead code
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] avoid supressing generic type warnings
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] unnecessary generics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] rename type parameter name
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] QU (short for quantity output) generic type instead of Q2
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused localization
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] profile constant visibility harmonized
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
No need to list transitive test dependencies, they are pulled in
automatically. Exception with sqlite4java shared libraries which are
needed for runtime.
With the update of DynamoDBLocal, tests require newer version of jetty
(9.4.18.v20190429), resolving #10502
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Update to SDKv2 Enhanced Client
In addition, introduce new more simple table layout, having only one
table for all items and with more efficient data encoding (saves some read capacity).
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Time To Live (TTL) support with new table schema
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Support QuantityType
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] suppress null warnings in tests
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Optimized query performance
Similar to https://github.com/openhab/openhab-addons/pull/8938,
avoid calling Item.getUnit() repeatedly when querying data.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Support for Group items
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Update copyright to 2021
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Removing TODO comments and add javadoc
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] javadoc
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Readability improved in TableCreatingPutItem
Also documenting the full retry logic.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] verify fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove slf4j from explicit dependencies
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove jackson from pom.xml, add as feature dep
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd.importpackage tuned
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] abort query() immediately if not configured to avoid NPE
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less chatty diagnostics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] xml formatting
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] corrected logger class
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] null checks
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] netty client configured
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd not to filter out importpackage org.slf4j.impl
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] cfg bundle group id
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove usage of org.apache.commons
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Remove extra prints from test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Reducing @SupressWarnings with generics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] README extra space removed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] spotless
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Removed unnecessary logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] encapsulation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] removed unnecessary NonNullByDefault({}) ctr-injected field
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] null annotations
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less verbose logging in tests
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Prefer Collections.emptyList over List.of()
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] less verbose call
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Visitor to return values (simplifies the code)
Less warnings suppressed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] comments for remaining warning supressions
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] README tuning, typo fixing
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Using less verbose syntax
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] simplified logging on errors
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Code review comments
Avoiding null checker while having more compact code
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] Null safety
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] configuration label and description formatting
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] xml indentation with tabs
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] @Nullable 1-line annotation with class fields
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] No need to override credentials per request
Client has the credentials set on build time
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] set API timeouts no matter what
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] adding exception message
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] static logger
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] dependency
- comments clarifying the logic of properties
- adding netty to dep.noembedding to ensure it is not compiled in
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] ensure correct jackson and netty versions using dependencyMgt
Specifically for development and testing
See https://github.com/openhab/openhab-addons/commit/051c764789aa27758c93627037a507bb6afb04e1
for further discussion why this is needed.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] avoid google collections
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] jackson-dataformat-cbor not jackson-cbor
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] also restrict netty-transport-native-epoll linux-x86_64 version
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] refering dynamodb.cfg similar to other bundles
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] bnd.importpackage to excl. reactivestreams and typesafe.netty
These are compiled-in dependencies, and thus we do not want to have them in
OSGi Import-Package.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.persistence.dynamodb/src/main/resources/OH-INF/config/config.xml
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.persistence.dynamodb/src/main/resources/OH-INF/config/config.xml
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [dynamodb] remove netty-codec-http2 as it is included in tp-netty
See https://github.com/openhab/openhab-core/pull/2257/
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] removed duplicate in bnd.importpackage
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] slf4j-api marked as provided to remove dep errors in runtime
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [modbus] More strict nullness. Remove apache.commons.lang from itests
* [modbus] Defaults for tcp and serial things according to docs
* [modbus] further explicit defaults
* [modbus] document default encoding for serial.
RTU is pretty much the only one used in the field.
Previous default was ascii implicitly.
* [modbus] verify defaults are used for undefined configuration parameters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Cascaded transforms with ∩
* [modbus] README to mention cascaded transformations
* [modbus] Take cascaded transformation into use
* [modbus] README to show preference towards new syntax
* [modbus] examples to use new syntax
* [modbus] fix test
* [modbus] remove apache commons lang dependency
- see also PR #10002
- I removed equals and hashCode implementation all-together, I could not see they played any role in practice.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [dynamodb] fix serialization of ZonedDateTime timestamps
Resolves#9156.
AWS SDK does not know how to serialize ZonedDateTime. We resolve this
by providing explicit serializer/deserializer.
In addition, integration tests had issue with timezones. The persistence
converts all timestamps from the DynamoDB to system timezone for display
purposes. This was not taken into account in the tests and failure was
expected with non-UTC system timezone.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sami SalonenandGitHub
