Zepp OS: Request only supported config groups

This commit is contained in:
José Rebelo
2025-06-29 16:23:20 +01:00
parent c619506057
commit ba1c9ddf2f
2 changed files with 3 additions and 11 deletions
@@ -862,8 +862,6 @@ public class ZeppOsSupport extends AbstractDeviceSupport
communicator.requestDeviceInfo(builder);
}
final ZeppOsCoordinator coordinator = getCoordinator();
for (AbstractZeppOsService service : mServiceMap.values()) {
if (mSupportedServices.contains(service.getEndpoint())) {
// Only initialize supported services
@@ -137,7 +137,6 @@ public class ZeppOsConfigService extends AbstractZeppOsService {
@Override
public void initialize(final ZeppOsTransactionBuilder builder) {
write(builder, CMD_CAPABILITIES_REQUEST);
requestAllConfigs(builder);
}
@Override
@@ -276,12 +275,13 @@ public class ZeppOsConfigService extends AbstractZeppOsService {
return;
}
final ZeppOsTransactionBuilder builder = createTransactionBuilder("configs request");
for (int i = 0; i < numGroups; i++) {
final ConfigGroup configGroup = ConfigGroup.fromValue(payload[3 + i]);
LOG.debug("Got supported config group {}: {}", String.format("0x%02x", payload[3 + i]), configGroup);
requestConfig(builder, configGroup);
}
// TODO: We should only request supported config groups
builder.queue(getSupport());
}
private boolean sentFitnessGoal = false;
@@ -338,12 +338,6 @@ public class ZeppOsConfigService extends AbstractZeppOsService {
}
}
public void requestAllConfigs(final ZeppOsTransactionBuilder builder) {
for (final ConfigGroup configGroup : ConfigGroup.values()) {
requestConfig(builder, configGroup);
}
}
public void requestConfig(final ZeppOsTransactionBuilder builder, final ConfigGroup config) {
requestConfig(builder, config, true, ZeppOsConfigService.ConfigArg.getAllArgsForConfigGroup(config));
}