demus/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge.git synced 2026-07-31 07:44:24 +02:00
Code Issues 1 Packages Projects Releases Wiki Activity

Timers: use fixed delay instead of fixed rate

Browse Source 
from lint:
Use of scheduleAtFixedRate is strongly discouraged because it can lead to unexpected behaviour when Android processes become cached (tasks may unexpectedly execute hundreds or thousands of times in quick succession when a process changes from cached to uncached).
This commit is contained in:
Thomas Kuehne
2025-07-06 09:43:30 +02:00
parent 63ee2fcf5c
commit 46d3f461e9
6 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/charts/LiveActivityFragment.java
+1 -1
View File
@@ -323,7 +323,7 @@ public class LiveActivityFragment extends AbstractActivityChartFragment<ChartsDa
private ScheduledExecutorService startActivityPulse(int interval) {
ScheduledExecutorService service = Executors.newSingleThreadScheduledExecutor();
service.scheduleAtFixedRate(new Runnable() {
service.scheduleWithFixedDelay(new Runnable() {
@Override
public void run() {
FragmentActivity activity = LiveActivityFragment.this.getActivity();
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/SleepAsAndroidSender.java
+1 -1
View File
@@ -123,7 +123,7 @@ public class SleepAsAndroidSender {
stopTracking();
accDataScheduler = Executors.newSingleThreadScheduledExecutor();
accDataScheduler.scheduleAtFixedRate(new Runnable() {
accDataScheduler.scheduleWithFixedDelay(new Runnable() {
@Override
public void run() {
aggregateAndSendAccelData();
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/HuamiSupport.java
+2 -2
View File
@@ -1512,7 +1512,7 @@ public abstract class HuamiSupport extends AbstractBTLESingleDeviceSupport
int loopInterval = getFindDeviceInterval();
LOG.info("Sending find device, interval: " + loopInterval);
findDeviceLoopTimer = new Timer("Huami Find Loop Timer");
findDeviceLoopTimer.scheduleAtFixedRate(new TimerTask() {
findDeviceLoopTimer.schedule(new TimerTask() {
@Override
public void run() {
sendFindDeviceCommand(true);
@@ -1998,7 +1998,7 @@ public abstract class HuamiSupport extends AbstractBTLESingleDeviceSupport
currentButtonTimerActivationTime = currentButtonPressTime;
LOG.info("Activating button timer");
buttonActionTimer = new Timer("Huami Button Action Timer");
buttonActionTimer.scheduleAtFixedRate(new TimerTask() {
buttonActionTimer.schedule(new TimerTask() {
@Override
public void run() {
processButtonAction();
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/zeppos/ZeppOsSupport.java
+1 -1
View File
@@ -778,7 +778,7 @@ public class ZeppOsSupport extends AbstractDeviceSupport
private ScheduledExecutorService startRawSensors() {
ScheduledExecutorService service = Executors.newSingleThreadScheduledExecutor();
service.scheduleAtFixedRate(new Runnable() {
service.scheduleWithFixedDelay(new Runnable() {
@Override
public void run() {
if (rawSensor) {
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/jyou/RealtimeSamplesSupport.java
+1 -1
View File
@@ -42,7 +42,7 @@ public abstract class RealtimeSamplesSupport {
return; // already running
}
realtimeStorageTimer = new Timer("JYou Realtime Storage Timer");
realtimeStorageTimer.scheduleAtFixedRate(new TimerTask() {
realtimeStorageTimer.schedule(new TimerTask() {
@Override
public void run() {
triggerCurrentSample();
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/miband/RealtimeSamplesSupport.java
+1 -1
View File
@@ -53,7 +53,7 @@ public abstract class RealtimeSamplesSupport {
return; // already running
}
realtimeStorageTimer = new Timer("Mi Band Realtime Storage Timer");
realtimeStorageTimer.scheduleAtFixedRate(new TimerTask() {
realtimeStorageTimer.schedule(new TimerTask() {
@Override
public void run() {
triggerCurrentSample();