demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-11 13:41:53 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity
1ac2e8978b
openhab-core/bundles
History
Markus Rathgeb 1ac2e8978b automation: remove specific handling for CompositeModuleHandlerFactory (#764) 
The member variable "compositeFactory" that holds the
"CompositeModuleHandlerFactory" instance is set in the activation method
by calling the constructor of of "CompositeModuleHandlerFactory".
This reference is destroyed and unset in the deactivate method.

There exists DS managed multiple optional references to
"ModuleHandlerFactory".
The "add" logic does not touch the "compositeFactory" variable.
The "remove" logic checks if the given service reference is a
"CompositeModuleHandlerFactory" and unsets the "compositeFactory" member
variable.

If e.g. a module handler factory is injected that also implements the
CompositeModuleHandlerFactory the CompositeModuleHandlerFactory created
by the activate method is still be used. If that specific module handler
factory is removed again, the variable "compositeFactory" is unset and
there is NO CompositeModuleHandlerFactory present anymore.

There are two options:
* The instance created in the activate method should be used as long as
  no other one is injected.
* The instance created in the activate method should be used all the
  time.

The whole code base does not contain another specific implementation for
CompositeModuleHandlerFactory, so there is no (at least in openHAB Core)
change that a CompositeModuleHandlerFactory is injected.

So instead of adding a non deterministic usage of "some" composite
module handler factory (which will require a fix of the "set module
handler factory method" and some others), let's drop the buggy code in
the "remove module handler factory" and use the manually created
composite module handler factory all the time.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-04-28 16:19:06 +02:00
..
org.openhab.core Added i18n feature for dynamic state descriptions (#655) 2019-04-26 12:54:40 +02:00
org.openhab.core.audio Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.auth.jaas Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.auth.oauth2client Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.automation automation: remove specific handling for CompositeModuleHandlerFactory (#764) 2019-04-28 16:19:06 +02:00
org.openhab.core.automation.module.media Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.automation.module.script remove build path entries for non-existent folders (#716) 2019-04-14 09:55:32 +02:00
org.openhab.core.automation.module.script.rulesupport Sort by filename instead of path (#724) 2019-04-18 20:15:50 +02:00
org.openhab.core.automation.rest Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.binding.xml Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.boot Configure LanguageServer exit behavior (#742) 2019-04-17 06:52:42 +02:00
org.openhab.core.compat1x Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.core Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.discovery Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.discovery.mdns Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.discovery.upnp Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.discovery.usbserial Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.discovery.usbserial.linuxsysfs Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.dispatch Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.serial Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.config.xml Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.extension.sample Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.id Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.console Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.console.eclipse Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.console.karaf differ between min. karaf version (OSGi) und karaf compilation tooling (#740) 2019-04-16 22:41:27 +02:00
org.openhab.core.io.console.rfc147 Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.http Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.http.auth Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.http.auth.basic Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.jetty.certificate Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.monitor Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.net Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.auth Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.core Added i18n feature for dynamic state descriptions (#655) 2019-04-26 12:54:40 +02:00
org.openhab.core.io.rest.log Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.mdns Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.optimize Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.sitemap Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.rest.sse drop blocking async SSE implementation (#754) 2019-04-25 20:05:22 +02:00
org.openhab.core.io.rest.voice Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.dbus Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.mdns Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.mqtt Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.serial Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.serial.javacomm Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.serial.rxtx Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.serial.rxtx.rfc2217 Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.io.transport.upnp Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.karaf differ between min. karaf version (OSGi) und karaf compilation tooling (#740) 2019-04-16 22:41:27 +02:00
org.openhab.core.model.codegen Updated NOTICE files to openHAB (#578) 2019-02-15 10:46:18 +01:00
org.openhab.core.model.core Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.item Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.item.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.item.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.lazygen Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.lsp Configure LanguageServer exit behavior (#742) 2019-04-17 06:52:42 +02:00
org.openhab.core.model.persistence Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.persistence.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.persistence.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.rule Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.rule.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.rule.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.script Import SmartHomeUnits in Script Scope (#745) 2019-04-18 21:45:33 +02:00
org.openhab.core.model.script.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.script.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.sitemap Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.sitemap.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.sitemap.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.thing Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.thing.ide Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.model.thing.runtime Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.persistence Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.scheduler Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.semantics Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.storage.json Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.storage.mapdb mapdb storage: minor cleanups (#707) 2019-04-09 21:23:25 +02:00
org.openhab.core.test Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.test.magic Added i18n feature for dynamic state descriptions (#655) 2019-04-26 12:54:40 +02:00
org.openhab.core.thing Added i18n feature for dynamic state descriptions (#655) 2019-04-26 12:54:40 +02:00
org.openhab.core.thing.xml Channel groups should not require static channels (#696) 2019-04-08 21:44:52 +02:00
org.openhab.core.transform Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.ui Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.ui.icon Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
org.openhab.core.voice Ignore and remove Eclipse project specific settings (#677) 2019-03-26 13:04:09 +01:00
pom.xml Attach source JARs without forking to fix Jenkins warnings (#741) 2019-04-17 06:55:41 +02:00