demus/openhab-core
1
0
Fork 0
mirror of https://github.com/danieldemus/openhab-core.git synced 2025-01-25 19:55:48 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity
2,150 Commits 1 Branch 0 Tags 39 MiB
ee6d7b39b2
Commit Graph

54 Commits

Author SHA1 Message Date
Wouter Born
3c6d855d4b
Remove redundant public and abstract modifiers from interfaces (#3560) 
* Remove redundant public modifiers from interfaces
* Remove redundant abstract modifiers from interfaces

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-04-20 20:22:58 +02:00
Holger Friedrich
769aa562a1
Code cleanup: Use Java 17 features (#3522) 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
 2023-04-16 21:43:59 +02:00
Wouter Born
4851bfbcae
Fix recently introduced SAT issues (#3516) 
* Fix recently introduced SAT issues

Signed-off-by: Wouter Born <github@maindrain.net>
 2023-04-01 17:18:22 +02:00
J-N-K
07e8ff56c7
Prevent duplicate events in WatchService (#3404) 
On Samba shares a single MODIFY event may result in different sequences of CREATE/DELETE/MODIFY events. Unfortunately this is not properly handled by the underlying library and we have to re-introduce our ugly workaround. The solution itself is a bit improved over the old one as it not only keeps the last event but determines the correct event by examining the sequence of received events.

Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-03-05 09:44:23 +01:00
J-N-K
7f113c51bc
Refactor WatchService (#3004) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-02-12 14:12:22 +01:00
J-N-K
8d64ecfd8d
Update license header to 2023 (#3294) 
* Update license header to 2023

Signed-off-by: Jan N. Klug <github@klug.nrw>
 2023-01-03 09:45:42 +01:00
Wouter Born
687688db7e
Update Eclipse .classpath files (#3250) 
Also adds some missing files for recently added projects.

Signed-off-by: Wouter Born <github@maindrain.net>
 2022-12-22 14:14:35 +01:00
J-N-K
3fc4d23734
Fix spotless and resolve itests (#3239) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2022-12-19 11:09:31 +01:00
openhab-bot
35254b3a0a [unleash-maven-plugin] Preparation for next development cycle. 2022-12-18 23:08:22 +00:00
Kai Kreuzer
61fd47c853
Apply spotless and resolver (#3018) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2022-06-27 13:41:28 +02:00
openhab-bot
8944bdbbe4 [unleash-maven-plugin] Preparation for next development cycle. 2022-06-26 16:37:00 +00:00
Wouter Born
92917946d4
Add even more null annotations (#2752) 
This PR adds even more missing null annotations which did not fit in #2742 as it grew too big.

Signed-off-by: Wouter Born <github@maindrain.net>
 2022-02-17 21:30:51 +01:00
J-N-K
ea6f21f74d
allow multiple listeners for same directory in WatchService (#2724) 
Signed-off-by: Jan N. Klug <github@klug.nrw>
 2022-02-07 10:14:41 +01:00
Christoph Weitkamp
cabb3f7315
Update license headers to 2022 (#2671) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2022-01-07 13:16:42 +01:00
Kai Kreuzer
e3b07782b4
pom reference update from http to https (#2644) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-12-23 22:55:20 +01:00
Kai Kreuzer
1ebf7395d9 Apply spotless 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-12-20 06:59:22 +01:00
openhab-bot
5ac05c4968 [unleash-maven-plugin] Preparation for next development cycle. 2021-12-19 21:49:34 +00:00
Kai Kreuzer
5a667cc868 applied spotless 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2021-06-27 23:22:02 +02:00
jenkins
b8d2077805 [unleash-maven-plugin] Preparation for next development cycle. 2021-06-27 15:50:02 +00:00
Wouter Born
05b7ec86f1
Fix new SAT findings (#2291) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2021-04-14 18:41:07 +02:00
Wouter Born
774b9d607b
Update license headers to 2021 (#2041) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2021-01-01 16:43:46 +01:00
Wouter Born
bf14e1077f
Apply Spotless, resolve itest runbundles for 3.1.0 (#1982) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-22 10:01:42 +01:00
jenkins
965531696b [unleash-maven-plugin] Preparation for next development cycle. 2020-12-20 22:24:39 +00:00
Wouter Born
0281c10036
[infrastructure] add external null-annotations (#1775) 
Add EEAs and fix null analysis errors.

Related to:

* #888
* openhab/openhab-addons#8848

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-11-03 21:33:48 +01:00
Wouter Born
057604cc2d
Use new Collection API methods (#1598) 
Using the new methods there will be less and more readable code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-22 23:04:11 +02:00
Kai Kreuzer
0f134996f2
removed boot bundle (#1559) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-07-24 13:11:56 +02:00
Kai Kreuzer
e37c28cfc9
[dsl] Model loading improvements (#1514) 
* Model loading improvements

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-06-09 09:37:47 +02:00
Christoph Weitkamp
b7ab807078
Model refactoring, UTF-8 (#1423) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-06-05 20:25:49 +02:00
Christoph Weitkamp
8808f04c30
Removed dependency on 'org.apache.commons.io' (#1441) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-21 15:17:00 +02:00
Christoph Weitkamp
5e8d7554d8
Avoid UnsupportedEncodingException & use const from StandardCharsets (#1480) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-20 21:40:49 +02:00
Wouter Born
61e17ce39e
Upgrade SAT and Spotless, apply Spotless and enable check (#1446) 
* Update SAT and Spotless dependencies
* Apply Spotless and enable check

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-26 11:15:24 +02:00
Christoph Weitkamp
d371a34321
Removed dependency on 'org.apache.commons.lang' (#1433) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-22 14:32:31 +02:00
Wouter Born
92027ca922
Use .equals() on constants and literals to prevent NPEs (#1420) 
* Use .equals() on constants and literals to prevent NPEs

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-16 07:40:49 +02:00
Christoph Weitkamp
79523d3a99
Removed usage of org.apache.commons.lang.ArrayUtils (#1357) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-02-07 13:42:18 +01:00
Wouter Born
18d0a52d02 Switch to Java 11 and drop Java 8 support (#1305) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-12 22:32:28 +01:00
Wouter Born
9d0cb4d9af Fix FolderObserver configuration PID (#1315) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-03 08:06:28 +01:00
Wouter Born
3811cb9560 Update copyright headers to 2020 (#1309) 
* Update copyright headers to 2020

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-01 18:06:34 +01:00
Christoph Weitkamp
800956598b Applied spotless formatter (#1302) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-30 22:55:19 +01:00
Christoph Weitkamp
59675788e0 Renamed packages 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-28 12:18:16 +01:00
Christoph Weitkamp
fca7c215a5 Moved files to new location 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-28 12:18:16 +01:00
jenkins
bc6a380297 [unleash-maven-plugin] Preparation for next development cycle. 2019-12-15 14:55:36 +00:00
Christoph Weitkamp
e85e1a6f44 Removed dependency on 'org.apache.commons.collections' (#1244) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-28 18:43:10 +01:00
Wouter Born
be69d2254e Use !isEmpty() instead of "size() > 0" or "size() != 0" (#1155) 
* Use !isEmpty() instead of "size() > 0" or "size() != 0"

!isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-21 09:00:52 +02:00
Christoph Weitkamp
91617d8af8 Fixed POM XML Shema Definition path (#1119) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-12 08:52:16 +02:00
Wouter Born
12e8edc039 Use diamond operator (#1114) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-11 02:29:47 -07:00
Wouter Born
3d52c72a91 Fix SAT AuthorContributionDescriptionCheck findings (#1110) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-10 11:36:05 +02:00
Wouter Born
12b3c1030f Fix SAT "Initial contribution" warnings (#1100) 
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-07 21:25:40 -07:00
Markus Rathgeb
f881ef87f1 model: prevent simultan access of singleton (#773) 
The singleton instance of "Diagnostician" is used without
synchronization.
The singleton "Diasnostician" instance is using the singleton
"EValidator.Registry" instance (without synchronization).
In very rare high load situations there has been CME detected.

My first "solution" has been to synchronize the access of
Diagnostician's instance method by using

```java
synchronized (Diagnostician.INSTANCE) {
    ...
```

But after realize that EMF is using internally other singletons I tried
to find any information about EMF and thread safety.

I found this one: https://javahacks.net/2016/07/13/emf-thread-safety/

  EMF models are not thread-safe by default and writing multithreaded
  applications is not that simple.
  The more complex our application became, the more often we got
  concurrent modification exceptions and had problems with filtering and
  sorting operations.

So, I assume instead of adding synchronizations to our code that is
using EMF (IIRC this has been already done on the ESH hosted code base
long time ago) we should try to execute EMF code in a safe manner.

This implementation adds a "SafeEMF" OSGi service that should be used to
execute EMF code to ensure none code of EMF (or at least the ones that
calls has been migrated to the SafeEMF usage) is accessed by separate
threads at the same time.

Related to: https://github.com/openhab/openhab-core/issues/772

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-05-01 23:19:07 +02:00
Wouter Born
cbb96945f0 Ignore and remove Eclipse project specific settings (#677) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-03-26 13:04:09 +01:00
Wouter Born
48d873a32b Use openHAB license headers (#632) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-03-06 16:10:00 +01:00