Commit Graph

236 Commits

Author SHA1 Message Date
David Gräff
e508e8e4af ConfigDescriptionParameter: javadoc getContext() (#623)
Improve javadoc by explaining the different defined context values. 
I have added "rule", "channel", "channeltype" and "cronexpression" as those are used within the automation module.
The i18n service uses "location" as context value and expects a map to be rendered.

Signed-off-by: davidgraeff <david.graeff@web.de>
2019-03-05 12:59:08 +01:00
Markus Rathgeb
bf4eac7d78 migrate tests for storage.json (#624)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-03-05 11:53:02 +01:00
David Gräff
4c9a5aa291 [Automation] GenericCronTrigger (#622)
A cron trigger module is actually not that "Generic" and a useful trigger type for a lot of rules.

Therefore I suggest to remove the visibility "HIDDEN" with this PR.
I have also added a context "cronexpression" to the TEXT configuration value, so that UI's can offer a cron expression
selection widget.
(we currently have: 'time','item','script','channel','dayOfWeek','rule')

Signed-off-by: davidgraeff <david.graeff@web.de>
2019-03-05 06:46:48 +01:00
David Gräff
eacb019e39 [Automation] DayOfWeekCondition (#621)
Remove inconsistent visibility "PUBLIC". This value is not documented (there is only HIDDEN and VISIBLE) and this is the only module type that uses PUBLIC instead of just not setting this value at all.

Signed-off-by: davidgraeff <david.graeff@web.de>
2019-03-04 11:19:47 +01:00
Kai Kreuzer
2d92336d72 added Guava version constraint
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-03-04 09:08:09 +01:00
Kai Kreuzer
227707c67a made package imports explicit
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-03-04 09:08:09 +01:00
Hilbrand Bouwkamp
caa9b71c21 Added new parent class for units to fix import problems. (#618)
The change with unit classes parent (#617) causes it to report missing imports of tec.uom.se when using static import. Before the change this was not a problem because the parent class was SmartHomeUnits. This change adds a new parent class for all units.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-03-02 14:26:01 +01:00
Hilbrand Bouwkamp
4517f3959b Added standard gravity and dBm units.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-03-01 23:50:13 +00:00
Hilbrand Bouwkamp
21bf4d9ef0 Reordered units alphabetical, changed extends on SmartHomeUnits
The classes ImperialUnits and SIUnits both extended SmartHomeUnits. But the classes are used a singletons.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-03-01 23:50:13 +00:00
Markus Rathgeb
45858f2dd2 model.core: respect OSGi lifecycle (#592)
Fixes: https://github.com/openhab/openhab-core/issues/591

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-21 10:13:54 +01:00
Gaël L'hopital
32bee0e22c Small UoM evolutions (#588)
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
2019-02-20 09:41:29 +00:00
Kai Kreuzer
fb0470c6d1 removed dashboard bundle as it has moved to https://github.com/openhab/openhab-webui (#586)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-02-20 05:37:41 +00:00
Hilbrand Bouwkamp
09e2292a58 Replaces 'Eclipse SmartHome' with 'openHAB' in text (#581)
Adapted CONTRIBUTING.md file.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-02-15 10:46:37 +01:00
Hilbrand Bouwkamp
d342afbc4e Updated NOTICE files to openHAB (#578)
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2019-02-15 10:46:18 +01:00
David Gräff
ee466da9bc [automation] Unify types - itemsActions (#579)
Unify types - Second try
See also types in automation/moduletypes/ItemTriggers.json

Signed-off-by: davidgraeff <david.graeff@web.de>
2019-02-15 09:31:11 +00:00
Markus Rathgeb
e9a3701417 migrate tests for model.thing
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-14 14:22:33 +01:00
Markus Rathgeb
fa8a368873 handle different possible service PID types (#560)
* handle different possible service PID types

The property value "service.pid" can use different types:
* String
* String[]
* Collection of String

Only "String" has been supported.

https://github.com/openhab/openhab-core/pull/557 adds support for
String[]

https://github.com/openhab/openhab-core/pull/559 removes the support for
String[] again and adds support for the Collection type List only.

This commit ensures that String arrays and every collection type is
supported, regardless which (valid) type is used by the OSGi framework
implementation.

Fixes: https://github.com/eclipse/smarthome/issues/6710

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-13 17:09:32 +01:00
Markus Rathgeb
afd1770da2 ensure rules can access joda time packages (#572)
Fixes: https://github.com/openhab/openhab-core/issues/553

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-13 09:29:53 +01:00
Markus Rathgeb
04bbd2e847 remove obsolete plugin configuration (#573)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-13 09:26:27 +01:00
Henning Treu
3c8e3efa93 Extend ChannelType by command options (#540)
This addresses https://github.com/eclipse/smarthome/issues/5099 by adding a command description with command options along with the state description.
Command options will give a hint to UIs about the specific commands a channel provides. Command options could be rendered as a drop down and also represent the current state or rendered as push buttons to simply send a command to the ThingHandler.
The infrstructure basically copies the StateDescription infrastructure with CommandDescriptionProviders and an `DynamicCommandDescriptionProvider` interface for bindings to hook in and provide dynamic command options.

Signed-off-by: Henning Treu <henning.treu@googlemail.com>
2019-02-12 13:41:01 +00:00
Markus Rathgeb
2535d3dd50 make optional import that's optionally used by Class.forName (dbus lib) (#562)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-11 18:19:47 +01:00
Kai Kreuzer
0197896f5f check for lists instead of arrays (#559)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-02-11 05:03:42 +00:00
Kai Kreuzer
e96aa523fc handle arrays for pids (#557)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-02-10 20:57:23 +00:00
Kai Kreuzer
4d9de63ca6 added missing versions for features and fixed assembly of jetty certificate bundle (#547)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-02-08 18:17:16 +00:00
Markus Rathgeb
223a371628 update Maven project settings (Eclipse IDE)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-06 15:56:00 +01:00
Markus Rathgeb
fd95b86b36 centralize the bundle identifier construction
The ready marker logic is created to hide the real usage. The ready
marker uses an "identifier" that is not specific or limited to bundles.

Currently the bundle symbolic name is used as bundle identifier.
That "convention" needs to be known at several different places.

There should be one method that created an identifier for a bundle and
"no one" needs to care about the implementation details.

Another point is that the bundle symbolic name that has been used is
optional. It may be null e.g. for bundles that has been installed by the
synthetic bundle installer mechanism etc.

The runtime assigns a bundle ID to an installed bundle that remains the
same for the bundle (see JavaDoc). The bundle ID is present all the
time.

The implementation of the "get identifier for bundle" has been choosen
to use the BSN -- if available -- (as before) but fallback to a custom
one using also the bundle ID (to be unique).
So we can provide always a non null identifier for a bundle.
It should be easily to change the identifier creation now if there is
every any need for.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-06 15:56:00 +01:00
Markus Rathgeb
92b71f1712 provide a better uninstall method for synthetic bundles
If a bundle misses a BSN the bundle cannot be installed.
We should provide a method to uninstall the bundle that has been created
by the synthetic installer itself.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-06 15:56:00 +01:00
Markus Rathgeb
23809b0cbd add provided storage capability to test bundle itself
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-06 15:55:59 +01:00
Markus Rathgeb
034e38d3e1 add test: org.openhab.core.config.core (#516)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-04 17:37:10 +01:00
Scott Rushworth
a65efe062d Add registration (#520)
Signed-off-by: Scott Rushworth <openhab@5iver.com>
2019-02-03 18:50:57 +01:00
Markus Rathgeb
93ef47c4a7 add test: org.openhab.core.id (#514)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 19:32:39 +01:00
Markus Rathgeb
7a1982e785 harden against missing bundle symbolic name (#510)
Fixes: https://github.com/openhab/openhab-core/issues/508

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 14:53:38 +01:00
Markus Rathgeb
68c8db8227 add missing no-arg constructors (#509)
* FirmwareUpdateProgressInfo
* FirmwareStatusInfo
* FirmwareUpdateResultInfo

Fixes: https://github.com/openhab/openhab-core/issues/507

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 14:24:25 +01:00
Markus Rathgeb
9475025cf7 at missing no-arg constructor for Gson deserialization (#505)
Fixes: https://github.com/openhab/openhab-core/issues/504

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 11:01:40 +01:00
Markus Rathgeb
6260f8e8ae fix scope (#502)
* fix scope

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 10:05:25 +01:00
Markus Rathgeb
4c856476a0 attach source artifact of "bundles" (#500)
Fixes: https://github.com/openhab/openhab-core/issues/496

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-02-01 09:04:17 +01:00
Kai Kreuzer
9f27727e09 REST API: (Optionally) include hidden widgets in sitemap API response (#499)
Also-by: Danny Baumann <dannybaumann@web.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-31 15:46:25 +00:00
Kai Kreuzer
0d1828f819 Extend usb serial discovery service to contain product ID (#497)
For better differentiation between different USB devices `UsbSerialDiscoveryService` is extended to add `usb_vendor_id` and `usb_product_id` properties to every thing which represents USB device.

Also-by: YordanDZhelev <zhelev.yordan@gmail.com>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-31 12:45:10 +00:00
Kai Kreuzer
53096ba08f removed Groovy support from tests (#490)
Also-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-31 05:15:43 +00:00
Markus Rathgeb
014cc6c708 MapDB storage: fix deserialization bug and add test (#486)
Fixes: https://github.com/eclipse/smarthome/issues/6877

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-30 17:17:23 +01:00
Kai Kreuzer
3b6dfbeddb Keep persisted disabled status when thing is removed (#493)
Also-By: Florian Stolte <fstolte@itemis.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-30 11:37:51 +01:00
Markus Rathgeb
76dd62623f make a first step to split between pure JUnit and integration tests (#488)
* make a first step to split between pure JUnit and integration tests

Related to: https://github.com/openhab/openhab-core/issues/482

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-30 08:57:06 +01:00
Markus Rathgeb
f7eec48c76 fix classpath (ESH-INF have been moved already) (#484)
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-29 11:19:45 +01:00
Markus Rathgeb
fbca7e806f remove project specific JDT settings (#481)
Done per request by @wborn.
Related to: https://github.com/openhab/openhab-core/pull/476#discussion_r251566034

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-29 10:24:39 +01:00
Markus Rathgeb
64dccd32dd tests: run pure JUnit tests (bugfix), add MapDB tests (migrated to JUnit) (#476)
* tests: run pure JUnit tests (bugfix), add MapDB tests (migrated to JUnit)
* remove project specific JDT settings

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-29 10:05:47 +01:00
Markus Rathgeb
12a5273cc8 mapdb storage: fix nullness handling (#479)
The `MapDbStorageService` calls the constructor with a `null`
classloader if there has been no one supplied.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-28 23:14:39 +01:00
Markus Rathgeb
a37cceab67 mavenize openHAB and integrate mavenized ESH repository (#467)
* mavenize openHAB and integrate mavenized ESH repository

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-01-28 13:07:31 +01:00
Kai Kreuzer
45a7ce27cb Removed addons from core (#469)
* removed addons from core
* removed homebuilder folder
* removed io.sound bundle

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-21 12:50:14 +01:00
Kai Kreuzer
10acf5cf46 Changed license from EPL v1 to EPL v2 (#466)
* updated license headers
* added NOTICE files
* moved about.html to NOTICE files
* changed main project license
* updated build.properties
* added files to check to prevent error about missing about.html
* removed license info on p2 feature

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-16 22:59:49 +01:00
Kai Kreuzer
eb8abdc894 updated to 2019 (#464)
* updated to 2019
* updated checkstyle check to 2019

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2019-01-07 22:53:19 +01:00