Wouter Born
91307993ad
Upgrade Units of Measurement dependencies ( #2319 )
...
Upgrades UoM dependencies to:
* javax.measure 2.1.2
* si-units 2.0.1
* indriya 2.1.2
An openHAB OSGi-ified si-units bundle is used as runtime dependency, because the latest si-units release is still missing proper OSGi manifest headers.
Notable changes:
* Quantity not longer implements an `equals` method, so the unit tests had to be adjusted. This should have any impact outside of the unit tests though since the rest of openHAB should be using QuantityType instead.
* RationalConverter is not package private, so instances of it much be created through the MultiplyConverter static functions.
* Quantities.getQuantity can no longer parse values without units like `100`. A workaround has been implemented.
* The unicode greek `mu` letter is now returned for unit prefixes instead of the unicode `micro` character. These characters are visually identical but the unit tests had to be adjusted. The new library seems to parse both types just fine.
Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-10 20:54:25 +02:00
Wouter Born
7579aa4d31
Fix more SAT findings and add a few suppressions ( #2335 )
...
* Fix more SAT findings and add a few suppressions
Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-05 20:59:59 +02:00
Christoph Weitkamp
4311b167f3
Added unit test for UTF-8 encoded properties ( #2295 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2021-04-19 17:07:47 +02:00
Wouter Born
05b7ec86f1
Fix new SAT findings ( #2291 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-14 18:41:07 +02:00
Wouter Born
64f444cf6e
Update Mockito, JUnit and use MockitoExtensions in itests ( #2075 )
...
* Updates Mockito to 3.7.0
* Updates JUnit to 5.7.0
* Use MockitoExtensions where possible
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-05 22:58:58 +01:00
Wouter Born
774b9d607b
Update license headers to 2021 ( #2041 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-01 16:43:46 +01:00
Wouter Born
0abf1aa987
Remove SmartHome leftovers ( #1901 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-08 12:49:06 +01:00
silamon
9a12f95dee
Remove the groupname from the members if the group item is removed ( #1833 )
...
Remove the groupname from the members if the group item is removed.
This is implemented in the ManagedItemProvider.
Fixes #1785
Fixes #1392
Signed-off-by: Simon Lamon <simonlamon93@hotmail.com>
2020-11-22 12:24:38 +01:00
Kai Kreuzer
70fed5a9c2
Fixed initialization of group items with aggregation functions ( #1718 )
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-10-15 23:03:22 +02:00
Wouter Born
057604cc2d
Use new Collection API methods ( #1598 )
...
Using the new methods there will be less and more readable code.
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-22 23:04:11 +02:00
Wouter Born
7300734585
Use "openhab" event topic prefix ( #1587 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-11 21:16:49 +02:00
Wouter Born
d3ea6063c0
Migrate to JUnit 5 ( #1580 )
...
* Migrates all tests to the JUnit 5 Jupiter API
* Updates bnd to 5.1.2
* Updates maven-surefire-plugin to 3.0.0-M5
* Updates Mockito to 3.4.6
* Updates Hamcrest to 2.2
* Removes org.openhab.core.boot POM dependencies
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-09 14:36:46 +02:00
Christoph Weitkamp
72c2ee78d1
Moved 'parseState()' method into 'GroupFunctionHelper' and apply only if needed ( #1534 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-07-09 23:25:15 +02:00
Christoph Weitkamp
1fddac192b
Removed deprecated contructors and methods ( #1500 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-06-13 21:01:06 +02:00
Christoph Weitkamp
8808f04c30
Removed dependency on 'org.apache.commons.io' ( #1441 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-05-21 15:17:00 +02:00
Wouter Born
f3508e4775
Use constructor injection and update null annotations ( #1487 )
...
* Use constructor injection and update null annotations
Signed-off-by: Wouter Born <github@maindrain.net>
2020-05-20 17:29:18 +02:00
Wouter Born
61e17ce39e
Upgrade SAT and Spotless, apply Spotless and enable check ( #1446 )
...
* Update SAT and Spotless dependencies
* Apply Spotless and enable check
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-26 11:15:24 +02:00
Christoph Weitkamp
d371a34321
Removed dependency on 'org.apache.commons.lang' ( #1433 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-22 14:32:31 +02:00
Wouter Born
92027ca922
Use .equals() on constants and literals to prevent NPEs ( #1420 )
...
* Use .equals() on constants and literals to prevent NPEs
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-16 07:40:49 +02:00
Wouter Born
945afcdb1a
Add and fix more null annotations ( #1407 )
...
* Add and fix more null annotations
* Add more @NonNullByDefault and @Nullable annotations
* Remove unnecessary @NonNull annotations
* Fix a few other trivial SAT issues
* Add constructor injection for MDNSDiscoveryService
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-06 10:45:39 +02:00
Wouter Born
1f825fc529
Fix null analysis errors in Eclipse ( #1403 )
...
Without helping the compiler a bit, it will show null analysis errors in Eclipse.
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-04 18:09:44 +02:00
Christoph Weitkamp
ac537c53d9
Added public method to remove all members from a group ( #1283 )
...
* Added public method to remove all members from a group
* Spelling in itest method names
* File encoding
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-01-26 12:54:37 +01:00
Christoph Weitkamp
08da8de5cf
Moved "ESH-INF/" folders to "OH-INF/" folders ( #1328 )
...
* Moved ESH-INF folders to OH-INF folders
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-01-17 15:29:18 +01:00
Wouter Born
3811cb9560
Update copyright headers to 2020 ( #1309 )
...
* Update copyright headers to 2020
Signed-off-by: Wouter Born <github@maindrain.net>
2020-01-01 18:06:34 +01:00
Christoph Weitkamp
800956598b
Applied spotless formatter ( #1302 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-12-30 22:55:19 +01:00
Christoph Weitkamp
dd4368e23f
Added nullness annotations; Some minor improvements; Unit tests for 'ItemCommandEvent' on group ( #1299 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-12-28 22:25:07 +01:00
Christoph Weitkamp
59675788e0
Renamed packages
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-12-28 12:18:16 +01:00
Christoph Weitkamp
fca7c215a5
Moved files to new location
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-12-28 12:18:16 +01:00
Christoph Weitkamp
2f86782c9d
Added 'InstaceCreator' for 'PersistedItem' ( #1173 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-11-01 16:28:53 +01:00
Wouter Born
42a0217386
Fixes a few more SAT findings ( #1145 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-19 14:10:18 +02:00
Wouter Born
b337e31621
Improve SafeCallerImplTest stability ( #1130 )
...
After some load testing these values improved the stability of the tests.
See: #1113
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-14 07:17:44 +02:00
Wouter Born
12e8edc039
Use diamond operator ( #1114 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-11 02:29:47 -07:00
Wouter Born
998168698a
Fix SAT MethodNameCheck findings ( #1111 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-10 11:38:29 +02:00
Wouter Born
3d52c72a91
Fix SAT AuthorContributionDescriptionCheck findings ( #1110 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-10 11:36:05 +02:00
Wouter Born
90005e4a56
Fix NoEmptyLineSeparatorCheck and NewlineAtEndOfFileCheck SAT findings ( #1108 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-08 22:19:54 -07:00
Wouter Born
08a1f9a86d
Fix SAT constant/variable name findings ( #1106 )
...
Fixes wrong names identified by the following rules:
* ConstantNameCheck
* LocalFinalVariableNameCheck
* LocalVariableNameCheck
* StaticVariableNameCheck
Most mismatches identified by the MemberNameCheck have also been fixed except for those where the variables are used in events/DTOs etc which would cause issues.
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-08 22:19:00 -07:00
Wouter Born
12b3c1030f
Fix SAT "Initial contribution" warnings ( #1100 )
...
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-07 21:25:40 -07:00
Wouter Born
3dacba3510
Fix SAT ModifierOrderCheck findings by using JLS suggested modifier order ( #1103 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-07 21:24:16 -07:00
Wouter Born
7926b2280e
Move core unit tests ( #1070 )
...
* Move core unit tests
Moves the core unit tests from the itests project to the bundle project.
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-03 19:51:53 +02:00
Wouter Born
eda0af1cd2
Fix ExpiringCacheAsyncTest.testFetchValue unreliability ( #1066 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2019-10-02 09:32:28 +02:00
Wouter Born
c9232d9651
Inject SchedulerImpl into DelegatedSchedulerImpl to fix waiting bundles ( #1054 )
...
Fixes #1053
Signed-off-by: Wouter Born <github@maindrain.net>
2019-09-29 16:47:19 +02:00
lolodomo
7b49f27823
Fix dynamic options in UI ( #1050 )
...
* Fix dynamic options in UI
* Added unit tests
Fixes #1040
Also-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2019-09-28 21:02:29 +02:00
Christoph Weitkamp
b9d9135771
Use constructor injection to simplify lifecycle ( #1037 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-09-27 12:19:50 +02:00
Christoph Weitkamp
cd57f1d79c
Refactoring of builders ( #908 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-09-16 21:10:39 +02:00
Christoph Weitkamp
be1cd25743
[itemregistry] Use constructor injection to simplify lifecycle ( #988 )
...
* Use constructor injection to simplify lifecycle
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* PR extended by ItemStateConverter
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-08-23 18:21:28 +02:00
lolodomo
e05819f6c1
Fix integration test for ExpiringCacheAsync ( #968 )
...
Fixes #967
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2019-08-10 19:20:36 +02:00
Christoph Weitkamp
4f3e1c17cb
Added equality tests for parsing and timzone ( #933 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2019-07-22 10:44:10 +02:00
Markus Rathgeb
ef05b4d878
start with an upper case on "initial contribution" ( #931 )
...
Related to: https://github.com/openhab/openhab-core/pull/916/#discussion_r305082016
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-07-21 12:24:58 +02:00
Markus Rathgeb
be40b7a1e8
explicit inspect for null instead of fail because of a NPE ( #876 )
...
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-06-20 21:20:59 +02:00
Markus Rathgeb
849753befe
small improvements of hexutils API and impl. ( #862 )
...
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
2019-06-10 17:07:04 +02:00