Wouter Born
85056d9d7b
Some more code cleanup ( #4021 )
...
This cleanup includes:
* Use enhanced for loops
* Use text blocks
* Use Objects.equals
* Fix some typos
* Remove redundant variable initialization
* Remove redundant null checks with instanceof
* Remove redundant thrown Exceptions
* Remove redundant empty String concatenation
Signed-off-by: Wouter Born <github@maindrain.net>
2024-02-04 11:17:55 +01:00
Wouter Born
2babea4c9a
Update license headers to 2024 ( #4011 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-03 21:20:34 +01:00
Wouter Born
6fc7700ea6
Use protected modifier with constructor of abstract classes ( #4010 )
...
Abstract classes should not have public constructors.
Constructors of abstract classes can only be called in constructors of their subclasses.
So there is no point in making them public.
The protected modifier should be enough.
Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-03 16:17:14 +01:00
Wouter Born
106c8b2270
Remove unnecessary semicolons ( #4009 )
...
This helps with stopping the proliferation of unnecessary semicolons.
Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-03 13:47:23 +01:00
Wouter Born
ec05a63738
Remove unnecessary boxing ( #3969 )
...
Using primitives makes the code faster and consume less memory.
Signed-off-by: Wouter Born <github@maindrain.net>
2023-12-27 17:50:09 +01:00
Holger Friedrich
839ba1ab4c
Apply spotless after release, resolve bundles ( #3953 )
...
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-12-22 23:14:28 +01:00
openhab-bot
3b279587b1
[unleash-maven-plugin] Preparation for next development cycle.
2023-12-22 11:48:43 +00:00
Holger Friedrich
9ad2fef549
Fix javadoc warnings ( #3870 )
...
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-11-15 09:21:07 +01:00
Wouter Born
e8e1c9fe73
Simplify code that creates List, Map and Set objects ( #3836 )
...
Simplifies the code by using List.of, List.copyOf etc. where possible which results in less code and imports.
Signed-off-by: Wouter Born <github@maindrain.net>
2023-10-09 18:00:00 +02:00
Kai Kreuzer
5692232e2b
Apply spotless
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2023-07-24 01:11:37 +02:00
openhab-bot
fd93f0a766
[unleash-maven-plugin] Preparation for next development cycle.
2023-07-23 17:14:35 +00:00
lolodomo
cfb2fa1be8
Icon server: remove old style request with the state in the URL ( #3548 )
...
The state is now expected to be passed only in the "state" parameter of the request.
As a result, the icon name can now contain hyphen(s).
Closes #3543
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2023-04-18 10:48:39 +02:00
Holger Friedrich
769aa562a1
Code cleanup: Use Java 17 features ( #3522 )
...
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-04-16 21:43:59 +02:00
Wouter Born
ec3af50f11
Upgrade to Karaf 4.4.3 ( #3252 )
...
* Sync runtime dependencies with Karaf 4.4.3, most notably:
* Jetty 9.4.50.v20221201
* Pax Logging 2.2.0
* Pax Web 8.0.15
* Use OSGi R8 as compile dependency
* Rework Servlets to use Http Whiteboard annotations in favor of proprietary `org.openhab.core.io.http.servlet` classes
* Resolve itest runbundles
Also-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-01 13:09:07 +01:00
J-N-K
8d64ecfd8d
Update license header to 2023 ( #3294 )
...
* Update license header to 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-03 09:45:42 +01:00
Wouter Born
687688db7e
Update Eclipse .classpath files ( #3250 )
...
Also adds some missing files for recently added projects.
Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-22 14:14:35 +01:00
J-N-K
3fc4d23734
Fix spotless and resolve itests ( #3239 )
...
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-19 11:09:31 +01:00
openhab-bot
35254b3a0a
[unleash-maven-plugin] Preparation for next development cycle.
2022-12-18 23:08:22 +00:00
J-N-K
c5d9c90971
Fix symlinks not followed ( #3023 )
...
Reported on the forum https://community.openhab.org/t/custom-icons-disappears-in-openhab-3-3/136957/4
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-06-29 21:55:00 +02:00
Kai Kreuzer
61fd47c853
Apply spotless and resolver ( #3018 )
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-06-27 13:41:28 +02:00
openhab-bot
8944bdbbe4
[unleash-maven-plugin] Preparation for next development cycle.
2022-06-26 16:37:00 +00:00
J-N-K
d8ebbb5857
Allow sub-directories for icons ( #2946 )
...
* Allow sub-directories for icons
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-05-16 22:33:32 +02:00
Wouter Born
ad936cd83f
Add more null annotations ( #2742 )
...
* Add more null annotations
* Fix mock name
Adds null annotations to most of the tests as well as a few other classes.
Also fixes a few other SAT findings.
Fixes ~300 SAT findings in total.
Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-14 11:33:50 +01:00
Christoph Weitkamp
cabb3f7315
Update license headers to 2022 ( #2671 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2022-01-07 13:16:42 +01:00
Kai Kreuzer
e3b07782b4
pom reference update from http to https ( #2644 )
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2021-12-23 22:55:20 +01:00
Kai Kreuzer
1ebf7395d9
Apply spotless
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2021-12-20 06:59:22 +01:00
openhab-bot
5ac05c4968
[unleash-maven-plugin] Preparation for next development cycle.
2021-12-19 21:49:34 +00:00
Wouter Born
8c1fe60abc
Fix IllegalStateException in IconServlet ( #2577 )
...
Fixes #2529
Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-28 22:01:00 +01:00
Kai Kreuzer
5a667cc868
applied spotless
...
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2021-06-27 23:22:02 +02:00
jenkins
b8d2077805
[unleash-maven-plugin] Preparation for next development cycle.
2021-06-27 15:50:02 +00:00
Wouter Born
7579aa4d31
Fix more SAT findings and add a few suppressions ( #2335 )
...
* Fix more SAT findings and add a few suppressions
Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-05 20:59:59 +02:00
Wouter Born
b64c84e8b9
Fix wrong/missing OpenAPI ApiResponse content ( #2258 )
...
This fixes some issues where the response content is missing or wrong in the generated OpenAPI spec.
Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-27 13:28:47 +01:00
Wouter Born
774b9d607b
Update license headers to 2021 ( #2041 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-01 16:43:46 +01:00
Wouter Born
bf14e1077f
Apply Spotless, resolve itest runbundles for 3.1.0 ( #1982 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-22 10:01:42 +01:00
jenkins
965531696b
[unleash-maven-plugin] Preparation for next development cycle.
2020-12-20 22:24:39 +00:00
Christoph Weitkamp
e909a81f4b
Removed references to not existing category ( #1915 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-12-12 22:35:20 +01:00
Christoph Hofmann
bbede78dc9
Added operationIds for OpenAPI specification ( #1861 )
...
Signed-off-by: Christoph Hofmann <christoph@hofmann.pm>
2020-12-10 23:12:11 +01:00
Wouter Born
13c2d7bf2b
Rename classes with "SmartHome" in their name ( #1896 )
...
* Rename SmartHomeUnits to Units
* Rename SmartHome Servlets and HTTP Context
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-06 23:35:37 +01:00
Wouter Born
d5e7fe3ab3
Update LastNPE EEAs to 2.2.1 ( #1821 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-17 16:29:09 +01:00
Wouter Born
0281c10036
[infrastructure] add external null-annotations ( #1775 )
...
Add EEAs and fix null analysis errors.
Related to:
* #888
* openhab/openhab-addons#8848
Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-03 21:33:48 +01:00
Wouter Born
d5529f0c1b
Fix various deprecations ( #1595 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-15 10:54:41 +02:00
Wouter Born
d3ea6063c0
Migrate to JUnit 5 ( #1580 )
...
* Migrates all tests to the JUnit 5 Jupiter API
* Updates bnd to 5.1.2
* Updates maven-surefire-plugin to 3.0.0-M5
* Updates Mockito to 3.4.6
* Updates Hamcrest to 2.2
* Removes org.openhab.core.boot POM dependencies
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-09 14:36:46 +02:00
Wouter Born
29dfb967c4
Migrate to OpenAPI 3 annotations ( #1576 )
...
* Upgrade to Swagger 2.1.0
* Add missing root and events resources
* Fix wrong and add missing response implementations
Signed-off-by: Wouter Born <github@maindrain.net>
2020-08-02 13:21:57 +02:00
Wouter Born
240c245b16
Annotate icon and tile classes with null annotations ( #1490 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-05-21 21:14:21 +02:00
Christoph Weitkamp
8808f04c30
Removed dependency on 'org.apache.commons.io' ( #1441 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-05-21 15:17:00 +02:00
Wouter Born
f3508e4775
Use constructor injection and update null annotations ( #1487 )
...
* Use constructor injection and update null annotations
Signed-off-by: Wouter Born <github@maindrain.net>
2020-05-20 17:29:18 +02:00
Wouter Born
84d9438737
Add null annotations to REST resources ( #1475 )
...
Signed-off-by: Wouter Born <github@maindrain.net>
2020-05-17 19:32:35 +02:00
Wouter Born
859da2e1c7
Migrate to JAX-RS Whiteboard ( #1443 )
...
* Migrate to JAX-RS Whiteboard
* Upgrade Jackson and Swagger TP feature dependencies
The upstream JAX-RS Whiteboard feature is not used because the version ranges currently do not work with Karaf on Windows.
See: https://issues.apache.org/jira/browse/KARAF-6536
* Update Felix logback to 1.0.2
This version adds the jul-to-slf4j bridge (FELIX-6027).
JUL is used by CXF and using the bridge we can use logback to reduce the verbosity of the info logging whenever org.apache.cxf.endpoint.ServerImpl creates endpoints.
* Update Aries Whiteboard to 1.0.8
* Removes the hated default web application (ARIES-1931)
* Improves performance
* Uses CXF 3.2.12
* Don't reuse SSE event builders
SSE event builders are not thread-safe.
It also causes the wrong default values being used.
Also-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Wouter Born <github@maindrain.net>
2020-05-14 22:32:35 +02:00
Wouter Born
61e17ce39e
Upgrade SAT and Spotless, apply Spotless and enable check ( #1446 )
...
* Update SAT and Spotless dependencies
* Apply Spotless and enable check
Signed-off-by: Wouter Born <github@maindrain.net>
2020-04-26 11:15:24 +02:00
Christoph Weitkamp
d371a34321
Removed dependency on 'org.apache.commons.lang' ( #1433 )
...
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
2020-04-22 14:32:31 +02:00