Remove unnecessary semicolons (#4009)

This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <github@maindrain.net>

bundles/org.openhab.core.config.core/src/main/java/org/openhab/core/config/core/xml/osgi/XmlDocumentBundleTracker.java

@@ -92,7 +92,7 @@ public class XmlDocumentBundleTracker<@NonNull T> extends BundleTracker<Bundle>
         CREATED,
         OPENED,
         CLOSED
-    };
+    }
 
     public static final String THREAD_POOL_NAME = "file-processing";
 

bundles/org.openhab.core.config.core/src/test/java/org/openhab/core/config/core/ConfigurationTest.java

@@ -41,7 +41,7 @@ public class ConfigurationTest {
             ON,
             OFF,
             UNKNOWN
-        };
+        }
 
         public MyEnum enumField = MyEnum.UNKNOWN;
         public int intField;

bundles/org.openhab.core.config.discovery/src/main/java/org/openhab/core/config/discovery/DiscoveryResultBuilder.java

@@ -50,7 +50,7 @@ public class DiscoveryResultBuilder {
 
     private DiscoveryResultBuilder(ThingUID thingUID) {
         this.thingUID = thingUID;
-    };
+    }
 
     /**
      * Creates a new builder for a given thing UID.

bundles/org.openhab.core.config.discovery/src/test/java/org/openhab/core/config/discovery/AbstractDiscoveryServiceTest.java

@@ -132,7 +132,7 @@ public class AbstractDiscoveryServiceTest implements DiscoveryListener {
                     .build();
             thingDiscovered(discoveryResult);
         }
-    };
+    }
 
     @Override
     public void thingDiscovered(DiscoveryService source, DiscoveryResult result) {

bundles/org.openhab.core.model.persistence/src/org/openhab/core/model/persistence/scoping/GlobalStrategies.java

@@ -27,26 +27,26 @@ public class GlobalStrategies {
         @Override
         public String getName() {
             return "everyUpdate";
-        };
+        }
     };
 
     public static final Strategy CHANGE = new StrategyImpl() {
         @Override
         public String getName() {
             return "everyChange";
-        };
+        }
     };
 
     public static final Strategy RESTORE = new StrategyImpl() {
         @Override
         public String getName() {
             return "restoreOnStartup";
-        };
+        }
     };
     public static final Strategy FORECAST = new StrategyImpl() {
         @Override
         public String getName() {
             return "forecast";
-        };
+        }
     };
 }

bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/ThingStatusDetail.java

@@ -67,7 +67,7 @@ public enum ThingStatusDetail {
         public ThingStatusDetail HANDLER_CONFIGURATION_PENDING = ThingStatusDetail.HANDLER_CONFIGURATION_PENDING;
         public ThingStatusDetail HANDLER_INITIALIZING_ERROR = ThingStatusDetail.HANDLER_INITIALIZING_ERROR;
         public ThingStatusDetail BRIDGE_UNINITIALIZED = ThingStatusDetail.BRIDGE_UNINITIALIZED;
-    };
+    }
 
     public static final class OnlineStatus {
         private OnlineStatus() {
@@ -75,7 +75,7 @@ public enum ThingStatusDetail {
 
         public ThingStatusDetail NONE = ThingStatusDetail.NONE;
         public ThingStatusDetail CONFIGURATION_PENDING = ThingStatusDetail.CONFIGURATION_PENDING;
-    };
+    }
 
     public static final class OfflineStatus {
         private OfflineStatus() {
@@ -88,5 +88,5 @@ public enum ThingStatusDetail {
         public ThingStatusDetail FIRMWARE_UPDATING = ThingStatusDetail.FIRMWARE_UPDATING;
         public ThingStatusDetail DUTY_CYCLE = ThingStatusDetail.DUTY_CYCLE;
         public ThingStatusDetail GONE = ThingStatusDetail.GONE;
-    };
+    }
 }

bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/events/ChannelDescriptionChangedEvent.java

@@ -37,7 +37,7 @@ public class ChannelDescriptionChangedEvent extends AbstractEvent {
         COMMAND_OPTIONS,
         PATTERN,
         STATE_OPTIONS
-    };
+    }
 
     /**
      * The channel description changed event type.

bundles/org.openhab.core.thing/src/main/java/org/openhab/core/thing/internal/firmware/ProgressCallbackImpl.java

@@ -64,7 +64,7 @@ final class ProgressCallbackImpl implements ProgressCallback {
         PENDING,
         RUNNING,
         INITIALIZED
-    };
+    }
 
     private InternalState state;
 

bundles/org.openhab.core.thing/src/test/java/org/openhab/core/thing/binding/BaseDynamicCommandDescriptionProviderTest.java

@@ -67,7 +67,7 @@ class BaseDynamicCommandDescriptionProviderTest {
             this.eventPublisher = eventPublisherMock;
             this.itemChannelLinkRegistry = itemChannelLinkRegistryMock;
         }
-    };
+    }
 
     private @NonNullByDefault({}) TestDynamicCommandDescriptionProvider subject;
 

bundles/org.openhab.core.thing/src/test/java/org/openhab/core/thing/binding/BaseDynamicStateDescriptionProviderTest.java

@@ -67,7 +67,7 @@ class BaseDynamicStateDescriptionProviderTest {
             this.eventPublisher = eventPublisherMock;
             this.itemChannelLinkRegistry = itemChannelLinkRegistryMock;
         }
-    };
+    }
 
     private @NonNullByDefault({}) BaseDynamicStateDescriptionProvider subject;
 

bundles/org.openhab.core.ui.icon/src/test/java/org/openhab/core/ui/icon/AbstractResourceIconProviderTest.java

@@ -82,17 +82,17 @@ public class AbstractResourceIconProviderTest {
                 String state = substringAfterLast(resourceName, "-");
                 state = substringBeforeLast(state, ".");
                 return "30".equals(state) || "y z".equals(state);
-            };
+            }
 
             @Override
             public Set<IconSet> getIconSets(@Nullable Locale locale) {
                 return Set.of();
-            };
+            }
 
             @Override
             public Integer getPriority() {
                 return 0;
-            };
+            }
         };
     }
 

bundles/org.openhab.core.ui/src/main/java/org/openhab/core/ui/items/ItemUIRegistry.java

@@ -49,7 +49,7 @@ public interface ItemUIRegistry extends ItemRegistry, ItemUIProvider {
         ITEM_NAME,
         /** No suitable label source could be determined */
         NONE
-    };
+    }
 
     /**
      * Retrieves the label for a widget.

itests/org.openhab.core.model.thing.tests/src/main/java/org/openhab/core/model/thing/test/hue/GenericThingProviderTest4.java

@@ -126,7 +126,7 @@ public class GenericThingProviderTest4 extends JavaOSGiTest {
                     return new BaseThingHandler(thing) {
                         @Override
                         public void handleCommand(ChannelUID arg0, Command arg1) {
-                        };
+                        }
 
                         @Override
                         public void initialize() {

itests/org.openhab.core.thing.tests/src/main/java/org/openhab/core/thing/binding/BindingBaseClassesOSGiTest.java

@@ -498,7 +498,7 @@ public class BindingBaseClassesOSGiTest extends JavaOSGiTest {
         public @Nullable Thing getThing() {
             return thing;
         }
-    };
+    }
 
     @Test
     public void assertThingCanBeUpdatedFromThingHandler() {

itests/org.openhab.core.thing.tests/src/main/java/org/openhab/core/thing/internal/ThingManagerOSGiJavaTest.java

@@ -434,7 +434,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             @Override
             public void childHandlerInitialized(ThingHandler childHandler, Thing childThing) {
                 assertDoesNotThrow(() -> childHandlerInitializedSemaphore.acquire());
-            };
+            }
         });
         registerThingHandlerFactory(THING_TYPE_UID, thing -> new BaseThingHandler(thing) {
             @Override
@@ -453,7 +453,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             public void thingUpdated(Thing thing) {
                 this.thing = thing;
                 assertDoesNotThrow(() -> thingUpdatedSemapthore.acquire());
-            };
+            }
         });
 
         Bridge bridge = BridgeBuilder.create(BRIDGE_TYPE_UID, BRIDGE_UID).build();
@@ -502,7 +502,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             @Override
             public void childHandlerInitialized(ThingHandler childHandler, Thing childThing) {
                 assertDoesNotThrow(() -> childHandlerInitializedSemaphore.acquire());
-            };
+            }
         });
 
         registerThingHandlerFactory(THING_TYPE_UID, thing -> new BaseThingHandler(thing) {
@@ -522,7 +522,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             public void thingUpdated(Thing thing) {
                 this.thing = thing;
                 assertDoesNotThrow(() -> thingUpdatedSemapthore.acquire());
-            };
+            }
         });
 
         Bridge bridge = BridgeBuilder.create(BRIDGE_TYPE_UID, BRIDGE_UID).build();
@@ -571,7 +571,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             @Override
             public void childHandlerInitialized(ThingHandler childHandler, Thing childThing) {
                 assertDoesNotThrow(() -> childHandlerInitializedSemaphore.acquire());
-            };
+            }
         });
         registerThingHandlerFactory(THING_TYPE_UID, thing -> new BaseThingHandler(thing) {
             @Override
@@ -587,7 +587,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
             public void thingUpdated(Thing thing) {
                 this.thing = thing;
                 assertDoesNotThrow(() -> thingUpdatedSemapthore.acquire());
-            };
+            }
         });
 
         Bridge bridge = BridgeBuilder.create(BRIDGE_TYPE_UID, BRIDGE_UID).build();
@@ -1115,7 +1115,7 @@ public class ThingManagerOSGiJavaTest extends JavaOSGiTest {
         protected @Nullable ThingHandler createHandler(Thing thing) {
             return thingHandlerProducer.apply(thing);
         }
-    };
+    }
 
     private AtomicReference<ThingHandlerCallback> initializeThingHandlerCallback() throws Exception {
         AtomicReference<ThingHandlerCallback> thc = new AtomicReference<>();