Also-by: Bert Plonus <bert.plonus@miele.com>
Also-by: Martin Lepsy <martin.lepsy@miele.com>
Also-by: Benjamin Bolte <benjamin.bolte@itemis.de>
Signed-off-by: Björn Lange <bjoern.lange@itemis.de>
* Syncs the karaf.version so the new Maven plugin is used
* Resolves itest runbundles for the new runtime dependencies
Signed-off-by: Wouter Born <github@maindrain.net>
* [modbus] gainOffset and bitMask profiles for working with modbus data
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README trailing whitespaces
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README and some final renaming
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] log error with incompatible units
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: test for incompatible unit
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] example renamed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused fields
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] gainOffset profile: make configuration parameters optional
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] xml indentantion fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static code analysis fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Minor fixes for null checking
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] remove comment
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile README disclaimer with many commands
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Grammar fixes in README
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix bit profile UI configuration
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Bit profile: Added possibility to invert value on read/write
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix typo with explanation of inverted
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] bit profile: unit tests for inverted parameter
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] static checker fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] write bit feature in data thing
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* wip
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] resolve itest
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fixes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Fix data thing readStart validation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] readme fix
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove bit profile test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Invalidate REFRESH data cache with cacheful writes
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] cleanup
- abort if command is not convertible to 0/1 (previously wrote the
cached data)
- fail fast conditionals instead of deep if's
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README Fix typo in example
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] fix data thing write when child of endpoint
Also added regression test
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* Update bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/config/gainOffset.xml
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [modbus] performance-optimized logging
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] README: Removing xtend syntax hint, not needed anymore
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] generics typing added
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] dead code
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] avoid supressing generic type warnings
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] unnecessary generics
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] rename type parameter name
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] QU (short for quantity output) generic type instead of Q2
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Remove unused localization
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] profile constant visibility harmonized
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] spotless:apply
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests
Related to openhab/openhab-distro#1167
Signed-off-by: Wouter Born <github@maindrain.net>
* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification
Signed-off-by: Wouter Born <github@maindrain.net>
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3
Related to openhab/openhab-addons#7722
Signed-off-by: Wouter Born <github@maindrain.net>
* [modbus] More strict nullness. Remove apache.commons.lang from itests
* [modbus] Defaults for tcp and serial things according to docs
* [modbus] further explicit defaults
* [modbus] document default encoding for serial.
RTU is pretty much the only one used in the field.
Previous default was ascii implicitly.
* [modbus] verify defaults are used for undefined configuration parameters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] Cascaded transforms with ∩
* [modbus] README to mention cascaded transformations
* [modbus] Take cascaded transformation into use
* [modbus] README to show preference towards new syntax
* [modbus] examples to use new syntax
* [modbus] fix test
* [modbus] remove apache commons lang dependency
- see also PR #10002
- I removed equals and hashCode implementation all-together, I could not see they played any role in practice.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [modbus] add support for rtu encoded over tcp
* [modbus] move classes to openhab/jamod
* [modbus] spotless
* [modbus] revert EndpointPoolConfiguration
* [modbus] remove virtual serial
* [modbus] resolve dependencies
* [modbus.studer] add support for RTU over TCP bridge
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* Added Channel for link to latest feed; update rome deoendency to version 1.15
* Removed unsed interface
* Run spotless
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Refactored discovery service to ThingHandlerService
* Fixed discovery for Geofence Sensor
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Configures XStream security to prevent "Security framework of XStream not initialized, XStream is probably vulnerable" warnings.
* Resolves the itest bundles for the upgrade to XStream 1.4.13
Related to openhab/openhab-core#1688
Signed-off-by: Wouter Born <github@maindrain.net>
Upgrades the compiler and its dependencies so the compiler results of Maven builds are more similar to those generated in recent Eclipse versions.
To fix compilation issues in Eclipse for add-ons using classes from javax.xml.stream several dependencies were upgraded/excluded.
Signed-off-by: Wouter Born <github@maindrain.net>
The ThingStatus is updated asynchronously so the test is unstable when the status is not updated immediately.
Signed-off-by: Wouter Born <github@maindrain.net>
* Improve exception handling of the embedded MQTT broker so the port can be reconfigured when it is already bound and it properly unlocks files
* Rework MQTT integration tests so they each run the embedded broker on their own reserved port
Signed-off-by: Wouter Born <github@maindrain.net>
With these changes and working channelLink events (openhab/openhab-core#1634) the ntp itest works again.
Signed-off-by: Wouter Born <github@maindrain.net>
With these changes and working channelLink events (openhab/openhab-core#1634) the feed itest works again.
Signed-off-by: Wouter Born <github@maindrain.net>
