Commit Graph

47 Commits

Author SHA1 Message Date
Wouter Born
a2868bb0dc
Use diamond operator and remove redundant type arguments (#16249)
Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-09 23:46:15 +01:00
Wouter Born
3415397a83
Remove unnecessary semicolons (#16214)
This helps with stopping the proliferation of unnecessary semicolons.

Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-05 23:56:58 +01:00
Jacob Laursen
f4596f581e
Update license headers to 2024 (#16168)
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2024-01-01 18:14:57 +01:00
Wouter Born
c58d894bf0
Use OnOffType.from to reduce code (#16101)
You can create an `OnOffType` using a boolean nowadays which reduces the amount of code.

Signed-off-by: Wouter Born <github@maindrain.net>
2023-12-23 19:06:21 +01:00
Holger Friedrich
f24a4305b8
Improve javadoc for some addons (#15701)
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-10-08 00:25:04 +02:00
Holger Friedrich
cbf4411034
Improve javadoc for all addons (#15667)
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-09-30 21:49:12 +02:00
Holger Friedrich
edaf17b345
Java 17 features (H-M) (#15520)
- add missing @override
- Java style array syntax
- remove redundant modifiers
- always move String constants to left side in comparisons
- simplify lambda expressions and return statements
- use replace instead of replaceAll w/o regex
- instanceof matching and multiline strings
- remove null check before instanceof

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-09-08 14:36:59 +02:00
robnielsen
216b41a2ef
[insteon] Add connection details (#14864)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2023-04-21 14:04:07 +02:00
Wouter Born
83cbe746d0
Remove redundant modifiers from interfaces (#14843)
Signed-off-by: Wouter Born <github@maindrain.net>
2023-04-18 13:07:04 +02:00
J-N-K
89d0689e36
fix i18n for bindings (#14235)
Also-By: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-21 12:14:51 +01:00
J-N-K
5f8214f08a
Adapt to core changes (addon.xml) (#13289)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-15 20:31:42 +01:00
Holger Friedrich
4e44de3894
Fix SAT warnings (#14202)
* Fix SAT warnings

- checkstyle.ModifierOrderCheck
- checkstyle.OneStatementPerLineCheck
- checkstyle.NeedBracesCheck
- PMD.UseStandardCharsets
- PMD.UseCollectionIsEmpty
- PMD.UnusedLocalVariable
- PMD.SimplifyBooleanReturns where reasonable, suppress where
readability is better without change
- PMD.SimplifyBooleanExpressions

* Include StandardCharsets

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-01-13 08:11:06 +01:00
Jacob Laursen
4dd6d3a8a2
Update license headers to 2023 (#14154)
* Update copyright year in configuration
* Update license headers

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-01-06 09:49:54 +01:00
Дилян Палаузов
0ffc5257d5
Typos a/an (#13876) 2022-12-08 21:12:49 +01:00
Дилян Палаузов
2a5d6beb64
Typos a/an (#13846) 2022-12-05 18:47:43 +01:00
Дилян Палаузов
6c1373f7c2
Typos a/an (#13819) 2022-12-02 13:07:31 +01:00
robnielsen
24e9228699
[insteon] set network to ONLINE after driver is initialized (#13030)
* [insteon] set network to ONLINE after driver is initialized

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-07-26 19:49:05 +02:00
robnielsen
3349cf4945
[insteon] set device offline if it doesn't exist in the plm/hub database (#12904)
* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @Nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-06-14 23:26:08 +02:00
robnielsen
53db5c4822
[insteon] change .equals() to == for ThingStatus equality check (#12826)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-05-27 16:12:04 +02:00
robnielsen
88e7ba3774
[insteon] set device to offline if network is not online after initialization (#12790)
* [insteon] set device to offline if network is not online during initialization

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-05-27 14:14:43 +02:00
robnielsen
5b79e18289
[insteon] ignore commands if device is not online (#12787)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-05-23 21:56:35 +02:00
Wouter Born
14058c1603
[insteon] Prevent null values from being inferred when printing to console (#12243)
This prevents the null analysis from inferring null values when printing to a Console.

Related to openhab/openhab-core#2742

Signed-off-by: Wouter Born <github@maindrain.net>
2022-02-08 21:27:17 +01:00
robnielsen
37c028ddc0
[insteon] Ignore missing network handler when disposing a device (#12169)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2022-01-30 18:50:47 +01:00
Hilbrand Bouwkamp
da59cdd255
Update license headers to 2022 (#11973)
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-01-06 18:14:47 +01:00
Wouter Born
07a1976c81
Add default translations for binding add-ons (#11760)
* Add default translations for binding add-ons

This makes the texts used by these add-ons translatable with Crowdin.

To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file.
We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications.

There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-15 18:40:21 +01:00
Wouter Born
589400e223
Fix/suppress PMD CompareObjectsWithEquals findings (#11476)
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-02 10:43:53 +01:00
robnielsen
3e94bb1e19
[insteon] added representation property for devices (#10908)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2021-07-06 19:51:09 +02:00
robnielsen
84a4896ffc
[insteon] add a read timeout when getting data from Insteon 2245-222 hub (#10708)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2021-05-17 22:12:02 +02:00
robnielsen
9ba28a50cc
[insteon] Fix SAT warnings (#10688)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2021-05-14 10:22:55 +02:00
robnielsen
ca3ee153c4
[insteon] delay setting state of network to UNKNOWN (#10620)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2021-05-09 20:22:13 +02:00
Wouter Born
0c36650179
Avoid star imports and add missing braces (#10521)
Fixes the following SAT findings:

* AvoidStarImportCheck (125)
* NeedBracesCheck (39)

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-15 16:12:05 +02:00
Kai Kreuzer
b0a15b48a3
Merge pull request from GHSA-r2hc-pmr7-4c9r
* Configured XML parsers to resist XXE attacks

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* added fix for avmfritz

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* added fix for sonos

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* added fix for vitotronic and bosesoundtouch

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* changed avmfritz to singleton pattern

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* addressed roku binding

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* address all uses of DocumentBuilderFactory

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* fixed other occurrences in roku binding

Signed-off-by: Kai Kreuzer <kai@openhab.org>
2021-01-24 15:06:00 +01:00
Hilbrand Bouwkamp
ac3f907b36
Normalized thread names (#9581)
Related to #8216

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2021-01-12 22:10:01 +01:00
Wouter Born
d6364aceb1
Update license headers to 2021 (#9620)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 22:03:14 +01:00
Wouter Born
ac6f08908f
Use renamed Units class (#9267)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-07 10:34:02 +01:00
Kai Kreuzer
007c3b56e5
removed deprecated author information from binding.xml (#9113)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-11-23 19:06:33 -08:00
robnielsen
4911fd0c4a
[insteon] Fixed status updates not getting published for some polled devices (#9110)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-11-24 00:12:25 +01:00
J-N-K
ba4c96d99d
[infrastructure] move infered nullness warnings to error and update EEA (#8949)
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
2020-11-12 21:07:11 +01:00
robnielsen
5b7f1b0e67
[insteon] added ability to configure the channels with parameters from the ui (#8959)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-11-11 19:11:17 -08:00
robnielsen
3c3e9adbb1
[insteon] sort the channels by channel id so they show up sorted in the ui (#8966)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-11-11 11:29:55 -08:00
robnielsen
0722bd71f5
[insteon] remove all @SuppressWarnings("null") (#8937)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-11-04 21:05:01 +01:00
Wouter Born
b423f93b1f
Remove Map null annotation workarounds (#8916)
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-04 13:57:24 +01:00
J-N-K
bd664ff0c8
[infrastructure] add external null-annotations (#8848)
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
2020-10-31 00:29:03 +01:00
robnielsen
0f3112d3f8
[insteon] handle cases when channelLinked is not called after initialization (#8803)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-10-21 00:54:40 +02:00
robnielsen
3abe27b224
[insteon] remove dependency on org.apache.commons.lang.StringUtils (#8630)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-10-01 14:55:19 -07:00
robnielsen
c30a5fa9e2
[insteon] remove optional from the description of network parameters (#8555)
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
2020-09-25 22:23:07 +02:00
Kai Kreuzer
6df6783b60 added migrated 2.x add-ons
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-09-21 03:37:19 +02:00