Commit Graph

31 Commits

Author SHA1 Message Date
Wouter Born
a2868bb0dc
Use diamond operator and remove redundant type arguments (#16249)
Signed-off-by: Wouter Born <github@maindrain.net>
2024-01-09 23:46:15 +01:00
Jacob Laursen
f4596f581e
Update license headers to 2024 (#16168)
* Update copyright year in configuration
* Update license headers
* Manually update nibeheatpump headers (.cpp/.h/.ino)
* Manually update smsmodem header
* Manually update hueemulation header
* Manually update addon-header.xml header

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2024-01-01 18:14:57 +01:00
Holger Friedrich
edaf17b345
Java 17 features (H-M) (#15520)
- add missing @override
- Java style array syntax
- remove redundant modifiers
- always move String constants to left side in comparisons
- simplify lambda expressions and return statements
- use replace instead of replaceAll w/o regex
- instanceof matching and multiline strings
- remove null check before instanceof

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-09-08 14:36:59 +02:00
Andrew Fiddian-Green
df9c270acf
[hdpowerview] Add support for Generation 3 (#13355)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2023-05-24 13:00:14 +02:00
Wouter Born
9aa72abd82
Resolve runbundles and fix tests (#14588)
Related to:

* openhab/openhab-core#3433
* openhab/openhab-core#3446
* openhab/openhab-core#3450

Some tests were updated because private lifecycle methods (annotated with @BeforeAll, @AfterAll, @BeforeEach, or @AfterEach) now lead to an exception.

See: https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-3

Signed-off-by: Wouter Born <github@maindrain.net>
2023-03-12 23:00:58 +01:00
Jacob Laursen
4dd6d3a8a2
Update license headers to 2023 (#14154)
* Update copyright year in configuration
* Update license headers

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-01-06 09:49:54 +01:00
Jacob Laursen
c114714a7b
[hdpowerview] Restructure DTO classes (#13630)
* Extract nested DTO's to separate classes
* Rename api to dto
* Move test classes into internal
* Finish moving of files and fix namespaces

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-04 18:24:39 +01:00
Andrew Fiddian-Green
dce6dc9f79
[hdpowerview] Correct shade capabilities information (#13330)
* [hdpowerview] corrections to capabilities database

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-09-10 10:01:54 +02:00
Andrew Fiddian-Green
f7295bd00f
[hdpowerview] Battery channels visible only when required (#13324)
* [hdpowerview] add batteryKind field
* [hdpowerview] battery channels visible depending on batteryKind

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-08-28 13:55:18 +02:00
Jacob Laursen
c7f8507cae
[hdpowerview] Refactor tests (#13175)
* Move test providers to dedicated folder
* Simplify resource loading
* Clarify what is being tested
* Extract online communication test to separate class
* Fix SAT findings
* Rename variable to comply with naming convention

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-07-30 20:43:17 +02:00
Andrew Fiddian-Green
650fc523b5
[hdpowerview] Return capabilities if capabilitiesOverride is not defined (#13031)
* [hdpowerview] bug fix capabilitiesOverride
* [hdpowerview] adopt reviewer requests
* [hdpowerview] suppress log warning on hub v1
* [hdpowerview] adopt reviwer suggestions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-06-30 10:40:37 +02:00
Andrew Fiddian-Green
c806c76631
[hdpowerview] Corrections to shade database and capabilities (#12902)
* [hdpowerview] add type 66 shutters to database
* [hdpowerview] shade database updates
* [hdpowerview] shade database additions and corrections
* [hdpowerview] enhance database features
* [hdpowerview] fix capabilities 8, 9 functionality
* [hdpowerview] adjust tests to match new capabilities
* [hdpowerview] correct method visibility
* [hdpowerview] test type 44
* [hdpowerview] remove comment
* [hdpowerview] name change
* [hdpowerview] remove comments attribute
* [hdpowerview] refactor capabilities code
* [hdpowerview] 'hard' properties now hidden
* [hdpowerview] adopt reviewer suggestion
* [hdpowerview] refactor constant names

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-06-10 20:10:31 +02:00
Jacob Laursen
f986183a21
[hdpowerview] Fix output to console from tests and eliminate warnings (#12824)
* Avoid logging to console
* Fix redundant null checks

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-06-04 08:44:44 +02:00
Andrew Fiddian-Green
308bb3013a
[hdpowerview] Change method names to match documentation (#12796)
* [hdpowerview] refactor method names

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-05-24 21:50:41 +02:00
Andrew Fiddian-Green
a3448a57d3
[hdpowerview] Fix for capabilities:1 shades (#12237)
* [hdpowerview] fix capabilities:1

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-02-08 13:16:32 +01:00
Jacob Laursen
608d0ae23a
[hdpowerview] Fix autoupdate quirk. (#12141)
Fixes #12140

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-01-27 21:38:29 +01:00
Andrew Fiddian-Green
8a2d507b21
[hdpowerview] Added support for rear blackout panel (#12098)
* [hdpowerview] refactor enum constant names
* [hdpowerview] add support for blackout shades
* [hdpowerview] unit tests for capabilities 8 & 9
* [hdpowerview] delete no longer valid comment
* [hdpowerview] blackout shade position is never UNDEF
* [hdpowerview] updated read me
* [hdpowerview] refactor unit tests into two classes

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-01-25 20:09:14 +01:00
Jacob Laursen
e44dfe7dbc
[hdpowerview] Refactor dynamic channels (#11853)
* Extract dynamic channel creation to separate classes.
* Avoid double list allocations.
* Add test coverage for scenarios with no channels built.
* Extract common builder stuff to super class.
* Fix grammar.
* Reduce constructor access modifiers.
* Removed unneeded this keyword for protected method.
* Fix null annotation issues.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-01-17 13:41:33 +01:00
Jacob Laursen
fee45a5b94
[hdpowerview] Refactor exception handling (#12049)
* Refactor exception handling.

Fixes #12048

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-01-15 19:16:09 +01:00
Hilbrand Bouwkamp
da59cdd255
Update license headers to 2022 (#11973)
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-01-06 18:14:47 +01:00
Andrew Fiddian-Green
d45bcdb7aa
[hdpowerview] Fix secondary position bug. Add shade database and properties. (#11698)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-01-04 20:23:48 +01:00
jlaur
8c83c27c57
[hdpowerview] Add support for scene groups (#11534)
* Add support for scene collections.

Fixes #11533

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Add unit test for parsing of scene collections response.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Add default i18n properties file.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix CAT: File does not end with a newline.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Update documentation with scene collections.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix CAT: File does not end with a newline.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix formatting.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix CAT: File does not end with a newline.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Split offline tests into separate distinct tests.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Increase test coverage for scene/scene collection parsing.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Internationalization of dynamic scene/scene collection channels.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Rename scene collections to scene groups.

Renamed for all user-oriented texts/references to be consistent with now abandoned feature of the PowerView app.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Change custom text keys to not collide with framework.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Avoid multiple thing updates.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Add missing label/description texts for secondary channel.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Remove unneeded @Nullable annotations.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-11-15 23:53:23 +01:00
Andrew Fiddian-Green
cb13ec6f1a
[hdpowerview] Secondary shade position was inverted (#11552)
* [hdpowerview] get secondary shade position value was inverted

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [hdpowerview] remove testing Jar from PR

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2021-11-12 01:23:25 +01:00
jlaur
805d56dc08
[hdpowerview] Add Hub configuration option hardRefreshBatteryLevel (#11260)
* Add Hub configuration option hardRefreshBatteryLevel for refreshing battery status more frequently.
* Explicitly update battery channels to Undefined when data is missing or invalid.

Fixes #11259

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-09-18 13:55:04 +02:00
jlaur
56a0449ce1
[hdpowerview] Add new battery level channel (#11206)
* Introduce new batteryLevel channel.

Fixes #11205

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-09-08 20:36:59 +02:00
jlaur
0087c8c828
[hdpowerview] Add new signal strength channel (#11198)
* Add new signal strength channel.

Fixes #11197

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-09-04 15:49:33 +02:00
Wouter Born
1633c705a1
Use Collection.isEmpty (#10525)
Fixes 47 SAT UseCollectionIsEmpty findings.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-15 21:00:47 +02:00
Andrew Fiddian-Green
596b261d47
[hdpowerview] Eliminate nightly crash dump in OH3 (#10118)
* [hdpowerview] refactor from jax-rs to http client
* [hdpowerview] adopt proposals of code reviewer
* [hdpowerview] adopt additional proposals of code reviewer
* [hdpowerview] provide exception class name

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2021-02-16 12:22:27 -08:00
Wouter Born
d6364aceb1
Update license headers to 2021 (#9620)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 22:03:14 +01:00
Wouter Born
bd82ca82df
Migrate tests to JUnit 5 (#8519)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-21 18:21:26 +02:00
Kai Kreuzer
6df6783b60 added migrated 2.x add-ons
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2020-09-21 03:37:19 +02:00