Since JUnit Jupiter test classes and methods do not need to be `public`.
It is recommended to omit the `public` modifier.
See https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods
"Class and method visibility
Test classes, test methods, and lifecycle methods are not required to be
`public`, but they must not be `private`.
It is generally recommended to omit the `public` modifier for test
classes, test methods, and lifecycle methods unless there is a technical
reason for doing so (...)"
Signed-off-by: Thomas Traude <t-riggs@gmx.net>
* [knx] Improve localization
- introduce localization of error messages
- add new strings for common exceptions
- provide helper functions for translation
- add test cases
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
* New translations openwebnet.properties (German)
* New translations sonos.properties (German)
* New translations openhabcloud.properties (German)
* New translations hueemulation.properties (German)
* New translations epsonprojector.properties (German)
* New translations hpprinter.properties (German)
* New translations http.properties (German)
* New translations knx.properties (German)
* New translations lcn.properties (German)
* New translations magentatv.properties (German)
* New translations onkyo.properties (German)
* New translations fineoffsetweatherstation.properties (German)
* New translations openweathermap.properties (German)
* [knx] Add support for KNX IP Secure
* add support for KNX IP Secure, new options SECURETUNNEL and
SECUREROUTER, refers to #8872
* add config options for credentials for secure connections
* update user documentation
* add test cases
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Starting with openHAB 3.3, the framework enforces using serial
ports which are detected by the system by default. This feature
is now disabled for the KNX addon to allow using symlinks to
ports as well.
Refers-to: openhab/openhab-core#3014
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Clarify handling of initial read and readInterval in documentation.
Updated labels to distinguish readInterval and pollInterval.
Fixes#12921.
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Items with dimensions (QuantityType) are now translated and can be sent to the
KNX bus. This requires the correct DPT to be specified in the channel
definition. Fixes#10706.
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
CEMI frame format is used by newer serial devices like kBerry.
Calimero library can be configured to use CEMI instead of default EMI.
Followup on #10407. Relates to #4026.
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
added NonNullByDefault annotations
rename functions and local variables not matching the naming scheme
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
* Fixed NullPointerException due to missing SecureApplicationLayer in creation of ProcessCommunicationResponder
Signed-off-by: Frank Seidinger <frank.seidinger@gmail.com>
Changed Example of Dimmer channel. Makes no sense to provide both Switch and Position Status in configuration, as an update of Switch Status will delete Position and vice versa. Position Status makes sense.
* Add default translations for binding add-ons
This makes the texts used by these add-ons translatable with Crowdin.
To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file.
We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications.
There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged.
Signed-off-by: Wouter Born <github@maindrain.net>
- Upstream update of base library for KNX access from v2.4 to v2.5.
- Adapt AbstractKNXClient to new interface and replace calls of deprecated
methods.
Fixes#6849.
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.
Signed-off-by: Wouter Born <github@maindrain.net>
The handleUpdate method was deprecated when profiles were introduced (see eclipse-archived/smarthome#4108).
Instead the "follow profile" can be used which forwards item updates as commands to handlers.
This profile works with any binding instead of only those that implement the handleUpdate method.
Related to openhab/openhab-core#1669
Signed-off-by: Wouter Born <github@maindrain.net>
