demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-25 14:55:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

[visualcrossing] Add missing @ActionOutput annotation (#17665)

Browse Source 
Related to #17504

Also fix the return of corresponding static methods

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This commit is contained in:
lolodomo 2024-10-29 21:25:40 +01:00 committed by Ciprian Pascu
parent 1feb51c454
commit eba17c1e43
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bundles/org.openhab.binding.visualcrossing/src/main/java/org/openhab/binding/visualcrossing/internal/WeatherCrossingActions.java
View File

@ -23,6 +23,7 @@ import org.openhab.binding.visualcrossing.internal.api.VisualCrossingAuthExcepti
import org.openhab.binding.visualcrossing.internal.api.VisualCrossingRateException;
import org.openhab.binding.visualcrossing.internal.api.dto.WeatherResponse;
import org.openhab.core.automation.annotation.ActionInput;
import org.openhab.core.automation.annotation.ActionOutput;
import org.openhab.core.automation.annotation.RuleAction;
import org.openhab.core.thing.binding.ThingActions;
import org.openhab.core.thing.binding.ThingActionsScope;
@ -47,8 +48,7 @@ public class WeatherCrossingActions implements ThingActions {
}
@RuleAction(label = "@text/action.timeline.label", description = "@text/action.timeline.description")
@Nullable
public WeatherResponse timeline(
public @Nullable @ActionOutput(label = "Result", type = "org.openhab.binding.visualcrossing.internal.api.dto.WeatherResponse") WeatherResponse timeline(
@ActionInput(name = "location", label = "@text/action.label.location", description = "@text/action.description.location") @Nullable String location,
@ActionInput(name = "unitGroup", label = "@text/action.label.unitGroup", description = "@text/action.description.unitGroup") @Nullable UnitGroup unitGroup,
@ActionInput(name = "lang", label = "@text/action.label.lang", description = "@text/action.description.lang") @Nullable String lang,
@ -62,21 +62,20 @@ public class WeatherCrossingActions implements ThingActions {
return localHandler.timeline(location, unitGroup, lang, dateFrom, dateTo);
}
public static void timeline(@Nullable ThingActions actions, @Nullable String location,
public static @Nullable WeatherResponse timeline(@Nullable ThingActions actions, @Nullable String location,
@Nullable UnitGroup unitGroup, @Nullable String lang, @Nullable String dateFrom, @Nullable String dateTo)
throws VisualCrossingAuthException, VisualCrossingApiException, VisualCrossingRateException {
((VisualCrossingHandler) requireNonNull(actions)).timeline(location, unitGroup, lang, dateFrom, dateTo);
return ((VisualCrossingHandler) requireNonNull(actions)).timeline(location, unitGroup, lang, dateFrom, dateTo);
}
@RuleAction(label = "@text/action.timeline.label", description = "@text/action.timeline.description")
@Nullable
public WeatherResponse timeline()
public @Nullable @ActionOutput(label = "Result", type = "org.openhab.binding.visualcrossing.internal.api.dto.WeatherResponse") WeatherResponse timeline()
throws VisualCrossingAuthException, VisualCrossingApiException, VisualCrossingRateException {
return timeline(null, null, null, null, null);
}
public static void timeline(@Nullable ThingActions actions)
public static @Nullable WeatherResponse timeline(@Nullable ThingActions actions)
throws VisualCrossingAuthException, VisualCrossingApiException, VisualCrossingRateException {
((VisualCrossingHandler) requireNonNull(actions)).timeline(null, null, null, null, null);
return ((VisualCrossingHandler) requireNonNull(actions)).timeline(null, null, null, null, null);
}
}