demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 15:11:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[homekit] fix thermostats with auto mode and only target temperature (#17136)

Browse Source 
allow configuring such an accessory, and it's up to the user to be okay
with how the Home app deals with it

Signed-off-by: Cody Cutrer <cody@cutrer.us>
This commit is contained in:
Cody Cutrer 2024-07-24 01:10:46 -06:00 committed by GitHub
parent 0158befacc
commit e9369b6956
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitThermostatImpl.java
View File

@ -83,13 +83,6 @@ class HomekitThermostatImpl extends AbstractHomekitAccessoryImpl {
var targetHeatingCoolingStateCharacteristic = getCharacteristic(TargetHeatingCoolingStateCharacteristic.class)
.get();
if (Arrays.stream(targetHeatingCoolingStateCharacteristic.getValidValues())
.anyMatch(v -> v.equals(TargetHeatingCoolingStateEnum.AUTO))
&& (!coolingThresholdTemperatureCharacteristic.isPresent()
|| !heatingThresholdTemperatureCharacteristic.isPresent())) {
throw new HomekitException(
"Both HeatingThresholdTemperature and CoolingThresholdTemperature must be provided if AUTO mode is allowed.");
}
// TargetTemperature not provided; simulate by forwarding to HeatingThresholdTemperature and
// CoolingThresholdTemperature