From ba5488f04083ba714823ffeca8f94537cfd9c048 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hans-J=C3=B6rg=20Merk?= Date: Mon, 26 Oct 2020 12:53:57 +0100 Subject: [PATCH] [intesis] Fixed error channels not being updated (#8863) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Hans-Jörg Merk --- bundles/org.openhab.binding.intesis/README.md | 37 +++++++++++-------- .../internal/handler/IntesisBoxHandler.java | 6 +-- .../resources/OH-INF/thing/thing-types.xml | 2 + 3 files changed, 26 insertions(+), 19 deletions(-) diff --git a/bundles/org.openhab.binding.intesis/README.md b/bundles/org.openhab.binding.intesis/README.md index b3567c0f9fd..506b0f896a8 100644 --- a/bundles/org.openhab.binding.intesis/README.md +++ b/bundles/org.openhab.binding.intesis/README.md @@ -68,14 +68,17 @@ Thing intesis:intesisBox:acOffice "AC Unit Adapter" @ "AC" [ipAddress="192.168. **Items** ```intesishome.items -Switch ac "Power" { channel="intesis:intesisHome:acOffice:power" } -String acMode "Mode" { channel="intesis:intesisHome:acOffice:mode" } -String acFanSpeed "Fan Speed" { channel="intesis:intesisHome:acOffice:fanSpeed" } -String acVanesUpDown "Vanes Up/Ddown Position" { channel="intesis:intesisHome:acOffice:vanesUpDown" } -String acVanesLeftRight "Vanes Left/Right Position" { channel="intesis:intesisHome:acOffice:vanesLeftRight" } -Number:Temperature acSetPoint "Target Temperature" { channel="intesis:intesisHome:acOffice:targetTemperature" } -Number:Temperature acAmbientTemp "Ambient Temperature" { channel="intesis:intesisHome:acOffice:ambientTemperature" } -Number:Temperature acOutdoorTemp "Outdoor Temperature" { channel="intesis:intesisHome:acOffice:outdoorTemperature" } +Switch ac "Power" { channel="intesis:intesisHome:acOffice:power" } +String acMode "Mode" { channel="intesis:intesisHome:acOffice:mode" } +String acFanSpeed "Fan Speed" { channel="intesis:intesisHome:acOffice:fanSpeed" } +String acVanesUpDown "Vanes Up/Ddown Position" { channel="intesis:intesisHome:acOffice:vanesUpDown" } +String acVanesLeftRight "Vanes Left/Right Position" { channel="intesis:intesisHome:acOffice:vanesLeftRight" } +Number:Temperature acSetPoint "Target Temperature" { channel="intesis:intesisHome:acOffice:targetTemperature" } +Number:Temperature acAmbientTemp "Ambient Temperature" { channel="intesis:intesisHome:acOffice:ambientTemperature" } +Number:Temperature acOutdoorTemp "Outdoor Temperature" { channel="intesis:intesisHome:acOffice:outdoorTemperature" } +String acErrorStatus "Errorstatus" { channel="intesis:intesisBox:acOffice:errorStatus" } +String acErrorCode "Errorcode" { channel="intesis:intesisBox:acOffice:errorCode" } +String acWifiSignal "Wifi Signal Quality" { channel="intesis:intesisBox:acOffice:wifiSignal" } ``` **Sitemap** @@ -85,13 +88,17 @@ sitemap intesishome label="My AC control" { Frame label="Climate" { Switch item=ac - Switch item=acMode icon="heating" mappings=[AUTO="Auto", HEAT="Heat", DRY="Dry", FAN="Fan", COOL="Cool"] - Switch item=acFanSpeed icon="qualityofservice" mappings=[AUTO="Auto", 1="Low", 2="Med", 3="MedHigh", 4="High"] - Switch item=acVanesUpDown icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] - Switch item=acVanesLeftRight icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] - Setpoint item=acSetPoint icon="temperature" minValue=16 maxValue=28 step=1 - Text item=acAmbientTemp icon="temperature" - Text item=acOutdoorTemp icon="temperature" + Switch item=acMode icon="heating" mappings=[AUTO="Auto", HEAT="Heat", DRY="Dry", FAN="Fan", COOL="Cool"] + Switch item=acFanSpeed icon="qualityofservice" mappings=[AUTO="Auto", 1="Low", 2="Med", 3="MedHigh", 4="High"] + Switch item=acVanesUpDown icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] + Switch item=acVanesLeftRight icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] + Setpoint item=acSetPoint icon="temperature" minValue=16 maxValue=28 step=1 + Text item=acAmbientTemp icon="temperature" + Text item=acOutdoorTemp icon="temperature" + Text item=acErrorStatus + Text item=acErrorCode + Text item=acWifiSignal icon="qualityofservice" + } } ``` diff --git a/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java b/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java index ee56499b077..eb363bac10e 100644 --- a/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java +++ b/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java @@ -263,12 +263,10 @@ public class IntesisBoxHandler extends BaseThingHandler implements IntesisBoxCha updateState(CHANNEL_TYPE_VANESLR, new StringType(value)); break; case "ERRCODE": - properties.put("errorCode", value); - updateProperties(properties); + updateState(CHANNEL_TYPE_ERRORCODE, new StringType(value)); break; case "ERRSTATUS": - properties.put("errorStatus", value); - updateProperties(properties); + updateState(CHANNEL_TYPE_ERRORSTATUS, new StringType(value)); if ("ERR".equals(value)) { updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "device reported an error"); diff --git a/bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml index f8bd16002aa..4a49712a873 100644 --- a/bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml +++ b/bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml @@ -59,12 +59,14 @@ String @text/channel-type.intesis.errorCode.description + String @text/channel-type.intesis.errorStatus.description +