demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 15:11:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[lifx] Fix all code analysis findings (#13638)

Browse Source 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
This commit is contained in:
lolodomo 2022-11-01 15:31:37 +01:00 committed by GitHub
parent 7728bbc232
commit aea2fd4002
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bundles/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/dto/HevCycleState.java
View File

@ -73,10 +73,7 @@ public class HevCycleState {
} else if (!duration.equals(other.duration)) {
return false;
}
if (enable != other.enable) {
return false;
}
return true;
return enable == other.enable;
}
@Override

5
bundles/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/dto/Packet.java
View File

@ -389,9 +389,6 @@ public abstract class Packet {
}
public boolean isFulfilled(Packet somePacket) {
if (isExpectedResponse(somePacket.getPacketType())) {
return true;
}
return false;
return isExpectedResponse(somePacket.getPacketType());
}
}

5
bundles/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/fields/HSBK.java
View File

@ -126,10 +126,7 @@ public class HSBK {
if (brightness != other.brightness) {
return false;
}
if (kelvin != other.kelvin) {
return false;
}
return true;
return kelvin == other.kelvin;
}
@Override

6
bundles/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/fields/MACAddress.java
View File

@ -101,10 +101,6 @@ public class MACAddress {
}
final MACAddress other = (MACAddress) obj;
if (!this.hex.equalsIgnoreCase(other.hex)) {
return false;
}
return true;
return this.hex.equalsIgnoreCase(other.hex);
}
}

4
bundles/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/util/LifxThrottlingUtil.java
View File

@ -23,8 +23,6 @@ import java.util.concurrent.locks.ReentrantLock;
import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable;
import org.openhab.binding.lifx.internal.fields.MACAddress;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* The {@link LifxThrottlingUtil} is a utility class that regulates the frequency at which messages/packets are
@ -37,8 +35,6 @@ import org.slf4j.LoggerFactory;
@NonNullByDefault
public final class LifxThrottlingUtil {
private static final Logger LOGGER = LoggerFactory.getLogger(LifxThrottlingUtil.class);
private LifxThrottlingUtil() {
// hidden utility class constructor
}