demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-25 14:55:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

[hue] API v1: retry once on timeout for GET requests to the bridge (#16902)

Browse Source 
Fix #16723

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This commit is contained in:
lolodomo 2024-06-22 12:01:30 +02:00 committed by Ciprian Pascu
parent 80c9e39ddb
commit 9ef18558ca
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/HueBridge.java
View File

@ -1096,6 +1096,11 @@ public class HueBridge {
private HueResult doNetwork(String address, HttpMethod requestMethod, @Nullable String body)
throws ConfigurationException, CommunicationException {
return doNetwork(address, requestMethod, body, requestMethod == HttpMethod.GET);
}
private HueResult doNetwork(String address, HttpMethod requestMethod, @Nullable String body, boolean retryOnTimeout)
throws ConfigurationException, CommunicationException {
logger.trace("Hue request: {} - URL = '{}'", requestMethod, address);
try {
final Request request = httpClient.newRequest(address).method(requestMethod).timeout(timeout,
@ -1123,9 +1128,14 @@ public class HueBridge {
e.getCause());
}
} catch (TimeoutException e) {
String message = e.getMessage();
logger.debug("TimeoutException occurred during execution: {}", message, e);
throw new CommunicationException(message == null ? TEXT_OFFLINE_COMMUNICATION_ERROR : message);
if (retryOnTimeout) {
logger.debug("TimeoutException occurred during execution, retry");
return doNetwork(address, requestMethod, body, false);
} else {
String message = e.getMessage();
logger.debug("TimeoutException occurred during execution: {}", message, e);
throw new CommunicationException(message == null ? TEXT_OFFLINE_COMMUNICATION_ERROR : message);
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
String message = e.getMessage();