demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 15:11:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[knx] Improve logging for serial gateways (#17793)

Browse Source 
* Logger in SerialAdapter respects the log setting for the binding.
* Additional warning if open port is detected.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This commit is contained in:
Holger Friedrich 2024-11-24 10:19:33 +01:00 committed by GitHub
parent 336875797b
commit 7b1c44547e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/SerialTransportAdapter.java
View File

@ -74,7 +74,7 @@ public class SerialTransportAdapter implements SerialCom {
if (portId == null) {
throw new IOException("Port not available");
}
logger = LoggerFactory.getLogger("SerialTransportAdapter:" + portId);
logger = LoggerFactory.getLogger(SerialTransportAdapter.class.getName() + ":" + portId);
final @Nullable SerialPortManager tmpSerialPortManager = serialPortManager;
if (tmpSerialPortManager == null) {
@ -83,6 +83,10 @@ public class SerialTransportAdapter implements SerialCom {
try {
SerialPortIdentifier portIdentifier = tmpSerialPortManager.getIdentifier(portId);
if (portIdentifier != null) {
if (portIdentifier.isCurrentlyOwned()) {
logger.warn("Configured port {} is currently in use by another application: {}", portId,
portIdentifier.getCurrentOwner());
}
logger.trace("Trying to open port {}", portId);
SerialPort serialPort = portIdentifier.open(this.getClass().getName(), OPEN_TIMEOUT_MS);
// apply default settings for com port, may be overwritten by caller