demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 15:11:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[iCloud] Ignore HTTP errors != 400 & >= 500 for 2-FA authentication (#14563)

Browse Source 
* Ignore HTTP errors != 400 for 2-FA authentication

---------

Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
This commit is contained in:
Simon Spielmann 2023-03-10 21:53:35 +01:00 committed by Jacob Laursen
parent 211955ccd6
commit 66d0377cff
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bundles/org.openhab.binding.icloud/src/main/java/org/openhab/binding/icloud/internal/ICloudService.java
View File

@ -246,8 +246,14 @@ public class ICloudService {
this.session.post(AUTH_ENDPOINT + "/verify/trusteddevice/securitycode", JsonUtils.toJson(requestBody),
headers);
} catch (ICloudApiResponseException ex) {
logger.debug("Code verification failed.", ex);
return false;
logger.trace("Exception on code verification with HTTP status {}. Verification might still be successful.",
ex.getStatusCode(), ex);
// iCloud API returns different 4xx error codes even if validation is successful
// currently 400 seems to show that verification "really" failed.
if (ex.getStatusCode() == 400 || ex.getStatusCode() >= 500) {
this.logger.debug("Verification failed with HTTP status {}.", ex.getStatusCode());
return false;
}
}
logger.debug("Code verification successful.");