demus/openhab-addons
1
0
Fork 0
mirror of https://github.com/openhab/openhab-addons.git synced 2025-01-10 23:22:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[pushover] Provides the ability to specify a timeout in the config (#10817)

Browse Source 
* Provides the ability to specify a timeout in the config, instead of using hardcoded 10 seconds.

Signed-off-by: Geroen Dierckx <geroen.dierckx@gmail.com>
This commit is contained in:
ridiekel 2021-06-09 07:12:30 +02:00 committed by GitHub
parent cf13bb8275
commit 047ae89aaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bundles/org.openhab.binding.pushover/README.md
View File

@ -21,6 +21,7 @@ You are able to create multiple instances of this Thing to broadcast to differen
| `sound` | text | The default notification sound on target device (default: `default`) (see [supported notification sounds](https://pushover.net/api#sounds)). |
| `retry` | integer | The retry parameter specifies how often (in seconds) the Pushover servers will send the same notification to the user (default: `300`). **advanced** |
| `expire` | integer | The expire parameter specifies how long (in seconds) your notification will continue to be retried (default: `3600`). **advanced** |
| `timeout` | integer | The timeout parameter specifies maximum number of seconds a request to Pushover can take. **advanced** |
The `retry` and `expire` parameters are only used for emergency-priority notifications.

1
bundles/org.openhab.binding.pushover/src/main/java/org/openhab/binding/pushover/internal/config/PushoverAccountConfiguration.java
View File

@ -31,4 +31,5 @@ public class PushoverAccountConfiguration {
public String sound = DEFAULT_SOUND;
public int retry = 300;
public int expire = 3600;
public int timeout = 10;
}

3
bundles/org.openhab.binding.pushover/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverAPIConnection.java
View File

@ -134,7 +134,8 @@ public class PushoverAPIConnection {
throws PushoverCommunicationException, PushoverConfigurationException {
logger.trace("Pushover request: {} - URL = '{}'", httpMethod, url);
try {
final Request request = httpClient.newRequest(url).method(httpMethod).timeout(10, TimeUnit.SECONDS);
final Request request = httpClient.newRequest(url).method(httpMethod).timeout(config.timeout,
TimeUnit.SECONDS);
if (body != null) {
if (logger.isTraceEnabled()) {

7
bundles/org.openhab.binding.pushover/src/main/resources/OH-INF/config/config.xml
View File

@ -48,6 +48,13 @@
<description>The expire parameter specifies how long your notification will continue to be retried.</description>
<default>3600</default>
</parameter>
<parameter name="timeout" type="integer" min="0" max="10800" unit="s">
<advanced>true</advanced>
<label>Timeout</label>
<description>The timeout parameter specifies maximum number of seconds a request to Pushover can
take.</description>
<default>10</default>
</parameter>
</config-description>
</config-description:config-descriptions>