From f460f6abd1146f4d54ace9ddae205645f01ce7f5 Mon Sep 17 00:00:00 2001
From: Andreas Shimokawa <shimokawa@fsfe.org>
Date: Tue, 21 Jul 2020 17:13:23 +0200
Subject: [PATCH] Amazfit Bip S: Change Unknown menu item to "World Clock"

Latest firmware has a world clock, setting the locations is not yet supported by Gadgetbridge
---
 .../devices/huami/amazfitbips/AmazfitBipSSupport.java       | 4 ++--
 app/src/main/res/values/arrays.xml                          | 6 +++---
 app/src/main/res/values/strings.xml                         | 1 +
 app/src/main/res/values/values.xml                          | 2 +-
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/amazfitbips/AmazfitBipSSupport.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/amazfitbips/AmazfitBipSSupport.java
index 7e62efe06..1b4d015d4 100644
--- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/amazfitbips/AmazfitBipSSupport.java
+++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/amazfitbips/AmazfitBipSSupport.java
@@ -123,12 +123,12 @@ public class AmazfitBipSSupport extends AmazfitBipSupport {
                 0x07, 0x00, (byte) 0xFF, 0x09, // Alarm
                 0x08, 0x00, (byte) 0xFF, 0x1B, // Timer
                 0x09, 0x00, (byte) 0xFF, 0x16, // Compass
-                0x0A, 0x00, (byte) 0xFF, 0x1A, // Unknown
+                0x0A, 0x00, (byte) 0xFF, 0x1A, // World clock
                 0x0B, 0x00, (byte) 0xFF, 0x0B, // Music
                 0x0C, 0x00, (byte) 0xFF, 0x13  // Settings
         };
 
-        String[] keys = {"status", "hr", "pai", "workout", "alipay", "nfc", "weather", "alarm", "timer", "compass", "unknown", "music", "settings"};
+        String[] keys = {"status", "hr", "pai", "workout", "alipay", "nfc", "weather", "alarm", "timer", "compass", "worldclock", "music", "settings"};
         byte[] ids = {1, 2, 25, 3, 17, 16, 4, 9, 27, 22, 26, 11, 19};
 
         if (pages != null) {
diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml
index 8ab63a0ac..99641dd85 100644
--- a/app/src/main/res/values/arrays.xml
+++ b/app/src/main/res/values/arrays.xml
@@ -437,7 +437,7 @@
         <item>@string/menuitem_alarm</item>
         <item>@string/menuitem_timer</item>
         <item>@string/menuitem_compass</item>
-        <item>@string/menuitem_unknown</item>
+        <item>@string/menuitem_worldclock</item>
         <item>@string/menuitem_music</item>
         <item>@string/menuitem_settings</item>
     </string-array>
@@ -453,7 +453,7 @@
         <item>@string/p_menuitem_alarm</item>
         <item>@string/p_menuitem_timer</item>
         <item>@string/p_menuitem_compass</item>
-        <item>@string/p_menuitem_unknown</item>
+        <item>@string/p_menuitem_worldclock</item>
         <item>@string/p_menuitem_music</item>
         <item>@string/p_menuitem_settings</item>
     </string-array>
@@ -469,7 +469,7 @@
         <item>@string/p_menuitem_alarm</item>
         <item>@string/p_menuitem_timer</item>
         <item>@string/p_menuitem_compass</item>
-        <item>@string/p_menuitem_unknown</item>
+        <item>@string/p_menuitem_worldclock</item>
         <item>@string/p_menuitem_music</item>
         <item>@string/p_menuitem_settings</item>
     </string-array>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 3a2904c86..1b78b1ce4 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -779,6 +779,7 @@
     <string name="menuitem_eventreminder">Event Reminder</string>
     <string name="menuitem_workout">Workout</string>
     <string name="menuitem_unknown">Unknown</string>
+    <string name="menuitem_worldclock">World Clock</string>
     <string name="watch9_time_minutes">Minutes:</string>
     <string name="watch9_time_hours">Hours:</string>
     <string name="watch9_time_seconds">Seconds:</string>
diff --git a/app/src/main/res/values/values.xml b/app/src/main/res/values/values.xml
index 6933e94ee..5a8bff4a9 100644
--- a/app/src/main/res/values/values.xml
+++ b/app/src/main/res/values/values.xml
@@ -37,7 +37,7 @@
     <item name="p_menuitem_pai" type="string">pai</item>
     <item name="p_menuitem_eventreminder" type="string">eventreminder</item>
     <item name="p_menuitem_workout" type="string">workout</item>
-    <item name="p_menuitem_unknown" type="string">unknown</item>
+    <item name="p_menuitem_worldclock" type="string">worldclock</item>
 
     <item name="p_off" type="string">off</item>
     <item name="p_on" type="string">on</item>