From cdaf78cbbc594aa5a9c3d28a4ce9745bfe32a5f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= <joserebelo@outlook.com>
Date: Tue, 8 Oct 2024 12:39:44 +0100
Subject: [PATCH] Activity list: Adjust padding and colors

---
 .../main/res/layout/activity_list_dashboard_item.xml  |  2 +-
 app/src/main/res/layout/activity_list_item.xml        | 11 ++++++-----
 .../res/layout/activity_summary_dashboard_item.xml    |  2 +-
 app/src/main/res/values/colors.xml                    |  4 +++-
 app/src/main/res/values/styles.xml                    |  4 ++++
 5 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/app/src/main/res/layout/activity_list_dashboard_item.xml b/app/src/main/res/layout/activity_list_dashboard_item.xml
index e89cc4002..0efb54315 100644
--- a/app/src/main/res/layout/activity_list_dashboard_item.xml
+++ b/app/src/main/res/layout/activity_list_dashboard_item.xml
@@ -127,6 +127,6 @@
         android:layout_below="@id/activity_list_summary_dashboard"
         android:layout_width="match_parent"
         android:layout_height="1dp"
-        android:background="@color/value_line_color_transparent"
+        android:background="?attr/row_separator"
         />
 </RelativeLayout>
\ No newline at end of file
diff --git a/app/src/main/res/layout/activity_list_item.xml b/app/src/main/res/layout/activity_list_item.xml
index 431f3f1e5..6383f9fdf 100644
--- a/app/src/main/res/layout/activity_list_item.xml
+++ b/app/src/main/res/layout/activity_list_item.xml
@@ -11,10 +11,10 @@
         android:id="@+id/list_item_subparent_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:paddingStart="5dp"
-        android:paddingTop="5dp"
-        android:paddingEnd="5dp"
-        android:paddingBottom="5dp"
+        android:paddingStart="10dp"
+        android:paddingTop="10dp"
+        android:paddingEnd="10dp"
+        android:paddingBottom="10dp"
         android:background="?attr/selectableItemBackground"
         android:orientation="horizontal">
 
@@ -57,6 +57,7 @@
                     android:id="@+id/line_layout_activity_icon"
                     android:layout_width="50dp"
                     android:layout_height="50dp"
+                    android:layout_marginEnd="5dp"
                     android:contentDescription="@string/candidate_item_device_image"
                     android:padding="8dp"
                     app:srcCompat="@drawable/ic_activity_unknown" />
@@ -280,6 +281,6 @@
         android:layout_below="@id/list_item_subparent_layout"
         android:layout_width="match_parent"
         android:layout_height="1dp"
-        android:background="@color/value_line_color_transparent"
+        android:background="?attr/row_separator"
         />
 </RelativeLayout>
\ No newline at end of file
diff --git a/app/src/main/res/layout/activity_summary_dashboard_item.xml b/app/src/main/res/layout/activity_summary_dashboard_item.xml
index b6c631c45..fccb0485f 100644
--- a/app/src/main/res/layout/activity_summary_dashboard_item.xml
+++ b/app/src/main/res/layout/activity_summary_dashboard_item.xml
@@ -471,6 +471,6 @@
         android:layout_below="@id/summary_dashboard"
         android:layout_width="match_parent"
         android:layout_height="1dp"
-        android:background="@color/value_line_color_transparent"
+        android:background="?attr/row_separator"
         />
 </RelativeLayout>
\ No newline at end of file
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index 8c863b5c2..d8e9409db 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -63,9 +63,11 @@
     <color name="steps_color" type="color">#00c9bf</color>
 
     <color name="value_line_color" type="color">#858585</color>
-    <color name="value_line_color_transparent" type="color">#70858585</color>
+    <color name="row_separator_light" type="color">#ffe2e2e5</color>
+    <color name="row_separator_dark" type="color">#19808080</color>
     <color name="gauge_line_color" type="color">#19808080</color>
 
+    <attr name="row_separator" format="color" />
     <color name="alternate_row_background_light">#FFEDEDED</color>
     <color name="alternate_row_background_dark">#545254</color>
 
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 9837817ed..3510312e6 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -31,6 +31,7 @@
         <item name="chart_activity">@color/chart_activity_light</item>
         <item name="chart_not_worn">@color/chart_not_worn_light</item>
         <item name="alternate_row_background">@color/alternate_row_background_light</item>
+        <item name="row_separator">@color/row_separator_light</item>
         <item name="sports_activity_summary_background">@color/chart_heartrate_fill</item>
 
         <item name="deviceIconPrimary">#2196f3</item>
@@ -73,6 +74,7 @@
         <item name="chart_activity">@color/chart_activity_dark</item>
         <item name="chart_not_worn">@color/chart_not_worn_dark</item>
         <item name="alternate_row_background">@color/alternate_row_background_dark</item>
+        <item name="row_separator">@color/row_separator_dark</item>
         <item name="sports_activity_summary_background">@color/alternate_row_background_dark</item>
 
         <item name="deviceIconPrimary">#2196f3</item>
@@ -101,6 +103,7 @@
         <item name="cardview_background_color">?attr/colorSurface</item>
         <item name="actionmenu_icon_color">?attr/colorOnSurface</item>
         <item name="alternate_row_background">?attr/colorSecondaryContainer</item>
+        <item name="row_separator">@color/row_separator_light</item>
         <item name="sports_activity_summary_background">?attr/colorSurface</item>
         <item name="preferenceTheme">@style/AppPreferenceThemeOverlay</item>
         <item name="android:navigationBarColor">?attr/colorSurface</item>
@@ -120,6 +123,7 @@
         <item name="cardview_background_color">?attr/colorSurface</item>
         <item name="actionmenu_icon_color">?attr/colorOnSurface</item>
         <item name="alternate_row_background">?attr/colorSecondaryContainer</item>
+        <item name="row_separator">@color/row_separator_dark</item>
         <item name="sports_activity_summary_background">?attr/colorSurface</item>
         <item name="preferenceTheme">@style/AppPreferenceThemeOverlay</item>
         <item name="android:navigationBarColor">?attr/colorSurface</item>