From 7a0e43a4de90aaaf0040e0607b4c5c5a29193502 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= Date: Sun, 10 Nov 2024 22:16:10 +0000 Subject: [PATCH] GBDevice: Do not unset firmware from dynamic state It is not clear why this was being done, but it is the source of issues for multiple devices, since the ensureDeviceUpToDate function will attempt to persist the null values, in non-nullable columns. --- .../nodomain/freeyourgadget/gadgetbridge/impl/GBDevice.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBDevice.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBDevice.java index 78ccbc4785..78dfba1107 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBDevice.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBDevice.java @@ -400,15 +400,12 @@ public class GBDevice implements Parcelable { } private void unsetDynamicState() { - setBatteryLevel(BATTERY_UNKNOWN, 0); setBatteryLevel(BATTERY_UNKNOWN, 1); setBatteryLevel(BATTERY_UNKNOWN, 2); setBatteryState(UNKNOWN, 0); setBatteryState(UNKNOWN, 1); setBatteryState(UNKNOWN, 2); - setFirmwareVersion(null); - setFirmwareVersion2(null); setRssi(RSSI_UNKNOWN); resetExtraInfos(); if (mBusyTask != null) {