From 650ffc0fedc3733f5d7c409f647ebf35f37a0c71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= Date: Fri, 29 May 2026 19:18:33 +0100 Subject: [PATCH] Fix DBHelper.getDevice calls device is never mutated --- .../activities/internet/InternetFirewallActivity.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/internet/InternetFirewallActivity.kt b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/internet/InternetFirewallActivity.kt index e9f32e0eb3..0f5eba975b 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/internet/InternetFirewallActivity.kt +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/internet/InternetFirewallActivity.kt @@ -76,7 +76,7 @@ class InternetFirewallActivity : AbstractGBActivity() { val qb = db.daoSession.internetFirewallRuleDao.queryBuilder() if (device != null) { // device-specific rules - val deviceFromDb = DBHelper.getDevice(device, db.daoSession) + val deviceFromDb = DBHelper.getDevice(device!!, db.daoSession) qb.where(InternetFirewallRuleDao.Properties.DeviceId.eq(deviceFromDb.id)) } else { // global rules @@ -198,7 +198,7 @@ class InternetFirewallActivity : AbstractGBActivity() { rule.domain = domain rule.action = action if (device != null) { - val deviceFromDb = DBHelper.getDevice(device, db.daoSession) + val deviceFromDb = DBHelper.getDevice(device!!, db.daoSession) rule.deviceId = deviceFromDb.id } db.daoSession.internetFirewallRuleDao.insert(rule)